Re: [BUGS] ISM shared memory on solaris

2003-10-27 Thread Josh Wilmes
Seems like the BEST case would be to have a configure test verify that it works and define something if it does, but i don't know what such a test would look like. --Josh Bruce Momjian wrote: Tom Lane wrote: Bruce Momjian <[EMAIL PROTECTED]> writes: ! #if defined(sun) && defined(__sparc__)

Re: [BUGS] ISM shared memory on solaris

2003-10-27 Thread Bruce Momjian
Tom Lane wrote: > Bruce Momjian <[EMAIL PROTECTED]> writes: > > > ! #if defined(sun) && defined(__sparc__) > > /* use intimate shared memory on SPARC Solaris */ > > memAddress = shmat(shmid, 0, SHM_SHARE_MMU); > > #else > > I think this is going in the wrong direction. Why isn't the co

Re: [BUGS] ISM shared memory on solaris

2003-10-27 Thread Tom Lane
Bruce Momjian <[EMAIL PROTECTED]> writes: > ! #if defined(sun) && defined(__sparc__) > /* use intimate shared memory on SPARC Solaris */ > memAddress = shmat(shmid, 0, SHM_SHARE_MMU); > #else I think this is going in the wrong direction. Why isn't the code just #if defined(SHM_SHA

Re: [BUGS] ISM shared memory on solaris

2003-10-25 Thread Bruce Momjian
Please use new patch. This uses __sun__ rather than sun. --- Josh Wilmes wrote: > > Bruce Momjian wrote: > > > Josh Wilmes wrote: > > > >>Nope, __solaris__ is not defined on our system either. > > > > > > I thought our

Re: [BUGS] ISM shared memory on solaris

2003-10-25 Thread Bruce Momjian
OK, attached patch applied. I tested for 'sun' rather than 'solaris'. --- Josh Wilmes wrote: > > Bruce Momjian wrote: > > > Josh Wilmes wrote: > > > >>Nope, __solaris__ is not defined on our system either. > > > > > >

Re: [BUGS] ISM shared memory on solaris

2003-10-24 Thread Josh Wilmes
Bruce Momjian wrote: Josh Wilmes wrote: Nope, __solaris__ is not defined on our system either. I thought our configure defined __portname__ for every platform, but I don't see that anywhere, so it seems we rely on the compiler to supply defines for the cpu and OS. Does src/tools/ccsym show you

Re: [BUGS] ISM shared memory on solaris

2003-10-24 Thread Josh Wilmes
Nope, __solaris__ is not defined on our system either. --Josh Bruce Momjian wrote: Yikes! We thought we were already using ISM on Solaris. Would you test the attached patch? It uses _solaris_ rather than SHM_SHARE_MMU in the define test. Does that work too? --

Re: [BUGS] ISM shared memory on solaris

2003-10-24 Thread Bruce Momjian
Josh Wilmes wrote: > Nope, __solaris__ is not defined on our system either. I thought our configure defined __portname__ for every platform, but I don't see that anywhere, so it seems we rely on the compiler to supply defines for the cpu and OS. Does src/tools/ccsym show you your defines? I woul

Re: [BUGS] ISM shared memory on solaris

2003-10-24 Thread Bruce Momjian
Yikes! We thought we were already using ISM on Solaris. Would you test the attached patch? It uses _solaris_ rather than SHM_SHARE_MMU in the define test. Does that work too? --- Josh Wilmes wrote: > I hope this is the r

[BUGS] ISM shared memory on solaris

2003-10-24 Thread Josh Wilmes
I hope this is the right place to send this.. the FAQ in the distribution mentions http://www.PostgreSQL.org/bugs/bugs.php, which doesn't work. We've found that postgresql wasn't using ISM shared memory on solaris, which theoretically would cost performance. The root cause in our case was th