Re: [BUGS] BUG #8467: Slightly confusing pgcrypto example in docs

2013-10-10 Thread Bruce Momjian
On Thu, Oct 10, 2013 at 08:32:32PM -0400, Bruce Momjian wrote: > > > How can the later entry not be MD5 hash? > > > > Because what you pass to the functions is 'md5', not 'md5 hash', which > > is what the new text appears to indicate. > > So if we revert, will it still be clear what is MD5 and w

Re: [BUGS] BUG #8467: Slightly confusing pgcrypto example in docs

2013-10-10 Thread Bruce Momjian
On Thu, Oct 10, 2013 at 08:22:30PM -0400, Peter Eisentraut wrote: > On Thu, 2013-10-10 at 19:14 -0400, Bruce Momjian wrote: > > > The changes shown below are incorrect, I think. > > > > > > > > > On 10/2/13 12:00 PM, Bruce Momjian wrote: > > > > *** gen_salt(type text [, iter_count in

Re: [BUGS] BUG #8467: Slightly confusing pgcrypto example in docs

2013-10-10 Thread Peter Eisentraut
On Thu, 2013-10-10 at 19:14 -0400, Bruce Momjian wrote: > > The changes shown below are incorrect, I think. > > > > > > On 10/2/13 12:00 PM, Bruce Momjian wrote: > > > *** gen_salt(type text [, iter_count integer > > > *** 353,359 > > > 12 years > > > > > >

Re: [BUGS] BUG #8467: Slightly confusing pgcrypto example in docs

2013-10-10 Thread Bruce Momjian
On Thu, Oct 10, 2013 at 04:05:50PM -0400, Peter Eisentraut wrote: > The changes shown below are incorrect, I think. > > > On 10/2/13 12:00 PM, Bruce Momjian wrote: > > *** gen_salt(type text [, iter_count integer > > *** 353,359 > > 12 years > > > > > >

Re: [BUGS] BUG #8467: Slightly confusing pgcrypto example in docs

2013-10-10 Thread Peter Eisentraut
The changes shown below are incorrect, I think. On 10/2/13 12:00 PM, Bruce Momjian wrote: > *** gen_salt(type text [, iter_count integer > *** 353,359 > 12 years > > > !md5 > 2345086 > 1 day > 3 years > --- 358,364 ---

Re: [BUGS] BUG #8467: Slightly confusing pgcrypto example in docs

2013-10-08 Thread Bruce Momjian
On Wed, Oct 2, 2013 at 12:00:44PM -0400, Bruce Momjian wrote: > Based on your report, I have developed the attached doc patch which > clarifies when MD5 hash is being referenced, and when MD5 crypt is. I > have also added your other suggestions. Patch applied, and backpatched to 9.3.X. Thanks f

Re: [BUGS] BUG #8467: Slightly confusing pgcrypto example in docs

2013-10-02 Thread Bruce Momjian
On Tue, Sep 24, 2013 at 11:20:55PM +0100, Richard Neill wrote: > I'm sorry about that: I think I need to correct my proposed > correction! I think I've been writing too much C recently, and so I > foolishly mis-read that as returning pswhash, rather than returning > the truth of the comparison. >

Re: [BUGS] BUG #8467: Slightly confusing pgcrypto example in docs

2013-09-24 Thread Richard Neill
Dear Magnus, Thanks for your reply. On 24/09/13 18:31, Magnus Hagander wrote: The following bug has been logged on the website: Bug reference: 8467 The documentation for pgcrypto: http://www.postgresql.org/docs/current/static/pgcrypto.html (and indeed all versions from 8.3-9.3) contains

Re: [BUGS] BUG #8467: Slightly confusing pgcrypto example in docs

2013-09-24 Thread Magnus Hagander
On Tue, Sep 24, 2013 at 1:11 AM, wrote: > The following bug has been logged on the website: > > Bug reference: 8467 > Logged by: Richard Neill > Email address: postgre...@richardneill.org > PostgreSQL version: 9.3.0 > Operating system: Documentation bug > Description: > > The

[BUGS] BUG #8467: Slightly confusing pgcrypto example in docs

2013-09-24 Thread postgresql
The following bug has been logged on the website: Bug reference: 8467 Logged by: Richard Neill Email address: postgre...@richardneill.org PostgreSQL version: 9.3.0 Operating system: Documentation bug Description: The documentation for pgcrypto: http://www.postgresql.