Re: [BUGS] BUG #7873: pg_restore --clean tries to drop tables that don't exist

2013-03-07 Thread Josh Kupershmidt
[Moving to -hackers] On Sat, Feb 23, 2013 at 2:51 PM, Pavel Stehule wrote: > so > > * --conditional-drops replaced by --if-exists Thanks for the fixes, I played around with the patch a bit. I was sort of expecting this example to work (after setting up the regression database with `make install

Re: [BUGS] BUG #7873: pg_restore --clean tries to drop tables that don't exist

2013-02-23 Thread Pavel Stehule
Hello 2013/2/21 Josh Kupershmidt : > On Tue, Feb 19, 2013 at 6:00 AM, Pavel Stehule > wrote: >> 2013/2/16 Pavel Stehule : >>> 2013/2/16 Tom Lane : I think it has come up before. I wouldn't object to a pg_dump option to add IF EXISTS to all the drop commands (though changing the defaul

Re: [BUGS] BUG #7873: pg_restore --clean tries to drop tables that don't exist

2013-02-20 Thread Josh Kupershmidt
On Tue, Feb 19, 2013 at 6:00 AM, Pavel Stehule wrote: > 2013/2/16 Pavel Stehule : >> 2013/2/16 Tom Lane : >>> I think it has come up before. I wouldn't object to a pg_dump option to >>> add IF EXISTS to all the drop commands (though changing the default >>> behavior would be more controversial).

Re: [BUGS] BUG #7873: pg_restore --clean tries to drop tables that don't exist

2013-02-19 Thread Pavel Stehule
Hello 2013/2/16 Pavel Stehule : > 2013/2/16 Tom Lane : >> Bruce Momjian writes: >>> On Fri, Feb 15, 2013 at 04:06:12PM -0600, Dave Rolsky wrote: Fair enough. It should probably an option to add "if exists", at least. I can't imagine I'm the only using this tool to ship database upd

Re: [BUGS] BUG #7873: pg_restore --clean tries to drop tables that don't exist

2013-02-16 Thread Pavel Stehule
2013/2/16 Tom Lane : > Bruce Momjian writes: >> On Fri, Feb 15, 2013 at 04:06:12PM -0600, Dave Rolsky wrote: >>> Fair enough. It should probably an option to add "if exists", at >>> least. I can't imagine I'm the only using this tool to ship database >>> updates around to different machines, some

Re: [BUGS] BUG #7873: pg_restore --clean tries to drop tables that don't exist

2013-02-16 Thread Tom Lane
Bruce Momjian writes: > On Fri, Feb 15, 2013 at 04:06:12PM -0600, Dave Rolsky wrote: >> Fair enough. It should probably an option to add "if exists", at >> least. I can't imagine I'm the only using this tool to ship database >> updates around to different machines, some of which may not have new >

Re: [BUGS] BUG #7873: pg_restore --clean tries to drop tables that don't exist

2013-02-15 Thread Bruce Momjian
On Fri, Feb 15, 2013 at 04:06:12PM -0600, Dave Rolsky wrote: > On Fri, 15 Feb 2013, Bruce Momjian wrote: > > >On Wed, Feb 13, 2013 at 08:22:43PM +, auta...@urth.org wrote: > >>The following bug has been logged on the website: > >> > >>Bug reference: 7873 > >>Logged by: Dave Rolsk

Re: [BUGS] BUG #7873: pg_restore --clean tries to drop tables that don't exist

2013-02-15 Thread Dave Rolsky
On Fri, 15 Feb 2013, Bruce Momjian wrote: On Wed, Feb 13, 2013 at 08:22:43PM +, auta...@urth.org wrote: The following bug has been logged on the website: Bug reference: 7873 Logged by: Dave Rolsky Email address: auta...@urth.org PostgreSQL version: 9.2.3 Operating system

Re: [BUGS] BUG #7873: pg_restore --clean tries to drop tables that don't exist

2013-02-15 Thread Bruce Momjian
On Wed, Feb 13, 2013 at 08:22:43PM +, auta...@urth.org wrote: > The following bug has been logged on the website: > > Bug reference: 7873 > Logged by: Dave Rolsky > Email address: auta...@urth.org > PostgreSQL version: 9.2.3 > Operating system: Linux > Description:

[BUGS] BUG #7873: pg_restore --clean tries to drop tables that don't exist

2013-02-13 Thread autarch
The following bug has been logged on the website: Bug reference: 7873 Logged by: Dave Rolsky Email address: auta...@urth.org PostgreSQL version: 9.2.3 Operating system: Linux Description: When you pass the --clean option to pg_restore it tries to drop tables without c