Re: [BUGS] BUG #6672: Memory leaks in dumputils.c

2012-06-04 Thread Peter Eisentraut
On fre, 2012-06-01 at 21:26 -0700, Josh Kupershmidt wrote: > It's too bad the clang > doesn't understand our ereport(ERROR, ...) calls don't return to the > caller, as those seem to account for a fair bit of the spurious > warnings. I haven't seen anything which I'd call an outright bug, > though t

Re: [BUGS] BUG #6672: Memory leaks in dumputils.c

2012-06-04 Thread Anna Zaks
On Fri, Jun 1, 2012 at 9:26 PM, Josh Kupershmidt wrote: > On Fri, Jun 1, 2012 at 4:23 PM, Anna Zaks wrote: > >> I opened an analyzer Bugzilla report for this issue in case you 'd >> like to follow up there: >> http://llvm.org/bugs/show_bug.cgi?id=13010 > > Thanks, I'll try to schedule another run

Re: [BUGS] BUG #6672: Memory leaks in dumputils.c

2012-06-04 Thread Anna Zaks
Josh, I opened an analyzer Bugzilla report for this issue in case you 'd like to follow up there: http://llvm.org/bugs/show_bug.cgi?id=13010 Thanks, Anna. On Fri, Jun 1, 2012 at 3:19 PM, Anna Zaks wrote: > On Fri, Jun 1, 2012 at 11:53 AM, Josh Kupershmidt wrote: >> On Fri, Jun 1, 2012 at 11:38

Re: [BUGS] BUG #6672: Memory leaks in dumputils.c

2012-06-04 Thread Anna Zaks
On Fri, Jun 1, 2012 at 11:53 AM, Josh Kupershmidt wrote: > On Fri, Jun 1, 2012 at 11:38 AM, Anna Zaks wrote: >> Josh, >> >> What kid of machine are you using? Please, let me know how long it >> took after it's done (It takes about one and a half hours on mine). > > It just finished, actually: too

Re: [BUGS] BUG #6672: Memory leaks in dumputils.c

2012-06-04 Thread Anna Zaks
On Fri, Jun 1, 2012 at 11:13 AM, Josh Kupershmidt wrote: > On Thu, May 31, 2012 at 10:06 PM, Tom Lane wrote: >> zaks.a...@gmail.com writes: > >>> There are two memory leaks in dumputils (v9.2.0beta1): >> >>> 1) >>> File:   src/bin/scripts/dumputils.c >>> Location:       line 604, column 11 >>> De

Re: [BUGS] BUG #6672: Memory leaks in dumputils.c

2012-06-04 Thread Anna Zaks
Peter, Some of the false positives can be suppressed by teaching the analyzer about the codebase. For example, many of them are due to the custom assertion/error handlers, where you stop execution on an error path by calling, for example, 'elog'. You can drastically reduce the number of false posi

Re: [BUGS] BUG #6672: Memory leaks in dumputils.c

2012-06-03 Thread Tom Lane
Josh Kupershmidt writes: >> zaks.a...@gmail.com writes: >>> There are two memory leaks in dumputils (v9.2.0beta1): > ... Both of these errors seem academic, since the callers > of buildACLCommands() will bail out with exit_horribly() or > exit_nicely() if it returns false. But IMO it's worth fixi

Re: [BUGS] BUG #6672: Memory leaks in dumputils.c

2012-06-01 Thread Josh Kupershmidt
On Fri, Jun 1, 2012 at 4:23 PM, Anna Zaks wrote: > I opened an analyzer Bugzilla report for this issue in case you 'd > like to follow up there: > http://llvm.org/bugs/show_bug.cgi?id=13010 Thanks, I'll try to schedule another run tonight and post additional details on that ticket. On Fri, Jun

Re: [BUGS] BUG #6672: Memory leaks in dumputils.c

2012-06-01 Thread Josh Kupershmidt
On Fri, Jun 1, 2012 at 11:38 AM, Anna Zaks wrote: > Josh, > > What kid of machine are you using? Please, let me know how long it > took after it's done (It takes about one and a half hours on mine). It just finished, actually: took about 7 hours to run, not counting the time the machine was aslee

Re: [BUGS] BUG #6672: Memory leaks in dumputils.c

2012-06-01 Thread Josh Kupershmidt
On Thu, May 31, 2012 at 10:06 PM, Tom Lane wrote: > zaks.a...@gmail.com writes: >> There are two memory leaks in dumputils (v9.2.0beta1): > >> 1) >> File:   src/bin/scripts/dumputils.c >> Location:       line 604, column 11 >> Description:    Memory is never released; potential leak of memory >>

Re: [BUGS] BUG #6672: Memory leaks in dumputils.c

2012-06-01 Thread Peter Geoghegan
On 1 June 2012 06:06, Tom Lane wrote: > There were no html reports attached, and I'd prefer plain text > anyway please ... I saw a number of false positives when I ran the Clang static analyser a few months ago. As I recall, I could see why the tool concluded that certain lines of code may have c

Re: [BUGS] BUG #6672: Memory leaks in dumputils.c

2012-05-31 Thread Tom Lane
zaks.a...@gmail.com writes: > The following bug has been logged on the website: > Bug reference: 6672 > Logged by: Anna Zaks > Email address: zaks.a...@gmail.com > PostgreSQL version: 9.1.3 > Operating system: MacOSX > Description: > There are two memory leaks in dumpu

[BUGS] BUG #6672: Memory leaks in dumputils.c

2012-05-31 Thread zaks . anna
The following bug has been logged on the website: Bug reference: 6672 Logged by: Anna Zaks Email address: zaks.a...@gmail.com PostgreSQL version: 9.1.3 Operating system: MacOSX Description: There are two memory leaks in dumputils (v9.2.0beta1): 1) File: src/bin/scr