Re: [BUGS] BUG #4680: Server crashed if using wrong (mismatch) conversion functions

2009-02-27 Thread Tom Lane
Heikki Linnakangas writes: > I think it would be good to have a circuit-breaker to break the infinite > recursion in case PANIC fails and recurses, for any reason. Well, your proposed patch replaces core dump due to stack overflow with core dump due to abort(), which is no improvement at all as

Re: [BUGS] BUG #4680: Server crashed if using wrong (mismatch) conversion functions

2009-02-27 Thread Heikki Linnakangas
Tom Lane wrote: Heikki Linnakangas writes: Tom Lane wrote: I wonder how ugly it would be to try to suppress encoding conversion as well? The error message might contain user data, which might contain non-ASCII characters. Or maybe not, but it seems like a shaky assumption to make. The pa

Re: [BUGS] BUG #4680: Server crashed if using wrong (mismatch) conversion functions

2009-02-27 Thread Tom Lane
Heikki Linnakangas writes: > Tom Lane wrote: >> I wonder how ugly it would be to try to suppress encoding >> conversion as well? > The error message might contain user data, which might contain non-ASCII > characters. Or maybe not, but it seems like a shaky assumption to make. The particular c

Re: [BUGS] BUG #4680: Server crashed if using wrong (mismatch) conversion functions

2009-02-27 Thread Heikki Linnakangas
Tom Lane wrote: Heikki Linnakangas writes: When the conversion function doesn't work, any attempt to send any text to the client will fail. Ah, now I remember: we arranged to short-circuit translation of the error message when we were in this situation. But it will still get passed through t

Re: [BUGS] BUG #4680: Server crashed if using wrong (mismatch) conversion functions

2009-02-27 Thread Tom Lane
Heikki Linnakangas writes: > When the conversion function doesn't work, any attempt to send any text > to the client will fail. Ah, now I remember: we arranged to short-circuit translation of the error message when we were in this situation. But it will still get passed through the encoding con

Re: [BUGS] BUG #4680: Server crashed if using wrong (mismatch) conversion functions

2009-02-27 Thread Heikki Linnakangas
Tom Lane wrote: Heikki Linnakangas writes: I think we should instead try to break the PANIC cycle. If we exceed ERRORDATA_STACK_SIZE, and we're already PANICing, we should just die immediately instead of throwing another PANIC about exceeding the stack size. The attached patch does that. I

Re: [BUGS] BUG #4680: Server crashed if using wrong (mismatch) conversion functions

2009-02-27 Thread Tom Lane
Heikki Linnakangas writes: > I think we should instead try to break the PANIC cycle. If we exceed > ERRORDATA_STACK_SIZE, and we're already PANICing, we should just die > immediately instead of throwing another PANIC about exceeding the stack > size. The attached patch does that. I don't think

Re: [BUGS] BUG #4680: Server crashed if using wrong (mismatch) conversion functions

2009-02-27 Thread Heikki Linnakangas
Denis Afonin wrote: test=# CREATE DEFAULT CONVERSION test1 FOR 'LATIN1' TO 'KOI8' FROM ascii_to_mic; CREATE CONVERSION test=# CREATE DEFAULT CONVERSION test2 FOR 'KOI8' TO 'LATIN1' FROM mic_to_ascii; CREATE CONVERSION test=# set client_encoding to 'LATIN1'; server closed the connection unexpected

[BUGS] BUG #4680: Server crashed if using wrong (mismatch) conversion functions

2009-02-27 Thread Denis Afonin
The following bug has been logged online: Bug reference: 4680 Logged by: Denis Afonin Email address: v...@itkm.ru PostgreSQL version: 8.3.6 Operating system: Linux Debian Lenny Description:Server crashed if using wrong (mismatch) conversion functions Details: I do: