Re: [BUGS] BUG #4374: pg_restore does not restore public schema comment

2008-09-05 Thread Bruce Momjian
Tom Lane wrote: > Craig Ringer <[EMAIL PROTECTED]> writes: > > The issue actually appears to be that the comment on default schema like > > `public' isn't dumped in the first place. > > Hmm ... there is a specific exclusion in _printTocEntry to suppress > dumping of either the CREATE SCHEMA comman

Re: [BUGS] BUG #4374: pg_restore does not restore public schema comment

2008-08-26 Thread Daniel Migowski
Hallo Craig, Craig Ringer schrieb: So: the user's report is incorrect in blaming pg_restore, but correct in that comments on the public schema (and presumably other default schema) aren't preserved by pg_dump | pg_restore. The real reason appears to be that they're not dumped in the first place.

Re: [BUGS] BUG #4374: pg_restore does not restore public schema comment

2008-08-25 Thread Tom Lane
Craig Ringer <[EMAIL PROTECTED]> writes: > The issue actually appears to be that the comment on default schema like > `public' isn't dumped in the first place. Hmm ... there is a specific exclusion in _printTocEntry to suppress dumping of either the CREATE SCHEMA command for "public" or its commen

Re: [BUGS] BUG #4374: pg_restore does not restore public schema comment

2008-08-25 Thread Craig Ringer
Tom Lane wrote: > "Daniel Migowski" <[EMAIL PROTECTED]> writes: >> Currently a schema dump (custom format, containing the public schema >> comment) can be restored, but the public schema version is not restored. > >> I assume you check if a schema already exists and the skip the schema part. > >

Re: [BUGS] BUG #4374: pg_restore does not restore public schema comment

2008-08-25 Thread Tom Lane
"Daniel Migowski" <[EMAIL PROTECTED]> writes: > Currently a schema dump (custom format, containing the public schema > comment) can be restored, but the public schema version is not restored. > I assume you check if a schema already exists and the skip the schema part. That assumption is false, s

[BUGS] BUG #4374: pg_restore does not restore public schema comment

2008-08-25 Thread Daniel Migowski
The following bug has been logged online: Bug reference: 4374 Logged by: Daniel Migowski Email address: [EMAIL PROTECTED] PostgreSQL version: 8.3.3 Operating system: Windows Description:pg_restore does not restore public schema comment Details: Hello dear developers