Re: [BUGS] BUG #3760: Comment on restore database

2007-11-20 Thread Simon Riggs
On Mon, 2007-11-19 at 18:38 -0500, Tom Lane wrote: > Simon Riggs <[EMAIL PROTECTED]> writes: > > Reason to do this now: Perf Tips have been changed for 8.3 to recommend > > using --single-transaction when restoring pg_dumps, because of fast COPY > > enhancement. Allowing this to cause an error will

Re: [BUGS] BUG #3760: Comment on restore database

2007-11-19 Thread Bruce Momjian
Tom Lane wrote: > Bruce Momjian <[EMAIL PROTECTED]> writes: > > Tom Lane wrote: > >> This is an extremely poorly phrased TODO item. > > > OK, updated: > > > o Prevent COMMENT ON dbname from issuing a warning when loading > > into a database with a different name, perhaps using C

Re: [BUGS] BUG #3760: Comment on restore database

2007-11-19 Thread Tom Lane
Bruce Momjian <[EMAIL PROTECTED]> writes: > Tom Lane wrote: >> This is an extremely poorly phrased TODO item. > OK, updated: > o Prevent COMMENT ON dbname from issuing a warning when loading > into a database with a different name, perhaps using COMMENT ON > CURRENT DA

Re: [BUGS] BUG #3760: Comment on restore database

2007-11-19 Thread Bruce Momjian
Tom Lane wrote: > Bruce Momjian <[EMAIL PROTECTED]> writes: > > I have added a TODO item: > > > o Allow COMMENT ON dbname to work when loading into a database > > with a different name > > This is an extremely poorly phrased TODO item. The problem is not that > you can't commen

Re: [BUGS] BUG #3760: Comment on restore database

2007-11-19 Thread Tom Lane
Bruce Momjian <[EMAIL PROTECTED]> writes: > I have added a TODO item: > o Allow COMMENT ON dbname to work when loading into a database > with a different name This is an extremely poorly phrased TODO item. The problem is not that you can't comment on a database with a different

Re: [BUGS] BUG #3760: Comment on restore database

2007-11-19 Thread Tom Lane
Simon Riggs <[EMAIL PROTECTED]> writes: > Reason to do this now: Perf Tips have been changed for 8.3 to recommend > using --single-transaction when restoring pg_dumps, because of fast COPY > enhancement. Allowing this to cause an error will prevent the whole dump > from restoring. If it were indee

Re: [BUGS] BUG #3760: Comment on restore database

2007-11-19 Thread Simon Riggs
On Mon, 2007-11-19 at 14:27 -0500, Bruce Momjian wrote: > Alvaro Herrera wrote: > > Bruce Momjian wrote: > > > Malcus Imhof wrote: > > > > > Yea, the dump thinks it is going into the same database. I don't see > > > any way of fixing that. We don't allow functions for the object name. > > > If

Re: [BUGS] BUG #3760: Comment on restore database

2007-11-19 Thread Bruce Momjian
Alvaro Herrera wrote: > Bruce Momjian wrote: > > Malcus Imhof wrote: > > > Yea, the dump thinks it is going into the same database. I don't see > > any way of fixing that. We don't allow functions for the object name. > > If we did we could use current_database(). Fortunately I think it is > >

Re: [BUGS] BUG #3760: Comment on restore database

2007-11-19 Thread Alvaro Herrera
Bruce Momjian wrote: > Malcus Imhof wrote: > Yea, the dump thinks it is going into the same database. I don't see > any way of fixing that. We don't allow functions for the object name. > If we did we could use current_database(). Fortunately I think it is > the only place where the database n

Re: [BUGS] BUG #3760: Comment on restore database

2007-11-19 Thread Bruce Momjian
Malcus Imhof wrote: > > The following bug has been logged online: > > Bug reference: 3760 > Logged by: Malcus Imhof > Email address: [EMAIL PROTECTED] > PostgreSQL version: 8.2.5 > Operating system: Windows 2003 > Description:Comment on restore database > Details: >

[BUGS] BUG #3760: Comment on restore database

2007-11-19 Thread Malcus Imhof
The following bug has been logged online: Bug reference: 3760 Logged by: Malcus Imhof Email address: [EMAIL PROTECTED] PostgreSQL version: 8.2.5 Operating system: Windows 2003 Description:Comment on restore database Details: When I'm restoring a dump done in a datab