Re: [BUGS] BUG #2685: Wrong charset of server messages on client

2006-10-12 Thread Sergiy Vyshnevetskiy
On Tue, 10 Oct 2006, Tom Lane wrote: Sergiy Vyshnevetskiy <[EMAIL PROTECTED]> writes: Here is a new and improved patch, that closes security hole as well. We really can't consider a patch like this, because not only does it ignore the problem of multiple spellings of encoding names, but it ac

Re: [BUGS] BUG #2685: Wrong charset of server messages on client

2006-10-10 Thread Tom Lane
Sergiy Vyshnevetskiy <[EMAIL PROTECTED]> writes: > Here is a new and improved patch, that closes security hole as well. We really can't consider a patch like this, because not only does it ignore the problem of multiple spellings of encoding names, but it actually breaks existing functionality on

Re: [BUGS] BUG #2685: Wrong charset of server messages on client

2006-10-10 Thread Sergiy Vyshnevetskiy
On Tue, 10 Oct 2006, Sergiy Vyshnevetskiy wrote: On Tue, 10 Oct 2006, Tom Lane wrote: Sergiy Vyshnevetskiy <[EMAIL PROTECTED]> writes: > > It's not magic, it's from ICU patch. Want me to send you a copy? :) You're missing my point, which is that non-ICU locale support doesn't necessarily

Re: [BUGS] BUG #2685: Wrong charset of server messages on client

2006-10-10 Thread Sergiy Vyshnevetskiy
On Tue, 10 Oct 2006, Tom Lane wrote: Sergiy Vyshnevetskiy <[EMAIL PROTECTED]> writes: It's not magic, it's from ICU patch. Want me to send you a copy? :) You're missing my point, which is that non-ICU locale support doesn't necessarily recognize the same encoding names. We would have done th

Re: [BUGS] BUG #2685: Wrong charset of server messages on client

2006-10-10 Thread Sergiy Vyshnevetskiy
On Tue, 10 Oct 2006, Tom Lane wrote: "Sergiy Vyshnevetskiy" <[EMAIL PROTECTED]> writes: Convert server messages to database charset. This has been discussed before: http://archives.postgresql.org/pgsql-patches/2005-08/msg00245.php The magic pg_enc2iananame_tbl[] you reference in your patch d

Re: [BUGS] BUG #2685: Wrong charset of server messages on client [PATCH]

2006-10-10 Thread Tom Lane
Sergiy Vyshnevetskiy <[EMAIL PROTECTED]> writes: >> It's not magic, it's from ICU patch. Want me to send you a copy? :) You're missing my point, which is that non-ICU locale support doesn't necessarily recognize the same encoding names. We would have done this years ago if we had a solution to th

Re: [BUGS] BUG #2685: Wrong charset of server messages on client

2006-10-10 Thread Sergiy Vyshnevetskiy
On Tue, 10 Oct 2006, Sergiy Vyshnevetskiy wrote: On Tue, 10 Oct 2006, Sergiy Vyshnevetskiy wrote: On Tue, 10 Oct 2006, Tom Lane wrote: > "Sergiy Vyshnevetskiy" <[EMAIL PROTECTED]> writes: > > Convert server messages to database charset. > > This has been discussed before: > http://

Re: [BUGS] BUG #2685: Wrong charset of server messages on client

2006-10-10 Thread Sergiy Vyshnevetskiy
On Tue, 10 Oct 2006, Sergiy Vyshnevetskiy wrote: On Tue, 10 Oct 2006, Tom Lane wrote: "Sergiy Vyshnevetskiy" <[EMAIL PROTECTED]> writes: > Convert server messages to database charset. This has been discussed before: http://archives.postgresql.org/pgsql-patches/2005-08/msg00245.php The m

Re: [BUGS] BUG #2685: Wrong charset of server messages on client [PATCH]

2006-10-10 Thread Tom Lane
"Sergiy Vyshnevetskiy" <[EMAIL PROTECTED]> writes: > Convert server messages to database charset. This has been discussed before: http://archives.postgresql.org/pgsql-patches/2005-08/msg00245.php The magic pg_enc2iananame_tbl[] you reference in your patch does not exist, and if it did exist it wo

[BUGS] BUG #2685: Wrong charset of server messages on client [PATCH]

2006-10-10 Thread Sergiy Vyshnevetskiy
The following bug has been logged online: Bug reference: 2685 Logged by: Sergiy Vyshnevetskiy Email address: [EMAIL PROTECTED] PostgreSQL version: 8.1 Operating system: FreeBSD-6 stable Description:Wrong charset of server messages on client [PATCH] Details: DESCRIPT