Re: [BUGS] BUG #1270: stack overflow in thread in fe_getauthname

2004-09-27 Thread Bruce Momjian
Tom Lane wrote: > Bruce Momjian <[EMAIL PROTECTED]> writes: > > Oops. Yep, that is sloppy programming on our part, perhaps my part if I > > added those. Anyway, patch attached and applied. I used the proper > > struct sizes instead of BUFSIZ. > > You just broke it. > > Those buffers are not use

Re: [BUGS] BUG #1270: stack overflow in thread in fe_getauthname

2004-09-27 Thread Bruce Momjian
Tom Lane wrote: > "PostgreSQL Bugs List" <[EMAIL PROTECTED]> writes: > > With the THREAD_SAFETY changes, a buffer is defined on the stack as: > > char pwdbuf[BUFSIZ]; > > This buffer overflows the stack when used in a thread. As the application > > creating the thread cannot be modified to

Re: [BUGS] BUG #1270: stack overflow in thread in fe_getauthname

2004-09-27 Thread Tom Lane
Bruce Momjian <[EMAIL PROTECTED]> writes: > Oops. Yep, that is sloppy programming on our part, perhaps my part if I > added those. Anyway, patch attached and applied. I used the proper > struct sizes instead of BUFSIZ. You just broke it. Those buffers are not used to hold struct passwd's, but t

Re: [BUGS] BUG #1270: stack overflow in thread in fe_getauthname

2004-09-27 Thread Tom Lane
"PostgreSQL Bugs List" <[EMAIL PROTECTED]> writes: > With the THREAD_SAFETY changes, a buffer is defined on the stack as: > char pwdbuf[BUFSIZ]; > This buffer overflows the stack when used in a thread. As the application > creating the thread cannot be modified to increase the stack size, i

Re: [BUGS] BUG #1270: stack overflow in thread in fe_getauthname

2004-09-27 Thread Bruce Momjian
Oops. Yep, that is sloppy programming on our part, perhaps my part if I added those. Anyway, patch attached and applied. I used the proper struct sizes instead of BUFSIZ. This will be in 8.0. I think it is too risky for 7.4.X but if others disagree, let me know. --

[BUGS] BUG #1270: stack overflow in thread in fe_getauthname

2004-09-27 Thread PostgreSQL Bugs List
The following bug has been logged online: Bug reference: 1270 Logged by: Peter Davie Email address: [EMAIL PROTECTED] PostgreSQL version: 7.4.5 Operating system: OSF/1 4.0f Description:stack overflow in thread in fe_getauthname Details: With the THREAD_SAFETY c