Re: [BUGS] [PATCH v2] Use CC atomic builtins as a fallback

2011-12-21 Thread Tom Lane
Martin Pitt writes: > Tom Lane [2011-12-20 21:14 -0500]: >> Another thing that is bothering me is that according to the gcc >> manual, eg here, >> http://gcc.gnu.org/onlinedocs/gcc-4.1.2/gcc/Atomic-Builtins.html >> __sync_lock_test_and_set is nominally provided for datatypes 1, 2, >> 4, or 8 bytes

Re: [BUGS] [PATCH v2] Use CC atomic builtins as a fallback

2011-12-21 Thread Martin Pitt
Hello Tom, all, Tom Lane [2011-12-20 21:14 -0500]: > Getting this thread back to the original patch ... I'm afraid that if we > apply this as-is, what will happen is that we fix ARMv7 and break older > versions. Right, I guess it's dependent on the compiler version, too. That's why my original pa

Re: [BUGS] [PATCH v2] Use CC atomic builtins as a fallback

2011-12-20 Thread Tom Lane
Martin Pitt writes: > The updated patch only uses the gcc builtins if there is no explicit > implementation, but drops the arm one as this doesn't work on ARMv7 > and newer, as stated in the original mail. Getting this thread back to the original patch ... I'm afraid that if we apply this as-is,

[BUGS] [PATCH v2] Use CC atomic builtins as a fallback

2011-12-19 Thread Martin Pitt
Robert Haas [2011-12-19 9:31 -0500]: > -1. Absent some evidence that gcc's implementations are superior to > ours, I think we should not change stuff that works now. That's > likely to lead to subtle bugs that are hard to find and perhaps > dependent on the exact compiler version used. > > But