[BUGS] Re: windows 8 RTM compatibility issue (could not reserve shared memory region for child)

2013-07-04 Thread Noah Misch
comes into play when your software already has a flaw and potentially reduces the impact of that flaw. > I've attached a patch that implements the stuff above. I can share the > code for the program that tests whether an address is reliably available > in a newborn postgres p

Re: [BUGS] PITR potentially broken in 9.2

2012-11-27 Thread Noah Misch
On Tue, Nov 27, 2012 at 10:08:12AM -0800, Jeff Janes wrote: > Doing PITR in 9.2.1, the system claims that it reached a consistent > recovery state immediately after redo starts. > This leads to it various mysterious failures, when it should instead > throw a "requested recovery stop point is before

Re: [BUGS] BUG #6510: A simple prompt is displayed using wrong charset

2012-10-15 Thread Noah Misch
On Mon, Oct 15, 2012 at 05:41:36AM -0400, Noah Misch wrote: > > --- a/src/port/sprompt.c > > +++ b/src/port/sprompt.c > > @@ -60,8 +60,13 @@ simple_prompt(const char *prompt, int maxlen, bool echo) > > * Do not try to collapse these into one "w+" mode fil

Re: [BUGS] BUG #6510: A simple prompt is displayed using wrong charset

2012-10-15 Thread Noah Misch
On Sun, Oct 14, 2012 at 12:10:42PM -0400, Tom Lane wrote: > Alexander Law writes: > > > +#ifdef WIN32 > > + termin = fopen("CONIN$", "r"); > > + termout = fopen("CONOUT$", "w+"); > > +#else > > termin = fopen(DEVTTY, "r"); > > termout = fopen(DEVTTY, "w"); > > +#endif > > if (!ter

Re: [BUGS] BUG #6510: A simple prompt is displayed using wrong charset

2012-10-15 Thread Noah Misch
On Sun, Oct 14, 2012 at 10:35:04AM +0400, Alexander Law wrote: > I agree with you, CONOUT$ way is much simpler. Please look at the patch. See comments below. > Regarding msys - yes, that check was not correct. > In fact you can use "con" with msys, if you run sh.exe, not a graphical > terminal.

Re: [BUGS] BUG #6510: A simple prompt is displayed using wrong charset

2012-10-10 Thread Noah Misch
Hi Alexander, I was able to reproduce the problem based on your description and test case, and your change does resolve it for me. On Tue, Mar 20, 2012 at 11:50:14PM +0400, Alexander LAW wrote: > Thanks, I've understood your point. > Please look at the patch. It implements the first way and it ma

[BUGS] Re: BUG #6712: PostgreSQL 9.2 beta2: alter table drop constraint does not work on inherited master table

2012-07-19 Thread Noah Misch
On Tue, Jul 17, 2012 at 08:59:50AM +, Amit kapila wrote: > Patch is attached with this mail. Thanks. This patch is ready for committer. > +-- Test non-inheritable indices [UNIQUE, EXCLUDE] contraints > +CREATE TABLE test_constraints (id int, val1 varchar, val2 int, UNIQUE(val1, > val2)); >

Re: [BUGS] Re: BUG #6712: PostgreSQL 9.2 beta2: alter table drop constraint does not work on inherited master table

2012-07-16 Thread Noah Misch
On Mon, Jul 16, 2012 at 12:47:37PM -0400, Tom Lane wrote: > Noah Misch writes: > > As a side question for the list, should we fix this differently in 9.2 to > > avoid forcing an initdb for the next beta? > > I'm confused, why would an initdb be involved? pg_constraint

[BUGS] Re: BUG #6712: PostgreSQL 9.2 beta2: alter table drop constraint does not work on inherited master table

2012-07-16 Thread Noah Misch
On Mon, Jul 16, 2012 at 04:49:46PM +0530, Amit Kapila wrote: > Code Changes > > I will make changes in following functions to ensure that connoinherit > should be appropriately set(pass the value as true). > a. index_constraint_create() > b. ATAddForeignKeyConstraint() > c. Cre

[BUGS] Re: BUG #6712: PostgreSQL 9.2 beta2: alter table drop constraint does not work on inherited master table

2012-07-15 Thread Noah Misch
On Mon, Jul 02, 2012 at 04:16:31PM +0530, Amit Kapila wrote: > > From: pgsql-bugs-ow...@postgresql.org > > [mailto:pgsql-bugs-ow...@postgresql.org] On Behalf Of > > miroslav.s...@fordfrog.com > > Sent: Saturday, June 30, 2012 4:28 PM > > test=# create table test_constraints (id int, val1 varchar

Re: [BUGS] fatal flex error in guc-file.l kills the postmaster

2012-01-17 Thread Noah Misch
On Mon, Jan 16, 2012 at 08:54:53PM -0500, Robert Haas wrote: > On Sun, Dec 18, 2011 at 11:53 AM, Noah Misch wrote: > > Here's a version that calls sigsetjmp() once per file. ?While > > postgresql.conf > > scanning hardly seems like the place to be shaving cycles, this d

Re: [BUGS] Re: BUG #6264: Superuser does not have inherent Replication permission

2012-01-14 Thread Noah Misch
On Sat, Jan 14, 2012 at 06:34:25PM +0200, Heikki Linnakangas wrote: > On 02.01.2012 21:46, Noah Misch wrote: >> On Fri, Oct 28, 2011 at 11:42:38AM -0400, Noah Misch wrote: >>> On Fri, Oct 28, 2011 at 09:32:30AM -0400, Robert Haas wrote: >>>> On Thu, Oct 27, 20

Re: [BUGS] Re: BUG #6264: Superuser does not have inherent Replication permission

2012-01-02 Thread Noah Misch
On Fri, Oct 28, 2011 at 11:42:38AM -0400, Noah Misch wrote: > On Fri, Oct 28, 2011 at 09:32:30AM -0400, Robert Haas wrote: > > On Thu, Oct 27, 2011 at 6:15 PM, Tom Lane wrote: > > > Noah Misch writes: > > >> Let's look at the behavior of DDL-exposed access con

Re: [BUGS] Re: [PATCH] Use CC atomic builtins if available [was: Re: TAS patch for building on armel/armhf thumb]

2011-12-19 Thread Noah Misch
On Mon, Dec 19, 2011 at 11:25:06PM +0200, Heikki Linnakangas wrote: > I compiled the attached test program on an HP Itanium box, using the > same flags you get from PostgreSQL's configure on that box. The relevant > assembler output is: > > xchg4 r14 = [r15], r14 //

[BUGS] Re: [PATCH] Use CC atomic builtins if available [was: Re: TAS patch for building on armel/armhf thumb]

2011-12-19 Thread Noah Misch
On Mon, Dec 19, 2011 at 05:09:11PM +0200, Heikki Linnakangas wrote: > Actually, I believe our Itanium (and possibly ARM, too) implementation > of S_UNLOCK() is wrong as it is. There is no platform-specific > S_UNLOCK() defined for Itanium, so we're using the generic > implementation: > > #if !

Re: [BUGS] fatal flex error in guc-file.l kills the postmaster

2011-12-18 Thread Noah Misch
On Sat, Dec 17, 2011 at 11:04:43PM -0500, Tom Lane wrote: > Noah Misch writes: > > Setting aside whether we should offer a better diagnostic when a user points > > "include" at a directory, the yy_fatal_error hack that made sense for scan.l > > doesn't cu

[BUGS] fatal flex error in guc-file.l kills the postmaster

2011-12-16 Thread Noah Misch
While testing the configuration include directory patch, I decided to try the regular postgresql.conf "include" on a directory: include 'base' Reloading the configuration then rather rudely kills the postmaster: FATAL: input in flex scanner failed Setting aside whether we should offer a be

Re: [BUGS] possible bug seen with -DCLOBBER_CACHE_ALWAYS and changing GUCs

2011-12-04 Thread Noah Misch
On Wed, Nov 30, 2011 at 08:10:22PM -0500, Tom Lane wrote: > Jeff Davis writes: > > SQL: > > set datestyle to postgres,us; > > prepare stmt as select '02-01-2011'::date::text; > > execute stmt; > > set datestyle to postgres,euro; > > execute stmt; > > deallocate stmt; > > > The results

Re: [BUGS] Re: BUG #6264: Superuser does not have inherent Replication permission

2011-10-28 Thread Noah Misch
On Fri, Oct 28, 2011 at 09:32:30AM -0400, Robert Haas wrote: > On Thu, Oct 27, 2011 at 6:15 PM, Tom Lane wrote: > > Noah Misch writes: > >> Let's look at the behavior of DDL-exposed access constraints for > >> precedent. ?We > >> currently have three

[BUGS] Re: BUG #6264: Superuser does not have inherent Replication permission

2011-10-27 Thread Noah Misch
On Thu, Oct 27, 2011 at 01:45:34PM -0400, Robert Haas wrote: > On Tue, Oct 25, 2011 at 8:39 AM, Magnus Hagander wrote: > > On Mon, Oct 24, 2011 at 16:37, Keith Fiske wrote: > >> On Sat, Oct 22, 2011 at 11:49 AM, Tom Lane wrote: > >>> "Keith Fiske" writes: > >> > If you create a user as a N

Re: [BUGS] BUG #5741: syslog line length

2011-08-05 Thread Noah Misch
On Fri, Aug 05, 2011 at 06:46:21PM -0400, Tom Lane wrote: > Noah Misch writes: > > A PG_SYSLOG_LIMIT value that loses data to truncation on nearly every > > default > > GNU/Linux installation makes for a poor default. > > When I changed it, it was on the strength o

Re: [BUGS] BUG #5741: syslog line length

2011-08-05 Thread Noah Misch
8 Perhaps, though, the default should be outright conservative, like 512. We could also have a compile-time fixed overhead and factor in actual lengths of parts we know at runtime, but that smells like overkill. Opinions? -- Noah Mischhttp://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services -- Sent via pgsql-bugs mailing list (pgsql-bugs@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-bugs

[BUGS] Re: BUG #6052: ADD COLUMN - ERROR: tables can have at most 1600 columns

2011-06-07 Thread Noah Misch
On Sat, Jun 04, 2011 at 07:09:27AM +, dinesh wrote: > I have a table which is used during data uploads, a so-called staging table. > This table has a fixed number of columns that [must] match the input CSV > file. This CSV file is uploaded using COPY command. Following the COPY, a > new column

[BUGS] Re: Bug with STABLE function using the wrong snapshot (probably during planning)

2011-05-10 Thread Noah Misch
Hi Matthijs, Thanks for the report. On Tue, Mar 22, 2011 at 04:31:47PM +0100, Matthijs Bomhoff wrote: > The bit of SQL below does not behave the way it should on postgres 8.4.4 > (tested by me) and 9.0.3 (verified independently on #postgresql). On git master, too. > The third statement in the