Re: [BUGS] Problem identifying constraints which should not be inherited

2008-04-02 Thread NikhilS
Hi Alvaro On Fri, Mar 28, 2008 at 6:05 PM, Alvaro Herrera <[EMAIL PROTECTED]> wrote: > NikhilS escribió: > > > I will take a look at the pg_dump related changes if you want. We will > need > > changes in flagInhAttrs() and in getTableAttrs() to query the backend >

Re: [BUGS] Problem identifying constraints which should not be inherited

2008-03-28 Thread NikhilS
Hi Alex, On Fri, Mar 28, 2008 at 4:58 AM, Alex Hunsaker <[EMAIL PROTECTED]> wrote: > On Thu, Mar 27, 2008 at 5:14 AM, NikhilS <[EMAIL PROTECTED]> wrote: > > * Add logic to disallow ADD CONSTRAINT ONLY to parent of an inheritance > > hierarchy > > > > * Add

Re: [BUGS] Problem identifying constraints which should not be inherited

2008-03-27 Thread NikhilS
ready mentions that we should make changes in pg_constraint to avoid this rudimentary way of determing the inheritance :). Am important decision here is about adding a new attribute to pg_constraint as it is the only sane way of determining inherited constraints, but that will require an initdb. Comm

Re: [BUGS] Problem identifying constraints which should not be inherited

2008-03-20 Thread NikhilS
Hi, On Thu, Mar 20, 2008 at 6:11 PM, Alvaro Herrera <[EMAIL PROTECTED]> wrote: > NikhilS escribió: > > > On Wed, Mar 19, 2008 at 8:23 PM, Tom Lane <[EMAIL PROTECTED]> wrote: > > > > If it's a small patch, it's wrong by definition. AFAICS ther

Re: [BUGS] Problem identifying constraints which should not be inherited

2008-03-19 Thread NikhilS
Hi, On Wed, Mar 19, 2008 at 8:23 PM, Tom Lane <[EMAIL PROTECTED]> wrote: > NikhilS <[EMAIL PROTECTED]> writes: > > On Fri, Mar 7, 2008 at 6:37 AM, Bruce Momjian <[EMAIL PROTECTED]> wrote: > >> Added to TODO: > >> o Require all CHECK constraints to b

Re: [BUGS] Problem identifying constraints which should not be inherited

2008-03-19 Thread NikhilS
ns like ADD COLUMN already in place too. Regards, Nikhils -- EnterpriseDB http://www.enterprisedb.com Index: src/backend/commands/tablecmds.c === RCS file: /repositories/postgreshome/cvs/pgsql/src/backend/commands/tablecmds.c,v re

Re: [BUGS] BUG #3829: Wrong index reporting from pgAdmin III (v1.8.0 rev 6766-6767)

2007-12-19 Thread NikhilS
> (1 row) > > Looks like pg_get_indexdef is unwell :-( yes, it was unwell in the area where the amcanorder was being processed. The attached patch should fix this. Regards, Nikhils -- EnterpriseDB http://www.enterprisedb.com Index: src/backend/utils/adt/ruleutils.c ===

Re: [BUGS] BUG #3811: Getting multiple values from a sequence generator

2007-12-10 Thread NikhilS
form a new set of values[], nulls[] entries before forming the corresponding tuple entry. I think the above will be a very useful enhancement to COPY. The syntax and other details mentioned above are ofcourse subject to discussion and approval on the list. Regards, Nikhils -- EnterpriseDB http://www.enterprisedb.com

Re: [HACKERS] [BUGS] BUG #3774: create table like including index doesn't update pg_constraints with primary key

2007-12-02 Thread NikhilS
confusing. I believe we should remove the following TODO now that the above has been checked in: CREATE - Have WITH CONSTRAINTS also create constraint indexes http://archives.postgresql.org/pgsql-patches/2007-04/msg00149.php Regards, Nikhils -- EnterpriseDB http://www.enterprisedb.com

Re: [BUGS] BUG #3774: create table like including index doesn't update pg_constraints with primary key

2007-11-29 Thread NikhilS
.com/Re%3A-CREATE-TABLE-LIKE-INCLUDING-INDEXES-support-p10683716.html maybe we should not? In other words "INCLUDING INDEXES" should only create those indexes which do not have isconstraint set to TRUE. Comments? Regards, Nikhils -- EnterpriseDB http://www.enterprisedb.com