Re: [BUGS] bool: symbol name collision

2010-05-11 Thread Bryan Henderson
it finds HAVE_BOOL defined? Then you could put in the user guide where it talks about what header files and macros a server extension needs if your program defines bool independently, define HAVE_BOOL and if you want Postgres to define it, don't. -- Bryan Henderson

Re: [BUGS] bool: symbol name collision

2010-05-11 Thread Bryan Henderson
hours to trace it back to my workaround and try something else. So it would be an improvement to remove the code that purports to cope with other definitions of bool. And maybe add a comment emphasizing that "bool" is part of the binary interface between server ext

Re: [BUGS] bool: symbol name collision

2010-05-10 Thread Bryan Henderson
inversely proportional to how popular the distribution was. Likewise, programmers who defined "bool" in their own private code were (and I guess still are) largely the inexperienced ones -- who hadn't yet been bitten by an interface header file that arrogantly claimed the name &quo

Re: [BUGS] bool: symbol name collision

2010-05-10 Thread Bryan Henderson
. >We did actually include a sizable patch into 9.0 to remove conflicts >with C++ reserved words (typename and such). I don't recall any >complaints about bool at the time. Bear in mind that this isn't a syntax error - the compiler simply generates the wrong code. -- Bryan

Re: [BUGS] bool: symbol name collision

2010-05-09 Thread Bryan Henderson
tension #includes a header file that #includes another that #includes the C99 standard header file . The server extension also #includes . The compile fails with the multiple definition of type "bool". Here's a worse one (but hypothetical; I haven

Re: [BUGS] reference to undefined macro _MSC_VER

2010-05-09 Thread Bryan Henderson
y excited about that. The thing is, you don't have to get terribly excited. Just slightly interested. Because it just takes two lines of code with zero chance of messing up anything to provide something with a practical use that makes logical sense as well. -- Bryan Henderson

[BUGS] bool: symbol name collision

2010-05-08 Thread Bryan Henderson
rver and user program are compiled with bools of different sizes, disaster occurs. Postgres's bool is one byte; often, bool is 4 bytes. I saw this in Postgres 8.4.3. -- Bryan Henderson San Jose, California -- Sent via pgsql-bugs mailing list (pgsql-bugs@post

[BUGS] reference to undefined macro _MSC_VER

2010-05-08 Thread Bryan Henderson
der file can work in all environments, it should have an #ifdef. I see this in Postgres 8.4.3. -- Bryan Henderson San Jose, California -- Sent via pgsql-bugs mailing list (pgsql-bugs@postgresql.org) To make changes to your subscription: http://www.postgresql.org/

[BUGS] BUG #5386: HBA rejection error message incorrect

2010-03-24 Thread Bryan Henderson
The following bug has been logged online: Bug reference: 5386 Logged by: Bryan Henderson Email address: bry...@giraffe-data.com PostgreSQL version: 8.4.3 Operating system: Linux Description:HBA rejection error message incorrect Details: The two usernames are