Re: [BUGS] 9.2 beta2 - pg_ctl crashes on Win32 when neither PGDATA nor -D specified

2012-06-13 Thread Amit Kapila
Please Find the patch based on idea I have suggested attached with this mail. Let me know your comments regarding the same. -Original Message- From: pgsql-bugs-ow...@postgresql.org [mailto:pgsql-bugs-ow...@postgresql.org] On Behalf Of Alvaro Herrera Sent: Wednesday, June 13, 2012 9:23 PM

Re: [BUGS] BUG #6666: pg_upgrade 9.2beta1 plpython/plpython2

2012-06-13 Thread Bruce Momjian
On Fri, Jun 08, 2012 at 11:32:40AM -0400, Robert Haas wrote: > On Fri, Jun 1, 2012 at 11:48 AM, Bruce Momjian wrote: > > Should this be back-patched?  (Problem first reported in PG 9.1 due to > > the removal of a backward-compatibility symlink.)  I am not sure we have > > had enough problem report

Re: [BUGS] 9.2 beta2 - pg_ctl crashes on Win32 when neither PGDATA nor -D specified

2012-06-13 Thread Alvaro Herrera
Excerpts from Amit Kapila's message of mié jun 13 00:53:47 -0400 2012: > > Unfortunately in src/backend/main/main.c it only does a cursory check > > for --help and --version. So it would need to become a little more > > complicated to scan for -C options at that stage. It's not too much > > if y

Re: [BUGS] 9.2 beta2 - pg_ctl crashes on Win32 when neither PGDATA nor -D specified

2012-06-13 Thread Bruce Momjian
On Wed, Jun 13, 2012 at 04:08:20PM +0100, Dave Page wrote: > On Wed, Jun 13, 2012 at 3:51 PM, Bruce Momjian wrote: > > On Mon, Jun 11, 2012 at 10:23:00PM -0400, Tom Lane wrote: > >> Hm, that patch seems to be several bricks shy of a load.  I will fix > >> two obvious bugs in it: > >> > >> (1) not

Re: [BUGS] 9.2 beta2 - pg_ctl crashes on Win32 when neither PGDATA nor -D specified

2012-06-13 Thread Dave Page
On Wed, Jun 13, 2012 at 3:51 PM, Bruce Momjian wrote: > On Mon, Jun 11, 2012 at 10:23:00PM -0400, Tom Lane wrote: >> Hm, that patch seems to be several bricks shy of a load.  I will fix >> two obvious bugs in it: >> >> (1) not dump core on boxes where printf("%s", NULL) dumps core; >> >> (2) not t

Re: [BUGS] 9.2 beta2 - pg_ctl crashes on Win32 when neither PGDATA nor -D specified

2012-06-13 Thread Bruce Momjian
On Mon, Jun 11, 2012 at 10:23:00PM -0400, Tom Lane wrote: > Hm, that patch seems to be several bricks shy of a load. I will fix > two obvious bugs in it: > > (1) not dump core on boxes where printf("%s", NULL) dumps core; > > (2) not try to call adjust_data_dir before complaining for lack of > a

Re: [BUGS] PostgreSQL 9.2 beta1's pg_upgrade fails on Windows XP

2012-06-13 Thread Bruce Momjian
On Tue, Jun 12, 2012 at 05:10:19PM +1200, Edmund Horner wrote: > On 26 May 2012 01:10, Bruce Momjian wrote: > > Ah, turns out I only need one extra log file on Windows, not two, > > because I can reuse the utility file for pg_ctl stop.  The original > > beta1 code usesd the utility file for pg_ctl

Re: [BUGS] Tab completion of function arguments not working in all cases

2012-06-13 Thread Dean Rasheed
On 12 June 2012 21:27, Josh Kupershmidt wrote: > On Sat, Jun 9, 2012 at 2:40 AM, Dean Rasheed wrote: > >> I noticed this while testing 9.2, but it seems to go back to at least >> 8.3. Tab completion of function arguments doesn't work if the function >> is schema-qualified or double-quoted. So for