Re: [BUGS] BUG #6672: Memory leaks in dumputils.c

2012-06-01 Thread Josh Kupershmidt
On Fri, Jun 1, 2012 at 4:23 PM, Anna Zaks wrote: > I opened an analyzer Bugzilla report for this issue in case you 'd > like to follow up there: > http://llvm.org/bugs/show_bug.cgi?id=13010 Thanks, I'll try to schedule another run tonight and post additional details on that ticket. On Fri, Jun

Re: [BUGS] BUG #6672: Memory leaks in dumputils.c

2012-06-01 Thread Josh Kupershmidt
On Fri, Jun 1, 2012 at 11:38 AM, Anna Zaks wrote: > Josh, > > What kid of machine are you using? Please, let me know how long it > took after it's done (It takes about one and a half hours on mine). It just finished, actually: took about 7 hours to run, not counting the time the machine was aslee

Re: [BUGS] BUG #6672: Memory leaks in dumputils.c

2012-06-01 Thread Josh Kupershmidt
On Thu, May 31, 2012 at 10:06 PM, Tom Lane wrote: > zaks.a...@gmail.com writes: >> There are two memory leaks in dumputils (v9.2.0beta1): > >> 1) >> File:   src/bin/scripts/dumputils.c >> Location:       line 604, column 11 >> Description:    Memory is never released; potential leak of memory >>

Re: [BUGS] BUG #6666: pg_upgrade 9.2beta1 plpython/plpython2

2012-06-01 Thread Bruce Momjian
On Thu, May 31, 2012 at 09:37:06PM -0400, Bruce Momjian wrote: > > I share Tom's caution on this, but I think we need to make sure we are > > addressing any possible risk of an isolated pg_upgrade fix, now that we > > understand the cause. > > FYI, this query will show any functions defined in the

Re: [BUGS] BUG #6672: Memory leaks in dumputils.c

2012-06-01 Thread Peter Geoghegan
On 1 June 2012 06:06, Tom Lane wrote: > There were no html reports attached, and I'd prefer plain text > anyway please ... I saw a number of false positives when I ran the Clang static analyser a few months ago. As I recall, I could see why the tool concluded that certain lines of code may have c