Re: [BUGS] BUG #4894: [patch] documentation bug on 'include' directive

2009-06-30 Thread Tom Lane
Peter Schuller writes: >>> The documentation says to use: >>> include 'filename' >>> Which fails with a generic error. >> >> What generic error? > Error: Invalid line 496 in /etc/postgresql/8.3/main/postgresql.conf: > »include 'filename' « failed! > This is with a Debian PostgreSQL 8.3. The

Re: [BUGS] BUG #4879: bgwriter fails to fsync the file in recovery mode

2009-06-30 Thread Tom Lane
Simon Riggs writes: > On Fri, 2009-06-26 at 16:48 -0400, Tom Lane wrote: >> * I find the RecoveryInProgress test in XLogNeedsFlush rather dubious. >> Why is it okay to disable that? For at least one of the two callers >> (SetHintBits) it seems like the safe answer is "true" not "false". >> This d

Re: [BUGS] BUG #4892: postmaster died and didn't restart

2009-06-30 Thread Alvaro Herrera
Craig Ringer wrote: > On Sun, 2009-06-28 at 22:54 +, Rikard Pavelic wrote: > > > log of death [i hate automatic translation feature :(] > > On UNIX, it's so easy to change what language PostgreSQL uses that it's > generally considered very helpful - the only time you really want to > disable

Re: [BUGS] BUG #4895: OneClickInstaller dont appreciates Client_Encoding and also listen_addresses='*'

2009-06-30 Thread Alvaro Herrera
Uwe Liebehenz wrote: > Description:OneClickInstaller dont appreciates Client_Encoding and > also listen_addresses='*' The "One-click installer" is not a PostgreSQL product. Please complain about it to EnterpriseDB. -- Alvaro Herrerahttp://www.CommandPro

[BUGS] BUG #4895: OneClickInstaller dont appreciates Client_Encoding and also listen_addresses='*'

2009-06-30 Thread Uwe Liebehenz
The following bug has been logged online: Bug reference: 4895 Logged by: Uwe Liebehenz Email address: liebeh...@mts-software.com PostgreSQL version: 8.3.7-2 Operating system: Windows / Linux Description:OneClickInstaller dont appreciates Client_Encoding and also list

Re: [BUGS] BUG #4879: bgwriter fails to fsync the file in recovery mode

2009-06-30 Thread Simon Riggs
On Fri, 2009-06-26 at 16:48 -0400, Tom Lane wrote: > * I find the RecoveryInProgress test in XLogNeedsFlush rather dubious. > Why is it okay to disable that? For at least one of the two callers > (SetHintBits) it seems like the safe answer is "true" not "false". > This doesn't matter too much ye

Re: [BUGS] BUG #4894: [patch] documentation bug on 'include' directive

2009-06-30 Thread Peter Schuller
> > The documentation says to use: > > include 'filename' > > Which fails with a generic error. > > What generic error? Error: Invalid line 496 in /etc/postgresql/8.3/main/postgresql.conf: »include 'filename' « failed! > > Correct syntax is: > > include = 'filename' > > The stated syntax