Re: [pgadmin-support] BUG: pgScript NOT thread safe!!

2009-06-26 Thread Dave Page
On Fri, Jun 26, 2009 at 9:57 AM, Ashesh Vashi wrote: > Looks good. > Working fine on linux and windows :) Thanks - I'll commit it. -- Dave Page EnterpriseDB UK: http://www.enterprisedb.com -- Sent via pgadmin-support mailing list (pgadmin-support@postgresql.org) To make changes to your subsc

Re: [pgadmin-support] BUG: pgScript NOT thread safe!!

2009-06-26 Thread Ashesh Vashi
Looks good. Working fine on linux and windows :) Dave Page wrote: On Fri, Jun 26, 2009 at 5:50 AM, Ashesh Vashi wrote: That's really weird. I tried that patch on windows and found that - the behavior of wxMutex is not as expected. :( On Gtk (Ubuntu 9.04 32bit), the message-box does not adjust

Re: [pgadmin-support] BUG: pgScript NOT thread safe!!

2009-06-26 Thread Dave Page
On Thu, Jun 25, 2009 at 6:55 PM, Mickael Deloison wrote: > Very sorry for this bug. I did not take into account the case when one > uses 2 or more Query tool windows. If one launches two windows, it > will create two pgsApplication. However, it will use the same > Flex/Bison parser. Actually I can

Re: [pgadmin-support] BUG: pgScript NOT thread safe!!

2009-06-26 Thread Dave Page
On Fri, Jun 26, 2009 at 5:50 AM, Ashesh Vashi wrote: > That's really weird. > I tried that patch on windows and found that - the behavior of wxMutex is > not as expected. :( > > On Gtk (Ubuntu 9.04 32bit), the message-box does not adjust to the length of > the title message. > (Please find the att

Re: [pgadmin-support] BUG: pgScript NOT thread safe!!

2009-06-25 Thread Dave Page
On Thu, Jun 25, 2009 at 7:37 PM, Ashesh Vashi wrote: > Hi Dave, > > Please find the updated patch. > I have realized that parallel execution of the queries is possible, which I > had disabled in the previous patch. :( OK, thats weird. It doesn't work for me on Windows or Mac, but it sure looks lik

Re: [pgadmin-support] BUG: pgScript NOT thread safe!!

2009-06-25 Thread Guillaume Lelarge
Le jeudi 25 juin 2009 à 20:37:40, Ashesh Vashi a écrit : > Hi Dave, > > Please find the updated patch. > I have realized that parallel execution of the queries is possible, > which I had disabled in the previous patch. :( > > Please find the updated patches (v2.1 - with message-box & v2.2 - > witho

Re: [pgadmin-support] BUG: pgScript NOT thread safe!!

2009-06-25 Thread Ashesh Vashi
Hi Dave, Please find the updated patch. I have realized that parallel execution of the queries is possible, which I had disabled in the previous patch. :( Please find the updated patches (v2.1 - with message-box & v2.2 - without message box). (Though I prefer the patch with the message box, I

Re: [pgadmin-support] BUG: pgScript NOT thread safe!!

2009-06-25 Thread Ashesh Vashi
Hi Mickael/Dave, Mickael Deloison wrote: 2009/6/25 Magnus Hagander : Ashesh Vashi wrote: Hi Dave, This patch does the job. But, it will not be able disable to toolbar buttons on each windows. Introduced a static variable of type wxMutex for these operations. Please take a look at it. I'd r

Re: [pgadmin-support] BUG: pgScript NOT thread safe!!

2009-06-25 Thread Magnus Hagander
Dave Page wrote: > That was my thought Ashesh - plus we could push out 1.10.1 pretty soon > with a long-term solution. I still think it's better with a message. Even if it's not translated for everybody. (And yes, I realize the issue for translators) But I'll defer to you if you think it's better

Re: [pgadmin-support] BUG: pgScript NOT thread safe!!

2009-06-25 Thread Magnus Hagander
Mickael Deloison wrote: > 2009/6/25 Magnus Hagander : >> Ashesh Vashi wrote: >>> Hi Dave, >>> >>> This patch does the job. >>> But, it will not be able disable to toolbar buttons on each windows. >>> Introduced a static variable of type wxMutex for these operations. >>> >>> Please take a look at i

Re: [pgadmin-support] BUG: pgScript NOT thread safe!!

2009-06-25 Thread Dave Page
That was my thought Ashesh - plus we could push out 1.10.1 pretty soon with a long-term solution. On 6/25/09, Ashesh Vashi wrote: > Hi Mickael/Dave, > > Mickael Deloison wrote: >> 2009/6/25 Magnus Hagander : >>> Ashesh Vashi wrote: Hi Dave, This patch does the job. But, it wi

Re: [pgadmin-support] BUG: pgScript NOT thread safe!!

2009-06-25 Thread Mickael Deloison
2009/6/25 Magnus Hagander : > Ashesh Vashi wrote: >>  Hi Dave, >> >> This patch does the job. >> But, it will not be able disable to toolbar buttons on each windows. >> Introduced a static variable of type wxMutex for these operations. >> >> Please take a look at it. > > I'd rather see something th

Re: [pgadmin-support] BUG: pgScript NOT thread safe!!

2009-06-25 Thread Magnus Hagander
Ashesh Vashi wrote: > Hi Dave, > > This patch does the job. > But, it will not be able disable to toolbar buttons on each windows. > Introduced a static variable of type wxMutex for these operations. > > Please take a look at it. I'd rather see something that throws up a messagebox informing th

Re: [pgadmin-support] BUG: pgScript NOT thread safe!!

2009-06-25 Thread Dave Page
No, thats what i figured. I assume the second script will just wait on the mutex before continuing automatically when the first finishes? (can't check atm - on iphone) Thanks! On 6/25/09, Ashesh Vashi wrote: > Hi Dave, > > This patch does the job. > But, it will not be able disable to toolbar bu

Re: [pgadmin-support] BUG: pgScript NOT thread safe!!

2009-06-25 Thread Ashesh Vashi
Hi Dave, This patch does the job. But, it will not be able disable to toolbar buttons on each windows. Introduced a static variable of type wxMutex for these operations. Please take a look at it. Dave Page wrote: Mickael; Is this something that can be fixed quickly and easily? We're building t

Re: [pgadmin-support] BUG: pgScript NOT thread safe!!

2009-06-25 Thread Dave Page
Mickael; Is this something that can be fixed quickly and easily? We're building the releases first thing tomorrow, UK time and unfortunately I can't delay as we're committed to the PostgreSQL release timing. Ashesh; in case Mickael doesn't see this in time, can you please work up a quick hack in p

Re: [pgadmin-support] BUG: pgScript NOT thread safe!!

2009-06-25 Thread Andras Fabian
Sorry, I have - of course - forgot to support the important pgAdmin and OS vewrsion information. It is pgAdmin 1.10rc1 run on Windows XP (SP3). Andras Fabian - - - - - - - - - - - - - - IT mailto:fab...@atrada.net Atrada Trading Network AG -Ursprüngliche Nachricht- Von: Andras Fabian