Re: [pgadmin-support] Small annoyance in pgAdmin 1.10

2009-08-11 Thread Dave Page
On Tue, Aug 11, 2009 at 6:30 AM, Guillaume Lelarge wrote: > Le mardi 11 août 2009 à 00:02:30, Rainer Bauer a écrit : >> [...] >> If not, when will there be a point release containing the change? >> > > In fact, there are 16 bug fixes in 1.10, and 1 remaining to be fixed. But I > don't know when we'

Re: [pgadmin-support] Small annoyance in pgAdmin 1.10

2009-08-10 Thread Guillaume Lelarge
Le mardi 11 août 2009 à 00:02:30, Rainer Bauer a écrit : > [...] > If not, when will there be a point release containing the change? > In fact, there are 16 bug fixes in 1.10, and 1 remaining to be fixed. But I don't know when we'll have a point release. -- Guillaume. http://www.postgresqlfr.

Re: [pgadmin-support] Small annoyance in pgAdmin 1.10

2009-08-10 Thread Rainer Bauer
Hello Guillaume, Monday, August 10, 2009, 10:16:47 PM, you wrote: GL> Done, and commited. Thanks. Thanks for the quick fix. However how do I get hold of the latest developement Snapshot? only offers the old beta releases. And also I do have VS2005, the

Re: [pgadmin-support] Small annoyance in pgAdmin 1.10

2009-08-10 Thread Guillaume Lelarge
Le lundi 10 août 2009 à 20:57:09, Dave Page a écrit : > On Mon, Aug 10, 2009 at 7:46 PM, Guillaume > > Lelarge wrote: > > Why didn't I think about this quite easy solution? no issue with pointer > > or reference. So here is the patch. > > That looks much cleaner :-) Can we get some spaces in the fu

Re: [pgadmin-support] Small annoyance in pgAdmin 1.10

2009-08-10 Thread Dave Page
On Mon, Aug 10, 2009 at 7:46 PM, Guillaume Lelarge wrote: > Why didn't I think about this quite easy solution? no issue with pointer or > reference. So here is the patch. That looks much cleaner :-) Can we get some spaces in the function for ease of reading please? int getTableCount() { return mo

Re: [pgadmin-support] Small annoyance in pgAdmin 1.10

2009-08-10 Thread Guillaume Lelarge
Le lundi 10 août 2009 à 15:17:17, Dave Page a écrit : > On Mon, Aug 10, 2009 at 2:08 PM, Dave Page wrote: > > On Mon, Aug 10, 2009 at 2:03 PM, Dave Page wrote: > >>> If I can't use a pointer, I don't see how I can do this. Or should I > >>> just remove the MessageBox? > >>> > >>> As per my understa

Re: [pgadmin-support] Small annoyance in pgAdmin 1.10

2009-08-10 Thread Dave Page
On Mon, Aug 10, 2009 at 2:08 PM, Dave Page wrote: > On Mon, Aug 10, 2009 at 2:03 PM, Dave Page wrote: >>> If I can't use a pointer, I don't see how I can do this. Or should I just >>> remove the MessageBox? >>> >>> As per my understanding, you always can use reference in place of pointer. >> >> Yes

Re: [pgadmin-support] Small annoyance in pgAdmin 1.10

2009-08-10 Thread Dave Page
On Mon, Aug 10, 2009 at 2:03 PM, Dave Page wrote: >> If I can't use a pointer, I don't see how I can do this. Or should I just >> remove the MessageBox? >> >> As per my understanding, you always can use reference in place of pointer. > > Yes, just pass by reference: > > bool generateSQL(const wxStr

Re: [pgadmin-support] Small annoyance in pgAdmin 1.10

2009-08-10 Thread Dave Page
On Mon, Aug 10, 2009 at 2:02 PM, Ashesh Vashi wrote: > Hi Guillaume, > > Guillaume Lelarge wrote: > > Le lundi 10 août 2009 à 14:49:21, Dave Page a écrit : > > On Mon, Aug 10, 2009 at 1:44 PM, Guillaume > > Lelarge wrote: > > Here is a patch that should fix this. Magnus, care to check it? I'm not >

Re: [pgadmin-support] Small annoyance in pgAdmin 1.10

2009-08-10 Thread Ashesh Vashi
Hi Guillaume, Guillaume Lelarge wrote: Le lundi 10 août 2009 à 14:49:21, Dave Page a écrit : On Mon, Aug 10, 2009 at 1:44 PM, Guillaume Lelarge wrote: Here is a patch that should fix this. Magnus, care to check it? I'm not ready to commit it without proper review. It plays with pointers, and

Re: [pgadmin-support] Small annoyance in pgAdmin 1.10

2009-08-10 Thread Guillaume Lelarge
Le lundi 10 août 2009 à 14:49:21, Dave Page a écrit : > On Mon, Aug 10, 2009 at 1:44 PM, Guillaume > > Lelarge wrote: > > Here is a patch that should fix this. Magnus, care to check it? I'm not > > ready to commit it without proper review. It plays with pointers, and > > that scares me a bit :) > >

Re: [pgadmin-support] Small annoyance in pgAdmin 1.10

2009-08-10 Thread Dave Page
On Mon, Aug 10, 2009 at 1:44 PM, Guillaume Lelarge wrote: > Here is a patch that should fix this. Magnus, care to check it? I'm not ready > to commit it without proper review. It plays with pointers, and that scares me > a bit :) Passing a pointer to a wxString around is *always* wrong. It can fu

Re: [pgadmin-support] Small annoyance in pgAdmin 1.10

2009-08-10 Thread Guillaume Lelarge
Le vendredi 7 août 2009 à 18:12:00, Guillaume Lelarge a écrit : > Le vendredi 7 août 2009 à 17:58:54, Magnus Hagander a écrit : > > On Fri, Aug 7, 2009 at 17:09, Guillaume Lelarge > > wrote: > > > Le vendredi 7 août 2009 à 09:56:34, Rainer Bauer a écrit : > > >> Hello, > > >> > > >> this is no bug,

Re: [pgadmin-support] Small annoyance in pgAdmin 1.10

2009-08-07 Thread Guillaume Lelarge
Le vendredi 7 août 2009 à 17:58:54, Magnus Hagander a écrit : > On Fri, Aug 7, 2009 at 17:09, Guillaume Lelarge wrote: > > Le vendredi 7 août 2009 à 09:56:34, Rainer Bauer a écrit : > >> Hello, > >> > >> this is no bug, but a little bit annoying: I sometimes accidently hit > >> the tab "Graphical

Re: [pgadmin-support] Small annoyance in pgAdmin 1.10

2009-08-07 Thread Magnus Hagander
On Fri, Aug 7, 2009 at 17:09, Guillaume Lelarge wrote: > Le vendredi 7 août 2009 à 09:56:34, Rainer Bauer a écrit : >> Hello, >> >> this is no bug, but a little bit annoying: I sometimes accidently hit >> the tab "Graphical Query Builder" in the Query window. No big deal, I >> just click on "SQL Ed

Re: [pgadmin-support] Small annoyance in pgAdmin 1.10

2009-08-07 Thread Guillaume Lelarge
Le vendredi 7 août 2009 à 09:56:34, Rainer Bauer a écrit : > Hello, > > this is no bug, but a little bit annoying: I sometimes accidently hit > the tab "Graphical Query Builder" in the Query window. No big deal, I > just click on "SQL Editor" to get back, but then a dialog pops up: "No > SQL query

[pgadmin-support] Small annoyance in pgAdmin 1.10

2009-08-07 Thread Rainer Bauer
Hello, this is no bug, but a little bit annoying: I sometimes accidently hit the tab "Graphical Query Builder" in the Query window. No big deal, I just click on "SQL Editor" to get back, but then a dialog pops up: "No SQL query was generated.". Wouldn't it be possible to suppress that dialog? Ra