Re: [pgadmin-support] Problem with multiple comments

2012-12-07 Thread Dave Page
On Fri, Dec 7, 2012 at 1:14 PM, Magnus Hagander wrote: > On Thu, Dec 6, 2012 at 6:39 PM, Dave Page wrote: >> On Thu, Dec 6, 2012 at 11:48 AM, Magnus Hagander wrote: >>> Certainly sounds like a very similar problem. If so, the query is >>> simply buggy - it's just that a pg_upgrade'd environment

Re: [pgadmin-support] Problem with multiple comments

2012-12-07 Thread Magnus Hagander
On Thu, Dec 6, 2012 at 6:39 PM, Dave Page wrote: > On Thu, Dec 6, 2012 at 11:48 AM, Magnus Hagander wrote: >> Certainly sounds like a very similar problem. If so, the query is >> simply buggy - it's just that a pg_upgrade'd environment is *much* >> more likely to run into the problem than before.

Re: [pgadmin-support] Problem with multiple comments

2012-12-07 Thread Dave Page
Thanks - I've committed and pushed the patch. On Fri, Dec 7, 2012 at 10:39 AM, Per Wigren wrote: > Unfortunately I don't have a build environment for this here at work but I > can confirm that by manually applying the change to the query in > edbPackage.cpp in the diff to the query I snatched fro

Re: [pgadmin-support] Problem with multiple comments

2012-12-07 Thread Per Wigren
Unfortunately I don't have a build environment for this here at work but I can confirm that by manually applying the change to the query in edbPackage.cpp in the diff to the query I snatched from pg_log, the output looks good. No more duplicates. // Per 2012/12/6 Dave Page > On Thu, Dec 6, 2012

Re: [pgadmin-support] Problem with multiple comments

2012-12-07 Thread Dave Page
On Thu, Dec 6, 2012 at 11:32 PM, Andrzej Zawadzki wrote: > On 06.12.2012 18:39, Dave Page wrote: >> On Thu, Dec 6, 2012 at 11:48 AM, Magnus Hagander wrote: >>> Certainly sounds like a very similar problem. If so, the query is >>> simply buggy - it's just that a pg_upgrade'd environment is *much*

Re: [pgadmin-support] Problem with multiple comments

2012-12-06 Thread Andrzej Zawadzki
On 06.12.2012 18:39, Dave Page wrote: > On Thu, Dec 6, 2012 at 11:48 AM, Magnus Hagander wrote: >> Certainly sounds like a very similar problem. If so, the query is >> simply buggy - it's just that a pg_upgrade'd environment is *much* >> more likely to run into the problem than before. >> >> I onl

Re: [pgadmin-support] Problem with multiple comments

2012-12-06 Thread Dave Page
On Thu, Dec 6, 2012 at 11:48 AM, Magnus Hagander wrote: > Certainly sounds like a very similar problem. If so, the query is > simply buggy - it's just that a pg_upgrade'd environment is *much* > more likely to run into the problem than before. > > I only checked the usages of pg_shdescription. The

Re: [pgadmin-support] Problem with multiple comments

2012-12-06 Thread Magnus Hagander
Certainly sounds like a very similar problem. If so, the query is simply buggy - it's just that a pg_upgrade'd environment is *much* more likely to run into the problem than before. I only checked the usages of pg_shdescription. The same bug might well exist with almost all uses of pg_description.

Re: [pgadmin-support] Problem with multiple comments

2012-12-06 Thread Per Wigren
ok, then the same issue occurs with functions as well because there are the same kind of duplicates in the list of functions. 2012/12/6 Dave Page > On Thu, Dec 6, 2012 at 11:03 AM, Per Wigren wrote: > > Yes, I have actually run pg_upgrade on it... Where can I find details > about > > this bug

Re: [pgadmin-support] Problem with multiple comments

2012-12-06 Thread Dave Page
On Thu, Dec 6, 2012 at 11:03 AM, Per Wigren wrote: > Yes, I have actually run pg_upgrade on it... Where can I find details about > this bug? The CHANGELOG just says: 2012-11-26 MH 1.16.1 Fix query for database descriptions So I guess the same issue occurs with schemas. I believe it occurs be

Re: [pgadmin-support] Problem with multiple comments

2012-12-06 Thread Per Wigren
Yes, I have actually run pg_upgrade on it... Where can I find details about this bug? The same thing happens with 1.16.1. 2012/12/6 Dave Page > On Thu, Dec 6, 2012 at 10:47 AM, Per Wigren wrote: > > I mailed you the screenshots. > > > > I snatched the SQL from pg_log that pgAdmin runs when r

Re: [pgadmin-support] Problem with multiple comments

2012-12-06 Thread Dave Page
On Thu, Dec 6, 2012 at 10:47 AM, Per Wigren wrote: > I mailed you the screenshots. > > I snatched the SQL from pg_log that pgAdmin runs when refreshing the list of > schemas and that query also returns these duplicate schemas. So do the > Object List Report html output. Hmm, odd. I don't suppose

Re: [pgadmin-support] Problem with multiple comments

2012-12-06 Thread Per Wigren
I mailed you the screenshots. I snatched the SQL from pg_log that pgAdmin runs when refreshing the list of schemas and that query also returns these duplicate schemas. So do the Object List Report html output. 2012/12/6 Dave Page > On Thu, Dec 6, 2012 at 10:31 AM, Per Wigren wrote: > > When q

Re: [pgadmin-support] Problem with multiple comments

2012-12-06 Thread Dave Page
On Thu, Dec 6, 2012 at 10:31 AM, Per Wigren wrote: > When querying pg_description for the oid of one schema that has duplicates > in pgAdmin I get this: > > bix_live=# select * from pg_description where objoid = 16458; > objoid | classoid | objsubid | > description > +--+-

Re: [pgadmin-support] Problem with multiple comments

2012-12-06 Thread Per Wigren
When querying pg_description for the oid of one schema that has duplicates in pgAdmin I get this: bix_live=# select * from pg_description where objoid = 16458; objoid | classoid | objsubid | description +--+--+--

Re: [pgadmin-support] Problem with multiple comments

2012-12-06 Thread Dave Page
On Thu, Dec 6, 2012 at 9:42 AM, Per Wigren wrote: > When there are multiple comments on a schema, pgAdmin 1.16 will display one > duplicate of the schema for each comment, where the only difference is the > last line "COMMENT ON SCHEMA schema_name IS 'something';". The same thing > happens in the

[pgadmin-support] Problem with multiple comments

2012-12-06 Thread Per Wigren
When there are multiple comments on a schema, pgAdmin 1.16 will display one duplicate of the schema for each comment, where the only difference is the last line "COMMENT ON SCHEMA schema_name IS 'something';". The same thing happens in the function list, where there are many duplicates only differe