[pgadmin-support] Re: [pgadmin-hackers] potential invalid input field of pgAdmin New Column GUI

2014-11-11 Thread Ashesh Vashi
Hi Sanket, Apart from variable persistence issue taken care in your patch, I've also observed the data persistence issue with: (When reloading the existing/new column in column dialog from table dialog) 1. Priviledges 2. Security Lables I also observed, when I remove some privileges from an exist

[pgadmin-support] Re: [pgadmin-hackers] potential invalid input field of pgAdmin New Column GUI

2014-11-11 Thread Ashesh Vashi
Hi Sanket, Quick review suggests that, you're not following the consistent name convention in new functions as per pgAdmin3 coding standard. I also observed a white-space warning, while apply the patch. Please resend the patch after resolving these issues. -- Thanks & Regards, Ashesh Vashi Ent

[pgadmin-support] Re: [pgadmin-hackers] potential invalid input field of pgAdmin New Column GUI

2014-11-11 Thread Sanket Mehta
Hi, Issue was occurring as mentioned below: While creating the new table using table wizard, when any variables or security labels are specified for certain column then in *dlgTable* class, it was not fetching those variable or security labels from *dlgColumn *class. So those were not visible on