Re: [pgadmin-support] pgadmin3-1.18.1//pgadmin/dd/ddmodel/ddDBReverseEnginering.cpp: 2 * bad if test ?

2013-12-06 Thread Dave Page
Thanks David. Guillaume, any chance you can take a look at this please? I'm not at all familiar with that code, and I'm not entirely sure what it's supposed to be doing. Thanks. On Fri, Dec 6, 2013 at 5:56 PM, David Binderman wrote: > hello there, > > I just ran the static analyser "cppcheck" ov

[pgadmin-support] pgadmin3-1.18.1//pgadmin/dd/ddmodel/ddDBReverseEnginering.cpp: 2 * bad if test ?

2013-12-06 Thread David Binderman
hello there, I just ran the static analyser "cppcheck" over the source code of pgadmin3-1.18.1. It said many things, including 1 > [dd/ddmodel/ddDBReverseEnginering.cpp:657] -> > [dd/ddmodel/ddDBReverseEnginering.cpp:657]: (style) Same expression on both > sides of '!='. Source code is  if(b