Re: [pgadmin-support] possible memory leak in Server Status window

2011-02-11 Thread Peter Geoghegan
On 11 February 2011 15:04, Dave Page wrote: > Ashesh had some code to implement a smart pointer a while back. I > suggested he post it here, but I know he's been too busy to do much > else with it.container I would prefer to use a stdlib smart ptr, or a well tested third party smart ptr that we

Re: [pgadmin-support] possible memory leak in Server Status window

2011-02-11 Thread Dave Page
On Fri, Feb 11, 2011 at 2:45 PM, Peter Geoghegan wrote: > On 11 February 2011 10:42, Julius Tuskenis wrote: >> Hello, Guillaume >> >> Please look at frmStatus::fillLogfileCombo(). Please note, that the set is >> defined and assigned, but then as it has not enough rows to be "interesting" >> the f

Re: [pgadmin-support] possible memory leak in Server Status window

2011-02-11 Thread Peter Geoghegan
On 11 February 2011 10:42, Julius Tuskenis wrote: > Hello, Guillaume > > Please look at frmStatus::fillLogfileCombo(). Please note, that the set is > defined and assigned, but then as it has not enough rows to be "interesting" > the function returns 0 and exits. So "delete set;" is never called. C

Re: [pgadmin-support] possible memory leak in Server Status window

2011-02-11 Thread Julius Tuskenis
Hello, Guillaume Please look at frmStatus::fillLogfileCombo(). Please note, that the set is defined and assigned, but then as it has not enough rows to be "interesting" the function returns 0 and exits. So "delete set;" is never called. Can this be the issue? int frmStatus::fillLogfileCombo(

Re: [pgadmin-support] possible memory leak in Server Status window

2011-02-11 Thread Julius Tuskenis
2011.02.10 23:55, Guillaume Lelarge rašė: I looked a bit in the source code, but can't find any memory leak in it. The code is pretty much the same for each report. The only specific thing for the lock report is that it can use a specific connection. But this doesn't trigger anything useful to fi