Thanks - looks good to me. Pushed to git.
On Fri, Jul 20, 2018 at 1:06 PM, Neel Patel
wrote:
> Hi Dave,
>
> Please find updated patch where we have linked "-pthread" library with x86
> and non-x86 linux.
> Do review it and let us know for comments.
>
> Thanks,
> Neel Patel
>
> On Fri, Jul 20, 20
Hi Dave,
Please find updated patch where we have linked "-pthread" library with x86
and non-x86 linux.
Do review it and let us know for comments.
Thanks,
Neel Patel
On Fri, Jul 20, 2018 at 4:03 PM, Dave Page wrote:
>
>
> On Fri, Jul 20, 2018 at 11:12 AM, Christoph Berg wrote:
>
>> Re: Dave Pa
On Fri, Jul 20, 2018 at 11:12 AM, Christoph Berg wrote:
> Re: Dave Page 2018-07-20 isg5-upf...@mail.gmail.com>
> > Yes, at minimum I suspect. Does it complain if it's there on x86 Linux?
> > Christoph said he needed it on non-x86 archs.
>
> It's needed on non-x86 Linux, but does not complain on
Re: Dave Page 2018-07-20
> Yes, at minimum I suspect. Does it complain if it's there on x86 Linux?
> Christoph said he needed it on non-x86 archs.
It's needed on non-x86 Linux, but does not complain on x86 (and I
think it's good style to use it there as well).
Christoph
On Fri, Jul 20, 2018 at 11:00 AM, Neel Patel
wrote:
> Hi Dave,
>
> Sure.
> I can see below warning during linking in windows.
>
>
> 1>-- Rebuild All started: Project: ZERO_CHECK, Configuration: Debug
> Win32 --
> 1> Checking Build System
> 1> CMake does not need to re-run because
> C:/
Hi Dave,
Sure.
I can see below warning during linking in windows.
1>-- Rebuild All started: Project: ZERO_CHECK, Configuration: Debug
Win32 --
1> Checking Build System
1> CMake does not need to re-run because
C:/Projects/pgagent/build/CMakeFiles/generate.stamp is up-to-date.
1> CMake
Hi
On Fri, Jul 20, 2018 at 9:55 AM, Christoph Berg wrote:
> All non-x868 architectures need -pthread to link with threads:
>
> https://buildd.debian.org/status/logs.php?pkg=pgagent&;
> ver=4.0.0-1&suite=sid
>
> This patch fixes the problem:
>
> --- a/CMakeLists.txt
> +++ b/CMakeLists.txt
> @@ -1
All non-x868 architectures need -pthread to link with threads:
https://buildd.debian.org/status/logs.php?pkg=pgagent&ver=4.0.0-1&suite=sid
This patch fixes the problem:
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -135,7 +135,7 @@ ENDIF(WIN32)
ADD_EXECUTABLE(pgagent ${_srcs})
TARGET_LINK_LIBR
