Re: [pgagent] regression test

2018-07-20 Thread Dave Page
On Fri, Jul 20, 2018 at 10:28 AM, Christoph Berg wrote: > The Debian package includes a regression test for pgagent which might > be useful for others as well. It installs a simple job, fires up > pgagent for 80 s (using `timeout` from coreutils), and checks if the > job was run at least once. >

Re: [pgagent] patch: link with -pthread

2018-07-20 Thread Dave Page
Thanks - looks good to me. Pushed to git. On Fri, Jul 20, 2018 at 1:06 PM, Neel Patel wrote: > Hi Dave, > > Please find updated patch where we have linked "-pthread" library with x86 > and non-x86 linux. > Do review it and let us know for comments. > > Thanks, > Neel Patel > > On Fri, Jul 20, 20

Re: [pgagent] patch: link with -pthread

2018-07-20 Thread Neel Patel
Hi Dave, Please find updated patch where we have linked "-pthread" library with x86 and non-x86 linux. Do review it and let us know for comments. Thanks, Neel Patel On Fri, Jul 20, 2018 at 4:03 PM, Dave Page wrote: > > > On Fri, Jul 20, 2018 at 11:12 AM, Christoph Berg wrote: > >> Re: Dave Pa

Re: [pgagent] patch: link with -pthread

2018-07-20 Thread Dave Page
On Fri, Jul 20, 2018 at 11:12 AM, Christoph Berg wrote: > Re: Dave Page 2018-07-20 isg5-upf...@mail.gmail.com> > > Yes, at minimum I suspect. Does it complain if it's there on x86 Linux? > > Christoph said he needed it on non-x86 archs. > > It's needed on non-x86 Linux, but does not complain on

Re: [pgagent] patch: link with -pthread

2018-07-20 Thread Christoph Berg
Re: Dave Page 2018-07-20 > Yes, at minimum I suspect. Does it complain if it's there on x86 Linux? > Christoph said he needed it on non-x86 archs. It's needed on non-x86 Linux, but does not complain on x86 (and I think it's good style to use it there as well). Christoph

Re: [pgagent] patch: link with -pthread

2018-07-20 Thread Dave Page
On Fri, Jul 20, 2018 at 11:00 AM, Neel Patel wrote: > Hi Dave, > > Sure. > I can see below warning during linking in windows. > > > 1>-- Rebuild All started: Project: ZERO_CHECK, Configuration: Debug > Win32 -- > 1> Checking Build System > 1> CMake does not need to re-run because > C:/

Re: [pgagent] patch: link with -pthread

2018-07-20 Thread Neel Patel
Hi Dave, Sure. I can see below warning during linking in windows. 1>-- Rebuild All started: Project: ZERO_CHECK, Configuration: Debug Win32 -- 1> Checking Build System 1> CMake does not need to re-run because C:/Projects/pgagent/build/CMakeFiles/generate.stamp is up-to-date. 1> CMake

[pgagent] regression test

2018-07-20 Thread Christoph Berg
The Debian package includes a regression test for pgagent which might be useful for others as well. It installs a simple job, fires up pgagent for 80 s (using `timeout` from coreutils), and checks if the job was run at least once. Christoph --- /dev/null +++ b/test/Makefile @@ -0,0 +1,4 @@ +PG_CON

Re: [pgagent] Instatallation destination?

2018-07-20 Thread Dave Page
Hi On Fri, Jul 20, 2018 at 10:00 AM, Christoph Berg wrote: > Hi, > > in the Debian package I notice that CMakeLists.txt installs README and > LICENSE to /usr (no subdirectory!), and pgagent.sql to /usr/share. > The first is clearly wrong, and the second somewhat debatable. As > pgagent.sql is no

Re: [pgagent] patch: link with -pthread

2018-07-20 Thread Dave Page
Hi On Fri, Jul 20, 2018 at 9:55 AM, Christoph Berg wrote: > All non-x868 architectures need -pthread to link with threads: > > https://buildd.debian.org/status/logs.php?pkg=pgagent&; > ver=4.0.0-1&suite=sid > > This patch fixes the problem: > > --- a/CMakeLists.txt > +++ b/CMakeLists.txt > @@ -1

[pgagent] Instatallation destination?

2018-07-20 Thread Christoph Berg
Hi, in the Debian package I notice that CMakeLists.txt installs README and LICENSE to /usr (no subdirectory!), and pgagent.sql to /usr/share. The first is clearly wrong, and the second somewhat debatable. As pgagent.sql is not really required (extension support), I added this patch: Don't install

Re: [pgagent] patch: supported cmake version

2018-07-20 Thread Dave Page
On Fri, Jul 20, 2018 at 9:53 AM, Christoph Berg wrote: > Uh, the subject should of course have been "[pgagent]"... > :-) Thanks - fixed in git. > > Re: To pgAdmin III support 2018-07-20 <20180720085156.ga15...@msg.df7cb.de > > > > While updating the Debian package I noticed that pgadmin requi

[pgagent] patch: link with -pthread

2018-07-20 Thread Christoph Berg
All non-x868 architectures need -pthread to link with threads: https://buildd.debian.org/status/logs.php?pkg=pgagent&ver=4.0.0-1&suite=sid This patch fixes the problem: --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -135,7 +135,7 @@ ENDIF(WIN32) ADD_EXECUTABLE(pgagent ${_srcs}) TARGET_LINK_LIBR

Re: [pgagent] patch: supported cmake version

2018-07-20 Thread Christoph Berg
Uh, the subject should of course have been "[pgagent]"... Re: To pgAdmin III support 2018-07-20 <20180720085156.ga15...@msg.df7cb.de> > While updating the Debian package I noticed that pgadmin requires at > least cmake 3.3: > > CMake Error at cmake/FindBoost.cmake:238 (cmake_policy): > Poli

[pgadmin] patch: supported cmake version

2018-07-20 Thread Christoph Berg
While updating the Debian package I noticed that pgadmin requires at least cmake 3.3: CMake Error at cmake/FindBoost.cmake:238 (cmake_policy): Policy "CMP0057" is not known to this version of CMake. https://cmake.org/cmake/help/v3.3/policy/CMP0057.html CMake 3.3 adds support for the new