[pgAdmin4][patch] Remove extra brackets in CREATE Script and DDL Comparison

2021-07-06 Thread zhangj...@fujitsu.com
Hi, all Extra brackets appear in CREATE Script and DDL Comparison, please refer to the attachment error1.png and error2.png for details. ■ scenario The step is as follow: 1) Connect to pg9.6 or pg9.5 2) The SQL to create the trigger is as follows. - CRE

[pgAdmin4][patch] In SharedServersGetTestCase, the prompt information is wrong

2021-07-22 Thread zhangj...@fujitsu.com
Hi, all SharedServersGetTestCase can only be tested in SERVER mode. So, in Desktop mode, prompt information will be output. However, the prompt is wrong. ("Can not run shared servers test cases in the SERVER mode.") I think it should be changed to the following prompt information "Can not run s

[pgAdmin4] Questions about trigger properties's Fires in edit mode

2021-07-29 Thread zhangj...@fujitsu.com
Hi, all In trigger's Properties screen, the 'fires' is disabled. What is the reason why 'fires' is disabled? I think it should be the same as 'evnt_insert', When server_type is ppas and in edit mode, 'fires' is disabled. file: web/pgadmin/browser/server_groups/servers/databases/schemas/tables/tr

[pgAdmin4][patch] error message is incorrect in domains

2021-09-27 Thread zhangj...@fujitsu.com
Hi, all In domains's create function, res is used for all error messages. I don't think this is correct. On line 13, doid should be used as the error message.Because the execution result of line 11 is doid. On line 21, scid should be used as the error message.Because the execution result of line

[pgAdmin4][patch] fix a typo in import_export_servers.rst

2021-12-09 Thread zhangj...@fujitsu.com
MAIL: zhangj...@fujitsu.com FNST Oline:http://online.fnst.cn.fujitsu.com/fnst-news - import_export_servers.patch Description: import_export_servers.patch

[PATCH] Change slash to backslash in make.bat

2022-02-15 Thread zhangj...@fujitsu.com
Hi, all In windows, backslash should be used in the path. In Linux, slash should be used in path. But in pgadmin4\make.bat, slash is used in the path. F