[pgAdmin4][patch] extract generate_url function from node.js and collection.js

Hi hackers, We tried to extract and refactor generate_url function in node.js and collection.js. Please see the patch attached. Thanks, Violet & Sarah diff --git a/web/pgadmin/browser/static/js/collection.js b/web/pgadmin/browser/static/js/collection.js index f97edcc0..c0cb0eb4 100644 --- a/web/

Re: [pgAdmin4][patch] update the alert style in the sub-navigation

Hi Surinder! Are you referring to the green message popup? If so, it also appears to be happening on master. We'll log a bug in our backlog and Redmine and prioritize it. We agree that it needs to be fixed, but don't think it's unrelated to this patch. Thanks! Violet & Sarah On Thu, Aug 10, 2017

Re: [pgAdmin4][patch] update the alert style in the sub-navigation

Here's the Redmine link https://redmine.postgresql.org/issues/2644 On Thu, Aug 10, 2017 at 4:03 PM, Violet Cheng wrote: > Hi Surinder! > > Are you referring to the green message popup? If so, it also appears to be > happening on master. We'll log a bug in our b

Re: [pgAdmin4][patch] Fix feature tests failure

Hi, Is there any update on this patch? Will it be committed soon? Thanks, Violet On Thu, Aug 10, 2017 at 11:32 AM, Wenlin Zhang wrote: > As Sarah discussed with Khushboo on slack (pgadminhackers.slack.com for > those who would like to join) yesterday, these errors seem to occur only on > her U

Re: [pgAdmin4][PATCH] Refactor and change of implementation of keyboard_shortcuts function dependencies

Hi, Is there any update on these patches? Will it be committed soon? Thanks, Violet On Thu, Aug 10, 2017 at 2:31 PM, Wenlin Zhang wrote: > Hi hackers, > >We have rebased all the three patches and they are ready to be applied. > > Thanks, > > Wenlin & Matt > > On Wed, Aug 9, 2017 at 11:20 A

Re: [pgAdmin4][patch] update the alert style in the sub-navigation

oAFdVMkTgoXzf3w%40mail.gmail.com> > . > > Thanks! > > On Thu, Aug 10, 2017 at 4:10 PM, Violet Cheng wrote: > >> Here's the Redmine link >> >> https://redmine.postgresql.org/issues/2644 >> >> On Thu, Aug 10, 2017 at 4:03 PM, Violet Cheng wrote: >>

Re: [pgAdmin4][patch] extract generate_url function from node.js and collection.js

Hi, Is there any update on this patch? Will it be committed soon? Thanks, Violet On Fri, Aug 11, 2017 at 2:38 PM, Ashesh Vashi wrote: > On Thu, Aug 10, 2017 at 1:15 PM, Violet Cheng wrote: > >> Hi hackers, >> >> We tried to extract and refactor generate_url

Re: [pgadmin4][patch] Fix the style of the alert when connecting/disconnecting from a server

Hi, Is there any update on this patch? Will it be committed soon? Thanks, Violet On Fri, Aug 11, 2017 at 2:46 PM, Surinder Kumar < surinder.ku...@enterprisedb.com> wrote: > Hi > > I reviewed this patch and it looks good to me. > > Thanks, > Surinder > > On Fri, Aug 11, 2017 at 9:13 AM, Sarah Mc

Re: [pgadmin4][Patch] Greenplum specific DDL and Dashboard display

Hi, Any comment on this patch? If no, will it be committed soon? Thanks, Violet On Wed, Aug 9, 2017 at 12:05 PM, Sarah McAlear wrote: > Hi Hackers! > > This patch enables Greenplum users to see the same charts on the dashboard > as postgres users. It also adds some additional information to th

Re: [pgAdmin4][patch] update the alert style in the sub-navigation

l.org/message-id/CAM5-9D8UJVgCD0MrKq6yPx0qx9k8v3r6_4e8SkHdGV1RBDnhbQ%40mail.gmail.com> > . > > Thanks, > Surinder > > On Wed, Aug 16, 2017 at 8:57 AM, Violet Cheng wrote: > >> Hi, >> >> Any update on this patch? Could it be committed soon? >> >> Thanks, >> Violet >> &

Re: [pgAdmin4][patch] extract generate_url function from node.js and collection.js

>> >>> Thanks, >> Khushboo >> >> On Fri, Aug 11, 2017 at 12:08 PM, Ashesh Vashi < >> ashesh.va...@enterprisedb.com> wrote: >> >>> On Thu, Aug 10, 2017 at 1:15 PM, Violet Cheng wrote: >>> >>>> Hi hackers, >>&