[pgAdmin][RM5071]Improve test framework to separate the testcases from multiple class

2020-01-07 Thread Pradip Parkale
Hi All, Attached is patch to separate the testcases from multiple classes. I've modified the existing testsuite to select and separate the testcase from multiple classes. RM5071.patch Description: Binary data

[pgAdmin][RM5050] Language node code coverage.

2020-01-15 Thread Pradip Parkale
Hi All, Attached is a patch for language node code coverage. This increases the code coverage of the language node from 45% to 69%. Command to run the tests - - python runtests.py --pkg browser.server_groups.servers.databases.languages.tests -- Thanks & Regards, Pradip Parkale

Re: [pgAdmin][RM5050] Language node code coverage.

2020-01-19 Thread Pradip Parkale
test_utils.py" > > Can you please fix the following for CAST node: > >- Remove 'TC-..' from all the scenario name. >- Used the same generic function(generate_scenario) from test_utils. > > > > On Wed, Jan 15, 2020 at 2:19 PM Pradip Parkale < > pra

[pgAdmin][RM4770] [Accessibility]Parse & validate the web pages

2020-01-29 Thread Pradip Parkale
Hi All, Attached is a patch for accessibility issues. I have added a label, title, and put some condition wherever required. Please note that this patch also includes the fix for RM5116 - Save Password' label disappears after clicking on it while creating a server. -- Thanks & Regard

[pgAdmin][RM5088] Event trigger node code coverage

2020-02-12 Thread Pradip Parkale
ards, Pradip Parkale QMG, EnterpriseDB Corporation RM5088.patch Description: Binary data

[pgAdmin][RM5154] [Accessibility] : Alertify

2020-02-19 Thread Pradip Parkale
includes the fix for the RM-5143 Accessibility issue to maximize the panel for backup and restore windows and all other places. -- Thanks & Regards, Pradip Parkale QMG, EnterpriseDB Corporation

Re: [pgAdmin][RM5154] [Accessibility] : Alertify

2020-02-19 Thread Pradip Parkale
Please find the attached patch. On Wed, Feb 19, 2020 at 5:02 PM Ashesh Vashi wrote: > Forgot to attach the patch? > > On Wed, 19 Feb 2020 at 16:58, Pradip Parkale < > pradip.park...@enterprisedb.com> wrote: > >> Hi Hackers, >> >> Attached is a patch for

Re: [pgAdmin][RM5154] [Accessibility] : Alertify

2020-02-25 Thread Pradip Parkale
dle the focus. > Fixed. > Also, make the required changes mentioned on the pull request - > https://github.com/EnterpriseDB/AlertifyJS/pull/1 > Fixed. > > > On Fri, Feb 21, 2020 at 11:19 AM Akshay Joshi < > akshay.jo...@enterprisedb.com> wrote: > >> Hi Ad

Re: [pgAdmin][RM5154] [Accessibility] : Alertify

2020-03-05 Thread Pradip Parkale
Hi Hackers, Please find the updated patch for RM5143. On Tue, Feb 25, 2020 at 6:26 PM Akshay Joshi wrote: > Thanks, patch applied. > > On Tue, Feb 25, 2020 at 3:32 PM Pradip Parkale < > pradip.park...@enterprisedb.com> wrote: > >> Hi Akshay/Aditya, >> >>

[PgAdmin][RM4237]: User can not change value of Datetime picker control using keyboard (Accessibility).

2020-03-07 Thread Pradip Parkale
Hi Hackers, Attached is a patch to change the Datetime picker value using a keyboard. -- Thanks & Regards, Pradip Parkale QMG, EnterpriseDB Corporation RM4237.patch Description: Binary data

Re: [PgAdmin][RM4237]: User can not change value of Datetime picker control using keyboard (Accessibility).

2020-03-10 Thread Pradip Parkale
Pradip > > I have tested the patch. I am able to navigate the dates using the > keyboard, but not able to select the year/month and time. Can you please > work on it and send the patch again. > > On Sat, Mar 7, 2020 at 7:00 PM Pradip Parkale < > pradip.park...@ent

[Accessibility] RM4608 Few issues in the dialogs.

2020-03-19 Thread Pradip Parkale
Hi Hackers, Please find the patch for accessibility errors in some of the dialogs. -- Thanks & Regards, Pradip Parkale QMG, EnterpriseDB Corporation RM4608.patch Description: Binary data

Re: [Accessibility] RM4608 Few issues in the dialogs.

2020-03-19 Thread Pradip Parkale
, Mar 19, 2020 at 2:26 PM Pradip Parkale < > pradip.park...@enterprisedb.com> wrote: > >> Hi Hackers, >> >> Please find the patch for accessibility errors in some of the dialogs. >> >> >> -- >> Thanks & Regards, >> Pradip Parkale &

[pgAdmin][RM5241] : Tab key navigation is not working in Grant wizard.

2020-03-26 Thread Pradip Parkale
to use the keyboard to update the Backgrid cell DateTime picker control. -- Thanks & Regards, Pradip Parkale QMG, EnterpriseDB Corporation RM5241.patch Description: Binary data

Re: [pgAdmin][RM5241] : Tab key navigation is not working in Grant wizard.

2020-03-30 Thread Pradip Parkale
lete' button in the >backgrid cell. > > This logic was added even before my patch(1st Patch). User needs to press the 'space' key to delete the privilege added. > > On Fri, Mar 27, 2020 at 9:47 AM Pradip Parkale < > pradip.park...@enterprisedb.com> wrote:

[PgAdmin][RM5275] Accessibilty :Tab navigation is not working for table>> parameters.

2020-04-03 Thread Pradip Parkale
Hi Hackers, Please find an attached patch for key navigation in Table >> Parameter. I have added a key down event to handle the key navigation. -- Thanks & Regards, Pradip Parkale QMG, EnterpriseDB Corporation RM5275.patch Description: Binary data

[pgAdmin][RM4206]: Grant wizard does not close when we press ESC key

2020-04-06 Thread Pradip Parkale
Hi Hackers, Please find the attached patch to close the Grant Wizard when the ESC key is pressed. -- Thanks & Regards, Pradip Parkale QMG, EnterpriseDB Corporation RM4206.patch Description: Binary data

Re: [pgAdmin][RM4206]: Grant wizard does not close when we press ESC key

2020-04-07 Thread Pradip Parkale
Hi Akshay, Please find the updated patch. On Mon, Apr 6, 2020 at 3:26 PM Akshay Joshi wrote: > Hi Pradip > > Patch not working, please check one more time. > > On Mon, Apr 6, 2020 at 2:20 PM Pradip Parkale < > pradip.park...@enterprisedb.com> wrote: > >>

[pgAdmin][RM5371] : Tab key navigation is not working in some of the dialogs

2020-04-13 Thread Pradip Parkale
;> Security 5 Foreign table >> columns. 2 >> security 6 Function >> Security. 7 MV >> Security. 8 Table >> Security 9 Trigger Function >> Security 10 View >> Security 11 Types >> Security 12 Procedure >> Security Please review. -- Thanks &

[pgAdmin][RM4545]: In grant wizard, last object is not selectable

2020-04-20 Thread Pradip Parkale
When you remove the text added in the filter search box by directly clicking the cross button, it doesn't show original data. -- Thanks & Regards, Pradip Parkale QMG, EnterpriseDB Corporation RM4545.patch Description: Binary data

[pgAdmin][RM4504] Make like options disable if Relation is not selected.

2020-04-24 Thread Pradip Parkale
Hi Hackers, Attached is a patch to make like options disable if Relation is not selected while creating a table. Please review. -- Thanks & Regards, Pradip Parkale QMG, EnterpriseDB Corporation RM4504.patch Description: Binary data

Re: [pgAdmin][RM4504] Make like options disable if Relation is not selected.

2020-04-24 Thread Pradip Parkale
ike options switch buttons are still enabled. > Fixed. > > > > On Fri, Apr 24, 2020 at 3:04 PM navnath gadakh < > navnath.gad...@enterprisedb.com> wrote: > >> Hi, >> I will be reviewing this RM. >> >> On Fri, Apr 24, 2020 at 1:48 PM Pradip P

Re: [pgAdmin][RM4504] Make like options disable if Relation is not selected.

2020-04-27 Thread Pradip Parkale
r as those options are not editable once the table is created. Please review. On Fri, Apr 24, 2020 at 6:29 PM Akshay Joshi wrote: > Thanks, patch applied. > > On Fri, Apr 24, 2020 at 5:42 PM Pradip Parkale < > pradip.park...@enterprisedb.com> wrote: > >> Hi Navnath

Re: [pgAdmin][RM4504] Make like options disable if Relation is not selected.

2020-04-27 Thread Pradip Parkale
Please ignore my previous patch. Please find the latest patch. On Mon, Apr 27, 2020 at 5:53 PM Pradip Parkale < pradip.park...@enterprisedb.com> wrote: > Hi Akshay/Aditya, > > Please find the updated patch. I fixed the regression where initial changes > were making the save but

[pgAdmin][RM5334] : [Code Coverage] Improve API test cases for Rules

2020-05-07 Thread Pradip Parkale
Hi Hackers, Please find the attached patch to improve the 'Rule' node coverage. Command to run the test cases - - python runtests.py --pkg browser.server_groups.servers.databases.schemas.tables.rules.tests -- Thanks & Regards, Pradip Parkale QMG, EnterpriseDB Corporation

[pgAdmin][RM5335]: [Code Coverage] Improve API test cases for Triggers and Compound Triggers

2020-05-15 Thread Pradip Parkale
rs.tests Command to run the trigger node test cases - - python runtests.py --pkg browser.server_groups.servers.databases.schemas.tables.triggers.tests -- Thanks & Regards, Pradip Parkale QMG, EnterpriseDB Corporation RM5335.patch Description: Binary data

Re: [pgAdmin][RM5516]: Added support of Row Security Policies

2020-06-22 Thread Pradip Parkale
n by default it is public. >- Keywords like select, where, As should be in upper case in Jinja >template. >- The policy node is disappeared when updating any value. Fixed that >issue. >- There is no icon showing after creating the RLS node. > > > > On Fri

[pgAdmin][RM5601] : [Schema Diff] Add RLS policy support in schema diff

2020-06-25 Thread Pradip Parkale
Hi Hackers, Please find the attached patch for RLS policy support in schema diff. -- Thanks & Regards, Pradip Parkale QMG, EnterpriseDB Corporation RM-5601.patch Description: Binary data

[SonarQube]: Rename class name

2020-06-26 Thread Pradip Parkale
Hi Hackers, Please find the attached patch for : 1. Rename class name to match the regular expression. -- Thanks & Regards, Pradip Parkale QMG, EnterpriseDB Corporation rename_class.patch Description: Binary data

Re: [pgAdmin][RM5601] : [Schema Diff] Add RLS policy support in schema diff

2020-06-30 Thread Pradip Parkale
olicy, all the headers are showing as a >comment on top of policy DDL in schema diff. >- If the policy event is different for source and target policy then >it is showing different but no diff SQL has been generated. >- Created new RM #5631, fixed that to test schema

[SonarQube]: Rename function and variable name to match the regular expression

2020-07-01 Thread Pradip Parkale
Hi Hackers, Please find the attached patch for : 1. Rename function and variable name to match the regular expression. -- Thanks & Regards, Pradip Parkale QMG, EnterpriseDB Corporation rename_function_variable_name.patch Description: Binary data

Re: [pgAdmin][RM5516]: Added support of Row Security Policies

2020-07-01 Thread Pradip Parkale
Hi Akshay, Please find the attached patch. I have added hints for 'Using' and 'With check'. On Mon, Jun 22, 2020 at 5:45 PM Akshay Joshi wrote: > Thanks, patch applied. > > On Mon, Jun 22, 2020 at 3:23 PM Pradip Parkale < > pradip.park...@enterprisedb.com&g

[pgAdmin][RM5622]: Permissive or restricted policy on table from PG 10 and above

2020-07-06 Thread Pradip Parkale
Hi Hackers, Please find the attached patch for a permissive and restrictive RLS policy support. I have also updated the document with new screenshots. -- Thanks & Regards, Pradip Parkale QMG, EnterpriseDB Corporation RM5622.patch Description: Binary data

[pgAdmin][RM5633]:Create RLS Policy option enabled for catalog objects

2020-07-08 Thread Pradip Parkale
Hi Hackers, Please find the attached patch. I have disabled creating an RLS policy option for catalog objects. -- Thanks & Regards, Pradip Parkale QMG, EnterpriseDB Corporation RM5633.patch Description: Binary data

Re: [SonarQube]: Rename function and variable name to match the regular expression

2020-07-08 Thread Pradip Parkale
Hi Hackers, Please find another patch variable naming convention. On Wed, Jul 1, 2020 at 1:54 PM Akshay Joshi wrote: > Thanks, patch applied. > > On Wed, Jul 1, 2020 at 1:10 PM Pradip Parkale < > pradip.park...@enterprisedb.com> wrote: > >> Hi Hackers, >> >

[pgAdmin][RM5686]: Unable to update RLS policy if the policy name contains space in it

2020-07-21 Thread Pradip Parkale
Hi Hackers, Please find the attached patch. I have fixed issue where the user was not able to update policy if the policy is created with space in policy name. -- Thanks & Regards, Pradip Parkale QMG, EnterpriseDB Corporation RM5686.patch Description: Binary data

[pgAdmin][SonarQube]: Cognitive complexity

2020-08-20 Thread Pradip Parkale
. user_mapping/__init__.py. 35 to 15. 5. browser/__init__.py. -- Thanks & Regards, Pradip Parkale Software Engineer | EnterpriseDB Corporation cognitive_comple_sonarQube.patch Description: Binary data

Re: [pgAdmin][SonarQube]: Cognitive complexity

2020-08-20 Thread Pradip Parkale
Please ignore the previous patch, find the updated patch in this mail. On Thu, Aug 20, 2020 at 8:52 PM Pradip Parkale < pradip.park...@enterprisedb.com> wrote: > Hi Hackers, > > The attached patch will reduce cognitive complexity for the following > functions. > >1. w

[pgAdmin][RM5722]: Not able to drop database.

2020-08-24 Thread Pradip Parkale
Hi Hackers, Please find the attached patch. Now, with this patch user can drop a database even if it is connected. -- Thanks & Regards, Pradip Parkale Software Engineer | EnterpriseDB Corporation RM5622.patch Description: Binary data

Re: [pgAdmin][SonarQube]: Cognitive complexity

2020-08-24 Thread Pradip Parkale
_operation" to generic or move that >function to PGChildNodeView class and update it in all the nodes where it >is used. > > Fixed. > >- > > > On Thu, Aug 20, 2020 at 8:56 PM Pradip Parkale < > pradip.park...@enterprisedb.com> wrote: >

[pgAdmin][SonarQube] : Remove duplicates string literals.

2020-09-03 Thread Pradip Parkale
Hi Hackers, Attached is a patch for removing duplicates string literals. /server_groups/servers/roles/__init__.py - 8 places -- Thanks & Regards, Pradip Parkale Software Engineer | EnterpriseDB Corporation sonar_Qube_v1.patch Description: Binary data

Re: [pgAdmin][SonarQube] : Remove duplicates string literals.

2020-09-03 Thread Pradip Parkale
n fact, can we use > >self.not_found_error_msg()instead of new constant. > >- Same with ERROR_FETCHING_ROLE_INFORMATION it's already in gettext, >also we can use this constant for string " > >Error retrieving roles from the database server" > > >

[pgAdmin][RM5764] : RLS SQL Incorrectly generated

2020-09-07 Thread Pradip Parkale
Hi Hackers, Please find the attached patch for the RLS SQL error.It was incorrectly generating. -- Thanks & Regards, Pradip Parkale Software Engineer | EnterpriseDB Corporation RM5764.patch Description: Binary data

[pgAdmin][RM-5732] : Scan and fix accessibility issues reported by WAVE.

2020-09-14 Thread Pradip Parkale
Hi Hackers, Please find the attached patch for some of the accessibility issues. -- Thanks & Regards, Pradip Parkale Software Engineer | EnterpriseDB Corporation RM5732.patch Description: Binary data

[pgAdmin][RM5834]:Remove server group option is not available through right click

2020-09-15 Thread Pradip Parkale
Hi Hackers, Please find the attached patch for server group error.' Remove server group' option was not available. -- Thanks & Regards, Pradip Parkale Software Engineer | EnterpriseDB Corporation RM5834.patch Description: Binary data

[pgAdmin][RM5739]: Export feature(COPY) does not work with SSH tunnel

2020-09-21 Thread Pradip Parkale
Hi Hackers, Export feature does not work with the SSH tunnel. Attached is the patch to fix the issue. -- Thanks & Regards, Pradip Parkale Software Engineer | EnterpriseDB Corporation RM5739.patch Description: Binary data

Re: RM5841: server.username can be empty when using .pg_service.conf

2020-09-21 Thread Pradip Parkale
es.com>* > > *Mobile: +91 976-788-8246* > -- Thanks & Regards, Pradip Parkale Software Engineer | EnterpriseDB Corporation diff --git a/web/pgadmin/browser/server_groups/servers/__init__.py b/web/pgadmin/browser/server_groups/servers/__init__.py index ed8fae0f0..10efa4e87 100644 --- a

Re: RM5841: server.username can be empty when using .pg_service.conf

2020-09-21 Thread Pradip Parkale
Hi Akshay, Please find the updated patch. On Mon, Sep 21, 2020 at 4:41 PM Pradip Parkale < pradip.park...@enterprisedb.com> wrote: > Hi Akshay, > > > On Mon, Sep 21, 2020 at 9:30 AM Akshay Joshi < > akshay.jo...@enterprisedb.com> wrote: > >> Hi Pradip >

[pgAdmin][RM5843] [SQL] - Some 'options' values for function not shown in sql

2020-09-22 Thread Pradip Parkale
Hi Hackers, The 'Unsafe' parallel option was not visible in the SQL for function and procedure. Attached is the patch to fix this issue. -- Thanks & Regards, Pradip Parkale Software Engineer | EnterpriseDB Corporation RM5843.patch Description: Binary data

[pgAdmin][RM5861]:Remove server' option is not available through context click

2020-09-23 Thread Pradip Parkale
Hi Hackers, Please find the attached patch following the issue. 1. The 'Remove server' option is not available. 2. 'Shared server owner' property is visible in a desktop mode which shouldn't. -- Thanks & Regards, Pradip Parkale Software Engineer | Ente

Re: [pgAdmin][RM5843] [SQL] - Some 'options' values for function not shown in sql

2020-09-23 Thread Pradip Parkale
Sep 23, 2020 at 12:14 PM Akshay Joshi < > akshay.jo...@enterprisedb.com> wrote: > >> Hi Pradip >> >> RESQL tests are failing on EPAS 9.5, 9.6, and 10. Please fix and resend >> the patch. >> >> On Tue, Sep 22, 2020 at 6:41 PM Pradip Parkale < >&g

Re: [pgAdmin][RM5867]:Some properties are not getting updated correctly if the server is shared server.

2020-09-30 Thread Pradip Parkale
Hi Akshay, Please find the attached patch for the API failure issue. On Wed, Sep 30, 2020 at 12:34 PM Akshay Joshi wrote: > Thanks, patch applied. > > On Wed, Sep 30, 2020 at 11:00 AM Pradip Parkale < > pradip.park...@enterprisedb.com> wrote: > >> Hi Hackers, >

Re: [pgAdmin][RM5843] [SQL] - Some 'options' values for function not shown in sql

2020-10-01 Thread Pradip Parkale
Hi Akshay, Please find the attached patch to allow the user to modify the option settings of the procedure. This issue was only for PPAS 11 and PPAS 12. On Wed, Sep 23, 2020 at 11:30 PM Pradip Parkale < pradip.park...@enterprisedb.com> wrote: > Hi Akshay, > > Please find the smal

[pgAdmin][RM5822]: Unable to change Start value for existing sequence

2020-10-05 Thread Pradip Parkale
Hi Hackers, Please find the attached patch to allow the user to change the start value of the existing sequence. -- Thanks & Regards, Pradip Parkale Software Engineer | EnterpriseDB Corporation RM5855.patch Description: Binary data

[pgAdmin][RM5835]: "can't execute an empty query" message displayed if user change the option of Auto FK index ? with No

2020-10-06 Thread Pradip Parkale
Hi Hackers, Attached is small patch to disable the Auto FK index? option to avoid 'can't execute an empty query' message. -- Thanks & Regards, Pradip Parkale Software Engineer | EnterpriseDB Corporation RM5835.patch Description: Binary data

[pgAdmin][RM5853]: [Dark theme] Explain > Analyze timings illegible in dark theme.

2020-10-09 Thread Pradip Parkale
Hi Hackers, Attached is a patch for RM5853. 'Rows X' column values were not visible properly in Explain Analyze in the Dark and High contrast theme. -- Thanks & Regards, Pradip Parkale Software Engineer | EnterpriseDB Corporation RM5853.patch Description: Binary data

Re: [pgAdmin][RM5843] [SQL] - Some 'options' values for function not shown in sql

2020-10-11 Thread Pradip Parkale
d. > > On Thu, Oct 1, 2020 at 2:25 PM Pradip Parkale < > pradip.park...@enterprisedb.com> wrote: > >> Hi Akshay, >> >> Please find the attached patch to allow the user to modify the option >> settings of the procedure. This issue was only for PPAS 11 and

[pgAdmin][RM5895]Toast table size in Statistics tab has no suffix

2020-10-18 Thread Pradip Parkale
Hi Hackers, Please find the attached patch for #RM5895. Toast table size unit was missing. -- Thanks & Regards, Pradip Parkale Software Engineer | EnterpriseDB Corporation RM5895.patch Description: Binary data

[pgAdmin][RM4639]: Truncate Trigger option should enabled in properties sections if trigger is already created without each rows

2020-10-20 Thread Pradip Parkale
Hi Hackers, Please find the attached for RM4639 and RM5779. For the trigger, most of the fields will be disabled in edit mode. -- Thanks & Regards, Pradip Parkale Software Engineer | EnterpriseDB Corporation RM4639.patch Description: Binary data

[pgAdmin][RM5842]: Query history shown out of order

2020-10-22 Thread Pradip Parkale
Hi Hackers, Please find the attached patch to sort the query history in descending order. -- Thanks & Regards, Pradip Parkale Software Engineer | EnterpriseDB Corporation RM5842.patch Description: Binary data

[pgAdmin][RM4061]: Backslashes are not handled correctly for SQL_ASCII database in View/Edit table data

2020-10-27 Thread Pradip Parkale
Hi Hackers, Please find the attached for RM4061. Backslashes were not handled correctly for SQL_ASCII database. -- Thanks & Regards, Pradip Parkale Software Engineer | EnterpriseDB Corporation RM4061.patch Description: Binary data

[pgAdmin][RM5914]:Mismatch in 'Estimated row' in properties dialogue on main page & proeties dialogue navigated through context click

2020-10-29 Thread Pradip Parkale
Hi Hackers, Please find the attached patch to fix the RM5914. Mismatch in 'estimated row' n properties dialogue for a created function which is fixed with this patch also disabled the returns to set and window option of the function in edit mode. -- Thanks & Regards, Pradip Pa

[pgAdmin]: Feature test failure

2020-10-30 Thread Pradip Parkale
Hi Hackers, Please find the patch for feature test failure. -- Thanks & Regards, Pradip Parkale Software Engineer | EnterpriseDB Corporation feature_test_failure.patch Description: Binary data

[pgAdmin][RM6153]: Add publication and subscription support in Schema Diff.

2021-02-03 Thread Pradip Parkale
Hi Hackers, Please find the attached patch for publication and subscription support in Schema Diff. Also, added the dependencies for publication and subscription. -- Thanks & Regards, Pradip Parkale Software Engineer | EnterpriseDB Corporation RM6153.patch Description: Binary data

Re: [pgAdmin][RM6153]: Add publication and subscription support in Schema Diff.

2021-02-15 Thread Pradip Parkale
Hi Akshay, Please find the attached patch for API failure. On Mon, Feb 15, 2021 at 4:08 PM Akshay Joshi wrote: > Thanks, patch applied. > > On Mon, Feb 8, 2021 at 3:01 PM Pradip Parkale < > pradip.park...@enterprisedb.com> wrote: > >> Hi Akshay, >> >> Plea

[pgAdmin][RM6201]:SSL Support in subscription.

2021-02-18 Thread Pradip Parkale
Hi Hackers, Please find the attached patch for SSL support in the subscription. I have also fixed the issue raised during the testing of logical replication. -- Thanks & Regards, Pradip Parkale Software Engineer | EnterpriseDB Corporation RM6201.patch Description: Binary data

[pgAdmin][RM4784]: autovacuum and analyze scale factors can't be edited with more than 2 decimals

2021-03-08 Thread Pradip Parkale
Hi Hackers, Please find attached the patch for RM4784. -- Thanks & Regards, Pradip Parkale Software Engineer | EnterpriseDB Corporation RM-4784.patch Description: Binary data

Re: [pgAdmin][RM4784]: autovacuum and analyze scale factors can't be edited with more than 2 decimals

2021-03-09 Thread Pradip Parkale
Hi Hackers, Please ignore my previous email and find the latest attachment. I have changed the default decimals value from 2 to 5. On Mon, Mar 8, 2021 at 10:07 PM Pradip Parkale < pradip.park...@enterprisedb.com> wrote: > Hi Hackers, > > Please find attached the p

[pgAdmin][RM4020]: Color issue on statistics tab for pg-10/11 for Safari Browser

2021-03-11 Thread Pradip Parkale
Hi Hackers, Please find the attached patch for RM4020. The color issue on the collection node statistics tab. This is specific to the Safari browser. -- Thanks & Regards, Pradip Parkale Software Engineer | EnterpriseDB Corporation RM4020.patch Description: Binary data

[pgAdmin][RM6307] - Incorrect values for dependents in pg10

2021-03-15 Thread Pradip Parkale
Hi Hackers, Please find the attached for RM6307 - Incorrect values for dependents for publications in pg10. This patch also includes the fix for RM6316- Primary key' in the table dialogue Is not visible properly. -- Thanks & Regards, Pradip Parkale Software Engineer | EnterpriseDB Co

[pgAdmin]:Patch for SonarQube fixes.

2021-03-18 Thread Pradip Parkale
ariable "e". -- Thanks & Regards, Pradip Parkale Software Engineer | EnterpriseDB Corporation sonarqube.patch Description: Binary data

[pgAdmin][RM6233]:SQL Formatter Uses Tab Size Even When Use Spaces is Set to False

2021-03-21 Thread Pradip Parkale
Hi Hackers, Please find the attached patch for #6233. If the 'Use spaces?' is false then the default tab size will be 4. -- Thanks & Regards, Pradip Parkale Software Engineer | EnterpriseDB Corporation RM6233.patch Description: Binary data

[pgAdmin][RM5519]: Unable to close tab after disconnecting server.

2021-03-31 Thread Pradip Parkale
Hi Hackers, Please find the attached patch for #5519. Updated the existing confirmation message and also added a new confirmation dialog before closing the query tool if the server is disconnected. -- Thanks & Regards, Pradip Parkale Software Engineer | EnterpriseDB Corporation RM5519.p

Re: [pgAdmin][RM5519]: Unable to close tab after disconnecting server.

2021-03-31 Thread Pradip Parkale
> disconnected.'), > > to: > > gettext('The current transaction has been rolled back because the server > was disconnected.'), > > On Wed, Mar 31, 2021 at 3:09 PM Pradip Parkale < > pradip.park...@enterprisedb.com> wrote: > >> Hi Hackers, >> Pl

[pgAdmin][RM6325]:Tools > Storage Manager should have file type as "All files" by default

2021-04-07 Thread Pradip Parkale
Hi Hackers, Please find the attached patch for #6325 - Tools > Storage Manager should have file type as "All files" by default. -- Thanks & Regards, Pradip Parkale Software Engineer | EnterpriseDB Corporation RM6325.patch Description: Binary data

Re: [pgAdmin][RM6325]:Tools > Storage Manager should have file type as "All files" by default

2021-04-07 Thread Pradip Parkale
Hi Akshay, Please find an updated patch. I missed few lines in my previous patch. On Wed, Apr 7, 2021 at 3:45 PM Akshay Joshi wrote: > Hi Pradip > > The issue is not fixed as per the expectation. Please fix and resend the > patch. > > On Wed, Apr 7, 2021 at 1:17

[pgAdmin]:SonarQube fixes.

2021-04-07 Thread Pradip Parkale
Hi Hackers, Please find the attached patch for few SonaQube Fixes. I have fixed the issues in the below files. 1. foreign_key.js 2. exclusion_constraint.js 3. function.js -- Thanks & Regards, Pradip Parkale Software Engineer | EnterpriseDB Corporation SonarQube.patch Descrip

Re: [pgAdmin][RM6325]:Tools > Storage Manager should have file type as "All files" by default

2021-04-07 Thread Pradip Parkale
thon 3.9 and resend the patch again > > On Wed, Apr 7, 2021 at 4:44 PM Pradip Parkale < > pradip.park...@enterprisedb.com> wrote: > >> Hi Akshay, >> >> Please find an updated patch. I missed few lines in my previous patch. >> >> On Wed, Apr 7, 2021 at 3:

[pgAdmin][RM6367]: [SQL] Save button enabled on opening edit table dialog pg 9.5.

2021-04-10 Thread Pradip Parkale
Hi Hackers, Please find the attached patch for # 6367 [SQL] Save button enabled on opening edit table dialog pg 9.5. -- Thanks & Regards, Pradip Parkale Software Engineer | EnterpriseDB Corporation RM6367.patch Description: Binary data

[pgAdmin][RM6385]: Backup on a shared server doesn't seem to work

2021-04-13 Thread Pradip Parkale
Hi Hackers, Please find the attached patch for #6385 Backup on a shared server doesn't seem to work. -- Thanks & Regards, Pradip Parkale Software Engineer | EnterpriseDB Corporation RM6385.patch Description: Binary data

[pgAdmin][RM6341] CSV download quotes numeric columns

2021-04-19 Thread Pradip Parkale
Hi Hackers, Please find the attached patch for #6341 CSV download quotes numeric columns. Initially, the double-precision value was getting typecast to a string. -- Thanks & Regards, Pradip Parkale Software Engineer | EnterpriseDB Corporation RM6341.patch Description: Binary data

[pgAdmin]:SonarQube Fixes

2021-04-20 Thread Pradip Parkale
Hi Hackers, Please find attached the patch for some SonarQube fixes. -- Thanks & Regards, Pradip Parkale Software Engineer | EnterpriseDB Corporation SonarQube.patch Description: Binary data

Re: [pgAdmin][RM6385]: Backup on a shared server doesn't seem to work

2021-04-22 Thread Pradip Parkale
Hi Akshay, Please find the updated patch. I did some modifications as some cases were failing due to my initial changes. Sorry for the inconvenience. On Wed, Apr 14, 2021 at 12:13 PM Akshay Joshi wrote: > Thanks, patch applied. > > On Tue, Apr 13, 2021 at 10:35 PM Pradi

Re: [pgAdmin]:SonarQube Fixes

2021-04-22 Thread Pradip Parkale
Hi, Please ignore my previous patch. PFA attachment of my updated patch. On Tue, Apr 20, 2021 at 1:49 PM Pradip Parkale < pradip.park...@enterprisedb.com> wrote: > Hi Hackers, > > Please find attached the patch for some SonarQube fixes. > > -- > Thanks & Regards,

Re: [pgAdmin][RM6341] CSV download quotes numeric columns

2021-04-26 Thread Pradip Parkale
Hi Akshay, Please find the updated patch for #6251. I have fixed the issue caused due to my initial patch. On Thu, Apr 22, 2021 at 5:42 PM Akshay Joshi wrote: > Thanks, patch applied. > > On Tue, Apr 20, 2021 at 10:54 AM Pradip Parkale < > pradip.park...@enterprisedb.com> wrot

Re: [pgAdmin][RM6385]: Backup on a shared server doesn't seem to work

2021-04-26 Thread Pradip Parkale
Hi Akshay, Please find the updated patch. I have added more checks so that it will pick the correct shared server. On Thu, Apr 22, 2021 at 5:43 PM Akshay Joshi wrote: > Thanks, patch applied. > > On Thu, Apr 22, 2021 at 2:37 PM Pradip Parkale < > pradip.park...@enterprisedb.com&

[pgAdmin][RM6355]: pgAdmin is able to open external files that are dragged into it.

2021-04-27 Thread Pradip Parkale
Hi Hackers, Please find the attached patch for #6355. I have added the event to prevent the browser from opening the dragged file. -- Thanks & Regards, Pradip Parkale Software Engineer | EnterpriseDB Corporation RM6355.patch Description: Binary data

[pgAdmin][RM4436]Drag and drop is incorrect in codemirror boxes in node properties dialog

2021-04-28 Thread Pradip Parkale
Hi Hackers, Please find the attached patch for #4436 - Drag and drop is incorrect in codemirror boxes in node properties dialog. -- Thanks & Regards, Pradip Parkale Software Engineer | EnterpriseDB Corporation RM4436.patch Description: Binary data

[pgAdmin][RM6417]:Query editor is not being closed if user Click on don't Save button

2021-04-29 Thread Pradip Parkale
Hi Hackers, Please find the attached patch for #6417 Query editor is not being closed if user Click on don't Save button. -- Thanks & Regards, Pradip Parkale Software Engineer | EnterpriseDB Corporation RM6417.patch Description: Binary data

Re: [pgAdmin][RM6355]: pgAdmin is able to open external files that are dragged into it.

2021-05-06 Thread Pradip Parkale
a > *EDB* > *POWER TO POSTGRES* > https://www.edbpostgres.com > > > On Wed, Apr 28, 2021 at 12:02 PM Akshay Joshi < > akshay.jo...@enterprisedb.com> wrote: > >> Thanks, patch applied. >> >> On Tue, Apr 27, 2021 at 8:12 PM Pradip Parkale < >> prad

[pgAdmin][RM6399]: Add panel option allows to add duplicate tabs.

2021-05-11 Thread Pradip Parkale
Hi Hackers, Please find the attached patch for #6399. I have partially fixed the issue. I have set the limit of 1 so that user won't be able to add any duplicate panel. -- Thanks & Regards, Pradip Parkale Software Engineer | EnterpriseDB Corporation RM6399.patch Description: Binary data

[pgAdmin][RM6443]: File Dialog shows incorrect files for selected file type

2021-05-13 Thread Pradip Parkale
Hi Hackers, Please find the attached patch for #6443 File Dialog shows incorrect files for the selected file type. -- Thanks & Regards, Pradip Parkale Software Engineer | EnterpriseDB Corporation RM6443.patch Description: Binary data

[pgAdmin][RM6414]: Help message not displaying correctly on Create - Login/Group Role

2021-05-16 Thread Pradip Parkale
Hi Hackers, Please find the attached patch for #6414 Help message not displaying correctly on Create - Login/Group Role. -- Thanks & Regards, Pradip Parkale Software Engineer | EnterpriseDB Corporation RM6414.patch Description: Binary data

[pgAdmin][RM6231]- Add OS, Browser details in pgAdmin About us pop-up

2021-05-21 Thread Pradip Parkale
Hi Hackers, Please find the attached patch for #6231. I have added OS, NW.js, browser details, and some server configuration in the About pgAdmin pop-up. Server configuration won't be visible to the non-admin users in server mode. -- Thanks & Regards, Pradip Parkale Software

[pgAdmin][RM6520]: pgAdmin4 v 5.3 text export error

2021-06-11 Thread Pradip Parkale
Hi Hackers, Please find the attached patch for #6520.Added check to typecast the numeric data while downloading the data in CSV format. -- Thanks & Regards, Pradip Parkale Software Engineer | EnterpriseDB Corporation RM6520.patch Description: Binary data

Re: [pgAdmin][RM6520]: pgAdmin4 v 5.3 text export error

2021-06-14 Thread Pradip Parkale
_cols or > numeric_keys. > > On Fri, Jun 11, 2021 at 7:17 PM Pradip Parkale < > pradip.park...@enterprisedb.com> wrote: > >> Hi Hackers, >> >> Please find the attached patch for #6520.Added check to typecast the >> numeric data while downloading the dat

[pgAdmin][RM6398]: Detaching query editor panel gives a blank white panel.

2021-06-16 Thread Pradip Parkale
Hi Hackers, Please find the attached patch for #6398.Detaching query editor panel gives a blank white panel. -- Thanks & Regards, Pradip Parkale Software Engineer | EnterpriseDB Corporation RM6398.patch Description: Binary data

[pgAdmin][RM6448]: [search object] error displayed for non superuser because of right on pg_catalog.pg_subscription

2021-06-22 Thread Pradip Parkale
Hi Hackers, Please find the attached patch for # 6448. I have added a check to ignore the subscription when the search type is 'All type' if the user doesn't have access to subscription. -- Thanks & Regards, Pradip Parkale Software Engineer | EnterpriseDB Corporation RM644

Re: [pgAdmin][RM6448]: [search object] error displayed for non superuser because of right on pg_catalog.pg_subscription

2021-06-22 Thread Pradip Parkale
Hi Hackers, Please ignore my previous email and find the attached patch. I have fixed some review comments given by Aditya. On Tue, Jun 22, 2021 at 2:21 PM Fred wrote: > nice ! > thanks > > fred > > > Le 22 juin 2021 09:08:05 GMT+02:00, Pradip Parkale < > pradip.

Re: [pgAdmin][RM6398]: Detaching query editor panel gives a blank white panel.

2021-06-24 Thread Pradip Parkale
Hi Akshay, Please find attached for debugger and ERD tool which was missing in my previous patch. On Wed, Jun 23, 2021 at 11:50 AM Akshay Joshi wrote: > Thanks, the patch applied. > > On Wed, Jun 16, 2021 at 11:29 PM Pradip Parkale < > pradip.park...@enterprisedb.com> wrot

  1   2   >