[pgAdmin4][Patch]: RM 6317 - Toggle buttons are inaccessible

2021-03-17 Thread Khushboo Vashi
Hi, Please find the attached patch to fix the RM #6317: Toggle buttons are inaccessible. Our toggle buttons are not the HTML buttons but the combinations of HTML tags which function as a toggle button. As the toggle button itself doesn't have a label/title as it wrapped around a div, we have pro

Re: OAuth error when logging in

2021-03-29 Thread Khushboo Vashi
Hi Florian, As Dave mentioned, we use the user's password as an encryption key for saving Postgres passwords, and we do so by maintaining KeyManager. As for OAuth implementation, you do not have a password, you need to bypass this step ( and that is the reason you are being redirected to the login

[pgAdmin4][Patch] - RM 6158 - Logging into PostgreSQL servers with Kerberos Authentication

2021-04-07 Thread Khushboo Vashi
Hi, Please find the attached patch for RM 6158: Support Kerberos Authentication - Phase 2. This patch includes the support for logging into PostgreSQL servers with Kerberos authentication. Thanks, Khushboo RM_6158.patch Description: Binary data

[pgAdmin4][Patch] - RM 6274 - LDAP auth module is not translatable

2021-04-08 Thread Khushboo Vashi
Hi, Please find the attached patch to fix RM #6274 - LDAP auth module is not translatable. Thanks, Khushboo RM_6274.patch Description: Binary data

Re: [pgAdmin4][Patch] - RM 6158 - Logging into PostgreSQL servers with Kerberos Authentication

2021-04-14 Thread Khushboo Vashi
Hi, Please find the attached patch with some minor improvements. Thanks, Khushboo On Wed, Apr 7, 2021 at 11:50 PM Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi, > > Please find the attached patch for RM 6158: Support Kerberos > Authentication - Phase 2. >

Re: [pgAdmin4][Patch] - RM 6158 - Logging into PostgreSQL servers with Kerberos Authentication

2021-05-03 Thread Khushboo Vashi
support it. So, now users can get the idea about the connection through The "Kerberos authentication" flag displayed on the properties tab. > >- *Suggestion 2*: If it is possible to detect that the database server >is connected using Kerberos then we should disable the

[pgAdmin4][Patch] - RM #5776 - Needlessly prompted for a password with SSPI logins

2021-05-04 Thread Khushboo Vashi
Hi, Please find the attached patch for RM #5776 - Needlessly prompted for a password with SSPI logins. To fix this issue, I have enabled the "Kerberos authentication" flag in the server dialog for Desktop mode also. So, if this flag is set to True, pgAdmin will not prompt for a password on conn

Re: oauth2 patch

2021-05-10 Thread Khushboo Vashi
On Mon, May 10, 2021 at 10:59 AM Akshay Joshi wrote: > Hi Khushboo > > Can you please review the patch? > On it. > > On Sun, May 9, 2021 at 12:53 AM Florian Sabonchi > wrote: > >> Hello in this patch I have implemented OAuth2. Unfortunately I wasn't >> sure how the test should look like, becaus

[pgAdmin4][Patch] - RM #6444 and #6445

2021-05-13 Thread Khushboo Vashi
Hi, Please find the attached patch to fix below RMs. #6444 - [Kerbores] - User is not warned if Kerberos ticket expiration is less than 30 min while initiating global backup. #6445 - [Kerbores] - Kerberos Auth flag is True in properties dialogue though server is connected with password. There i

Re: oauth2 patch

2021-05-24 Thread Khushboo Vashi
https://redmine.postgresql.org/issues/5940, I have attached your initial patch in the RM itself. Thanks, Khushboo On Mon, May 10, 2021 at 4:02 PM Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > > > On Mon, May 10, 2021 at 10:59 AM Akshay Joshi < > akshay.j

[pgAdmin4][Patch] - RM 6513 - pgAdmin server mode does not open after password reset.

2021-06-10 Thread Khushboo Vashi
Hi, Please find the attached patch to fix the RM 6513 - pgAdmin server mode does not open after password reset. Thanks, Khushboo forgot_password.patch Description: Binary data

[pgAdmin4][Patch] - Test cases failure fix

2021-06-17 Thread Khushboo Vashi
Hi, Please find the attached patch to fix the test cases failure due to below error on PG 9.6. psycopg2.errors.ObjectInUse: database "test_db_1658f" is being accessed by other users DETAIL: There is 1 other session using the database. Thanks, Khushboo api_test_cases_failure_fixes.patch Descri

Re: Refactor: Registry Classes

2021-06-24 Thread Khushboo Vashi
Hi, This patch introduced the server mode api test case failure, please find the attached patch to fix those as well as some of the old issues in the server mode. Patch by: Ashesh Vashi Thanks, Khushboo On Thu, Jun 24, 2021 at 11:31 AM Akshay Joshi wrote: > Thanks, the patch applied. > > On W

Re: RM 6427 - Newlines in text columns of resultset show an allegedly "empty" field

2021-06-30 Thread Khushboo Vashi
Hi Dave, On Wed, Jun 30, 2021 at 3:35 PM Dave Page wrote: > Here's a simple patch for $SUBJECT. It will remove any leading spaces from > the grid cell display and replace them with '[...] '. In edit mode, the > data is unchanged. > > The patch looks good to me. Do we need to specify somewhere wh

Re: [patch][pgAdmin] Fix for pgadmin4-linux-qa #1651 failure

2021-06-30 Thread Khushboo Vashi
On Wed, Jun 30, 2021 at 6:55 PM Dave Page wrote: > Hi > > On Wed, Jun 30, 2021 at 9:22 AM Dave Page wrote: > >> Hi >> >> On Wed, Jun 30, 2021 at 8:28 AM Rahul Shirsat < >> rahul.shir...@enterprisedb.com> wrote: >> >>> Hi All, >>> >>> Please find the attached patch for resolving this issue wrt ab

Re: [pgAdmin4][patch] Remove extra brackets in CREATE Script and DDL Comparison

2021-07-06 Thread Khushboo Vashi
Patch looks good to me. On Tue, Jul 6, 2021 at 3:15 PM zhangj...@fujitsu.com wrote: > Hi, all > > Extra brackets appear in CREATE Script and DDL Comparison, > please refer to the attachment error1.png and error2.png for details. > > â–  scenario > The step is as follow: > 1) Connect to pg9.6 or pg

[pgAdmin4][Patch] - RESQL testcase fixes for Triggers

2021-07-07 Thread Khushboo Vashi
Hi, Please find the attached patch to fix the RESQL test cases for Triggers. Thanks, Khushboo RESQL_test_case_fixes_triggers.patch Description: Binary data

[pgAdmin4][Patch]: RM 6590 - Improve the error message if the Oauth2 profile doesn't have email id

2021-07-07 Thread Khushboo Vashi
Hi, Please find the attached patch to fix the RM #6590 - Informative error should be shown if Oauth2 profile does not have email id registered. Thanks, Khushboo RM_6590.patch Description: Binary data

[pgAdmin4][Patch] - RM #6594 - Unable to login with OAuth2 when LDAP & OAuth2 configured as login sources

2021-07-09 Thread Khushboo Vashi
Hi, Please find the attached patch to fix the RM #6594 - Unable to login with OAuth2 when LDAP & OAuth2 configured as login sources. Thanks, Khushboo RM_6594.patch Description: Binary data

[pgAdmin4][Patch] - RM #6595 - Unable to add server in Kerberos Authentication Mode with Master Password enabled

2021-07-09 Thread Khushboo Vashi
Hi, Please find the attached patch to fix the RM#6595 - Unable to add server in Kerberos Authentication Mode with Master Password enabled. Thanks, Khushboo RM_6596.patch Description: Binary data

Re: [patch][pgAdmin] RM6369 CSRF errors for stale sessions

2021-07-13 Thread Khushboo Vashi
Hi Rahul, You made this change at the end of the config.py file, so the changes made by the user for this parameter in config_local or config_system file will not be reflected. Thanks, Khushboo On Tue, Jul 13, 2021 at 6:24 PM Rahul Shirsat < rahul.shir...@enterprisedb.com> wrote: > Hi Hackers,

Re: [patch][pgAdmin] RM6369 CSRF errors for stale sessions

2021-07-13 Thread Khushboo Vashi
On Wed, Jul 14, 2021 at 10:49 AM Rahul Shirsat < rahul.shir...@enterprisedb.com> wrote: > @Khushboo Vashi 👍 > > Please find the updated patch. > The code change looks good. > > On Tue, Jul 13, 2021 at 6:33 PM Khushboo Vashi < > khushboo.va...@enterprisedb.com>

Re: SQLAlchemy updates for check tables.

2021-07-19 Thread Khushboo Vashi
On Mon, Jul 19, 2021 at 2:17 PM Dave Page wrote: > Hi > > On Mon, Jul 19, 2021 at 6:37 AM Nikhil Mohite < > nikhil.moh...@enterprisedb.com> wrote: > >> Hi Hackers, >> >> Please find the attached patch for SQLAlchemy updates for check table is >> present in the database or not. (This will resolve

Re: SQLAlchemy updates for check tables.

2021-07-20 Thread Khushboo Vashi
On Mon, Jul 19, 2021 at 3:14 PM Dave Page wrote: > > > On Mon, Jul 19, 2021 at 9:58 AM Khushboo Vashi < > khushboo.va...@enterprisedb.com> wrote: > >> >> >> On Mon, Jul 19, 2021 at 2:17 PM Dave Page wrote: >> >>> Hi >>> >

[pgAdmin4][Patch] - Fix for RM #6664

2021-08-08 Thread Khushboo Vashi
Hi, Please find the attached fix for the RM #6664. The issue is, even if the user is locked, he can reset the password and can login into pgAdmin. With this fix, I have also ensured that the account should be locked with the multiple failed attempts only for the Internal pgAdmin users. Thanks, K

Re: [pgAdmin4][Patch] - Fix for RM #6664

2021-08-09 Thread Khushboo Vashi
Hi, Kerberos Login fails for the first time which is a regression of the #6337 - Login page brute force. Please find the attached updated patch with this fix. Thanks, Khushboo On Mon, Aug 9, 2021 at 11:32 AM Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi, > >

Re: [pgAdmin][PATCH] Add OAUTH2_SCOPE variable for scope configuration

2021-08-31 Thread Khushboo Vashi
Hi, The patch looks good to me. Please find the attached patch for the same. Thanks, Khushbo On Sun, Aug 29, 2021 at 7:46 PM Akshay Joshi wrote: > Hi Khushboo > > Can you please review/test the patch? > > On Fri, Aug 27, 2021 at 7:46 PM Nico Rikken > wrote: > >> In certain cases like with Ope

Re: [pgAdmin][PATCH] Add OAUTH2_SCOPE variable for scope configuration

2021-08-31 Thread Khushboo Vashi
Hi, Note that this patch just includes the configurable Scope (which would be helpful in OpenID connect), it does not include the proper OIDC implementation. Thanks, Khushboo On Tue, Aug 31, 2021 at 12:52 PM Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi, > >

Re: [pgAdmin][PATCH] Add OAUTH2_SCOPE variable for scope configuration

2021-08-31 Thread Khushboo Vashi
On Tue, Aug 31, 2021 at 1:25 PM Nico Rikken wrote: > Thanks for reviewing. Indeed this is a bandaid to expand the usability of > the OAuth implementation. As I've written on the redmine issue as well > https://redmine.postgresql.org/issues/6627 I've tested my usecase with a > modified scope by pa

[pgAdmin4][Patch] - Fixed Dialog Closing issue

2021-09-28 Thread Khushboo Vashi
Hi, Please find the attached patch to fix the dialog closing issue. Thanks, Khushboo update_issue.patch Description: Binary data

[pgAdmin4][Patch]: Fixed Tree Item add error

2021-09-28 Thread Khushboo Vashi
Hi, Please find the attached patch to fix the error on the console while adding the new node. Thanks, Khushboo tree_add_item_fix.patch Description: Binary data

[pgAdmin4][Patch] - Fixes for RM #6817 & RM #6820

2021-09-28 Thread Khushboo Vashi
Hi, Please find the attached patch for the RM #6817 and RM #6820. #6817 - Browser panel turns blank on connecting disconnected database & server has multiple databases #6820 - Use hand pointer instead of arrow Thanks, Khushboo RM_6817_6820.patch Description: Binary data

[pgAdmin4][Patch] - Fixes for RM #6817, #6821, #6824

2021-09-29 Thread Khushboo Vashi
Hi, Please find the attached patch to fix the below RMs: #6817 - Browser panel turns blank on connecting disconnected database & server has multiple databases #6821 -Object is not selected/properties panel is not updated when user moves to object with arrow keys #6824 - Object get deselected af

Re: [pgAdmin4][Patch] - Fixes for RM #6817, #6821, #6824

2021-09-29 Thread Khushboo Vashi
Hi, Please find the rebased patch. Thanks, Khushboo On Wed, Sep 29, 2021 at 4:02 PM Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi, > > Please find the attached patch to fix the below RMs: > > #6817 - Browser panel turns blank on connecting disconnected da

[pgAdmin4][Patch] - Fixes RM #6833

2021-09-30 Thread Khushboo Vashi
Hi, Please find the attached patch to partial fix the RM #6833 - The Properties panel is not updated when any object is added/deleted from the browser tree. This patch includes the fix when we delete the object from the collection node. It also includes the fix when the pgAdmin window is resized

Re: [pgAdmin4][Patch] - Fixes RM #6833

2021-09-30 Thread Khushboo Vashi
Hi, Please find the attached updated patch. Thanks, Khushboo On Thu, Sep 30, 2021 at 1:37 PM Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi, > > Please find the attached patch to partial fix the RM #6833 - The > Properties panel is not updated when any objec

[pgAdmin4][Patch] - Fixes for RM #6839 & RM #6852

2021-10-02 Thread Khushboo Vashi
Hi, Please find the attached patch to fix the below RMs: RM #6839 - Newly added server/server group is not visible in tree unless pgAdmin refreshed RM #6852 - Internal server error displayed if disconnect the server Thanks, Khushboo RM_6839_6852.patch Description: Binary data

[pgAdmin4][Patch] - RM #6847 - High Contrast theme hover issue

2021-10-03 Thread Khushboo Vashi
Hi, Please find the attached patch to fix the RM #6847 - [UI-Tree view][High Contrast theme]: Hover on any node its label is not visible. Thanks, Khushboo RM_6847.patch Description: Binary data

Re: [pgAdmin4][Patch] - RM #6847 - High Contrast theme hover issue

2021-10-04 Thread Khushboo Vashi
Hi, Please find the attached patch to fix the hover issue. Thanks, Khushboo On Mon, Oct 4, 2021 at 11:36 AM Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi, > > Please find the attached patch to fix the RM #6847 - [UI-Tree view][High > Contrast theme]: Hover on

[pgAdmin4][Patch] - RM #6844 - Partitions collection node loading issue.

2021-10-04 Thread Khushboo Vashi
Hi, Please find the attached patch to fix the RM #6844 - [Table node]: Partitions collection node loading issue. Thanks, Khushboo RM_6844.patch Description: Binary data

[pgAdmin4][Patch] - Fixes for #6863 & #6861

2021-10-05 Thread Khushboo Vashi
Hi, Please find the attached patch to fix the below RMs: RM # 6863 - Table Dialogue does not close on addition/deletion pf partition. RM # 6861 - Nodes are loaded multiple times in server mode on 'Rest Layout'. Thanks, Khushboo RM_6861_6863.patch Description: Binary data

[pgAdmin4][Patch] - RM #6828 - Search object: Issue with focus the searched object in the tree.

2021-10-06 Thread Khushboo Vashi
Hi, Please find the attached patch to fix the RM #6828 - Search object: Issue with focus the searched object in the tree. Note: Please commit this patch after release. Thanks, Khushboo RM_6828.patch Description: Binary data

[pgAdmin4][Patch] - RM 6657 - Support for REMOTE_USER as Authentication.

2021-10-11 Thread Khushboo Vashi
Hi, Please find the attached patch for #6657 - Support for REMOTE_USER as Authentication. The initial patch was provided by *Tom Schreiber,* I have made the necessary changes to work with pgAdmin and also added test cases and documentation. Please commit the patch on *Tom Schreiber's *name. This

[pgAdmin4][Patch] - RM #6882 - Object browser tree table columns display order

2021-10-12 Thread Khushboo Vashi
Hi, Please find the attached patch to fix the RM #6882 - Object browser tree table columns display order. Thanks, Khushboo RM_6882.patch Description: Binary data

[pgAdmin4][Patch] - RM #6881 - Browser tree falls apart upon changing resolution

2021-10-12 Thread Khushboo Vashi
Hi, Please find the attached patch for RM #6881 - Browser tree falls apart upon changing resolution Thanks, Khushboo RM_6881.patch Description: Binary data

[pgAdmin4][Patch] - RM #4596 - Directory tree indent guides

2021-10-12 Thread Khushboo Vashi
Hi, Please find the attached patch to fix the RM #4596 - Directory tree indent guides. Thanks, Khushboo RM_4596.patch Description: Binary data

[pgAdmin4][Patch] - RM #6905 - Impossible to load databases

2021-10-13 Thread Khushboo Vashi
Hi, Please find the attached patch to fix the RM #6905 - Impossible to load databases. Thanks, Khushboo RM_6905.patch Description: Binary data

[pgAdmin4][Patch] - RM #6908 - pgAdmin 4 v6.0 browser bug (objects refresh issue).

2021-10-15 Thread Khushboo Vashi
Hi, Please find the attached patch to fix the RM #6908 - pgAdmin 4 v6.0 browser bug (objects refresh issue). Thanks, Khushboo RM_6908.patch Description: Binary data

[pgAdmin4][Patch] - RM #6912 - pgadmin 6.0: browser tree sort order regression

2021-10-15 Thread Khushboo Vashi
Hi, Please find the attached patch to fix the RM #6912 - pgadmin 6.0: browser tree sort order regression. Thanks, Khushboo RM_6912.patch Description: Binary data

Re: feature #6640

2021-10-17 Thread Khushboo Vashi
Hi Florian, Review comments: - Allowed_organisation is introduced for all, so the code comments and documentation should reflect it. Github should be an example of that. - The below code checks all the Oauth2 configs, so if I have set ALLOWED_ORGANIZATIONS for only github, it will check for all t

Re: Patch for Bug #6832

2021-10-17 Thread Khushboo Vashi
Hi Florian, The patch will fail if we have AUTHENTICATION_SOURCES = ['ldap', 'oauth2'] settings. Also, please rebase your patch. Thanks, Khushboo On Wed, Oct 13, 2021 at 4:03 PM Florian Sabonchi wrote: > Hello I have written a patch for the bug #6832 > >

[pgAdmin4][Patch] - Fix for RM #6928

2021-10-18 Thread Khushboo Vashi
Hi, Please find the attached patch for the RM #6928 - Master password is not asked when On MASTER_PASSWORD_REQUIRED=True & AUTHENTICATION_SOURCES=['webserver'] Thanks, Khushboo RM_6928.patch Description: Binary data

[pgAdmin4][Patch] - RM #6930 - Existing Server group disappear if user rename it

2021-10-18 Thread Khushboo Vashi
Hi, Please find the attached patch to fix the RM #6930 - Existing Server group disappear if user rename it Thanks, Khushboo RM_6930.patch Description: Binary data

[pgAdmin4][Patch] - RM 6905 - Impossible to load databases

2021-11-09 Thread Khushboo Vashi
Hi, Please find the attached patch to fix the RM #6905 - Impossible to load databases. The database nodes are not getting loaded *behind* *reverse proxy with SSL*. This issue has been fixed in this patch. Note: Yogesh helped me to setup the apache server with reverse proxy with SSL and to reprod

[pgAdmin4][Patch] - RM #6953 - Webserver Authentication enhancement

2021-11-10 Thread Khushboo Vashi
Hi, Please find the attached patch for the RM # 6953 - Webserver Authentication: Include headers coming from servers. In the RM, 2 users have provided the solution, I have merged them. As per the current behaviour, pgAdmin only considers the REMOTE_USER environment variable (set by the webserver

Re: [pgAdmin4][Patch] - RM 6905 - Impossible to load databases

2021-11-10 Thread Khushboo Vashi
regards > > Ayad Mohamed > > > > > > > > > > > > ------ > > > Videresendt brev > *Fra*: Khushboo Vashi > > *Til*: pgadmin-hackers > > *Emne*: [pgAdmin4][Patch] - RM 6905 - Impossible to loa

Re: [pgAdmin4][Patch] - RM 6905 - Impossible to load databases

2021-11-10 Thread Khushboo Vashi
t-drift > Vester Voldgade 123 > 1552 København V > Tlf.: 3587 8889 > > Direkte tlf.: +45 4172 7259 > E-mail: ayad.moha...@stil.dk tree_nodes.ts > > > -- > *From:* Khushboo Vashi > *Sent:* 10 November 2021 13:01 > *To:* Ayad Mohamed &

Re: [pgAdmin4][Patch] - RM 6905 - Impossible to load databases

2021-11-10 Thread Khushboo Vashi
Børne- og Undervisningsministeriet > Styrelsen for It og Læring > Kontor for It-drift > Vester Voldgade 123 > 1552 København V > Tlf.: 3587 8889 > > Direkte tlf.: +45 4172 7259 > E-mail: ayad.moha...@stil.dk > > > -- > *From:* Kh

Re: [pgAdmin4][Patch] - RM 6905 - Impossible to load databases

2021-11-11 Thread Khushboo Vashi
elsen for It og Læring > Kontor for It-drift > Vester Voldgade 123 > 1552 København V > Tlf.: 3587 8889 > > Direkte tlf.: +45 4172 7259 > E-mail: ayad.moha...@stil.dk > > > -- > *From:* Khushboo Vashi > *Sent:* 11 November 2021 08:18 >

[pgAdmin4][Patch] - RM #6896 - Tree view: Issue with navigate using arrow keys from keyboard.

2021-11-14 Thread Khushboo Vashi
Hi, Please find the attached patch to fix the RM # 6896 - Tree view: Issue with navigate using arrow keys from keyboard. Thanks, Khushboo RM_6896.patch Description: Binary data

[pgAdmin4][Patch]: Fixed tree keyboard navigation visibility issue

2021-11-15 Thread Khushboo Vashi
Hi, Please find the attached patch to fix the tree keyboard navigation visibility issue. Thanks, Khushboo tree_keyboard_navigation_visibility_fix.patch Description: Binary data

Re: OAUTH2 Problems

2021-11-15 Thread Khushboo Vashi
Hi, On Mon, Nov 15, 2021 at 10:12 PM Francisco Cardoso < francisco.card...@datascience-service.at> wrote: > Hello pgadmin hackers, > > > > I have problems with the configuration of the oauth2 with azureAD. > > > > It seems like the configuration is not applied as the display name is not > applied

[pgAdmin4][Patch]: SonarQube Fixes

2022-01-27 Thread Khushboo Vashi
Hi, Please find the attached patch to fix the Sonarqube issues which are assigned to me. Thanks, Khushboo tree_sonarqube_fixes.patch Description: Binary data

[pgAdmin4][Patch]: SonarQube Regression Fix

2022-02-03 Thread Khushboo Vashi
Hi, Please find the attached patch to fix the regression due to SonarQube fixes in the browser tree. Thanks, Khushboo SonarQube_fixes.patch Description: Binary data

Re: Bug #6991 - Suggestion to Contribute Fix

2022-02-10 Thread Khushboo Vashi
Will review and test the patch. On Fri, Feb 11, 2022 at 10:16 AM Akshay Joshi wrote: > Hi Khushboo > > Can you please review the patch? > > On Thu, Feb 10, 2022 at 1:49 PM Charlet, Christoph < > christoph.char...@d-fine.de> wrote: > >> That’s great. >> >> >> >> I am suggesting the attached chang

Re: "Disconnect from server"

2022-02-13 Thread Khushboo Vashi
On Fri, Feb 11, 2022 at 9:23 PM Anthony DeBarros wrote: > Hi, hackers, > > I was happy to see the menu item Disconnect Server renamed to Disconnect > from server. That one always scared me a little as a newer user, and the > rename makes it more explicit. > > Wondering whether it also makes sense

Re: [pgAdmin4][Patch] - PostgreSQL deployment on Amazon RDS

2022-02-14 Thread Khushboo Vashi
ython3/#\!\/usr\/pgadmin4\/venv\/bin\/python3/g' venv/bin/*" failed > in "_create_python_virtualenv" with exit code 4. > > > API test cases for Utilities are failing. > Please find the attached patch to fix the API test cases. Thanks, Khushboo > > On Mon, Feb 1

Re: Bug #6991 - Suggestion to Contribute Fix

2022-02-16 Thread Khushboo Vashi
Hi Akshay, On Fri, Feb 11, 2022 at 11:46 AM Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Will review and test the patch. > The patch looks good to me, however I couldn't test the patch as I am facing an SSL handshake issue on my laptop which is not related to th

[pgAdmin4][Patch] - Cloud Deployment Fixes

2022-02-18 Thread Khushboo Vashi
Hi, Please find the fixes related to the cloud deployment module. Below issues are fixed: - No options are shown in the instance type. - Only reproducible if you click immediately after selecting Instance class - No options for last 2 types.- Intermittent - Unable to change Storage c

[pgAdmin4][Patch] - AWS Cloud Deployment fixes

2022-02-27 Thread Khushboo Vashi
Hi, Please find the attached patch to fix the below issues in AWS cloud deployment: - Fixed issue of Mumbai region - Regions Display name modified properly - Added validation same as AWS for Password field - Added support to provide list of IPs in *public IP range* field Thanks, Khushboo aws_c

[pgAdmin4][Patch] - Cloud Wizard fixes

2022-03-02 Thread Khushboo Vashi
Hi, Please find the attached patch to fix the below issues/suggestions: - Mask the credentials input fields - Loading symbol doesn't work while reloading the options in the select control - Decrease the wizard opening timeout - Host IP fetch issue due to urllib library upgrade Thanks, Khushboo

[pgAdmin4][Patch]: Fixed default public IP range issue in AWS deployment

2022-03-10 Thread Khushboo Vashi
Hi, Please find the attached patch to fix the default Public IP range issue in AWS deployment. @Yogesh Mahajan , please test. Thanks, Khushboo cloud_public_ip_fix.patch Description: Binary data

Re: [pgAdmin4][Patch]: Fixed default public IP range issue in AWS deployment

2022-03-10 Thread Khushboo Vashi
Yogesh Mahajan >> EnterpriseDB >> >> >> On Fri, Mar 11, 2022 at 8:49 AM Khushboo Vashi < >> khushboo.va...@enterprisedb.com> wrote: >> >>> Hi, >>> >>> Please find the attached patch to fix the default Public IP range issue >

Re: Portuguese Brazilian Translation

2022-03-20 Thread Khushboo Vashi
Hi Anderson, On Fri, Mar 18, 2022 at 4:02 PM Anderson de Barros Carpi < anderson.ca...@unesp.br> wrote: > Hi guys, > > Always used the tool and I thought it would be nice to help the project a > little, even with translations... > > There are any Portuguese (brazilian) translations already happen

Re: Portuguese Brazilian Translation

2022-03-20 Thread Khushboo Vashi
On Mon, Mar 21, 2022 at 9:52 AM Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi Anderson, > > On Fri, Mar 18, 2022 at 4:02 PM Anderson de Barros Carpi < > anderson.ca...@unesp.br> wrote: > >> Hi guys, >> >> Always used the tool and I t

Re: [Patch] Bug #5836 - LDAP auth - Case Sensitive

2022-03-29 Thread Khushboo Vashi
I have done the code review and it looks good to me. On Tue, Mar 29, 2022 at 12:58 PM Yogesh Mahajan < yogesh.maha...@enterprisedb.com> wrote: > Hello, > > Attached patch adds a new ldap authentication configuration parameter > which indicates case sensitivity of the ldap schema/server. > > > Tha

Re: Translate PgAdmin Portuguese Brazil

2022-04-04 Thread Khushboo Vashi
Hi, On Mon, Apr 4, 2022 at 5:09 PM Leonardo Costa wrote: > Hi, my name is Leonardo > > I would like to translate PgAdmin into Brazilian Portuguese, how can i > participate in the project? > > Please go through the links below to add support for a new language. https://www.pgadmin.org/developmen

[pgAdmin4][Patch]- Feature #7012 - disable master password requirement when using alternative auth source

2022-04-10 Thread Khushboo Vashi
Hi, Please find the attached patch to implement the feature #7012 - Disable master password requirement when using alternative auth source When pgAdmin stores a connection password, it encrypts it using a key that is formed either from the master password, or from the pgAdmin login password for t

[pgAdmin4][Patch] - RM #7026 - Browser panel is not completely viewable

2022-04-13 Thread Khushboo Vashi
Hi, Please find the attached patch to fix the rm #7026 - Browser panel is not completely viewable. Thanks, Khushboo RM_7026.patch Description: Binary data

[pgAdmin4][Patch] - RM #6746 - kerberos problems and kerberos documentation

2022-04-13 Thread Khushboo Vashi
Hi, Please find the attached patch to improve the Kerberos Authentication. Note: I have given the reference to the Kerberos understanding in the documentation. Thanks, Khushboo RM_6746.patch Description: Binary data

Re: [pgAdmin4][Patch]- Feature #7012 - disable master password requirement when using alternative auth source

2022-04-22 Thread Khushboo Vashi
On Fri, Apr 22, 2022 at 2:01 PM Dave Page wrote: > Hi > > On Mon, 11 Apr 2022 at 09:20, Akshay Joshi > wrote: > >> Thanks, the patch applied. >> >> On Mon, Apr 11, 2022 at 12:00 PM Khushboo Vashi < >> khushboo.va...@enterprisedb.com> wrote: >>

Re: [pgAdmin4][Patch]- Feature #7012 - disable master password requirement when using alternative auth source

2022-04-22 Thread Khushboo Vashi
On Fri, Apr 22, 2022 at 2:34 PM Dave Page wrote: > > > On Fri, 22 Apr 2022 at 09:57, Khushboo Vashi < > khushboo.va...@enterprisedb.com> wrote: > >> >> >> On Fri, Apr 22, 2022 at 2:01 PM Dave Page wrote: >> >>> Hi >>>

[pgAdmin4][Patch] - Server Disconnect Issue

2022-04-26 Thread Khushboo Vashi
Hi, Please find the attached patch to fix the Server Disconnect Issue. Steps to reproduce the issue: Connect the server -> Refresh the page -> Disconnect the server. Password popup will appear on disconnection. Thanks, Khushboo server_disconnect_issue.patch Description: Binary data

[pgAdmin4][Patch] - Linter Fixes

2022-04-26 Thread Khushboo Vashi
Hi, Please find the attached patch to fix the linter issue. Thanks, Khushboo linter_fixes.patch Description: Binary data

[pgAdmin4][Patch] - BigAnimal Fixes

2022-04-26 Thread Khushboo Vashi
Hi, While deploying the PostgreSQL on the BigAnimal cloud, the Public IP addresses were not added, fixed this issue in the attached patch. Thanks, Khushboo cloud_public_ip_fixe.patch Description: Binary data

[pgAdmin 4][Patch] : Fixed the RM #7368

2022-05-23 Thread Khushboo Vashi
Hi, Please find the attached updated patch to fix the RM #7368 - BigAnimal - Unnecessary APIs are being called. The EDB BigAnimal SVG icon has also been added, which was missing from the provider list. Thanks, Khushboo RM_7368.patch Description: Binary data

[pgAdmin 4][Patch] - RM #7408 - Fixed Column Type issue

2022-05-25 Thread Khushboo Vashi
Hi, Please find the attached patch for the RM #7408 - If the user selects a data type with length/precision, the user can not see a data type and the save button is also enabled in properties. When we have a table with a column having an array type with length/precision, the column type is not se

Re: Feature #7178 - PostgreSQL deployment on Microsoft Azure

2022-06-01 Thread Khushboo Vashi
On Wed, Jun 1, 2022 at 3:28 PM Akshay Joshi wrote: > Hi Khushboo > > Can you please review it? > > Will do it tomorrow. > On Wed, Jun 1, 2022 at 10:11 AM Yogesh Mahajan < > yogesh.maha...@enterprisedb.com> wrote: > >> Hi, >> >> Please find the attached patch which provides functionality to deplo

Re: [Patch] - Housekeeping #7315 - Update pgAdmin4 doc for Traefikv2 containerization

2022-06-05 Thread Khushboo Vashi
Hi Yogesh, Review comments: - Step 2: The below statements should be in a different line, like - "Azure CLI" will use the currently logged in identity through Azure CLI on the local machine. - "Interactive Browser" opens a browser to authenticate a user interactively.

Re: Feature #7178 - PostgreSQL deployment on Microsoft Azure

2022-06-06 Thread Khushboo Vashi
Hi Yogesh, Review comments: - Step 2: The below statements should be in a different line, like - - "Azure CLI" will use the currently logged in identity through Azure CLI on the local machine. - "Interactive Browser" opens a browser to authenticate a user interactive

Re: [pgAdmin][RM7351]: Templates not displayed

2022-06-06 Thread Khushboo Vashi
On Mon, Jun 6, 2022 at 2:17 PM Dave Page wrote: > > > On Fri, 3 Jun 2022 at 08:26, Akshay Joshi > wrote: > >> Hi Pradip >> >> Following are the review comments: >> >>- Fixed pep8 issues. >>- Documentation updates are missing. >>- In the 'alter_online.sql' file correct the comment abo

Re: Encryption of pdAdmin on OpenShift with TLS termination type reencrypt

2022-06-06 Thread Khushboo Vashi
Hello, On Tue, Jun 7, 2022 at 1:58 AM wrote: > Hello everyone, > > > > I am trying to encrypt the connection from client side to the pod of > pgAdmin 4 (container) on OpenShift. I have included a certificate > (server.cert) and a key (server.key), which are extracted from the PFX file > from our

Re: Encryption of pdAdmin on OpenShift with TLS termination type reencrypt

2022-06-06 Thread Khushboo Vashi
On Tue, Jun 7, 2022 at 10:29 AM Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hello, > > On Tue, Jun 7, 2022 at 1:58 AM wrote: > >> Hello everyone, >> >> >> >> I am trying to encrypt the connection from client side to the pod of >&g

[pgAdmin 4][Patch] - Cloud Deployment - Fixed Review Comments

2022-06-08 Thread Khushboo Vashi
Hello, Please find the attached patch to fix the review comments given in the Cloud Deployment demo: - Added High Availability option - Server group renamed to pgAdmin server group - Removed the Private option from Networking otherwise, it would not be possible to connect the server from pgAdmin.

Re: [pgAdmin 4][Patch] - Cloud Deployment - Fixed Review Comments

2022-06-08 Thread Khushboo Vashi
Hi Akshay, Please find the attached updated patch. On Wed, Jun 8, 2022 at 3:56 PM Akshay Joshi wrote: > Hi Khushboo > > Please fix the pep8, linter, and jasmine test cases. > Fixed. Thanks, Khushboo > > On Wed, Jun 8, 2022 at 1:35 PM Khushboo Vashi < > khushboo.va...

Re: Feature #7178 - PostgreSQL deployment on Microsoft Azure

2022-06-13 Thread Khushboo Vashi
ease find the updated patch with documentation. > > > On Mon, Jun 6, 2022 at 1:10 PM Khushboo Vashi < > khushboo.va...@enterprisedb.com> wrote: > >> Hi Yogesh, >> >> Review comments: >> >>- Step 2: The below statements should be in a differ

Re: Feature #7178 - PostgreSQL deployment on Microsoft Azure

2022-06-14 Thread Khushboo Vashi
On Tue, 14 Jun 2022, 13:29 Yogesh Mahajan, wrote: > Hi Khushboo, > > Thanks for reviewing the patch. > > On Tue, Jun 14, 2022 at 11:35 AM Khushboo Vashi < > khushboo.va...@enterprisedb.com> wrote: > >> Hi Yogesh, >> >>- Spelling mistake in bel

[pgAdmin4][Patch]: BigAnimal High Availability Fix

2022-06-14 Thread Khushboo Vashi
Hi, While deploying the instance into the cloud, if the High Availability option is not selected, it will throw a backend error. Please find the attached patch to fix it. Thanks, Khushboo biganimal_high_avail_fix.patch Description: Binary data

Re: Feature #7178 - PostgreSQL deployment on Microsoft Azure

2022-06-14 Thread Khushboo Vashi
eDB > > > On Tue, Jun 14, 2022 at 1:36 PM Khushboo Vashi < > khushboo.va...@enterprisedb.com> wrote: > >> >> >> >> On Tue, 14 Jun 2022, 13:29 Yogesh Mahajan, < >> yogesh.maha...@enterprisedb.com> wrote: >> >>> Hi Khu

Re: Proposal Dashboard design for system of pgadmin

2022-06-27 Thread Khushboo Vashi
On Mon, Jun 27, 2022 at 1:59 PM Dave Page wrote: > Hi > > On Sun, 26 Jun 2022 at 12:40, Kunal Garg wrote: > >> Plan:- >> >> To integrate a detailed view of system activity into the existing pgAdmin >> dashboard following a consistent design that matches the existing UI/UX and >> meets User Accep

<    2   3   4   5   6   7   8   >