Re: [pgadmin4][Patch] Greenplum specific DDL and Dashboard display

2017-08-21 Thread Jing Li
Hi Dave, Since we're hoping to get this change working for GPDB we've currently using this method to detect if it's gpdb and show the appropriate graphs. Right now it displays errors on the dashboard if it's connected to a gpdb server.For this patch specifically, the goal is to improve the experie

Re: [pgAdmin4][PATCH] Highlighting greenplum keywords in sql editor

2017-09-11 Thread Jing Li
Can we get this patch into the 2.0 release? On Mon, Sep 11, 2017 5:38 PM, Teng Zhang tezh...@pivotal.io wrote: Hi Hackers, Attached is a patch that makes SQL editor show syntax highlighting with Greenplum keywords. - Upgrade CodeMirror from 5.28 to 5.29 to include mime type "x-gpsql" - Use

Re: [pgadmin-hackers] Autoformatting

2017-09-14 Thread Jing Li
Hi Murtuza, We had to put the autoformatting feature on hold for a while to focus on some greenplum work. We have a library in progress but we're not currently far enough along with this to submit a patch. Thanks,~Jing On Wed, Sep 13, 2017 1:13 AM, Murtuza Zabuawala murtuza.zabuaw...@enterp