Re: [pgAdmin4][Patch]: To fix issues in Boolean editor

2017-11-22 Thread Dave Page
On Wed, Nov 22, 2017 at 5:46 AM, Ashesh Vashi wrote: > On Wed, Nov 22, 2017 at 11:00 AM, Murtuza Zabuawala enterprisedb.com> wrote: > >> ​Hi Dave, >> >> On Tue, Nov 21, 2017 at 10:53 PM, Dave Page wrote: >> >>> Hi >>> >>> On Tue, Nov

pgAdmin 4 commit: Honour whitespace properly in the data grid. Fixes #2

2017-11-22 Thread Dave Page
Honour whitespace properly in the data grid. Fixes #2880 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=fdb4fa454a121fb43c6643c608e6ec3419880a0c Author: Murtuza Zabuawala Modified Files -- web/pgadmin/tools/sqleditor/static/css/s

Re: [pgAdmin4][Patch]: To display leading whitespace properly in columns - Query tool

2017-11-22 Thread Dave Page
za Zabuawala > EnterpriseDB: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company

Re: [pgAdmin4][Patch]: Switching between Tabs resets table viewport to first row in gird - Query tool

2017-11-22 Thread Dave Page
ab, the data moves up two rows! It's almost like it's calculating the viewport taking into account the row header (e.g. row 250 is visible immediate below the header), but then re-positioning without taking it into account (e.g. row 250 is aligned with the top of the row header, thus making

pgAdmin 4 commit: Fix bundle creation on Windows which was failing due

2017-11-23 Thread Dave Page
Fix bundle creation on Windows which was failing due to \r\n line endings in code mirror. Fixes #2908 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=5f5c590ffd2a0d33ea38d35fd9a66d98468f998c Author: Maxim Zakharov Modified Files

Re: [pgAdmin4][Patch]: Switching between Tabs resets table viewport to first row in gird - Query tool

2017-11-23 Thread Dave Page
Thanks, applied. On Thu, Nov 23, 2017 at 8:03 AM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi Dave, > > PFA updated patch. > > > On Wed, Nov 22, 2017 at 10:26 PM, Dave Page wrote: > >> Hi >> >> On Wed, Nov 22, 2017 at 3

pgAdmin 4 commit: Ensure the scroll location is retains in the query to

2017-11-23 Thread Dave Page
Ensure the scroll location is retains in the query tool data grid if the user changes tab and then returns. Fixes #2875 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=38f111d969d3faee673afad7dd0cd147f86758f7 Author: Murtuza Zabuawala Modifi

pgAdmin 4 commit: Make the "Save Changes" prompts in the query tool opt

2017-11-23 Thread Dave Page
Make the "Save Changes" prompts in the query tool optional. Fixes #2845 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=05a00f4ac80542a63b48ef4e062932c3e9744994 Author: Harshal Dhumal Modified Files -- web/pgadmin/tools/datagrid/_

Re: Fix for RM2845: Make "Save changes" prompt configurable

2017-11-23 Thread Dave Page
b.com > The Enterprise PostgreSQL Company > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company

Re: [pgAdmin4][Patch]: RM-2859: Can't create new user

2017-11-23 Thread Dave Page
hich has been fixed. > If my screen is too small, it now looks like the attached screenshot, which is really quite ugly. -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company

pgAdmin 4 commit: Disable the line ending check entirely in eslint, as

2017-11-23 Thread Dave Page
Disable the line ending check entirely in eslint, as the previous platform-specific fix doesn't work with all versions. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=fd077e25364c2ac52778cf3bd801389308a7b6e6 Modified Files -- web

Re: [pgAdmin4][Patch]: RM-2859: Can't create new user

2017-11-24 Thread Dave Page
On Thu, Nov 23, 2017 at 10:43 AM, Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > > > On Thu, Nov 23, 2017 at 2:58 PM, Dave Page wrote: > >> Hi >> >> On Thu, Nov 23, 2017 at 5:03 AM, Khushboo Vashi < >> khushboo.va...@enterprisedb.c

Re: [pgAdmin4][Patch]: RM-2859: Can't create new user

2017-11-27 Thread Dave Page
On Mon, Nov 27, 2017 at 5:25 AM, Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi Dave, > > On Fri, Nov 24, 2017 at 3:21 PM, Dave Page wrote: > >> >> >> On Thu, Nov 23, 2017 at 10:43 AM, Khushboo Vashi < >> khushboo.va...@enterprisedb.co

Re: [pgAdmin4][Patch]: RM-2859: Can't create new user

2017-11-27 Thread Dave Page
On Mon, Nov 27, 2017 at 9:19 AM, Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > > > On Mon, Nov 27, 2017 at 2:20 PM, Dave Page wrote: > >> >> >> On Mon, Nov 27, 2017 at 5:25 AM, Khushboo Vashi < >> khushboo.va...@enterprisedb.com> wro

Re: [pgAdmin4][Patch]: RM-2859: Can't create new user

2017-11-27 Thread Dave Page
On Mon, Nov 27, 2017 at 10:39 AM, Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > > > On Mon, Nov 27, 2017 at 2:59 PM, Dave Page wrote: > >> >> >> On Mon, Nov 27, 2017 at 9:19 AM, Khushboo Vashi < >> khushboo.va...@enterprisedb.com> wr

pgAdmin 4 commit: Doc screenshot update

2017-11-27 Thread Dave Page
Doc screenshot update Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=b8c23267643f8872931196aef6f794deb205bf9d Author: Chethana Kumar Modified Files -- docs/en_US/images/add_pgadmin_user.png | Bin 38475 -> 60446 bytes

pgAdmin 4 commit: Revert inadvertant change to doc page

2017-11-27 Thread Dave Page
Revert inadvertant change to doc page Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=542f2911a31077cd507a9c221603c41759a249a7 Modified Files -- docs/en_US/pgadmin_login.rst | 2 -- 1 file changed, 2 deletions(-)

Re: [pgAdmin4][Patch]: RM-2859: Can't create new user

2017-11-27 Thread Dave Page
On Mon, Nov 27, 2017 at 11:03 AM, Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > > > On Mon, Nov 27, 2017 at 4:13 PM, Dave Page wrote: > >> >> >> On Mon, Nov 27, 2017 at 10:39 AM, Khushboo Vashi < >> khushboo.va...@enterprisedb.com> wr

pgAdmin 4 commit: Ensure we don't show the full path on the server when

2017-11-27 Thread Dave Page
Ensure we don't show the full path on the server when using virtual filesystem roots in server mode for SSL certs. Fixes #2866 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=d614c88ada2df37a751c9c89a3342ac75308abe4 Author: Murtuza Zabuawala

Re: [pgAdmin4][Patch]: Do not use actual path when displaying dummy SSL certificates files

2017-11-27 Thread Dave Page
erver mode. > RM#2866 > > -- > Regards, > Murtuza Zabuawala > EnterpriseDB: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company

Re: [pgAdmin4][Patch]: RM-2859: Can't create new user

2017-11-27 Thread Dave Page
On Mon, Nov 27, 2017 at 11:26 AM, Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > > > On Mon, Nov 27, 2017 at 4:47 PM, Dave Page wrote: > >> >> >> On Mon, Nov 27, 2017 at 11:03 AM, Khushboo Vashi < >> khushboo.va...@enterprisedb.com> wr

Re: [pgAdmin4][Patch]: RM #2849 - Allow editing of data on tables with OIDs but no primary key

2017-11-27 Thread Dave Page
, can't we do the same for primary key values? That would be consistent with OIDs, and would remove the need to disable rows, leading to a much nicer use experience I think. -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company

pgAdmin 4 commit: Attempt to decode database errors based on lc_message

2017-11-27 Thread Dave Page
Attempt to decode database errors based on lc_messages. Fixes #2806. Fixes #2821 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=fe7cfa35df3b5244ecf493c378bdc1a68d7a4ce1 Author: Murtuza Zabuawala Modified Files -- web/pgadmin/util

Re: [pgAdmin4][Patch]: To decode database errors properly

2017-11-27 Thread Dave Page
has > environment dependent encoding. > RM#2806 > RM#2821 > > -- > Regards, > Murtuza Zabuawala > EnterpriseDB: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company

Re: Fix for RM2811

2017-11-27 Thread Dave Page
this patch also includes minor fix related to status text > colour. > Seems to work nicely, except that the text scrolls out of view almost immediately. Can you fix it to jump to the end of the text when more is appended please? Thanks. -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pg

pgAdmin 4 commit: Use sufficiently long random strings in test objects

2017-11-27 Thread Dave Page
Use sufficiently long random strings in test objects to avoid conflicts. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=80c4a3fb1a6c23b8e81a4144ec8ca5a37da2e835 Author: Navnath Gadakh Modified Files -- .../databases/event_trigger

pgAdmin 4 commit: Display process output as it happens. Fixes #2811

2017-11-27 Thread Dave Page
Display process output as it happens. Fixes #2811 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=7db7da5b0e6476971c752394870e251bcc507f89 Author: Harshal Dhumal Modified Files -- web/pgadmin/misc/bgprocess/processes.py

Re: Fix for RM2811

2017-11-28 Thread Dave Page
On Tue, Nov 28, 2017 at 9:10 AM, Harshal Dhumal < harshal.dhu...@enterprisedb.com> wrote: > Hi Dave, > -- > On Mon, Nov 27, 2017 at 9:20 PM, Harshal Dhumal > wrote: > >> >> >> On Mon, Nov 27, 2017 at 6:32 PM, Dave Page wrote: >> >>> Hi &g

pgAdmin 4 commit: Illustrate how to set the default mail sender name.

2017-11-28 Thread Dave Page
Illustrate how to set the default mail sender name. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=10c8befb7133e9c237fc9aab96419aca1cc3262d Modified Files -- web/config.py | 4 1 file changed, 4 insertions(+)

pgAdmin 4 commit: Cleanup properly after running the Foreign Table test

2017-11-28 Thread Dave Page
Cleanup properly after running the Foreign Table test cases. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=035c134fede1bf5df4dda84fd3a08b084f5b7dc7 Author: Navnath Gadakh Modified Files -- .../foreign_tables/tests/test_foreign_t

Re: [pgAdmin4][Patch]: RM-2859: Can't create new user

2017-11-28 Thread Dave Page
On Tue, Nov 28, 2017 at 7:10 AM, Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > > > On Mon, Nov 27, 2017 at 5:01 PM, Khushboo Vashi < > khushboo.va...@enterprisedb.com> wrote: > >> >> >> On Mon, Nov 27, 2017 at 4:58 PM, Dave Page wrote: &g

Re: [pgAdmin4][Patch]: Allow user to change their password without leaving application

2017-11-28 Thread Dave Page
cordingly. > > -- > Regards, > Murtuza Zabuawala > EnterpriseDB: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company

pgAdmin 4 commit: Allow changing of the users password without leaving

2017-11-28 Thread Dave Page
Allow changing of the users password without leaving the app. Fixes #2891 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=9ae4a03784fa73e886be34d6aca553dbfc8a42a7 Author: Murtuza Zabuawala Modified Files -- docs/en_US/change_user_

pgAdmin 4 commit: Allow form validation messages to be close in case th

2017-11-28 Thread Dave Page
Allow form validation messages to be close in case the eclipse anything on the form. Fixes #2859 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=5bfa450a5fd261b2cd8c74f464d0b4a6acbeadac Author: Khushboo Vashi Modified Files -- we

Re: [pgAdmin4][Patch]: RM-2859: Can't create new user

2017-11-28 Thread Dave Page
able globally > > Thanks, > Khushboo > > On Tue, Nov 28, 2017 at 4:18 PM, Khushboo Vashi < > khushboo.va...@enterprisedb.com> wrote: > >> >> >> On Tue, Nov 28, 2017 at 3:40 PM, Dave Page wrote: >> >>> >>> >>> On Tue, Nov 28, 2

pgAdmin 4 commit: Format JSON/JSONB nicely when displaying it in the gr

2017-11-28 Thread Dave Page
Format JSON/JSONB nicely when displaying it in the grid editor pop-up. Fixes #2748 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=362bd15c8ef3815e0ebc5f699be09c6afc5057f3 Author: Murtuza Zabuawala Modified Files -- web/pgadmin/s

Re: [pgAdmin4][Patch]: Add basic JSON formatting - Query tool

2017-11-28 Thread Dave Page
r testing. > > -- > Regards, > Murtuza Zabuawala > EnterpriseDB: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company

pgAdmin 4 commit: Add missing __init__.py to backports.csv when buildin

2017-11-29 Thread Dave Page
Add missing __init__.py to backports.csv when building the MSVC windows build. Fixes #2918 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=4617a90123b22381682e9fe2942b7471c70b5cb2 Author: Maxim Zakharov Modified Files -- Make.bat

pgAdmin 4 commit: Ensure the auto-complete selection list can display l

2017-11-29 Thread Dave Page
Ensure the auto-complete selection list can display longer names. Fixes #2726 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=f10733e8d42370cb4456f5c2560e3c10da849147 Author: Murtuza Zabuawala Modified Files -- web/pgadmin/tools/s

Re: [pgAdmin4][Patch]: Remove fixed width from sql-hint popup - Query tool

2017-11-29 Thread Dave Page
; Regards, > Murtuza Zabuawala > EnterpriseDB: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company

pgAdmin 4 commit: Add a missing screenshot, and remove personal info fr

2017-11-30 Thread Dave Page
Add a missing screenshot, and remove personal info from another. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=709f646f5e0f6020afe94f844379898e38a991f4 Author: Chethana Kumar Modified Files -- docs/en_US/images/role_membership.p

Re: [pgAdmin4][RM2922] Login desktop user only once in runtime

2017-11-30 Thread Dave Page
ogged in > each request > in runtime. > > -- > *Harshal Dhumal* > *Sr. Software Engineer* > > EnterpriseDB India: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://w

pgAdmin 4 commit: Cleanup the layout of the filter data dialogue. Fixes

2017-11-30 Thread Dave Page
Cleanup the layout of the filter data dialogue. Fixes #2924 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=389cf01af753e6c96a558131779312c0e177340b Author: Murtuza Zabuawala Modified Files -- web/pgadmin/tools/datagrid/static/js/

pgAdmin 4 commit: Fix the width of Role dialogue so tabs don't wrap.

2017-11-30 Thread Dave Page
Fix the width of Role dialogue so tabs don't wrap. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=2995d6e9c5e93901ff47fe193129efb5d4494580 Author: Murtuza Zabuawala Modified Files -- web/pgadmin/browser/server_groups/servers/role

pgAdmin 4 commit: Refuse password changes (and tell the user) if the no

2017-11-30 Thread Dave Page
Refuse password changes (and tell the user) if the notification email cannot be sent. Fixes #2892 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=35a5cf22d5094645b1e2e66e7d2fbe1c40847232 Author: Harshal Dhumal Modified Files -- w

Re: [pgAdmin4][RM2892] Handle password changes properly if error occurs during sending email

2017-11-30 Thread Dave Page
hese > callbacks and > add addition code to handle such exceptions. > > -- > *Harshal Dhumal* > *Sr. Software Engineer* > > EnterpriseDB India: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > -- Dave Page Blog: http://pgsnake.blogspot.com Tw

Re: [pgAdmin4][RM2892] Handle password changes properly if error occurs during sending email

2017-11-30 Thread Dave Page
rs/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/flask/app.py", line 1811, in handle_url_build_error reraise(exc_type, exc_value, tb) File "/Users/dpage/.virtualenvs/pgadmin4/lib/python2.7/site-packages/flask/helpers.py", line 322, in url_for force_external=external

Re: [pgAdmin4][RM2922] Login desktop user only once in runtime

2017-11-30 Thread Dave Page
Engineer* > > EnterpriseDB India: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company

pgAdmin 4 commit: Don't login the user with every request in desktop mo

2017-11-30 Thread Dave Page
Don't login the user with every request in desktop mode. Just do it once. Fixes #2922 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=f3256aef712faee6744c404415ff9afc8c248490 Author: Harshal Dhumal Modified Files -- web/pgadmin/_

Re: Patch for pgAdmin docs (role_dialog.rst, resource_group_dialog.rst)

2017-11-30 Thread Dave Page
log.rst: patch does not apply error: patch failed: docs/en_US/role_dialog.rst:6 error: docs/en_US/role_dialog.rst: patch does not apply -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company

pgAdmin 4 commit: Doc updates for resource groups and roles.

2017-11-30 Thread Dave Page
Doc updates for resource groups and roles. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=54389595da90513a60b08775d30a1e667f6c9633 Author: Susan Douglas Modified Files -- docs/en_US/resource_group_dialog.rst | 15 ---

pgAdmin 4 commit: Fix regression tests for password reset in server mod

2017-11-30 Thread Dave Page
Fix regression tests for password reset in server mode Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=1a4e21e6dd689aa6e5c53f1453f342529850aaa3 Author: Harshal Dhumal Modified Files -- web/pgadmin/browser/__init__.py

Re: [pgAdmin4][RM2892] Handle password changes properly if error occurs during sending email

2017-11-30 Thread Dave Page
com > The Enterprise PostgreSQL Company > > On Thu, Nov 30, 2017 at 5:09 PM, Harshal Dhumal < > harshal.dhu...@enterprisedb.com> wrote: > >> sure Dave, looking in it now. >> >> -- >> *Harshal Dhumal* >> *Sr. Software Engineer* >> >> En

Re: [pgAdmin4][Patch]: RM #2849 - Allow editing of data on tables with OIDs but no primary key

2017-12-01 Thread Dave Page
Hi On Thursday, November 30, 2017, Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi, > > Please find the attached updated patch. > > On Mon, Nov 27, 2017 at 5:15 PM, Dave Page > wrote: > >> Hi >> >> On Thu, Nov 23, 201

Re: [pgAdmin4][Patch]: Remove default 'Altertify JS' header from debugger related error alerts

2017-12-01 Thread Dave Page
ue in other modules. > > -- > Regards, > Murtuza Zabuawala > EnterpriseDB: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company

pgAdmin 4 commit: Add a note to the README on creating the bundle.

2017-12-01 Thread Dave Page
Add a note to the README on creating the bundle. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=7e419d1bfe30fae4dc008c948bd51c0af877e99f Modified Files -- README | 24 1 file changed, 24 insertions(+)

pgAdmin 4 commit: Cleanup some inconsistent error dialog titles. Fixes

2017-12-01 Thread Dave Page
Cleanup some inconsistent error dialog titles. Fixes #2098 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=bac9c77c4e3911fd5860312fa4da53f4eab50102 Author: Murtuza Zabuawala Modified Files -- web/pgadmin/tools/backup/static/js/bac

Re: [pgAdmin4][Patch]: RM #2849 - Allow editing of data on tables with OIDs but no primary key

2017-12-04 Thread Dave Page
Hi On Mon, Dec 4, 2017 at 4:01 PM, Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > > > On Sat, Dec 2, 2017 at 10:42 AM, Dave Page wrote: > >> Hi >> >> On Thursday, November 30, 2017, Khushboo Vashi < >> khushboo.va...@enterprisedb.c

Re: [pgAdmin4][Patch]: To fix the issue in Debugger module

2017-12-04 Thread Dave Page
Thanks, patch applied! On Mon, Dec 4, 2017 at 6:13 PM, Murtuza Zabuawala < murtuza.zabuaw...@enterprisedb.com> wrote: > Hi Dave, > > PFA updated patch. > > On Sat, Dec 2, 2017 at 10:42 AM, Dave Page wrote: > >> Hi >> >> On Thursday, November 30, 2

pgAdmin 4 commit: Fix debugging of self-referencing functions. Fixes #2

2017-12-04 Thread Dave Page
Fix debugging of self-referencing functions. Fixes #2524 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=136ed0d3e297f4dfcc467e1c0143aaeb276f0982 Author: Murtuza Zabuawala Modified Files -- web/pgadmin/tools/debugger/static/js/dir

pgAdmin 4 commit: Prevent the user pressing the select button in the fi

2017-12-04 Thread Dave Page
Prevent the user pressing the select button in the file manager when it is supposed to be disabled. Fixes #2923 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=7fab041623234ca1748df656f19787081dc74417 Author: Murtuza Zabuawala Modified Files

Re: [pgAdmin4][Patch]: To fix the issue in File manager

2017-12-04 Thread Dave Page
gt; > -- > Regards, > Murtuza Zabuawala > EnterpriseDB: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company

pgAdmin 4 commit: Add license field to package.json to stop yarn bleati

2017-12-04 Thread Dave Page
Add license field to package.json to stop yarn bleating. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=67f0c8a39ee5c7de2b8cfe8a79a222855470c0a1 Modified Files -- web/package.json | 1 + 1 file changed, 1 insertion(+)

pgAdmin 4 commit: Push HTTPD logs to container stdout/stderr as appropr

2017-12-04 Thread Dave Page
Push HTTPD logs to container stdout/stderr as appropriate. Fixes #2920 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=3b7656b3d5fee047d76eac93458ef0de45a5578b Modified Files -- pkg/docker/Dockerfile | 6 ++ 1 file changed, 6 in

pgAdmin 4 commit: Update EXPLAIN icons. Fixes #2936

2017-12-05 Thread Dave Page
Update EXPLAIN icons. Fixes #2936 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=c74b348bacc32ae7b5a3f1c75067121f29e2ca84 Author: Chethana Kumar Modified Files -- .../misc/static/explain/img/ex_aggregate.png | Bin 574 -> 0

pgAdmin 4 commit: Misc fixes for the pgAgent module:

2017-12-05 Thread Dave Page
Misc fixes for the pgAgent module: 1) User was allowed to enter start date ahead of end date while scheduling a job. Fixes #2921 2) Datetime picker was not displaying in the grid (sub-node collection control). Fixes #1749 3) Fixed UI issue where validation error was not displaying properly for

Re: [pgAdmin4][Patch]: To fix issues in pgAgent module

2017-12-05 Thread Dave Page
http://www.enterprisedb.com > The Enterprise PostgreSQL Company > > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company

pgAdmin 4 commit: Fix a reference before assignment error in the file d

2017-12-05 Thread Dave Page
Fix a reference before assignment error in the file dialogue. Fixes #2934 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=22c38e4562dc23b2669b3fb9f97e8c0a1309cd31 Author: Murtuza Zabuawala Modified Files -- web/pgadmin/misc/file_m

Re: [pgAdmin4][Patch]: To fix the issue in File manager

2017-12-05 Thread Dave Page
seDB: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company

pgAdmin 4 commit: Correct names for the Japanese translators:

2017-12-07 Thread Dave Page
Correct names for the Japanese translators: Junichi Tado Kosuke Kida Nozomi Anzai Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=4bcec932a3b04c08efdfffc9d277363762723f60 Modified Files -- web/pgadmin/translations/ja/LC_MESSAGES/m

pgAdmin 4 commit: Update query tool docs.

2017-12-11 Thread Dave Page
Update query tool docs. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=61080ce5139ff62b0aa7ba1f71c38a7e8f8d7bb3 Author: Susan Douglas Modified Files -- docs/en_US/developer_tools.rst | 1 + docs/en_US/editgrid.rst

Re: [pgAdmin4][Patch]: Fixed RM #2779 - Lost field size

2017-12-11 Thread Dave Page
. > Also, while changing column type, it does not honour the length and > precision. > Now it loses the collation if you edit the length. :-( -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company

pgAdmin 4 commit: Add support for editing data in tables with OIDs but

2017-12-13 Thread Dave Page
Add support for editing data in tables with OIDs but no primary keys. Fixes #2849. This patch also updates the editor to retrieve all row values on save, thus immediately showing default values and allowing subsequent editing without a refresh. Branch -- master Details --- https://git

Re: [pgAdmin4][Patch]: RM #2849 - Allow editing of data on tables with OIDs but no primary key

2017-12-13 Thread Dave Page
sedb.com> wrote: > >> Hi Dave, >> >> On Tue, Dec 5, 2017 at 9:43 AM, Dave Page wrote: >> >>> Hi >>> >>> On Mon, Dec 4, 2017 at 4:01 PM, Khushboo Vashi < >>> khushboo.va...@enterprisedb.com> wrote: >>> >>>>

Re: [pgAdmin4][RM2782][RM2822] fix array representation in query tool and data grid

2017-12-13 Thread Dave Page
are Engineer* > > EnterpriseDB India: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company

pgAdmin 4 commit: Re-hash the way that we handle rendering of special t

2017-12-13 Thread Dave Page
Re-hash the way that we handle rendering of special types such as arrays. Fixes #2782. Fixes #2822. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=55254a649f8864e246afe9442aef2d882a4479cb Author: Harshal Dhumal Modified Files --

pgAdmin 4 commit: Ensure password changes are successful if authenticat

2017-12-13 Thread Dave Page
Ensure password changes are successful if authenticating using a pgpass file. Fixes #2720 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=4246a3b22f292179ef85833b0cbee85accd32c65 Author: Murtuza Zabuawala Modified Files -- .../br

Re: [pgAdmin4][Patch]: Change password doesn't work if pgpass file is used

2017-12-13 Thread Dave Page
; Also ViewData/Query tool functionality was not working with pgpass file. > RM#2720 > > -- > Regards, > Murtuza Zabuawala > EnterpriseDB: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsna

pgAdmin 4 commit: Fix label inconsistency spotted by Susan.

2017-12-13 Thread Dave Page
Fix label inconsistency spotted by Susan. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=b2e844c0adc9bcc8421d548bd7cbde9c5e7d0491 Modified Files -- web/pgadmin/browser/server_groups/servers/static/js/server.js | 4 ++-- 1 file chan

Re: [INSTALLERS] pgAdmin 4: Add-on support

2017-12-13 Thread Dave Page
changes. > > -- > > Thanks & Regards, > > Ashesh Vashi > EnterpriseDB INDIA: Enterprise PostgreSQL Company > <http://www.enterprisedb.com> > > > *http://www.linkedin.com/in/asheshvashi* > <http://www.linkedin.com/in/asheshvashi> > -- Dave Page Bl

pgAdmin 4 commit: Ensure the datatype cache is updated when a domain is

2017-12-13 Thread Dave Page
Ensure the datatype cache is updated when a domain is added. Fixes #2778 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=c5d1fc81898fad57c9a67b607f85255d5622ba7b Author: Murtuza Zabuawala Modified Files -- .../servers/databases/sc

Re: [pgAdmin4][Patch]: Newly created domain not listed in Data type

2017-12-13 Thread Dave Page
2778 > > Also fixed typo in FTS Configuration. > > -- > Regards, > Murtuza Zabuawala > EnterpriseDB: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company

pgAdmin 4 commit: Prevent attempts to select directories as files in th

2017-12-13 Thread Dave Page
Prevent attempts to select directories as files in the file dialogue. Fixes #2937 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=96a2987ef6de8f1bfed920696f96511001984368 Author: Murtuza Zabuawala Modified Files -- web/pgadmin/mi

Re: [pgAdmin4][Patch]: File manager - Fix logic to enable 'Select' button in List/Table view

2017-12-13 Thread Dave Page
gt; -- > Regards, > Murtuza Zabuawala > EnterpriseDB: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company

pgAdmin 4 commit: Ensure column collation isn't lost when changing fiel

2017-12-13 Thread Dave Page
Ensure column collation isn't lost when changing field size. Fixes #2779 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=107795db1097367b5090e30869046377106c9eef Author: Khushboo Vashi Modified Files -- .../schemas/tables/column/s

Re: [pgAdmin4][Patch]: Fixed RM #2779 - Lost field size

2017-12-13 Thread Dave Page
t 5:45 PM, Khushboo Vashi < >> khushboo.va...@enterprisedb.com> wrote: >> >>> >>> >>> On Mon, Dec 11, 2017 at 5:40 PM, Dave Page wrote: >>> >>>> Hi >>>> >>>> On Wed, Dec 6, 2017 at 5:45 AM, Khushboo Vashi <

pgAdmin 4 commit: Preferences dialogue help update.

2017-12-13 Thread Dave Page
Preferences dialogue help update. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=d02a0de8c9eba597c7289a7a3c03b7dba8df433f Author: Susan Douglas Modified Files -- docs/en_US/images/preferences_browser_display.png | Bin 54470 -> 5

Re: pgAdmin 4 - Update for Preferences dialog

2017-12-13 Thread Dave Page
27;d > appreciate it! > > As always, let me know if there are problems - Thanks! > > -- Susan > > PS - I've attached the .rst and .png files that were updated in this patch > below as well... > > > > > > -- Dave Page VP, Chief Architect, Tools &

pgAdmin 4 commit: Don't un-comment code with alt+. in the query tool. I

2017-12-13 Thread Dave Page
Don't un-comment code with alt+. in the query tool. It's only supposed to respond to ctrl/cmd+. Fixes #2769 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=937984f2dc6e62480312663e7776830700a8527d Author: Murtuza Zabuawala Modified Files ---

Re: [pgAdmin4][Patch]: To fix query tool editor keyboard shortcut

2017-12-13 Thread Dave Page
g > it should only trigger if user presses Ctrl + . > RM#2769 > > Tested on macOS, Linux, Windows with web version. > > -- > Regards, > Murtuza Zabuawala > EnterpriseDB: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > > -- Dave Page Blog: http://p

Re: [pgAdmin4][Patch]: Add basic Tab navigation - Debugger

2017-12-13 Thread Dave Page
rk on Debugger window Panel navigation. > Given our conversation this morning, do we still want to apply this at this time? (for the benefit of the list, Murtuza, Khushboo, Harshal and I were discussing a keyboard navigation strategy for the whole application). -- Dave Page Blog: http://pgsnake.

pgAdmin 4 commit: Don't try to render security URLs in desktop mode. Fi

2017-12-18 Thread Dave Page
Don't try to render security URLs in desktop mode. Fixes #2952. Fixes #2922 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=bceb6aef3cdde642acdf39ddd8abed0634ee1733 Author: Murtuza Zabuawala Modified Files -- web/pgadmin/__init__.

Re: [pgAdmin4][Patch]: Do not render security URL in templates if running in Desktop mode

2017-12-18 Thread Dave Page
t;> Also reverted RM#2922 because it not working as expected and causing >>> runtime to render login screen. >>> >>> >>> Thanks to Neel for helping me in testing the patch with latest runtime >>> code. >>> >>> >>> -- >>> Regards, >>> Murtuza Zabuawala >>> EnterpriseDB: http://www.enterprisedb.com >>> The Enterprise PostgreSQL Company >>> >>> >> > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company

pgAdmin 4 commit: Add tab indexes for debugger controls.

2017-12-18 Thread Dave Page
Add tab indexes for debugger controls. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=36d779df5d70b70f40fe1123eb8457a614edd109 Author: Murtuza Zabuawala Modified Files -- .../tools/debugger/static/js/debugger_ui.js| 37 ++

Re: [pgAdmin4][Patch]: Add basic Tab navigation - Debugger

2017-12-18 Thread Dave Page
k we should hold till our final design gets ready. >> > ​Adding 'tabindex' on button won't hurt in anyway and not become any kind > of hurdle in design.​ > > >> I will keep the RM open until we add Tab navigation :) >>> >>> >>> On Wed, D

Re: Enums printout - possible bug

2017-12-18 Thread Dave Page
7 at 5:24 PM, Harshal Dhumal < >> harshal.dhu...@enterprisedb.com> wrote: >> >>> >>> -- >>> *Harshal Dhumal* >>> *Sr. Software Engineer* >>> >>> EnterpriseDB India: http://www.enterprisedb.com >>> The Enterprise PostgreSQ

pgAdmin 4 commit: Allow files to be opened by double clicking on them.

2017-12-18 Thread Dave Page
Allow files to be opened by double clicking on them. Fixes #2810 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=eae6f05b7c1b8e23b1cdc15225900ad713d91129 Author: Murtuza Zabuawala Modified Files -- web/pgadmin/misc/file_manager/st

Re: [pgAdmin4][Patch]: File manager - Allow user to load the file by double clicking on it

2017-12-18 Thread Dave Page
2810 > > -- > Regards, > Murtuza Zabuawala > EnterpriseDB: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company

Re: [pgAdmin4][Patch]: Allow user to select error text

2017-12-18 Thread Dave Page
za Zabuawala > EnterpriseDB: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > > -- Dave Page Blog: http://pgsnake.blogspot.com Twitter: @pgsnake EnterpriseDB UK: http://www.enterprisedb.com The Enterprise PostgreSQL Company

pgAdmin 4 commit: Allow selection of validation error text. Fixes #2954

2017-12-18 Thread Dave Page
Allow selection of validation error text. Fixes #2954 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=3fe655e9444cfb19d9a05c43bc50474381992fbd Author: Murtuza Zabuawala Modified Files -- web/pgadmin/static/scss/_alert.scss | 5 +++

<    3   4   5   6   7   8   9   10   11   12   >