pgAdmin 4 commit: Fix label inconsistency spotted by Susan.

2018-01-03 Thread Ashesh Vashi
Fix label inconsistency spotted by Susan. Branch -- WEBPACK_DEVEL2 Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=725c6bdcf4d3530fba66c07733391a954acec3c9 Author: Dave Page Modified Files -- web/pgadmin/browser/server_groups/servers/static/js/ser

pgAdmin 4 commit: Allow selection of validation error text. Fixes #2954

2018-01-03 Thread Ashesh Vashi
Allow selection of validation error text. Fixes #2954 Branch -- WEBPACK_DEVEL2 Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=0c125a4d2d17f9b0a3c7f5e762ac30036c1710f3 Author: Murtuza Zabuawala Modified Files -- web/pgadmin/static/scss/_alert.scss

pgAdmin 4 commit: Ensure column collation isn't lost when changing fiel

2018-01-03 Thread Ashesh Vashi
Ensure column collation isn't lost when changing field size. Fixes #2779 Branch -- WEBPACK_DEVEL2 Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=c3de5e224767085d293d6ccc4429f909bac45e48 Author: Khushboo Vashi Modified Files -- .../schemas/tables/

pgAdmin 4 commit: Make the query tool datatype test easily configurable

2018-01-03 Thread Ashesh Vashi
Make the query tool datatype test easily configurable and extendable and add support for multi-dimensional arrays and enums. Branch -- WEBPACK_DEVEL2 Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=52c7945d4847ac835f3f3a04854e6b221767c4cd Author: Harshal Dhuma

pgAdmin 4 commit: Fix duplicate link text

2018-01-03 Thread Ashesh Vashi
Fix duplicate link text Branch -- WEBPACK_DEVEL2 Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=f31695d51bf429f7b3d739b9c961c737ed6fe292 Author: Dave Page Modified Files -- docs/en_US/server_dialog.rst | 4 ++-- 1 file changed, 2 insertions(+), 2

pgAdmin 4 commit: When selecting an SSL cert or key, update only the ex

2018-01-03 Thread Ashesh Vashi
When selecting an SSL cert or key, update only the expected path in the UI, not all of them. Fixes #2760. Fixes #2867 Branch -- WEBPACK_DEVEL2 Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=a53548dd845077a25934363d9dd11a30d363770a Author: Harshal Dhumal Mod

pgAdmin 4 commit: Doc updates for server connection dialogue and relate

2018-01-03 Thread Ashesh Vashi
Doc updates for server connection dialogue and related info. Branch -- WEBPACK_DEVEL2 Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=81d389fb0aaf99977cf5db3262d494319a2b5334 Author: Susan Douglas Modified Files -- docs/en_US/images/server_advance

pgAdmin 4 commit: Clarify how virtual envs can be used in WSGI mode, an

2018-01-03 Thread Ashesh Vashi
Clarify how virtual envs can be used in WSGI mode, and ensure we ship the required bits on Windows. Branch -- WEBPACK_DEVEL2 Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=6f719a74ead76df23e974420a6a574334ba5310e Author: Surinder Kumar Modified Files --

pgAdmin 4 commit: Fixing the on the javascript files - 'web/pgadmin/sta

2018-01-03 Thread Ashesh Vashi
Fixing the on the javascript files - 'web/pgadmin/static/js/*.js' for the errors reported by the eslint. Branch -- WEBPACK_DEVEL2 Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=b45fecf09d0c3988894150ede2bcb48503ef06d5 Modified Files -- web/pgadmin

pgAdmin 4 commit: Allow connections to be coloured in the treeview and

2018-01-03 Thread Ashesh Vashi
Allow connections to be coloured in the treeview and query tool. Fixes #1383. Fixes #2802 Branch -- WEBPACK_DEVEL2 Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=80835e410de6bc5361ac0ed00f38f87137c269a4 Author: Murtuza Zabuawala Modified Files -

pgAdmin 4 commit: Re-hash the way that we handle rendering of special t

2018-01-03 Thread Ashesh Vashi
Re-hash the way that we handle rendering of special types such as arrays. Fixes #2782. Fixes #2822. Branch -- WEBPACK_DEVEL2 Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=444589a58dbb98a58a69a6399cbbf7d38aedb497 Author: Harshal Dhumal Modified Files --

pgAdmin 4 commit: Allow connections to be coloured in the treeview and

2018-01-03 Thread Ashesh Vashi
Allow connections to be coloured in the treeview and query tool. Fixes #1383. Fixes #2802 Branch -- WEBPACK_DEVEL2 Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=da31616a19e40f697c040548bb31c52c38ef842a Author: Murtuza Zabuawala Modified Files -

pgAdmin 4 commit: Misc fixes for the pgAgent module:

2018-01-03 Thread Ashesh Vashi
Misc fixes for the pgAgent module: 1) User was allowed to enter start date ahead of end date while scheduling a job. Fixes #2921 2) Datetime picker was not displaying in the grid (sub-node collection control). Fixes #1749 3) Fixed UI issue where validation error was not displaying properly for

pgAdmin 4 commit: Avoid a potential crash when downloading. Fixes #2964

2018-01-03 Thread Ashesh Vashi
Avoid a potential crash when downloading. Fixes #2964 Branch -- WEBPACK_DEVEL2 Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=b5813fd438eb330fc86b88e426c7de61fe1379ae Author: Neel Patel Modified Files -- runtime/BrowserWindow.cpp | 4 ++-- 1 file

pgAdmin 4 commit: Runtime version update

2018-01-03 Thread Ashesh Vashi
Runtime version update Branch -- WEBPACK_DEVEL2 Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=de0244a63d0053162ba582480fbb3d92ead53b69 Author: Dave Page Modified Files -- runtime/Info.plist | 4 ++-- runtime/pgAdmin4.pro | 2 +- 2 files changed,

pgAdmin 4 commit: Use the correct lexer in the Apache/Windows docs.

2018-01-03 Thread Ashesh Vashi
Use the correct lexer in the Apache/Windows docs. Branch -- WEBPACK_DEVEL2 Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=08d7e44adbe0221758840dce1ec3c9e9e0ecffac Author: Dave Page Modified Files -- docs/en_US/server_deployment.rst | 9 -

pgAdmin 4 commit: Add the ability to build a basic Docker container.

2018-01-03 Thread Ashesh Vashi
Add the ability to build a basic Docker container. Branch -- WEBPACK_DEVEL2 Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=5d1cc245e19740d7fa59ef041810419068932d39 Author: Dave Page Modified Files -- pkg/docker/Dockerfile| 1 - pkg/docker/ent

pgAdmin 4 commit: Allow to terminate a session from the server, and dat

2018-01-03 Thread Ashesh Vashi
Allow to terminate a session from the server, and database dashboard. Branch -- WEBPACK_DEVEL2 Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=fe0945bf3be521eea33e08cfad78dfbfdfb848ad Modified Files -- web/pgadmin/dashboard/static/js/dashboard.js |

pgAdmin 4 commit: Moved the webcabin-docker in the 'web/pgadmin/static/

2018-01-03 Thread Ashesh Vashi
Moved the webcabin-docker in the 'web/pgadmin/static/vendor' directory to resolve a possible issue, when we created webpack reference for vendor. webcabin-docker uses the jquery.1.11.1 as hard dependency, and latest jquery for 1.11.2 is available as npm, and which is used by us. Webpack referenc

pgAdmin 4 commit: Fix a number of cases where strings were not properly

2018-01-03 Thread Ashesh Vashi
Fix a number of cases where strings were not properly marked for translation. Branch -- WEBPACK_DEVEL2 Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=c913f02e5ef312da008cf387cfc342a52aa0af0d Author: Alexander Lakhin Modified Files -- web/pgadmin/

pgAdmin 4 commit: Upgraded the font-mfizz to latest version (v:2.4.1) t

2018-01-03 Thread Ashesh Vashi
Upgraded the font-mfizz to latest version (v:2.4.1) to resolve an issue, about showing the PostgreSQL logo in italic in runtime on windows. Branch -- WEBPACK_DEVEL2 Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=1c89aecff27e0c6739ec54ca6230cc727da40676 Modifi

pgAdmin 4 commit: Extending the tools, and miscellaneous javascript mod

2018-01-03 Thread Ashesh Vashi
Extending the tools, and miscellaneous javascript modules from the browser tools. Branch -- WEBPACK_DEVEL2 Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=9e38bf8493e8b1dbba4144b9307d51a36e4209c1 Modified Files -- web/pgadmin/tools/datagrid/static/

pgAdmin 4 commit: No longer using the 'get_own_javascripts' method for

2018-01-03 Thread Ashesh Vashi
No longer using the 'get_own_javascripts' method for refering the javascript modules exposed through a module, instead added them in the webpack (shim) configuration directly. Instead - exposed a new method - 'get_javascript_entries' to be used later by the new implementation of the webpack config

pgAdmin 4 commit: Enable webpackaging the pgadmin javascript files in d

2018-01-03 Thread Ashesh Vashi
Enable webpackaging the pgadmin javascript files in different small modules, which can be referred from other modules. We can have two types of webpack modules. 1. Reference (using the dll plugin of webpack) This type of webpack module can be referred from the other webpack modules. And, it

pgAdmin 4 commit: Allow selection of SSL certificates and pgpass files

2018-01-03 Thread Ashesh Vashi
Allow selection of SSL certificates and pgpass files in connection properties. Fixes #2649. Fixes #2650 Branch -- WEBPACK_DEVEL2 Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=1d6c1323286521d05ae355be8d14374cd3e17d5a Author: Murtuza Zabuawala Modified Files

pgAdmin 4 commit: Bump version for some dev builds.

2018-01-03 Thread Ashesh Vashi
Bump version for some dev builds. Branch -- WEBPACK_DEVEL2 Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=a23d0a73ade37c74a12610d0333f386133b15c9b Author: Dave Page Modified Files -- web/config.py | 6 +++--- 1 file changed, 3 insertions(+), 3 del

pgAdmin 4 commit: Don't un-comment code with alt+. in the query tool. I

2018-01-03 Thread Ashesh Vashi
Don't un-comment code with alt+. in the query tool. It's only supposed to respond to ctrl/cmd+. Fixes #2769 Branch -- WEBPACK_DEVEL2 Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=6898b0e4c5c2dfd29a5d1ece77cb46312fbb5870 Author: Murtuza Zabuawala Modified F

pgAdmin 4 commit: Update query tool docs.

2018-01-03 Thread Ashesh Vashi
Update query tool docs. Branch -- WEBPACK_DEVEL2 Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=47fc970fae4c867d3897bcedc2661cd8b1803db3 Author: Susan Douglas Modified Files -- docs/en_US/developer_tools.rst | 1 + docs/en_US/editgrid.rs

pgAdmin 4 commit: Ensure the datatype cache is updated when a domain is

2018-01-03 Thread Ashesh Vashi
Ensure the datatype cache is updated when a domain is added. Fixes #2778 Branch -- WEBPACK_DEVEL2 Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=e09cf061ea44d45e895cc9a643cc311b44356154 Author: Murtuza Zabuawala Modified Files -- .../servers/data

pgAdmin 4 commit: Add support for editing data in tables with OIDs but

2018-01-03 Thread Ashesh Vashi
Add support for editing data in tables with OIDs but no primary keys. Fixes #2849. This patch also updates the editor to retrieve all row values on save, thus immediately showing default values and allowing subsequent editing without a refresh. Branch -- WEBPACK_DEVEL2 Details --- htt

pgAdmin 4 commit: Improve icon alignment.

2018-01-03 Thread Ashesh Vashi
Improve icon alignment. Branch -- WEBPACK_DEVEL2 Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=ed94285f9668379a5602df563877a697a38140c0 Author: Chethana Kumar Modified Files -- .../browser/server_groups/servers/databases/casts/static/img/cast.sv

pgAdmin 4 commit: Resolved the logo issue.

2018-01-03 Thread Ashesh Vashi
Resolved the logo issue. For some unknown reason, font-mfizz was showing the slonik icon in italic. Even after upgrading it to the latest version of font-mfizz, the problem was not resolved. So - instead of using the vector font, using the PostgreSQL SVG logo as the application icon, and document

pgAdmin 4 commit: Changed array representation and formatting for the d

2018-01-03 Thread Ashesh Vashi
Changed array representation and formatting for the data types in Query Tool and View Data. Fixes #2671 Branch -- WEBPACK_DEVEL2 Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=2b742bdc5173f6167fd64151078de09ea70a07e9 Author: Harshal Dhumal Modified Files --

pgAdmin 4 commit: Remove any Apache HTTPD PID file before starting the

2018-01-03 Thread Ashesh Vashi
Remove any Apache HTTPD PID file before starting the container, to prevent failures during restart. (cherry picked from commit 3289a18a1a6bb99360894bffa5c192c37cda485d) Conflicts: pkg/docker/entry.sh Branch -- WEBPACK_DEVEL2 Details --- https://git.postgresql.org/gitweb?p=pgadm

Re: [INSTALLERS] pgAdmin 4: Add-on support

2018-01-03 Thread Ashesh Vashi
find the spare time. > > On Thu, Dec 7, 2017 at 4:05 PM, Ashesh Vashi < > ashesh.va...@enterprisedb.com> wrote: > >> Hi Dave, >> >> I've merged the master branch in the 'WEBPACK_DEVEL2' branch. >> >> In this branch, I've modified t

pgAdmin 4 commit: Preferences dialogue help update.

2018-01-03 Thread Ashesh Vashi
Preferences dialogue help update. Branch -- WEBPACK_DEVEL2 Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=8c73be9186c78f75f24801e30dcac09b89bb3e3f Author: Susan Douglas Modified Files -- docs/en_US/preferences.rst | 8 1 file changed, 8 d

pgAdmin 4 commit: Revert inadvertant change to doc page

2018-01-03 Thread Ashesh Vashi
Revert inadvertant change to doc page Branch -- WEBPACK_DEVEL2 Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=068f84804fc2c33b2d5c8742de147e7fa83e468f Author: Dave Page Modified Files -- docs/en_US/pgadmin_login.rst | 2 -- 1 file changed, 2 delet

pgAdmin 4 commit: Fix bundle creation on Windows which was failing due

2018-01-03 Thread Ashesh Vashi
Fix bundle creation on Windows which was failing due to \r\n line endings in code mirror. Fixes #2908 Branch -- WEBPACK_DEVEL2 Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=5f60c77d151e7041e53a7e050a10c99394fac0df Author: Maxim Zakharov Modified Files

pgAdmin 4 commit: Doc updates for server connection dialogue and relate

2018-01-03 Thread Ashesh Vashi
Doc updates for server connection dialogue and related info. Branch -- WEBPACK_DEVEL2 Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=0494a91178563c93ef86ca39af36f6c5f1dddc05 Author: Susan Douglas Modified Files -- docs/en_US/server_dialog.rst | 2

pgAdmin 4 commit: Add optional TLS support to the docker container.

2018-01-03 Thread Ashesh Vashi
Add optional TLS support to the docker container. Branch -- WEBPACK_DEVEL2 Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=272b8ee948c4955392245afc9cf7f98274a267f8 Author: Dave Page Modified Files -- pkg/docker/pgadmin4.conf | 22 -

pgAdmin 4 commit: Revert "Fix a number of cases where strings were not

2018-01-03 Thread Ashesh Vashi
Revert "Fix a number of cases where strings were not properly marked for translation." This reverts commit 1f23838a4c2c4919499bb07f41efab7202843016 due to unintended side effects it caused - specifically, expanding Databases on the treeview displayed Servers again Branch -- WEBPACK_DEVEL2

pgAdmin 4 commit: Updated colours of tree view icons, which is to be mo

2018-01-03 Thread Ashesh Vashi
Updated colours of tree view icons, which is to be more comfortable in identifying. Branch -- WEBPACK_DEVEL2 Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=849ad18d733ce5c59dcbb3ede77803c188f32856 Author: Chethana Kumar Modified Files -- .../bro

pgAdmin 4 commit: Check and attempt to fir the registry on Windows, if

2018-01-03 Thread Ashesh Vashi
Check and attempt to fir the registry on Windows, if the text/css type is misconfigured. Fixes #2716 Branch -- WEBPACK_DEVEL2 Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=920b648485327c595f9d6775c9a8015f1061b16a Author: Neel Patel Modified Files -

pgAdmin 4 commit: Ensure we can download large files and keep the user

2018-01-03 Thread Ashesh Vashi
Ensure we can download large files and keep the user informed about progress. Fixes #2829. Fixes #2491. Fixes #2715 Branch -- WEBPACK_DEVEL2 Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=162dda0f1f997f75540733dda49f1720349060bc Author: Neel Patel Modified

pgAdmin 4 commit: Disable the line ending check entirely in eslint, as

2018-01-03 Thread Ashesh Vashi
Disable the line ending check entirely in eslint, as the previous platform-specific fix doesn't work with all versions. Branch -- WEBPACK_DEVEL2 Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=c3570c22de5ff3017c1298f66dd083d5393b5034 Author: Dave Page Modifi

pgAdmin 4 commit: When selecting an SSL cert or key, update only the ex

2018-01-03 Thread Ashesh Vashi
When selecting an SSL cert or key, update only the expected path in the UI, not all of them. Fixes #2760. Fixes #2867 Branch -- WEBPACK_DEVEL2 Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=527b502633465f4c853434c0625833f96fcf44da Author: Harshal Dhumal Mod

pgAdmin 4 commit: Some browsers don't properly support tri-state checkb

2018-01-03 Thread Ashesh Vashi
Some browsers don't properly support tri-state checkboxes, so create our own control to handle true/false/null. Fixes #2848 Branch -- WEBPACK_DEVEL2 Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=e8694cd0c1a81f214d92df42cdc80598e6ecfc1a Author: Murtuza Zabuaw

pgAdmin 4 commit: Confirm with the user before exiting the runtime. Fix

2018-01-03 Thread Ashesh Vashi
Confirm with the user before exiting the runtime. Fixes #2443 Branch -- WEBPACK_DEVEL2 Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=66805b1e6680b4d263700d47ddb258fcf95eed45 Author: Neel Patel Modified Files -- runtime/BrowserWindow.cpp | 2 +- 1

pgAdmin 4 commit: Tag some translations that were not, well, tagged. Cu

2018-01-03 Thread Ashesh Vashi
Tag some translations that were not, well, tagged. Current stats: 1481 of 1777 messages (83%) translated in pgadmin/translations/de/LC_MESSAGES/messages.po 1694 of 1777 messages (95%) translated in pgadmin/translations/ja/LC_MESSAGES/messages.po 1472 of 1777 messages (82%) translated in pgadmin

pgAdmin 4 commit: Fix a referenced before assignment bug in connection

2018-01-03 Thread Ashesh Vashi
Fix a referenced before assignment bug in connection management. Fixes #2868 Branch -- WEBPACK_DEVEL2 Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=aa148078e6300839223ee41e1d37bd4423413d72 Author: Harshal Dhumal Modified Files -- web/pgadmin/bro

pgAdmin 4 commit: Allow configuration of CSV and clipboard formatting o

2018-01-03 Thread Ashesh Vashi
Allow configuration of CSV and clipboard formatting of query results. Fixes #2781 Branch -- WEBPACK_DEVEL2 Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=c7c3d52aa82ef8eb70019befb6dee8dc00ea73d8 Author: Khushboo Vashi Modified Files -- docs/en_U

pgAdmin 4 commit: Doc screenshot update

2018-01-03 Thread Ashesh Vashi
Doc screenshot update Branch -- WEBPACK_DEVEL2 Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=46e3f664e9d3eb0d96a6cdab3ddd07026b509718 Author: Chethana Kumar Modified Files -- docs/en_US/images/server_advanced.png | Bin docs/en_US/images/server

pgAdmin 4 commit: Stop Python 2.6 barfing on newer versions of Selenium

2018-01-03 Thread Ashesh Vashi
Stop Python 2.6 barfing on newer versions of Selenium Branch -- WEBPACK_DEVEL2 Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=c3a4b627a3e535337ed8a021db02454f4c56a779 Author: Murtuza Zabuawala Modified Files -- web/regression/requirements.txt | 1

pgAdmin 4 commit: Re-hash the way that we handle rendering of special t

2018-01-03 Thread Ashesh Vashi
Re-hash the way that we handle rendering of special types such as arrays. Fixes #2782. Fixes #2822. Branch -- WEBPACK_DEVEL2 Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=56ff374f643e2ff9e7eacf394b4d7af685af3b33 Author: Harshal Dhumal Modified Files --

pgAdmin 4 commit: Fixed regression (typos) introduced during the 'pgadm

2018-01-04 Thread Ashesh Vashi
Fixed regression (typos) introduced during the 'pgadmin4/master' merge. Branch -- WEBPACK_DEVEL2 Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=ae601581a9ae58b69ea7c7f4b664d248b1d7ec27 Modified Files -- web/pgadmin/static/js/backform.pgadmin.js

Re: [pgAdmin4][Patch]: Adding connection status in Query tool

2018-01-08 Thread Ashesh Vashi
On Mon, Jan 8, 2018 at 7:21 PM, Dave Page wrote: > > > On Mon, Jan 8, 2018 at 1:24 PM, Murtuza Zabuawala enterprisedb.com> wrote: > >> Hi Dave, >> >> PFA updated patch. >> >> On Mon, Jan 8, 2018 at 5:11 PM, Dave Page wrote: >> >>> Hi >>> >>> On Fri, Jan 5, 2018 at 8:49 AM, Murtuza Zabuawala < >

Re: ESLINT: On pgAdmin static javascripts

2018-01-08 Thread Ashesh Vashi
st option is to check the regression tests all pass, do some > manual testing yourself, and then commit. > Done some manual testing. It would be helpful, If somebody can help with some more testing, which I may have missed. -- Thanks, Ashesh > > On Mon, Jan 8, 2018 at 1:

Re: ESLINT: On pgAdmin static javascripts

2018-01-08 Thread Ashesh Vashi
On Mon, Jan 8, 2018 at 8:52 PM, Dave Page wrote: > Hi > > On Mon, Jan 8, 2018 at 3:18 PM, Ashesh Vashi < > ashesh.va...@enterprisedb.com> wrote: > >> On Mon, Jan 8, 2018 at 8:31 PM, Dave Page wrote: >> >>> Hi >>> >>> I think the

Re: ESLINT: On pgAdmin static javascripts

2018-01-08 Thread Ashesh Vashi
t; 55 > > -- > Regards, > Murtuza Zabuawala > EnterpriseDB: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > > > On Mon, Jan 8, 2018 at 9:11 PM, Ashesh Vashi < > ashesh.va...@enterprisedb.com> wrote: > >> >> On Mon, Jan 8

Re: ESLINT: On pgAdmin static javascripts

2018-01-10 Thread Ashesh Vashi
in a separate patch. -- Thanks, Ashesh > > -- > ​ Murtuza​ > > On Tue, Jan 9, 2018 at 1:19 PM, Ashesh Vashi < > ashesh.va...@enterprisedb.com> wrote: > >> >> >> On Tue, Jan 9, 2018 at 12:28 AM, Ashesh Vashi < >> ashesh.va...@enterprise

pgAdmin 4 commit: Clear the messages tab when running EXPLAIN/EXPLAIN A

2018-01-10 Thread Ashesh Vashi
Clear the messages tab when running EXPLAIN/EXPLAIN ANALYZE. Fixes #2974 Branch -- WEBPACK_DEVEL2 Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=47db3a2d71a0db8c4c3286a6fbafba828cc0e2ef Author: Murtuza Zabuawala Modified Files -- web/pgadmin/stat

pgAdmin 4 commit: Use the correct lexer in the Apache/Windows docs.

2018-01-10 Thread Ashesh Vashi
Use the correct lexer in the Apache/Windows docs. Branch -- WEBPACK_DEVEL2 Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=c53212b886de348ead2c04392bd1ed2c15649899 Author: Dave Page Modified Files -- docs/en_US/server_deployment.rst | 9 -

pgAdmin 4 commit: Add the ability to build a basic Docker container.

2018-01-10 Thread Ashesh Vashi
Add the ability to build a basic Docker container. Branch -- WEBPACK_DEVEL2 Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=8a8a35533d7f4836f5636e4a0aff40f8acd2708a Author: Dave Page Modified Files -- pkg/docker/pgadmin4.conf | 22

pgAdmin 4 commit: Ensure invalid options can't be selected on triggers

2018-01-10 Thread Ashesh Vashi
Ensure invalid options can't be selected on triggers on views. Fixes #2945 Branch -- WEBPACK_DEVEL2 Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=06634715c879f04eedd51a7a8ef706e007a964ce Author: Khushboo Vashi Modified Files -- .../tables/templa

pgAdmin 4 commit: Only allow specification of a pgpass file if libpq >=

2018-01-10 Thread Ashesh Vashi
Only allow specification of a pgpass file if libpq >= 10. Fixes #2768 Branch -- WEBPACK_DEVEL2 Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=a6fb536cb6429cc89234e7236e1ea9961f9dc1c7 Author: Murtuza Zabuawala Modified Files -- web/pgadmin/browser

pgAdmin 4 commit: Correct alignment of the X button on dismissable aler

2018-01-10 Thread Ashesh Vashi
Correct alignment of the X button on dismissable alerts. Branch -- WEBPACK_DEVEL2 Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=8e18711ac224410c9d4e765c02f385440d6231d8 Author: Murtuza Zabuawala Modified Files -- web/pgadmin/static/css/bootstrap

pgAdmin 4 commit: Do not decrypt the password when the password is 'Non

2018-01-10 Thread Ashesh Vashi
Do not decrypt the password when the password is 'None'. Fixes #2765 This should avoid the common but harmless exception "ValueError: IV must be 16 bytes long while decrypting the password." Branch -- WEBPACK_DEVEL2 Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdi

pgAdmin 4 commit: Enable webpackaging the pgadmin javascript files in d

2018-01-10 Thread Ashesh Vashi
Enable webpackaging the pgadmin javascript files in different small modules, which can be referred from other modules. We can have two types of webpack modules. 1. Reference (using the dll plugin of webpack) This type of webpack module can be referred from the other webpack modules. And, it

pgAdmin 4 commit: When selecting an SSL cert or key, update only the ex

2018-01-10 Thread Ashesh Vashi
When selecting an SSL cert or key, update only the expected path in the UI, not all of them. Fixes #2760. Fixes #2867 Branch -- WEBPACK_DEVEL2 Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=a9ac6f77ff17ea78ab9fe766cae82dc5038e2fa9 Author: Harshal Dhumal Mod

pgAdmin 4 commit: Show complete SQL for FTS dictionaries. Fixes #2949

2018-01-10 Thread Ashesh Vashi
Show complete SQL for FTS dictionaries. Fixes #2949 Branch -- WEBPACK_DEVEL2 Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=8dcf6dc1363d13fab1a0a00b289ffb1f83ecaf86 Author: Khushboo Vashi Modified Files -- .../servers/databases/schemas/fts_dictio

pgAdmin 4 commit: Allow use of transition tables in PG 10 triggers. Fix

2018-01-10 Thread Ashesh Vashi
Allow use of transition tables in PG 10 triggers. Fixes #2933 Branch -- WEBPACK_DEVEL2 Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=1eb18b6529f06bd78497e782b820ba0a216ddb8f Author: Khushboo Vashi Modified Files -- .../templates/trigger/sql/10_p

pgAdmin 4 commit: Fixing the on the javascript files - 'web/pgadmin/sta

2018-01-10 Thread Ashesh Vashi
Fixing the on the javascript files - 'web/pgadmin/static/js/*.js' for the errors reported by the eslint. Branch -- WEBPACK_DEVEL2 Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=204a7113dee5a802cc5c951b144b602b6a6c3055 Modified Files -- web/pgadmin

pgAdmin 4 commit: Fix user manager role handling. Fixes #2641

2018-01-10 Thread Ashesh Vashi
Fix user manager role handling. Fixes #2641 Branch -- WEBPACK_DEVEL2 Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=1dcf12675055b2e2f39cfd6a0c0881a91bdaf7e3 Author: Harshal Dhumal Modified Files -- web/pgadmin/tools/user_management/static/js/user

pgAdmin 4 commit: Upgraded the font-mfizz to latest version (v:2.4.1) t

2018-01-10 Thread Ashesh Vashi
Upgraded the font-mfizz to latest version (v:2.4.1) to resolve an issue, about showing the PostgreSQL logo in italic in runtime on windows. Branch -- WEBPACK_DEVEL2 Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=66383c13fa850866a051366a9f99a3f1e79cb036 Modifi

pgAdmin 4 commit: Allow selection of SSL certificates and pgpass files

2018-01-10 Thread Ashesh Vashi
Allow selection of SSL certificates and pgpass files in connection properties. Fixes #2649. Fixes #2650 Branch -- WEBPACK_DEVEL2 Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=a20715047abb21f2c31ad299bea4727685bd36cb Author: Murtuza Zabuawala Modified Files

pgAdmin 4 commit: Close user language preference drop down when it lose

2018-01-10 Thread Ashesh Vashi
Close user language preference drop down when it loses focus. Fixes #2956 Branch -- WEBPACK_DEVEL2 Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=f11e5260f412968263bb69807bcc509ec0c00d87 Author: Khushboo Vashi Modified Files -- web/pgadmin/prefer

pgAdmin 4 commit: Allow connections to be coloured in the treeview and

2018-01-10 Thread Ashesh Vashi
Allow connections to be coloured in the treeview and query tool. Fixes #1383. Fixes #2802 Branch -- WEBPACK_DEVEL2 Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=2458f3c4517b9b102411044a85f4903f2ebea849 Author: Murtuza Zabuawala Modified Files -

pgAdmin 4 commit: Prevent multiple connections to new slow-to-respond s

2018-01-10 Thread Ashesh Vashi
Prevent multiple connections to new slow-to-respond servers being initiated in error. Fixes #2928 Branch -- WEBPACK_DEVEL2 Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=149e651fc6cc90e69307d1689c7a3263a04671d7 Author: Murtuza Zabuawala Modified Files -

pgAdmin 4 commit: Ensure the switch animation is consistent on the tabl

2018-01-10 Thread Ashesh Vashi
Ensure the switch animation is consistent on the table dialogue and avoid displaying an error incorrectly. Fixes #2624 Branch -- WEBPACK_DEVEL2 Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=cf17bbeaa591772360fe03bad64f7853528c36a2 Author: Murtuza Zabuawala

pgAdmin 4 commit: Update copyright notices for 2018.

2018-01-10 Thread Ashesh Vashi
Update copyright notices for 2018. Branch -- WEBPACK_DEVEL2 Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=28fac6755bf45ae6868e1825373035c8069e395c Author: Dave Page Modified Files -- LICENSE| 38 +

pgAdmin 4 commit: When selecting an SSL cert or key, update only the ex

2018-01-10 Thread Ashesh Vashi
When selecting an SSL cert or key, update only the expected path in the UI, not all of them. Fixes #2760. Fixes #2867 Branch -- WEBPACK_DEVEL2 Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=517cf177ceee1762d7573a9ba1d59e2fbe1796be Author: Harshal Dhumal Mod

pgAdmin 4 commit: Resolved the logo issue.

2018-01-10 Thread Ashesh Vashi
Resolved the logo issue. For some unknown reason, font-mfizz was showing the slonik icon in italic. Even after upgrading it to the latest version of font-mfizz, the problem was not resolved. So - instead of using the vector font, using the PostgreSQL SVG logo as the application icon, and document

pgAdmin 4 commit: Add ALT tags to images for accessibility. Fixes #2902

2018-01-10 Thread Ashesh Vashi
Add ALT tags to images for accessibility. Fixes #2902 Branch -- WEBPACK_DEVEL2 Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=4b832a2fa3a0706fb7f84b2214bcb476baf02387 Author: Murtuza Zabuawala Modified Files -- web/pgadmin/about/templates/about/i

pgAdmin 4 commit: Clarify how virtual envs can be used in WSGI mode, an

2018-01-10 Thread Ashesh Vashi
Clarify how virtual envs can be used in WSGI mode, and ensure we ship the required bits on Windows. Branch -- WEBPACK_DEVEL2 Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=d71d258caa0de84b4cb15c8d651af7736044e95f Author: Surinder Kumar Modified Files --

pgAdmin 4 commit: Improve icon alignment.

2018-01-10 Thread Ashesh Vashi
Improve icon alignment. Branch -- WEBPACK_DEVEL2 Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=f1012bcff5232d53124066736501c0f1294045fb Author: Chethana Kumar Modified Files -- .../browser/server_groups/servers/databases/casts/static/img/cast.sv

pgAdmin 4 commit: No longer using the 'get_own_javascripts' method for

2018-01-10 Thread Ashesh Vashi
No longer using the 'get_own_javascripts' method for refering the javascript modules exposed through a module, instead added them in the webpack (shim) configuration directly. Instead - exposed a new method - 'get_javascript_entries' to be used later by the new implementation of the webpack config

pgAdmin 4 commit: Fixed the warnings/errors reported by eslint for all

2018-01-11 Thread Ashesh Vashi
Fixed the warnings/errors reported by eslint for all the static javascripts. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=c32eb6bd37157fd5abc4d6a4ceeb6c7c954ba377 Modified Files -- web/pgadmin/about/static/js/about.js

Re: ESLINT: On pgAdmin static javascripts

2018-01-11 Thread Ashesh Vashi
On Thu, Jan 11, 2018 at 11:16 AM, Ashesh Vashi < ashesh.va...@enterprisedb.com> wrote: > Hi Murtuza, > > On Tue, Jan 9, 2018 at 4:08 PM, Murtuza Zabuawala enterprisedb.com> wrote: > >> All patches looks good to me except one issue as shown in screenshot >&g

Re: ESLINT: On pgAdmin static javascripts

2018-01-15 Thread Ashesh Vashi
On Tue, Jan 16, 2018 at 11:10 AM, Fahar Abbas wrote: > Hi Ashesh, > > I have finished smoke verification for all the modules and no issue found > so far and currently doing testing in detail. > Thanks Fahar for the update! -- Thanks & Regards, Ashesh Vashi > > Kind R

pgAdmin 4 commit: Introducing custom linter script for javascript files

2018-01-16 Thread Ashesh Vashi
Introducing custom linter script for javascript files. Also, changed the 'linter' yarn-command to use this script. This script will run the 'eslint' against all the static javascripts, found under pgadmin and regression directories of source (excepts 'vendor', 'generated'). It also allows to run t

pgAdmin 4 commit: Fixing the javascript file after running pga_eslint.j

2018-01-16 Thread Ashesh Vashi
Fixing the javascript file after running pga_eslint.js script Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=404f1cc8efa038579b1dab4c8f25b16e86cca541 Modified Files -- web/pgadmin/static/bundle/app.js | 30 --

Re: [pgadmin4] Explain plans

2018-01-20 Thread Ashesh Vashi
ntation the constraint we have is that snapsvg <http://snapsvg.io/> library which we use to draw the explain plan do not support any other format except JSON. snapsvg has nothing to do with JSON plan. ​ snapsvg has nothing to do with JSON. We choose JSON based plan to avoid unnecessary p

Re: Build failed in Jenkins: pgadmin4-master-python34 #440

2018-01-22 Thread Ashesh Vashi
Dave, We need to make habit of running the following command before committing any javascript files. > *yarn run linter* -- Thanks, Ashesh On Mon, Jan 22, 2018 at 4:25 PM, Dave Page wrote: > Hi Surinder, > > It seems that updating ESLint exposed various issues. Can you take a > look ASAP ple

Re: Build failed in Jenkins: pgadmin4-master-python34 #440

2018-01-22 Thread Ashesh Vashi
On Mon, Jan 22, 2018 at 4:29 PM, Ashesh Vashi wrote: > Dave, > > We need to make habit of running the following command before committing > any javascript files. > >> *yarn run linter* > > Surinder, Please run the following command to fix most of the indentation issue

Re: Build failed in Jenkins: pgadmin4-master-python34 #440

2018-01-22 Thread Ashesh Vashi
On Mon, Jan 22, 2018 at 4:32 PM, Dave Page wrote: > On Mon, Jan 22, 2018 at 10:59 AM, Ashesh Vashi > wrote: > > Dave, > > > > We need to make habit of running the following command before committing > any > > javascript files. > >> > >> yarn r

Re: Revamped runtime vs. Version number

2018-02-01 Thread Ashesh Vashi
On Feb 1, 2018 8:15 PM, "Dave Page" wrote: So there's been nothing but positive feedback about the PoC revamped runtime I asked folks on the lists to test. Thank you to everyone that did so. With that in mind, I think we should use that in the next version and moving forwards, and bump the versi

Re: pgAdmin 4 commit: Don't quote variable values used by SET. It's usually

2018-02-04 Thread Ashesh Vashi
On Mon, Feb 5, 2018 at 1:35 AM, Dave Page wrote: > Hi > > On 4 Feb 2018, at 18:07, Ashesh Vashi > wrote: > > Hi Dave, > > There is a possibility of SQL Injection (if we don't use qtLiteral. > We need some kind of check for this. > > What do you say? &g

Re: [pgadmin4] Hide tabs in create table

2018-02-07 Thread Ashesh Vashi
On Thu, Feb 8, 2018 at 4:01 AM, Joao De Almeida Pereira < jdealmeidapere...@pivotal.io> wrote: > Hi hackers, > We are trying to hide the advanced tab in the Create Table screen, and we > were looking into table.js file, but cannot find a way to hide it . > > Does anyone have an idea on how to do t

Re: [pgAdmin4][RM#3140] Add service parameter

2018-03-12 Thread Ashesh Vashi
that. -- Thanks & Regards, Ashesh Vashi EnterpriseDB INDIA: Enterprise PostgreSQL Company <http://www.enterprisedb.com> *http://www.linkedin.com/in/asheshvashi* <http://www.linkedin.com/in/asheshvashi> On Tue, Mar 13, 2018 at 6:18 AM, Dave Page wrote: > Hi > > On Mon, Ma

Re: [pgAdmin4][RM#3140] Add service parameter

2018-03-12 Thread Ashesh Vashi
gt; EnterpriseDB: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > > > On Tue, Mar 13, 2018 at 9:01 AM, Ashesh Vashi < > ashesh.va...@enterprisedb.com> wrote: > >> Murtuza/Dave, >> >> I have to reviewed/seen the patch yet. >> But

<    1   2   3   4   5   6   >