Hey Akshay
This patch passed our test pipelines.
Anthony and Victoria
On Thu, Apr 19, 2018 at 1:48 AM, Akshay Joshi wrote:
> Hi Hackers
>
> I have implemented the SSH Tunnel support using https://pypi.org/
> project/sshtunnel/ python package. Added "SSH Tunnel" Tab in server
> dialog. This imp
> On Mon, Apr 23, 2018 at 1:30 PM, Dave Page wrote:
>
>> Hi
>>
>> On Thu, Apr 19, 2018 at 6:56 PM, Anthony Emengo
>> wrote:
>>
>>> Hey Akshay
>>>
>>> This patch passed our test pipelines.
>>>
>>
>> Did you test the
Just manually verified that this worked, and the patch successfully went
through our pipelines.
Thanks so much for fixing this issue!
- Joao and Anthony
On Mon, Apr 23, 2018 at 3:40 AM, Ashesh Vashi wrote:
> Hi Team,
>
> Please find the patch for fixing the RM #3290.
> The 'Close button' was m
We also tried running the tests with this patch. It didn't launch without
some code changes and several tests were failing. We should really defer
pulling this in until we have more robust results on Firefox
In order to have the tests running we had to do the following change:
diff --git a/web/re
Hi there,
Yes, there's a lot of TODO that we intend for this effort - to be
submitted. We'd like to remove as much *direct* invocations on the ACI Tree
library, as it causes a lot of coupling to the library. It is not the final
patch, but we cannot come up with a definitive list of the things we i
>
> I was expecting a separate layer between the tree implementation, and
> aciTree adaptor.
> Please find the patch for the example.
> It will separate the two layers, and easy to replace with the new
> implementation in future.
In general, we want defer the separation of the layers for now. Eve
Hi Hackers,
Please find the attached patch to fix the RM #3324 : user cannot load
“External Tables” on the navigation pane.
The issue was that ultimately paths were not being cleaned after being
munged from the “template” input which would result in template_paths that
resembled: path//to//dir.sq
Forgive me but please consider the following patch instead - as it better
adheres to the python style guide.
On Wed, May 2, 2018 at 12:43 PM Anthony Emengo wrote:
> Hi Hackers,
>
> Please find the attached patch to fix the RM #3324 : user cannot load
> “External Tables” on the nav
Hey Akshay,
Regarding your previous comment:
As I know time.sleep is not a good idea and I am new to feature test and in
> learning phase, can someone correct/suggest the way to fix those issues.
Although the feature tests already have some sleeps, it’s generally not a
best practice for browser
Hey hackers,
Attached is a patch that accommodates the recent `os.path` implementation
changes for Windows. The tests were previously working on Unix but not yet
Windows
Joao && Anthony
0001-Fix-Windows-Tests.patch
Description: Binary data
Hi Hackers,
Attached you can find a patch that changes the way we are running ESLint on
the Javascript files. Instead of using Javascript we can use ESLint
parameters to archive the same goal.
In the future this will also allow us to use the rest of the cli parameters
like (--fix and others...)
Apologies, here's a redo that should apply cleanly on top of master
Anthony && Joao
On Mon, May 14, 2018 at 3:25 PM Anthony Emengo wrote:
> Hi Hackers,
>
> Attached you can find a patch that changes the way we are running ESLint
> on the Javascript files. Instead of us
Understood. Thanks for bringing this to our attention.
On Wed, May 16, 2018 at 6:52 AM Dave Page wrote:
> All,
>
> Please don't send images to show code changes. It's unnecessary when you
> could just send a diff file, and just increases the amount of bandwidth and
> storage used in peoples mail
Hey,
The code looks great! The tests all passed as well.
Sincerely
Anthony and Victoria
Hey all,
We've noticed that our feature tests make extensive use of xpath with the
selenium api. It's well documented that css selectors are easier to read
and more efficient. I think we should start to favor these if we have not
considered so already.
http://bugsareinthegaps.com/what-is-the-best
export function canCreate(pgBrowser, childOfCatalogType) {
return canCreateObject.bind({
browser: pgBrowser,
childOfCatalogType: childOfCatalogType,
});
}
With respect to the above code: this bind pattern looks good and seems like
the idiomatic way to handle this in JavaScript. On a li
Hey all, we'd definitely like some feedback on this patch. Does does it not
apply cleanly? Do we need to resend it?
Thanks
Anthony
On Mon, May 14, 2018 at 3:47 PM Anthony Emengo wrote:
> Apologies, here's a redo that should apply cleanly on top of master
>
> Anthony &&a
Hey all,
We haven't heard from you all in a while regarding our last statements. Is
there any thing that I need to clarify? We feel left in the dark here and
just want to know what we can do help.
Cheers!
Anthony && Joao
Here’s a followup patch with the relevant README and Makefile changes. To
be clear, both patches need to be applied in succession to run the tests.
The error that you were running into was because the appropriate PYTHONPATH
environment variable was not set. We updated the README to reflect that,
b
de' class defined
> in 'pgadmin/.../schemas/static/js/child.js' script.
>
> Let me know if you need more information.
>
>
>> Let's keep in mind that the original intent was simply to introduce this
>> abstraction into the code base, which is a big
20 matches
Mail list logo
