Re: [pgAdmin][RM4329] Initialization error when parameterised functions debugged in parallel in two separate tabs

2019-06-19 Thread Akshay Joshi
;>> Thanks, patch applied. >>>> >>>> On Mon, Jun 10, 2019 at 1:58 PM Aditya Toshniwal < >>>> aditya.toshni...@enterprisedb.com> wrote: >>>> >>>>> Hi Hackers, >>>>> >>>>> Attached is the updated patch with f

[pgAdmin4][Patch]: RM #4362 trigger function create script

2019-06-19 Thread Akshay Joshi
Hi Hackers, Attached is the patch to fix RM #4362 trigger function create script. Please review it. -- *Thanks & Regards* *Akshay Joshi* *Sr. Software Architect* *EnterpriseDB Software India Private Limited* *Mobile: +91 976-788-8246* RM_4362.patch Description: Binary data

pgAdmin 4 commit: Capitalize the word 'export' used in Import/Export mo

2019-06-19 Thread Akshay Joshi
Capitalize the word 'export' used in Import/Export module. Fixes #4345 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=5c0ea0c012839d69f9b40f3efcc632a5c4d52cff Modified Files -- docs/en_US/release_notes_4_9.rst

Re: [pgAdmin4][Patch]: RM #4362 trigger function create script

2019-06-19 Thread Akshay Joshi
Hi Dave On Wed, 19 Jun, 2019, 19:57 Dave Page, wrote: > Hi > > On Wed, Jun 19, 2019 at 9:55 AM Akshay Joshi < > akshay.jo...@enterprisedb.com> wrote: > >> Hi Hackers, >> >> Attached is the patch to fix RM #4362 trigger function create script. >> Plea

Re: [pgAdmin4][Patch]: RM #4362 trigger function create script

2019-06-19 Thread Akshay Joshi
Hi Dave On Wed, Jun 19, 2019 at 8:47 PM Akshay Joshi wrote: > Hi Dave > > On Wed, 19 Jun, 2019, 19:57 Dave Page, wrote: > >> Hi >> >> On Wed, Jun 19, 2019 at 9:55 AM Akshay Joshi < >> akshay.jo...@enterprisedb.com> wrote: >> >>> Hi Hacke

pgAdmin 4 commit: Update message catalogs

2019-06-21 Thread Akshay Joshi
Update message catalogs Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=c4de5474a42c64d337393e3885dfa9db673994dc Modified Files -- web/pgadmin/messages.pot | 1149 +- .../translations/de/LC_MESSAGES

Translators: Release next week

2019-06-21 Thread Akshay Joshi
Hi Translators, We will have release next week, so updates to translations prior to release would be helpful. The template and catalogs have been updated in git. -- *Thanks & Regards* *Akshay Joshi* *Sr. Software Architect* *EnterpriseDB Software India Private Limited* *Mobile: +91 976

pgAdmin 4 commit: Update French translation

2019-06-21 Thread Akshay Joshi
Update French translation Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=4e5d8fe8e2331ed0f04d6cf5380121246f345bef Author: Fred Escallier Modified Files -- .../translations/fr/LC_MESSAGES/messages.mo| Bin 159835 -> 170745

Re: Translators: Release next week

2019-06-21 Thread Akshay Joshi
Thanks patch applied. On Fri, Jun 21, 2019 at 4:40 PM wrote: > hello > fr messages update for upcoming release > Fred > > > ------ > *De: *"Akshay Joshi" > *À: *"pgadmin-hackers" > *Envoyé: *Vendredi 21 Juin 2019 12:

pgAdmin 4 commit: Update Japanese translation

2019-06-23 Thread Akshay Joshi
Update Japanese translation Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=b3490ba3de9fa38225566acec9cacca825e868a1 Author: Identifier Anonymous Modified Files -- .../translations/ja/LC_MESSAGES/messages.mo| Bin 166261 ->

Re: Japanese translation (July 2019)

2019-06-23 Thread Akshay Joshi
Thanks patch applied. On Sat, Jun 22, 2019 at 9:04 PM fn ln wrote: > Hello. > Updated translation for version 4.9 is in attachment. > messages.pot was taken from git c4de5474. > -- *Thanks & Regards* *Akshay Joshi* *Sr. Software Architect* *EnterpriseDB Software India

pgAdmin 4 commit: Fix an XSS issue when username contains XSS vulnerabl

2019-06-24 Thread Akshay Joshi
Fix an XSS issue when username contains XSS vulnerable text. Fixes #4386 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=c39d257bf65b4c2c8f07901f4a909708c771775c Author: Aditya Toshniwal Modified Files -- docs/en_US/release_notes_

pgAdmin 4 commit: Update version for release

2019-06-24 Thread Akshay Joshi
Update version for release Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=173acd46a5d85c1523e34b105046f70a7ea42b2a Modified Files -- runtime/Info.plist | 4 ++-- runtime/pgAdmin4.pro | 2 +- web/config.py| 4 ++-- 3 files c

pgAdmin4 v4.9 candidate builds

2019-06-24 Thread Akshay Joshi
Hi All, pgAdmin4 v4.9 candidate builds and source can be found at https://developer.pgadmin.org/builds/2019-06-24-1/ Fahar, can you please verify it for release on Thursday. -- *Thanks & Regards* *Akshay Joshi* *Sr. Software Architect* *EnterpriseDB Software India Private Limited* *Mo

pgAdmin 4 v4.9 released

2019-06-27 Thread Akshay Joshi
Container and source code tarball from: https://www.pgadmin.org/download/ RPM and DEB packages are expected to be available on the postgresql.org repositories within the next few days. -- Akshay Joshi pgAdmin Project

pgAdmin 4 commit: Update version for release

2019-06-28 Thread Akshay Joshi
Update version for release Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=252429df50a27a7a6499358441f703463dbac796 Modified Files -- runtime/Info.plist | 4 ++-- runtime/pgAdmin4.pro | 2 +- web/config.py| 4 ++-- 3 files c

pgAdmin 4 commit: update the release date and message catalogs

2019-06-28 Thread Akshay Joshi
update the release date and message catalogs Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=d6c6b4a15abbc82636a22126ae15f891001ca71d Modified Files -- docs/en_US/release_notes_4_10.rst |2 +- web/pgadmin/messag

pgAdmin4 v4.10 candidate builds

2019-06-28 Thread Akshay Joshi
ards* *Akshay Joshi* *Sr. Software Architect* *EnterpriseDB Software India Private Limited* *Mobile: +91 976-788-8246*

Re: [pgAdmin][RM4421] Inno setup script version compare fix

2019-07-02 Thread Akshay Joshi
. > > -- > Thanks and Regards, > Aditya Toshniwal > Software Engineer | EnterpriseDB India | Pune > "Don't Complain about Heat, Plant a TREE" > -- *Thanks & Regards* *Akshay Joshi* *Sr. Software Architect* *EnterpriseDB Software India Private Limited* *Mobile: +91 976-788-8246*

pgAdmin 4 commit: Ensure the version comparision should be correct for

2019-07-02 Thread Akshay Joshi
Ensure the version comparision should be correct for windows installer. Fixes #4421 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=b76e0bea839fe3c5d59e2490713d0caba029b0ca Author: Aditya Toshniwal Modified Files -- docs/en_US/re

Re: [pgAdmin][RM4421] Inno setup script version compare fix

2019-07-02 Thread Akshay Joshi
ww.arvydas.co.uk/2015/04/compare-version-strings-with-innosetup/ > > Kindly review. > > On Tue, Jul 2, 2019 at 2:34 PM Akshay Joshi > wrote: > >> Hi Aditya >> >> I have asked Paresh to review the patch, he has given some review >> comments. Please fix those a

Re: pgAdmin4 v4.10 candidate builds

2019-07-02 Thread Akshay Joshi
Abbas wrote: > Hi, > > Here is the showstopper issue for pgadmin4 4.10: > > https://redmine.postgresql.org/issues/4421 > > Kind Regards, > > On Fri, Jun 28, 2019 at 8:21 PM Akshay Joshi < > akshay.jo...@enterprisedb.com> wrote: > >> Hi All, >> >&

pgAdmin 4 commit: Correct the condition to compare version for Windows

2019-07-02 Thread Akshay Joshi
Correct the condition to compare version for Windows installer. Regression of last commit. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=15556f9f89c1268e99fcc4f0eaf6c6e9ab608ce5 Author: Aditya Toshniwal Modified Files -- pkg/wi

Re: pgAdmin4 v4.10 candidate builds

2019-07-02 Thread Akshay Joshi
; and not -1. > Attached is the patch. > > Sorry for trouble to build again. :/ > > > On Tue, Jul 2, 2019 at 4:39 PM Akshay Joshi > wrote: > >> Hi Fahar >> >> We have fixed RM #4421. Candidate builds and source can be found at >> https://developer.pgad

Re: pgAdmin4 v4.10 candidate builds

2019-07-02 Thread Akshay Joshi
Hi Fahar, Candidate builds and source can be found at https://developer.pgadmin.org/builds/2019-07-02-3/ Please verify the upgrade scenario and rest of the testing for the release on Thursday 4th July. On Tue, Jul 2, 2019 at 8:13 PM Akshay Joshi wrote: > Thanks patch applied. > > On T

Re: RE-SQL tests for Roles & Resource Group nodes

2019-07-03 Thread Akshay Joshi
; -- >> >> Ran 1 test in 0.480s >> >> >> OK (skipped=1) >> >> >> == >> >> Test Result Summary >> >>

[pgAdmin4][Patch]: RM 4393 Edit users with parameters 'all' gives error while saving

2019-07-04 Thread Akshay Joshi
Hi Hackers, Attached is the patch to fix RM #4393 Edit users with parameters 'all' gives error while saving. Apart from that I have modified the function qtIdent, qtTypeIdent and qtLiteral to handle integer value. Please review it -- *Thanks & Regards* *Akshay Joshi* *Sr. Soft

pgAdmin 4 commit: Fix table icon issue when updating any existing field

2019-07-04 Thread Akshay Joshi
Fix table icon issue when updating any existing field. Fixes #4437 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=bf1f9a4b077f398d76bd83fb6f0f30e2524faaf6 Modified Files -- docs/en_US/release_notes_4_11.rst

pgAdmin 4 v4.10 released

2019-07-04 Thread Akshay Joshi
://www.pgadmin.org/download/ RPM and DEB packages are expected to be available on the postgresql.org repositories within the next few days. -- Akshay Joshi pgAdmin Project

pgAdmin 4 commit: Update the version number in release note.

2019-07-04 Thread Akshay Joshi
Update the version number in release note. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=fabb644230249d6bdc4424fa4d5a9442f47a709a Modified Files -- docs/en_US/release_notes_4_11.rst | 2 +- 1 file changed, 1 insertion(+), 1 deleti

pgAdmin 4 commit: Added logic to provide custom schema name in re_sql t

2019-07-05 Thread Akshay Joshi
Added logic to provide custom schema name in re_sql test framework. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=954c0d31019a6cd19e15ee024f032f92c6654628 Author: Khushboo Vashi Modified Files -- web/regression/re_sql/tests/test

pgAdmin 4 commit: Fix small issue which is required to support the cust

2019-07-08 Thread Akshay Joshi
Fix small issue which is required to support the custom schema in re_sql test cases. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=7c38c1cb380bcbd6ffde6486029cd913cd59ef83 Author: Khushboo Vashi Modified Files -- .../browser/se

Re: pgAdmin 4 commit: Added logic to provide custom schema name in re_sql t

2019-07-08 Thread Akshay Joshi
Thanks patch applied On Mon, Jul 8, 2019 at 11:10 AM Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi, > > One small change is required to support the custom schema. > Please find the attached patch for the same. > > Thanks, > Khushboo > > On Fri, Ju

pgAdmin 4 commit: Ensure browser should not be started by Selenium when

2019-07-08 Thread Akshay Joshi
Ensure browser should not be started by Selenium when feature tests are excluded from a test run. Fixes #4442 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=8c39b10d9c50925a6a791fdae627a691f096266c Modified Files -- docs/en_US/re

pgAdmin 4 commit: Fix reverse engineered sql for Foreign Data Wrapper c

2019-07-08 Thread Akshay Joshi
Fix reverse engineered sql for Foreign Data Wrapper created on EPAS server in redwood mode. Fixes #4450 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=a17687e27c4a95195b1730796db502893b89fac4 Modified Files -- docs/en_US/release_

pgAdmin 4 commit: Modified the creation logic of custom schema and adde

2019-07-09 Thread Akshay Joshi
Modified the creation logic of custom schema and added support for schema id in re_sql test framework. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=f4ac1e804e1b943a2ef8db71c06fb7b982096585 Author: Khushboo Vashi Modified Files ---

pgAdmin 4 commit: 1) Ensure re_sql tests should not abort at the first

2019-07-09 Thread Akshay Joshi
1) Ensure re_sql tests should not abort at the first failure, it should run all the test cases. 2) Added place holder for owner, so we won't need to create separate pg/ppas folder just because of change in the owner name. Branch -- master Details --- https://git.postgresql.org/gitweb?p=

pgAdmin 4 commit: Remove some files which was committed by mistake.

2019-07-09 Thread Akshay Joshi
Remove some files which was committed by mistake. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=f085460453abaae2f0fcdc5ef0adc16e92d00f77 Modified Files -- .../tests/9.3_plus/create_trusted_language.sql | 11 -- .../tests/9

[pgAdmin4][Patch]: RM 4452 Add RE-SQL tests for Languages

2019-07-10 Thread Akshay Joshi
Hi Hackers, Attached is the patch to fix RM #4452 "Add RE-SQL tests for Languages". Please review it. -- *Thanks & Regards* *Akshay Joshi* *Sr. Software Architect* *EnterpriseDB Software India Private Limited* *Mobile: +91 976-788-8246* RM_4452.patch Description: Binary data

pgAdmin 4 commit: Added re_sql test cases for privileges in Foreign Dat

2019-07-10 Thread Akshay Joshi
Added re_sql test cases for privileges in Foreign Data Wrappers Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=6c7e95a4638e2db631a20626f1565ace2e60c0cd Modified Files -- .../foreign_data_wrappers/sql/9.3_plus/acl.sql | 1 + ..

Re: RE-SQL tests patch for packages node

2019-07-11 Thread Akshay Joshi
< navnath.gad...@enterprisedb.com> wrote: > Hi Dave, > > I have attached the patch for RE-SQL test cases for *Packages* node. > > Thanks! > > -- > *Regards,* > *Navnath Gadakh* > -- *Thanks & Regards* *Akshay Joshi* *Sr. Software Architect* *EnterpriseDB Software

pgAdmin 4 commit: Fixed resql test cases for Extensions specific to dat

2019-07-11 Thread Akshay Joshi
Fixed resql test cases for Extensions specific to database servers. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=e6c067025cfe6ecff786efe3b671c8c7dd840c17 Author: Nagesh Dhope Modified Files -- .../tests/9.4_plus/alter_extension

Re: Updated patch for RM #4453

2019-07-11 Thread Akshay Joshi
Thanks patch applied. But we still need to modify the logic to check extension with exact version is available on database servers. On Thu, Jul 11, 2019 at 12:58 PM Nagesh Dhope wrote: > Hi, > PFA, updated patch for RM #4453 > > Thanks, > Nagesh > -- *Thanks & Regard

[pgAdmin4][Patch]: RM 4389 "string indices must be integers" error displayed if select Privileges for Columns

2019-07-11 Thread Akshay Joshi
Hi Hackers, Attached is the patch to fix RM 4389 "string indices must be integers" error displayed if select Privileges for Columns. Added API test case for the scenario. Please review it. -- *Thanks & Regards* *Akshay Joshi* *Sr. Software Architect* *EnterpriseDB Software

[pgAdmin4][Patch]: RM 3996 "Error dropping Schedule" message displayed if drop schedule through property section

2019-07-12 Thread Akshay Joshi
Hi Hackers, Attached is the patch to fix RM 3996 "Error dropping Schedule" message displayed if drop schedule through property section. Added regression test cases for delete multiple pgAgent Job, multiple schedules and multiple steps. -- *Thanks & Regards* *Akshay Joshi*

[pgAdmin4][Patch]: RM 4428 and 4448

2019-07-15 Thread Akshay Joshi
on test cases to add schedule and step from the pgagent job itself. Please review it. -- *Thanks & Regards* *Akshay Joshi* *Sr. Software Architect* *EnterpriseDB Software India Private Limited* *Mobile: +91 976-788-8246* RM_4428_4448.patch Description: Binary data

pgAdmin 4 commit: Correct the issue number and sequence in release note

2019-07-18 Thread Akshay Joshi
Correct the issue number and sequence in release note. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=5a0aae0c1ccd63046480e0d84cc0bef47f016577 Modified Files -- docs/en_US/release_notes_4_11.rst | 6 +++--- 1 file changed, 3 insert

pgAdmin 4 commit: Update message catalogs.

2019-07-19 Thread Akshay Joshi
Update message catalogs. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=003ab44a918820dfe9f387bff43938a2468ce665 Modified Files -- web/pgadmin/messages.pot | 1137 ++- .../translations/de/L

Translators: Release next week

2019-07-19 Thread Akshay Joshi
Hi Translators, We will have release next week, so updates to translations prior to release would be helpful. The template and catalogs have been updated in git. -- *Thanks & Regards* *Akshay Joshi* *Sr. Software Architect* *EnterpriseDB Software India Private Limited* *Mobile: +91 976

pgAdmin 4 commit: Update Japanese translation

2019-07-21 Thread Akshay Joshi
Update Japanese translation Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=4a6991d0df5548a9970de23b9c1bb00a405030d1 Author: Identifier Anonymous Modified Files -- .../translations/ja/LC_MESSAGES/messages.mo| Bin 167523 ->

Re: Japanese translation (August 2019)

2019-07-21 Thread Akshay Joshi
Thanks patch applied. On Fri, Jul 19, 2019 at 11:08 PM fn ln wrote: > Hello. > Updated translation for upcoming version 4.11 is in attachment. > messages.pot was taken from git 003ab44a. > -- *Thanks & Regards* *Akshay Joshi* *Sr. Software Architect* *EnterpriseDB Softwa

pgAdmin 4 commit: Update French translation

2019-07-22 Thread Akshay Joshi
Update French translation Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=6e49c9c36f2b169cc855bf203b7f51f3907a1efa Author: Fred Escallier Modified Files -- .../translations/fr/LC_MESSAGES/messages.mo| Bin 160764 -> 172056

Re: Translators: Release next week

2019-07-22 Thread Akshay Joshi
Thanks patch applied. On Mon, Jul 22, 2019 at 4:44 PM wrote: > hello > french translation for upcoming release > Fred > > > ------ > *De: *"Akshay Joshi" > *À: *"pgadmin-hackers" > *Envoyé: *Vendredi 19 Juillet 2019 14:

pgAdmin 4 commit: 1) Fix an error while retrieving json data from the t

2019-07-22 Thread Akshay Joshi
1) Fix an error while retrieving json data from the table. Fixes #4427 2) Fix an issue where Explain and Explain Analyze are not working, it's regression of #1760. Fixes #4484 3) Fix an issue where Filter toolbar button is not working in view/edit data, it's regression of keyboard navigation. Fix

Re: [pgAdmin4][Patch] - RM 4427 , RM 4484, RM 4485

2019-07-22 Thread Akshay Joshi
n Analyze are broken > #4485 - View Data - Filter Data is broken > > This issues are the regression of below commits: > > 74cfeabd02c8fd63d2604ac826dae7ed4308a91e > 710d520631b1b4649eb4a8d924e3141ff74af449 > > 4cbc1f2f59192f6461cfeea96aec2d3ee5df5f06 > > Thanks, > Khus

pgAdmin 4 commit: Update version for release

2019-07-22 Thread Akshay Joshi
Update version for release Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=b4d9fea83d8b06fc1d836ca948f047dab7143695 Modified Files -- runtime/Info.plist | 4 ++-- runtime/pgAdmin4.pro | 2 +- web/config.py| 4 ++-- 3 files c

pgAdmin4 v4.11 candidate builds

2019-07-22 Thread Akshay Joshi
Hi All, pgAdmin4 v4.11 candidate builds and source can be found at https://developer.pgadmin.org/builds/2019-07-23-1/ Fahar, can you please verify it for release on Thursday. -- *Thanks & Regards* *Akshay Joshi* *Sr. Software Architect* *EnterpriseDB Software India Private Limited* *Mo

Re: pgAdmin4 v4.11 candidate builds

2019-07-23 Thread Akshay Joshi
Hi Devrim On Wed, Jul 24, 2019 at 3:24 AM Devrim Gündüz wrote: > On Tue, 2019-07-23 at 11:01 +0530, Akshay Joshi wrote: > > Hi All, > > > > pgAdmin4 v4.11 candidate builds and source can be found at > > https://developer.pgadmin.org/builds/2019-07-23-1/ > > Ju

[pgAdmin4][Patch]: Fix for Feature #4334, RM #4496 and #4497

2019-07-24 Thread Akshay Joshi
ult value of a column and then select the datatype to serial/bigserial/smallserial, it generates wrong msql. Modified/Added regression test cases for adding Identity column and Generated columns. Please review it. -- *Thanks & Regards* *Akshay Joshi* *Sr. Software Architect* *Enterpris

Re: pgAdmin4 v4.11 candidate builds

2019-07-24 Thread Akshay Joshi
Hi Devrim On Wed, Jul 24, 2019 at 1:02 PM Devrim Gündüz wrote: > > Hi, > > On Wed, 2019-07-24 at 10:48 +0530, Akshay Joshi wrote: > >Feature test are not stable yet, so we will have to remove that from > our > > build process. > > How? Will you re-wrap 4.11?

Re: pgAdmin4 v4.11 candidate builds

2019-07-24 Thread Akshay Joshi
n Wed, 2019-07-24 at 13:08 +0530, Akshay Joshi wrote: > >No, I'll not re-wrap 4.11. I am not much aware of the RPM's, but I > think > > you will need to change the spec file and add "--exclude > > feature_tests" > > parameter to the command for

Re: pgAdmin4 v4.11 candidate builds

2019-07-24 Thread Akshay Joshi
On Wed, 24 Jul, 2019, 19:26 Devrim Gündüz, wrote: > > Hi Akshay, > > On Wed, 2019-07-24 at 14:45 +0530, Akshay Joshi wrote: > > We have figure out the problem with the syntax print("Copy rows...", > > file=sys.stderr, end="") with Python 2.7. > &g

pgAdmin 4 commit: Fix syntax error in query tool feature test for Pytho

2019-07-24 Thread Akshay Joshi
Fix syntax error in query tool feature test for Python 2.7 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=8cfe39e8371a6255b23b35c281e6d86f1a6e4ef4 Modified Files -- web/pgadmin/feature_tests/query_tool_journey_test.py | 1 + 1 file

pgAdmin 4 commit: 1) Fix accessibility issue for checkbox in IE11. Fixe

2019-07-25 Thread Akshay Joshi
1) Fix accessibility issue for checkbox in IE11. Fixes #4490 2) Fix adjacent switch cell focus issue in backgrid for IE. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=136bb412a1363a161a7b4f37151d97db1de19cfb Author: Ganesh Jaybhay Modified

Re: [pgAdmin][RM4490] Checkbox doesn't highlight on focus in IE11

2019-07-25 Thread Akshay Joshi
Thanks patch applied. On Tue, Jul 23, 2019 at 11:27 PM Ganesh Jaybhay < ganesh.jayb...@enterprisedb.com> wrote: > Hi Hackers, > > Attached is the minor css fix to highlight checkbox on focus in IE11. > Kindly review. > > Regards, > Ganesh Jaybhay > -- *Thanks

pgAdmin 4 commit: Fix accessibility issue for Datetime cell in backgrid

2019-07-25 Thread Akshay Joshi
Fix accessibility issue for Datetime cell in backgrid. Fixes #4508 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=108af5c10b9d629c409b4e9955775a16a5585e26 Author: Murtuza Zabuawala Modified Files -- docs/en_US/release_notes_4_12.

Re: [RM#4508] Fix tab navigation issue with Backgrid Datetime cell

2019-07-25 Thread Akshay Joshi
http://www.enterprisedb.com > The Enterprise PostgreSQL Company > > -- *Thanks & Regards* *Akshay Joshi* *Sr. Software Architect* *EnterpriseDB Software India Private Limited* *Mobile: +91 976-788-8246*

pgAdmin 4 v4.11 released

2019-07-25 Thread Akshay Joshi
indows and macOS are available now, along with a Python Wheel, Docker Container and source code tarball from: https://www.pgadmin.org/download/ RPM and DEB packages are expected to be available on the postgresql.org repositories within the next few days. -- Akshay Joshi pgAdmin Project

Re: [pgAdmin][Patch] Highlight adjacent switch cell on focus in backgrid(IE11)

2019-07-25 Thread Akshay Joshi
Hi Dave Yesterday I have committed this patch, as email was held for moderation. Ganesh has send the patch to me directly. On Thu, 25 Jul, 2019, 21:25 Dave Page, wrote: > Hi, > > What's the RM number for this please? > > On Thu, Jul 25, 2019 at 4:49 PM Ganesh Jaybhay < > ganesh.jayb...@enterpr

Re: [GSoC] Support editing resultsets from tables with OIDs

2019-07-28 Thread Akshay Joshi
Engineering student, >> The Faculty of Engineering, >> Cairo University (2021). >> Class representative of CMP 2021. >> https://www.linkedin.com/in/yosrym93/ >> > > > -- > Dave Page > Blog: http://pgsnake.blogspot.com > Twitter: @pgsnake > > EnterpriseDB UK: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > -- *Thanks & Regards* *Akshay Joshi* *Sr. Software Architect* *EnterpriseDB Software India Private Limited* *Mobile: +91 976-788-8246*

pgAdmin 4 commit: Added support for editing of result sets from tables

2019-07-29 Thread Akshay Joshi
Added support for editing of result sets from tables with OIDs in query tool. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=82d209946f6967a45238364659fe2d20313fcaae Author: Yosry Muhammad Modified Files -- docs/en_US/query_tool.

Re: [GSoC] Support editing resultsets from tables with OIDs

2019-07-29 Thread Akshay Joshi
Thanks patch applied. On Mon, Jul 29, 2019 at 11:12 AM Akshay Joshi wrote: > > On Fri, Jul 26, 2019 at 5:33 PM Dave Page wrote: > >> Akshay; can you take a look at this and commit if appropriate please? I'm >> somewhat busy at the moment :-( >> > >

pgAdmin 4 commit: Swap the Schema and Schemas icons and Catalog and Cat

2019-07-31 Thread Akshay Joshi
Swap the Schema and Schemas icons and Catalog and Catalogs icons that had been used the wrong way around. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=1ff007d1cbde81498101951e122e70138060927b Modified Files -- .../databases/sch

Re: pgAdmin 4 commit: Swap the Schema and Schemas icons and Catalog and Cat

2019-07-31 Thread Akshay Joshi
Thu, Aug 1, 2019 at 11:40 AM Akshay Joshi wrote: > Swap the Schema and Schemas icons and Catalog and Catalogs icons that had > been used the wrong way around. > > Branch > -- > master > > Details > --- > > https://git.postgres

Re: [RM#4546] Add RE-SQL tests for Column node

2019-08-01 Thread Akshay Joshi
erpriseDB: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > > -- *Thanks & Regards* *Akshay Joshi* *Sr. Software Architect* *EnterpriseDB Software India Private Limited* *Mobile: +91 976-788-8246*

Re: [RM#4546] Add RE-SQL tests for Column node

2019-08-01 Thread Akshay Joshi
such test cases. - Generated expression should use existing columns if possible like (col1 * col2). Apart from that can you please look into *RM #4500 *which seems minor issue. Please send separate patch for both. On Thu, Aug 1, 2019 at 5:36 PM Akshay Joshi wrote: > Hi All > > I&#

pgAdmin 4 commit: Ensure triggers should be updated properly for EPAS s

2019-08-05 Thread Akshay Joshi
Ensure triggers should be updated properly for EPAS server. Fixes #4559 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=b5c8c85c90b369aff0c613db32cedfc3a9667516 Author: Aditya Toshniwal Modified Files -- docs/en_US/release_notes_4

Re: [pgAdmin][RM4559] Updating a trigger on EPAS server throws browser error

2019-08-05 Thread Akshay Joshi
hanks and Regards, > Aditya Toshniwal > Software Engineer | EnterpriseDB India | Pune > "Don't Complain about Heat, Plant a TREE" > -- *Thanks & Regards* *Akshay Joshi* *Sr. Software Architect* *EnterpriseDB Software India Private Limited* *Mobile: +91 976-788-8246*

Re: [pgAdmin4][Patch] - RM 4555 - RE-SQL for Exclusion Constraint

2019-08-05 Thread Akshay Joshi
it should be like 'alter_comment.sql'. On Mon, Aug 5, 2019 at 12:30 PM Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi, > > Please find the attached patch for the RE-SQL tests of the Exclusion > constraint node with some bug fixes in SQL. > > Thanks, >

pgAdmin 4 commit: Add Reverse Engineered SQL tests for Exclusion Constr

2019-08-05 Thread Akshay Joshi
Add Reverse Engineered SQL tests for Exclusion Constraint. Fixes #4555 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=f8afe2ef940be607e8b6e87b62875b17e1b0c2c2 Author: Khushboo Vashi Modified Files -- docs/en_US/release_notes_4_12

Re: [pgAdmin4][Patch] - RM 4555 - RE-SQL for Exclusion Constraint

2019-08-05 Thread Akshay Joshi
Thanks patch applied. On Mon, Aug 5, 2019 at 2:00 PM Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi Akshay, > > Please find the attached updated patch. > > On Mon, Aug 5, 2019 at 1:20 PM Akshay Joshi > wrote: > >> Hi Khushboo >> >>

pgAdmin 4 commit: Fix generation of reverse engineered SQL for partitio

2019-08-07 Thread Akshay Joshi
Fix generation of reverse engineered SQL for partition table, partitions were shown as a child of indexes. Fixes #4414 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=7f53e13aa728298a2adb31ab28624b04b4332166 Modified Files -- docs

pgAdmin 4 commit: 1) Add support of Compound Triggers for EPAS 12+. Fix

2019-08-08 Thread Akshay Joshi
1) Add support of Compound Triggers for EPAS 12+. Fixes #4144. 2) Ensure enable trigger menu should be visible when trigger is disabled. Fixes #4578. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=350ffcce7c6ce7eb13f813f343944585aef23717 Mod

pgAdmin 4 commit: Fix console error when changing kind(SQL/BATCH) for p

2019-08-08 Thread Akshay Joshi
Fix console error when changing kind(SQL/BATCH) for pgAgent job step. Fixes #4582 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=1281f5cd6cd5c6631c6e26bf1f04e78f25f2e975 Author: Aditya Toshniwal Modified Files -- docs/en_US/rele

Re: [pgAdmin][RM4582] pgAgent - In create job step changing "kind" (SQL/Batch) throws console error

2019-08-08 Thread Akshay Joshi
gt; > -- > Thanks and Regards, > Aditya Toshniwal > Software Engineer | EnterpriseDB India | Pune > "Don't Complain about Heat, Plant a TREE" > -- *Thanks & Regards* *Akshay Joshi* *Sr. Software Architect* *EnterpriseDB Software India Private Limited* *Mobile: +91 976-788-8246*

Re: [RM- 4575] RE_SQL for Schema

2019-08-08 Thread Akshay Joshi
n't specify the hardcode value for "oid": 40970. On Thu, Aug 8, 2019 at 4:23 PM Vishal Sawale wrote: > Hi Hackers, > > PFA the patch for RE-SQL test cases for Schema node. Please review. > > Regards, > Vishal > > > > -- *Thanks & Regards* *Aksh

pgAdmin 4 commit: Fix double click issue to expand the contents of a ce

2019-08-08 Thread Akshay Joshi
Fix double click issue to expand the contents of a cell if the resultset was not editable. Fixes #4585 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=b618dfe286146c3c8db73de834eda60e8a12d556 Author: Yosry Muhammad Modified Files ---

Re: Query Tool - Cell Double Click Fix

2019-08-08 Thread Akshay Joshi
> *Yosry Muhammad Yosry* > > Computer Engineering student, > The Faculty of Engineering, > Cairo University (2021). > Class representative of CMP 2021. > https://www.linkedin.com/in/yosrym93/ > -- *Thanks & Regards* *Akshay Joshi* *Sr. Software Architect* *EnterpriseDB

Re: [pgAdmin][RM4582] pgAgent - In create job step changing "kind" (SQL/Batch) throws console error

2019-08-11 Thread Akshay Joshi
> On Thu, Aug 8, 2019 at 6:44 PM Akshay Joshi > wrote: > >> Thanks patch applied. >> >> On Thu, Aug 8, 2019 at 4:40 PM Aditya Toshniwal < >> aditya.toshni...@enterprisedb.com> wrote: >> >>> Hi Hackers, >>> >>> Attached is the

pgAdmin 4 commit: Update the documentation for pgAgent to clarify Batch

2019-08-11 Thread Akshay Joshi
Update the documentation for pgAgent to clarify Batch jobs won't run on remote servers. Fix minor css issue in docs. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=a850e7bd5a0b4e074116dffaa8c3312056f557f6 Author: Aditya Toshniwal Modified F

Re: [pgAdmin][RM4552] Dragging the selected text in SQL editor throws console errors

2019-08-12 Thread Akshay Joshi
gt;> Aditya Toshniwal >>> Software Engineer | EnterpriseDB India | Pune >>> "Don't Complain about Heat, Plant a TREE" >>> >> >> >> -- >> Dave Page >> Blog: http://pgsnake.blogspot.com >> Twitter: @pgsnake >> >&

pgAdmin 4 commit: Fix issue in drag drop feature. It's regression of RM

2019-08-12 Thread Akshay Joshi
Fix issue in drag drop feature. It's regression of RM #4552 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=a51de7829229fe03719fabac824d110ea0a95f0a Author: Aditya Toshniwal Modified Files -- web/pgadmin/tools/sqleditor/static/js/

pgAdmin 4 commit: Fix generation of reverse engineered SQL for Rules. F

2019-08-12 Thread Akshay Joshi
Fix generation of reverse engineered SQL for Rules. Fixes #4586 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=35bbee3023d3559940f84fafb33cb13429eb3b15 Modified Files -- docs/en_US/images/rule_commands.png| Bin 0 -

pgAdmin 4 commit: Fix PEP8 issue

2019-08-12 Thread Akshay Joshi
Fix PEP8 issue Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=4403f326e9979b6ca7ca8cd4671b71785e1d41a3 Modified Files -- web/pgadmin/browser/server_groups/servers/databases/schemas/utils.py | 3 ++- 1 file changed, 2 insertions(+),

Re: [GSoC] Query History Upgrade

2019-08-14 Thread Akshay Joshi
>>>>>>> (pgadmin.feature_tests.query_tool_journey_test.QueryToolJourneyTest) >>>>>>>>> Tests the path through the query tool >>>>>>>>> >>>>>>>>> -- >>>>>>>>> Traceback (most recent call last): >>>>>>>>> File >>>>>>>>> "/Users/adityatoshniwal/projects/pgadmin4/web/pgadmin/feature_tests/query_tool_journey_test.py", >>>>>>>>> line 79, in runTest >>>>>>>>> self._test_updatable_resultset() >>>>>>>>> File >>>>>>>>> "/Users/adityatoshniwal/projects/pgadmin4/web/pgadmin/feature_tests/query_tool_journey_test.py", >>>>>>>>> line 240, in _test_updatable_resultset >>>>>>>>> self._check_query_results_editable(query, False) >>>>>>>>> File >>>>>>>>> "/Users/adityatoshniwal/projects/pgadmin4/web/pgadmin/feature_tests/query_tool_journey_test.py", >>>>>>>>> line 378, in _check_query_results_editable >>>>>>>>> is_editable = self._check_cell_editable(1) >>>>>>>>> File >>>>>>>>> "/Users/adityatoshniwal/projects/pgadmin4/web/pgadmin/feature_tests/query_tool_journey_test.py", >>>>>>>>> line 395, in _check_cell_editable >>>>>>>>> self.assertFalse('editable' in cell_classes) >>>>>>>>> AssertionError: True is not false >>>>>>>>> >>>>>>>>> >>>>>>>>> -- >>>>>>>>> Ran 1 test in 38.118s >>>>>>>>> >>>>>>>>> FAILED (failures=1) >>>>>>>>> >>>>>>>>>> >>>>>>>>>> Thanks ! >>>>>>>>>> >>>>>>>>>> -- >>>>>>>>>> *Yosry Muhammad Yosry* >>>>>>>>>> >>>>>>>>>> Computer Engineering student, >>>>>>>>>> The Faculty of Engineering, >>>>>>>>>> Cairo University (2021). >>>>>>>>>> Class representative of CMP 2021. >>>>>>>>>> https://www.linkedin.com/in/yosrym93/ >>>>>>>>>> >>>>>>>>> >>>>>>>>> >>>>>>>>> -- >>>>>>>>> Thanks and Regards, >>>>>>>>> Aditya Toshniwal >>>>>>>>> Software Engineer | EnterpriseDB India | Pune >>>>>>>>> "Don't Complain about Heat, Plant a TREE" >>>>>>>>> >>>>>>>> >>>>>>>> >>>>>>>> -- >>>>>>>> *Yosry Muhammad Yosry* >>>>>>>> >>>>>>>> Computer Engineering student, >>>>>>>> The Faculty of Engineering, >>>>>>>> Cairo University (2021). >>>>>>>> Class representative of CMP 2021. >>>>>>>> https://www.linkedin.com/in/yosrym93/ >>>>>>>> >>>>>>> >>>>>>> >>>>>>> -- >>>>>>> Thanks and Regards, >>>>>>> Aditya Toshniwal >>>>>>> Software Engineer | EnterpriseDB India | Pune >>>>>>> "Don't Complain about Heat, Plant a TREE" >>>>>>> >>>>>> >>>>>> >>>>>> -- >>>>>> *Yosry Muhammad Yosry* >>>>>> >>>>>> Computer Engineering student, >>>>>> The Faculty of Engineering, >>>>>> Cairo University (2021). >>>>>> Class representative of CMP 2021. >>>>>> https://www.linkedin.com/in/yosrym93/ >>>>>> >>>>> >>>>> >>>>> -- >>>>> Thanks and Regards, >>>>> Aditya Toshniwal >>>>> Software Engineer | EnterpriseDB India | Pune >>>>> "Don't Complain about Heat, Plant a TREE" >>>>> >>>> >>>> >>>> -- >>>> *Yosry Muhammad Yosry* >>>> >>>> Computer Engineering student, >>>> The Faculty of Engineering, >>>> Cairo University (2021). >>>> Class representative of CMP 2021. >>>> https://www.linkedin.com/in/yosrym93/ >>>> >>> >>> >>> -- >>> *Yosry Muhammad Yosry* >>> >>> Computer Engineering student, >>> The Faculty of Engineering, >>> Cairo University (2021). >>> Class representative of CMP 2021. >>> https://www.linkedin.com/in/yosrym93/ >>> >> >> >> -- >> Thanks and Regards, >> Aditya Toshniwal >> Software Engineer | EnterpriseDB India | Pune >> "Don't Complain about Heat, Plant a TREE" >> > > > -- > *Yosry Muhammad Yosry* > > Computer Engineering student, > The Faculty of Engineering, > Cairo University (2021). > Class representative of CMP 2021. > https://www.linkedin.com/in/yosrym93/ > -- *Thanks & Regards* *Akshay Joshi* *Sr. Software Architect* *EnterpriseDB Software India Private Limited* *Mobile: +91 976-788-8246*

Re: [GSoC] Query History Upgrade

2019-08-14 Thread Akshay Joshi
s been created to track it. On Wed, Aug 14, 2019 at 1:39 PM Yosry Muhammad wrote: > Great! thanks everyone. > > On Wed, Aug 14, 2019, 10:08 AM Akshay Joshi > wrote: > >> Hi Yosry >> >> >> On Tue, Aug 13, 2019 at 6:33 PM Yosry Muhammad >> wrote: &

Re: [GSoC] Query History Upgrade

2019-08-14 Thread Akshay Joshi
On Wed, Aug 14, 2019 at 3:53 PM Yosry Muhammad wrote: > Hi, > > On Wed, Aug 14, 2019 at 12:03 PM Akshay Joshi < > akshay.jo...@enterprisedb.com> wrote: > >> Hi Yosry >> >> I have found following issues: >> >>- Jasmine test cases are failing

Re: [GSoC] Query History Upgrade

2019-08-14 Thread Akshay Joshi
en it is set to "No" it will show queries for second record. On Wed, Aug 14, 2019 at 4:47 PM Yosry Muhammad wrote: > Please find an updated patch attached with the aforementioned issues > fixed. > > On Wed, Aug 14, 2019 at 12:33 PM Akshay Joshi < > akshay.j

pgAdmin 4 commit: Add support in query history to show internal queries

2019-08-16 Thread Akshay Joshi
Add support in query history to show internal queries generated by pgAdmin during save data operations. Fixes #4612 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=687204771ce936697508997fb7988ad8551b9b81 Author: Yosry Muhammad Modified File

Re: [GSoC] Query History Upgrade

2019-08-16 Thread Akshay Joshi
bugs. >> >> On Wed, Aug 14, 2019 at 2:34 PM Akshay Joshi < >> akshay.jo...@enterprisedb.com> wrote: >> >>> Hi Yosry >>> >>> I am still facing following issues: >>> >>>- No icons for already saved(before applying your pa

<    2   3   4   5   6   7   8   9   10   11   >