pgAdmin 4 commit: Rename some internal environment variables that could

2019-12-12 Thread Akshay Joshi
Rename some internal environment variables that could conflict with Kubernetes. Fixes #4999. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=8cb239abcbbc2543a91af8b061a8404364d546ef Author: Dave Page Modified Files -- docs/en_US/

Re: RM4999 - Rename variables that could conflict with Kubernetes

2019-12-12 Thread Akshay Joshi
Dave Page > Blog: http://pgsnake.blogspot.com > Twitter: @pgsnake > > EnterpriseDB UK: http://www.enterprisedb.com > The Enterprise PostgreSQL Company > -- *Thanks & Regards* *Akshay Joshi* *Sr. Software Architect* *EnterpriseDB Software India Private Limited* *Mobile: +91 976-788-8246*

pgAdmin 4 commit: Improved performance while fetching edit types for ea

2019-12-16 Thread Akshay Joshi
Improved performance while fetching edit types for each column. Edit types query is executed for every column when open properties dialog of the table. Change the logic to fetch the edit types for all the distinct column types used in the table at once. Branch -- master Details --- htt

Re: [pgAdmin][RM4988] Refactoring of all the SQL files used by pgAdmin4

2019-12-16 Thread Akshay Joshi
Also, while generating RE-SQL for columns, edit_mode_types.sql will not > be executed. > This will definitely reduce time. > > Kindly review. > > -- > Thanks and Regards, > Aditya Toshniwal > Sr. Software Engineer | EnterpriseDB India | Pune > "Don't Complain about Heat,

pgAdmin 4 commit: Fix an issue where servers.json import fails when run

2019-12-16 Thread Akshay Joshi
Fix an issue where servers.json import fails when running in desktop mode. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=e29ea15554b0939be993f4060246fd15d68fb525 Author: Levitt Olivier Modified Files -- pkg/docker/entrypoint.sh

Re: [Pgadmin] [Docker] servers.json import fails when running in desktop mode

2019-12-16 Thread Akshay Joshi
--user parameter and it successfully imported the > servers.json configuration. > > Should I submit a patch ? First time contributing to Pgadmin :) > Please do. > > > -- > > Thanks & Regards, > > Ashesh Vashi > EnterpriseDB INDIA: Enterprise PostgreSQL Company< &g

pgAdmin 4 commit: 1) Allow screen-reader to read relationship attribute

2019-12-16 Thread Akshay Joshi
1) Allow screen-reader to read relationship attributes for tab, tabpanels and tables under it. Similar changes are done for subnode controls. 2) Add role="img" for font icons. Fixes #4764 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=f1a187

Re: [pgAdmin][RM4764][Accessibility] Allow screen-reader to read relationship attributes in nested elements

2019-12-16 Thread Akshay Joshi
t; 2) Add role="img" for font icons, per - > https://www.w3.org/WAI/WCAG21/Techniques/aria/ARIA24.html > > Kindly review. > > -- > Thanks and Regards, > Aditya Toshniwal > Sr. Software Engineer | EnterpriseDB India | Pune > "Don't Complain about Heat,

pgAdmin 4 commit: Updated node alpine image from 8 to 10.

2019-12-17 Thread Akshay Joshi
Updated node alpine image from 8 to 10. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=584a200bf0ea4683cdc6f3fd2f5781657b795931 Modified Files -- Dockerfile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

pgAdmin 4 commit: Fixed couple of typos for edit types which results in

2019-12-18 Thread Akshay Joshi
Fixed couple of typos for edit types which results in showing proper edit types instead of all data types. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=a6841bb1e18d902a32af36e1dd2ab80120971140 Author: Aditya Toshniwal Modified Files -

Re: [pgAdmin][RM4988] Refactoring of all the SQL files used by pgAdmin4

2019-12-18 Thread Akshay Joshi
ere > displayed in edit table dialog. > Kindly find the patch to fix it. > > On Mon, Dec 16, 2019 at 6:54 PM Akshay Joshi < > akshay.jo...@enterprisedb.com> wrote: > >> Thanks, patch applied. >> >> On Mon, Dec 16, 2019 at 5:40 PM Aditya Toshniwal <

Re: [pgAdmin][RM5017] Use cheroot as default production server

2019-12-19 Thread Akshay Joshi
India | Pune > "Don't Complain about Heat, Plant a TREE" > -- *Thanks & Regards* *Akshay Joshi* *Sr. Software Architect* *EnterpriseDB Software India Private Limited* *Mobile: +91 976-788-8246*

pgAdmin 4 commit: Use cheroot as default production server for pgAdmin4

2019-12-19 Thread Akshay Joshi
Use cheroot as default production server for pgAdmin4. Fixes #5017 If DEBUG is true then we used the default flask server. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=15c518f0f1a299b93676ea4e5d9d9de8a62c32c2 Author: Aditya Toshniwal Modi

pgAdmin 4 commit: Optimized edit types and properties SQL for table/col

2019-12-19 Thread Akshay Joshi
Optimized edit types and properties SQL for table/columns. It is part of #4988. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=4b9bfb2e4ae13a0bc0466def350597c57a05fb0f Modified Files -- .../templates/columns/sql/10_plus/properties

pgAdmin 4 commit: 1) Refactored SQL of Table's and it's child nodes. Fi

2019-12-20 Thread Akshay Joshi
1) Refactored SQL of Table's and it's child nodes. Fixes #4988. 2) Ensure that the error message should not be displayed if Tablespace is not selected while creating the index. Fixes #5008. 3) Fix an issue where operator, access method and operator class is not visible for exclusion constraints.

pgAdmin 4 commit: Refactored SQL of Views and Materialized Views. Fixes

2019-12-20 Thread Akshay Joshi
Refactored SQL of Views and Materialized Views. Fixes #5023. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=f495af7a766713da460d8f1738a13638219f896c Author: Khushboo Vashi Modified Files -- docs/en_US/release_notes_4_17.rst

Re: [pgAdmin4][Patch] - 5023 - Refactoring SQL of View and Materialized View.

2019-12-20 Thread Akshay Joshi
Thanks, patch applied. On Fri, Dec 20, 2019 at 3:40 PM Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi, > > Please find the attached small patch of refactoring SQL of views module. > RM -5023 > > Thanks, > Khushboo > -- *Thanks & Regards* *Aksh

pgAdmin 4 commit: 1) Added aria-label to buttons used in graphical expl

2019-12-30 Thread Akshay Joshi
1) Added aria-label to buttons used in graphical explain plan. 2) Fixed minor issue where we use dialog tab navigator keyboard shortcut only on visible tabs. 3) Fixed an issue where Zoom in, Zoom out, Zoom to original and Download button should not blur the focus after a click on them. Initial p

pgAdmin 4 commit: Refactored SQL of Functions and Procedures. Fixes #50

2019-12-30 Thread Akshay Joshi
Refactored SQL of Functions and Procedures. Fixes #5024. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=cc5c3776cabc4908847256f16b6eefa276761d07 Author: Aditya Toshniwal Modified Files -- docs/en_US/release_notes_4_17.rst

Re: [pgAdmin4][RM#4772] Add aria-label attribute to buttons used in graphical explain plan

2019-12-30 Thread Akshay Joshi
y use dialog tab navigator >> keyboard shortcuts only on visible tabs. >> >> >> -- >> Regards, >> Murtuza Zabuawala >> EnterpriseDB: http://www.enterprisedb.com >> The Enterprise PostgreSQL Company >> >> > > -- > Thanks, > Nagesh > -- *Thanks & Regards* *Akshay Joshi* *Sr. Software Architect* *EnterpriseDB Software India Private Limited* *Mobile: +91 976-788-8246*

Re: [pgAdmin][RM5024] Refactoring SQL of Functions and Procedures.

2019-12-30 Thread Akshay Joshi
Don't Complain about Heat, Plant a TREE" > -- *Thanks & Regards* *Akshay Joshi* *Sr. Software Architect* *EnterpriseDB Software India Private Limited* *Mobile: +91 976-788-8246*

Re: [pgAdmin][RM4842] trigger/compound trigger on a partitioned table

2019-12-30 Thread Akshay Joshi
an be multilevel. > > Kindly review. > > -- > Thanks and Regards, > Aditya Toshniwal > pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune > "Don't Complain about Heat, Plant a TREE" > -- *Thanks & Regards* *Akshay Joshi* *Sr. Software Architect* *EnterpriseDB Software India Private Limited* *Mobile: +91 976-788-8246*

pgAdmin 4 commit: Added tab navigation for tabs under explain panel in

2019-12-31 Thread Akshay Joshi
Added tab navigation for tabs under explain panel in query tool. Fixes #5047. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=fc5287bd9fa8d1b8048094dd90fe37ca6ec8ccdc Author: Ganesh Jaybhay Modified Files -- docs/en_US/release_not

pgAdmin 4 commit: Added aria-label attribute wherever missing for acces

2019-12-31 Thread Akshay Joshi
Added aria-label attribute wherever missing for accessibility. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=8c4dff057fcb44dda760bebe0ae085d0960091ba Author: Nagesh Dhope Modified Files -- web/pgadmin/browser/static/js/toolbar.j

Re: [RM4772] [Accessibility] aria-label in missing places

2019-12-31 Thread Akshay Joshi
Thanks, patch applied. On Tue, Dec 31, 2019 at 7:17 PM Nagesh Dhope wrote: > Hi Hackers, > I have added an aria-label attribute where ever it is missing. PFA for the > same. > > -- > Thanks, > Nagesh > -- *Thanks & Regards* *Akshay Joshi* *Sr. Software Archi

Re: [pgAdmin4][RM#5047] Add tab navigation for tabs under explain panel in query tool

2019-12-31 Thread Akshay Joshi
ndly review. > > Regards, > Ganesh Jaybhay > -- *Thanks & Regards* *Akshay Joshi* *Sr. Software Architect* *EnterpriseDB Software India Private Limited* *Mobile: +91 976-788-8246*

pgAdmin 4 commit: Added support for on-demand loading of items in Selec

2019-12-31 Thread Akshay Joshi
Added support for on-demand loading of items in Select2. Fixes #5038. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=737f8375fb463f1ee4592fb3af2d65bcbf8082a2 Author: Aditya Toshniwal Modified Files -- docs/en_US/release_notes_4_1

Re: [pgAdmin][RM5038] Select2 enhancement - Load items on demand (scroll)

2019-12-31 Thread Akshay Joshi
gt; > -- > Thanks and Regards, > Aditya Toshniwal > pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune > "Don't Complain about Heat, Plant a TREE" > -- *Thanks & Regards* *Akshay Joshi* *Sr. Software Architect* *EnterpriseDB Software India Private Limited* *Mobile: +91 976-788-8246*

pgAdmin 4 commit: Ensure that constraints, indexes, rules, triggers, an

2019-12-31 Thread Akshay Joshi
Ensure that constraints, indexes, rules, triggers, and compound triggers should be created on partitions. Fixes #4842. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=febbd729ec766ff75348924e70a492a697d644fe Author: Aditya Toshniwal Modified

Re: [pgAdmin][RM4842] trigger/compound trigger on a partitioned table

2019-12-31 Thread Akshay Joshi
Hi Aditya I have removed the generated folder and it works. Thanks, patch applied. On Wed, Jan 1, 2020 at 11:58 AM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Akshay, > > On Tue, Dec 31, 2019 at 1:28 PM Akshay Joshi < > akshay.jo...@enterprisedb.com&g

pgAdmin 4 commit: Fix syntax highlighting in code mirror for backslash

2020-01-01 Thread Akshay Joshi
Fix syntax highlighting in code mirror for backslash and escape constant. Fixes #4198. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=964f746d760638a0d1ee42f88a1fc6a249e76fec Author: Aditya Toshniwal Modified Files -- docs/en_US

Re: [pgAdmin][RM4198] Backslash as last char in constant confuses syntax highlighting

2020-01-01 Thread Akshay Joshi
e patch to update the version in pgAdmin to fix syntax > highlighting. > > -- > Thanks and Regards, > Aditya Toshniwal > pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune > "Don't Complain about Heat, Plant a TREE" > -- *Thanks & Regards* *Aksh

[pgAdmin][RM4633] Bad view in partitioned tables

2020-01-03 Thread Akshay Joshi
problems mentioned in the RM. I have fixed the first one and we won't fix the second problem as by design we decided to show Partitions like Schema->Table->Partitions Please review it. -- *Thanks & Regards* *Akshay Joshi* *Sr. Software Architect* *EnterpriseDB Software India

pgAdmin 4 commit: Added code coverage tool for pgAdmin. Fixes #5048.

2020-01-03 Thread Akshay Joshi
Added code coverage tool for pgAdmin. Fixes #5048. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=66f5a40cd9da651a0d4c7d64f4bf9fe9d5076b98 Author: Navnath Gadakh Modified Files -- docs/en_US/release_notes_4_17.rst |

Re: [pgAdmin][RM5048] : code coverage tool

2020-01-03 Thread Akshay Joshi
ture_tests' > With specific module > run 'python runtests.py --pkg browser.server_groups.servers.tests > --coverage' > > Thanks! > -- > *Regards,* > *Navnath Gadakh* > -- *Thanks & Regards* *Akshay Joshi* *Sr. Software Architect* *EnterpriseDB Software India Private Limited* *Mobile: +91 976-788-8246*

pgAdmin 4 commit: Update message catalogs.

2020-01-03 Thread Akshay Joshi
Update message catalogs. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=7668d9af085f4f9f0369eeffefe6c0a1402a4c1a Modified Files -- web/pgadmin/messages.pot | 1019 - .../translations/de/LC_MESSAGES

Translators: Release next week

2020-01-03 Thread Akshay Joshi
Hi Translators, We will have a release next week, so updates to translations before release would be helpful. The template and catalogs have been updated in git. -- *Thanks & Regards* *Akshay Joshi* *Sr. Software Architect* *EnterpriseDB Software India Private Limited* *Mobile: +91 976

pgAdmin 4 commit: Update Japanese translation.

2020-01-05 Thread Akshay Joshi
Update Japanese translation. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=df0f6690fd5bb53eb646d2f03ef5e7ee889f3a6c Author: Identifier Anonymous Modified Files -- .../translations/ja/LC_MESSAGES/messages.mo| Bin 175667 -

pgAdmin 4 commit: Update French translation.

2020-01-05 Thread Akshay Joshi
Update French translation. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=c0532f6d13443eedccfae5e53b42c61f4b1fb84f Author: Fred Escallier Modified Files -- .../translations/fr/LC_MESSAGES/messages.mo| Bin 166126 -> 17845

pgAdmin 4 commit: Update Italian translation.

2020-01-05 Thread Akshay Joshi
Update Italian translation. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=4d53d0eb010f7affb67ef1aa7f21fcc5a02df622 Author: Domenico Sgarbossa Modified Files -- .../translations/it/LC_MESSAGES/messages.mo| Bin 163994 ->

Re: Translators: Release next week

2020-01-05 Thread Akshay Joshi
Thanks, patch applied. On Sat, Jan 4, 2020 at 10:35 PM wrote: > hi > here's French translation update for upcoming release > bye > Fred > > > ------ > *De: *"Akshay Joshi" > *À: *"pgadmin-hackers" > *Envoyé: *

Re: Translators: Release next week

2020-01-05 Thread Akshay Joshi
Thanks, patch applied. On Fri, Jan 3, 2020 at 8:29 PM Domenico Sgarbossa wrote: > Here italian translation files. > Bye > > Sgarbossa Domenico > > > Il venerdì 3 gennaio 2020, 14:36:03 CET, Akshay Joshi < > akshay.jo...@enterprisedb.com> ha scritto: > >

Re: Japanese translation (January 2020)

2020-01-05 Thread Akshay Joshi
Thanks, patch applied. On Sun, Jan 5, 2020 at 6:38 PM fn ln wrote: > Hello. > Updated translation for upcoming version 4.17 is in attachment. > messages.pot was taken from git 7668d9af . > -- *Thanks & Regards* *Akshay Joshi* *Sr. Software Architect* *EnterpriseDB Softwa

pgAdmin 4 commit: Fixed broken tags and tokenizer options of select2. R

2020-01-05 Thread Akshay Joshi
Fixed broken tags and tokenizer options of select2. Regression of #5038 With the change of data adapter, we have configured adapters for tags and tokenizers. We also renamed the method onDemandLoad to showOnScroll to avoid confusion. Branch -- master Details --- https://git.postgresql.o

pgAdmin 4 commit: Added support to view multilevel partitioned tables.

2020-01-06 Thread Akshay Joshi
Added support to view multilevel partitioned tables. Fixes #4633. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=2979424db5c8e43aff4ea77e48b80d9ff52894da Modified Files -- docs/en_US/release_notes_4_17.rst | 1 +

Re: [pgAdmin][RM4633] Bad view in partitioned tables

2020-01-06 Thread Akshay Joshi
On Mon, Jan 6, 2020 at 12:01 PM Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi Akshay, > > On Fri, Jan 3, 2020 at 4:58 PM Akshay Joshi > wrote: > >> Hi Hackers >> >> Attached is the patch to support the view part of the multilevel &

pgAdmin 4 commit: Update version for release.

2020-01-06 Thread Akshay Joshi
Update version for release. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=195e9663dae3ee03771a4c8f9f30598cbcf7e25b Modified Files -- runtime/Info.plist | 4 ++-- runtime/pgAdmin4.pro | 2 +- web/config.py| 4 ++-- 3 files

pgAdmin 4 commit: Ensure that the user should be able to select/modify

2020-01-06 Thread Akshay Joshi
Ensure that the user should be able to select/modify tablespace for the partitioned table on v12 and above. Fixes #4950. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=82c2d5088527b870b98a09f31f2cc5694800f2f0 Modified Files -- do

pgAdmin 4 commit: Fixed linter error.

2020-01-06 Thread Akshay Joshi
Fixed linter error. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=4080511d9d84a80b8a94dd2acfecb61412fd1f31 Modified Files -- .../server_groups/servers/databases/schemas/tables/static/js/table.js | 2 +- 1 file changed, 1 inserti

pgAdmin4 v4.17 candidate builds

2020-01-06 Thread Akshay Joshi
Hi All, pgAdmin4 v4.17 candidate builds and source can be found at https://developer.pgadmin.org/builds/2020-01-06-1/ Fahar, can you please verify it for release on Thursday. -- *Thanks & Regards* *Akshay Joshi* *Sr. Software Architect* *EnterpriseDB Software India Private Limited* *Mo

pgAdmin 4 commit: Fix an issue where the table is not created with auto

2020-01-07 Thread Akshay Joshi
Fix an issue where the table is not created with autovacuum_enabled and  toast.autovacuum_enabled for PG/EPAS 12. Fixes #5068. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=76d04205ef8d6a476502ac400218f0ce073747d4 Modified Files

pgAdmin 4 commit: Remove cheroot server for now until we find a way to

2020-01-07 Thread Akshay Joshi
Remove cheroot server for now until we find a way to shutdown cheroot using REST call. Fixes #5069. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=093d7af748e8726dee218e56cf3196a6fcefa83a Author: Aditya Toshniwal Modified Files

Re: [pgAdmin][RM5069] pgadmin4 server broken with shutdown server

2020-01-07 Thread Akshay Joshi
Regards, > Aditya Toshniwal > pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune > "Don't Complain about Heat, Plant a TREE" > -- *Thanks & Regards* *Akshay Joshi* *Sr. Software Architect* *EnterpriseDB Software India Private Limited* *Mobile: +91 976-788-8246*

Re: pgAdmin4 v4.17 candidate builds

2020-01-07 Thread Akshay Joshi
Hi All, Due to a showstopper issue, we have to regenerate the candidate build. Candidate builds and source can be found at https://developer.pgadmin.org/builds/2020-01-07-1/ Fahar, can you please verify it for release on Thursday. On Mon, Jan 6, 2020 at 7:52 PM Akshay Joshi wrote: > Hi

pgAdmin 4 v4.17 released

2020-01-09 Thread Akshay Joshi
postgresql.org repositories within the next few days. -- Akshay Joshi pgAdmin Project

pgAdmin 4 commit: Tag REL-4_17 has been created.

2020-01-09 Thread Akshay Joshi
Tag REL-4_17 has been created. View: https://git.postgresql.org/gitweb?p=pgadmin4.git;a=tag;h=refs/tags/REL-4_17 Log Message --- Tag v4.17

pgAdmin 4 commit: Fix an issue where select, insert and update scripts

2020-01-09 Thread Akshay Joshi
Fix an issue where select, insert and update scripts on tables throwing an error. Fixes #5074. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=be4b8284c501d0833b147835aa5380cf76840d21 Modified Files -- docs/en_US/release_notes.rst

pgAdmin 4 commit: Improve the test framework to run for multiple classe

2020-01-09 Thread Akshay Joshi
Improve the test framework to run for multiple classes defined in a single file. Fixes #5071. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=ed279cac31575891ab195823cdf2593b1e601871 Author: Pradip Parkale Modified Files -- docs/

Re: [pgAdmin][RM5071]Improve test framework to separate the testcases from multiple class

2020-01-09 Thread Akshay Joshi
Thanks, patch applied. On Wed, Jan 8, 2020 at 1:03 PM Pradip Parkale wrote: > Hi All, > > Attached is patch to separate the testcases from multiple classes. > I've modified the existing testsuite to select and separate the testcase > from multiple classes. > -- *Th

pgAdmin 4 commit: Updated wcDocker package which includes aria-label ac

2020-01-09 Thread Akshay Joshi
Updated wcDocker package which includes aria-label accessibility improvements. Fixes #5072. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=a54efeddfab7da4762d85f30af2d5235b2cf92ab Author: Nagesh Dhope Modified Files -- docs/en_U

Re: Update wcDocker

2020-01-09 Thread Akshay Joshi
Thanks, patch applied. On Wed, Jan 8, 2020 at 12:31 PM Nagesh Dhope wrote: > Created https://redmine.postgresql.org/issues/5072 for the same. > -- *Thanks & Regards* *Akshay Joshi* *Sr. Software Architect* *EnterpriseDB Software India Private Limited* *Mobile: +91 976-788-8246*

pgAdmin 4 commit: 1) Ensure that path file name should not disappear wh

2020-01-09 Thread Akshay Joshi
1) Ensure that path file name should not disappear when changing ext from the dropdown in file explorer dialog. Fixes #3812. 2) Fix column resizable issue in the file explorer dialog. Fixes #4827. Used tablesorter's resizable widget. Branch -- master Details --- https://git.postgresql.o

pgAdmin 4 commit: Added Schema Diff tool to compare two schemas and gen

2020-01-10 Thread Akshay Joshi
Added Schema Diff tool to compare two schemas and generate the difference script. Currently supported objects are Table, View, Materialized View, Function and Procedure. Backend comparison of two schemas implemented by: Akshay Joshi Fixes #3452. Branch -- master Details --- https

pgAdmin 4 commit: Fix an issue where setting STORAGE_DIR to empty shoul

2020-01-12 Thread Akshay Joshi
Fix an issue where setting STORAGE_DIR to empty should show all the volumes on Windows in server mode. Fixes #5025. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=9dccd20bb3617ad9abcc706eb796d9c227b8d7a5 Author: Simon Wimmesberger Modified

pgAdmin 4 commit: Schema Diff Improvements:

2020-01-13 Thread Akshay Joshi
Schema Diff Improvements: 1. Grid header should be center aligned vertically. 2. Increase the space between object counts. 3. The previous selected objects should not be re-selected on comparison. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h

Re: [pgAdmin4][Patch]: RM 5053 - Getting an error while changing the columns in the existing view

2020-01-13 Thread Akshay Joshi
r RM #5053 - Getting an error while > changing the columns in the existing view. > > PostgreSQL doesn't allow to change the view columns. So, while performing > this task the existing view should be dropped first and then recreate it > and also user will get a warning first. > >

Re: [pgAdmin][RM5000] Logout the inactive session

2020-01-15 Thread Akshay Joshi
n the queries complete, the inactivity timer > +# will restart in this case. If set to False, user inactivity may cause > transactions > +# or in-process debugging sessions to be aborted. > +OVERRIDE_USER_INACTIVITY_TIMEOUT = True > > -- > Dave Page > Blog: http://pgsnake.blogspot.com > Twitter: @p

pgAdmin 4 commit: Logout the pgAdmin session when no user activity of m

2020-01-15 Thread Akshay Joshi
Logout the pgAdmin session when no user activity of mouse move, click or keypress. Fixes #5000. Introduced two config params: 1. USER_INACTIVITY_TIMEOUT - Interval in seconds for the timeout. Default is 0-Zero which means disabled. 2. OVERRIDE_USER_INACTIVITY_TIMEOUT - If set to true, tools like

Re: [pgAdmin][RM5000] Logout the inactive session

2020-01-15 Thread Akshay Joshi
view. > > On Wed, Jan 15, 2020 at 2:54 PM Akshay Joshi < > akshay.jo...@enterprisedb.com> wrote: > >> Hi Aditya >> >> We should not detect the user inactivity when SERVER_MODE = False. I have >> tested it with SERVER_MODE = False and it refreshed the comple

pgAdmin 4 commit: Replace node-sass with sass for SCSS compilation. Fix

2020-01-16 Thread Akshay Joshi
Replace node-sass with sass for SCSS compilation. Fixes #5096 This will fix issues reported by the yarn audit. sass is better-maintained library than node-sass. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=e2bfac9e42938af97b091a41f755e3c40

pgAdmin 4 commit: Improve code coverage and API test cases for the CAST

2020-01-16 Thread Akshay Joshi
Improve code coverage and API test cases for the CAST module. Fixes #5049. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=4ab3bbeb82ca282327b1823205f9f9b2376ff396 Author: Yogesh Mahajan Modified Files -- docs/en_US/release_notes_

Re: [pgAdmin][RM5096] Replace node-sass with sass for SCSS compilation

2020-01-16 Thread Akshay Joshi
sues > reported by yarn audit. sass is better maintained library than node-sass. > > Kindly review. > > -- > Thanks and Regards, > Aditya Toshniwal > pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune > "Don't Complain about Heat, Plant a TREE&qu

Re: RM5049 Patch

2020-01-16 Thread Akshay Joshi
t; Added new file (cast_test_cases.json) storing inventory, test, expected >>> data. >>> Also covers test cases for all cast node related api, >>> This increase code coverage for cast from 33% to 68%. >>> >>> Command to run tests - >>> --

Re: [pgAdmin][RM5050] Language node code coverage.

2020-01-16 Thread Akshay Joshi
y --pkg > browser.server_groups.servers.databases.languages.tests > > > -- > Thanks & Regards, > Pradip Parkale > QMG, EnterpriseDB Corporation > -- *Thanks & Regards* *Akshay Joshi* *Sr. Software Architect* *EnterpriseDB Software India Private Limited* *Mobile: +91 976-788-8246*

pgAdmin 4 commit: Updated the incorrect icon used for the cast node on

2020-01-16 Thread Akshay Joshi
Updated the incorrect icon used for the cast node on refresh. Fixes #5065. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=430e9ae994006fa7669a73f60cf523ac6dde12d3 Modified Files -- docs/en_US/release_notes_4_18.rst

pgAdmin 4 commit: Fix an issue where refreshing a package results in th

2020-01-16 Thread Akshay Joshi
Fix an issue where refreshing a package results in the change in the object completely. Fixes #5066. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=af56b92af4630806312ab7c2b8cb3316fc258736 Modified Files -- docs/en_US/release_not

pgAdmin 4 commit: Improve code coverage and API test cases for the LANG

2020-01-19 Thread Akshay Joshi
Improve code coverage and API test cases for the LANGUAGE module. Fixes #5050. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=30b4b5b3491dde285e3fc9bcaf90f8a5bee6245f Author: Pradip Parkale Modified Files -- docs/en_US/release_no

Re: [pgAdmin][RM5050] Language node code coverage.

2020-01-19 Thread Akshay Joshi
Thanks, patch applied. On Mon, Jan 20, 2020 at 11:43 AM Pradip Parkale < pradip.park...@enterprisedb.com> wrote: > Hi Akshay, > > Please find the updated patch. > I have accommodated all the changes mentioned in the review. > > On Thu, Jan 16, 2020 at 5:54 PM Ak

pgAdmin 4 commit: Fixed API test cases for missing language pack and ja

2020-01-20 Thread Akshay Joshi
Fixed API test cases for missing language pack and jasmin test case. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=b4b54d6b9489eee63464ef635b32cc3dc325e198 Modified Files -- .../languages/tests/language_test_data.json| 31

pgAdmin 4 commit: Fixed an issue where Grant wizard unable to handle mu

2020-01-20 Thread Akshay Joshi
Fixed an issue where Grant wizard unable to handle multiple objects when the query string parameter exceeds its limit. Fixes #4511 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=fde8e4054a53560954c858342acb89a33893606a Author: Aditya Toshniwa

Re: [pgAdmin][RM4511] Grant Wizard: Unable to handle multiple objects when query string parameter exceeds its limit

2020-01-20 Thread Akshay Joshi
gt; "Don't Complain about Heat, Plant a TREE" > -- *Thanks & Regards* *Akshay Joshi* *Sr. Software Architect* *EnterpriseDB Software India Private Limited* *Mobile: +91 976-788-8246*

Re: [pgAdmin4][RM#5107] Add tab navigation for tabs under explain panel in query tool

2020-01-22 Thread Akshay Joshi
bhay > -- *Thanks & Regards* *Akshay Joshi* *Sr. Software Architect* *EnterpriseDB Software India Private Limited* *Mobile: +91 976-788-8246*

Re: [pgAdmin][RM4993] [Accessibility] Read-only controls and disabled controls needs to be separately identified

2020-01-22 Thread Akshay Joshi
disabled as it > depends on business logic. The patch is mainly for the properties tab. > > Kindly review. > > -- > Thanks and Regards, > Aditya Toshniwal > pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune > "Don't Complain about Heat,

Re: [pgAdmin][RM4993] [Accessibility] Read-only controls and disabled controls needs to be separately identified

2020-01-22 Thread Akshay Joshi
al > pgAdmin Hacker | Sr. Software Engineer | EnterpriseDB India | Pune > "Don't Complain about Heat, Plant a TREE" > -- *Thanks & Regards* *Akshay Joshi* *Sr. Software Architect* *EnterpriseDB Software India Private Limited* *Mobile: +91 976-788-8246*

pgAdmin 4 commit: Fixed an issue while editing char[] or character vary

2020-01-23 Thread Akshay Joshi
Fixed an issue while editing char[] or character varying[] column from View/Edit data throwing an error.Fixes #4410. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=f5d46bf9f1505f5570aa3e413933c105ce7b33a4 Author: Nick Barnes Modified Files

Re: Error when editing char(n)[] cells

2020-01-23 Thread Akshay Joshi
he same issue reported in #4410 > <https://redmine.postgresql.org/issues/4410>. > > Looks like the cause is a format() template which is using "%s" instead of > "{}", leaving a literal "%s" in the generated SQL. Patch attached. > > Cheers, > Nick >

pgAdmin 4 commit: Added support for a multi-level partitioned table. Fi

2020-01-23 Thread Akshay Joshi
Added support for a multi-level partitioned table. Fixes #2554. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=198063f046f16aaee9f8654a79863f188abd85e1 Modified Files -- docs/en_US/images/table_partition.png | Bin 253

pgAdmin 4 commit: Default tablespace should not be visible for the mult

2020-01-23 Thread Akshay Joshi
Default tablespace should not be visible for the multi-level partitioned table on PG 12 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=4faf14b45ff4878b7fcb1c98235f22c7756a14a7 Modified Files -- .../schemas/tables/templates/partit

pgAdmin 4 commit: 1) Disable Fill Factor and Has OIDs control for the p

2020-01-24 Thread Akshay Joshi
1) Disable Fill Factor and Has OIDs control for the partitioned table. 2) Added reloptions for the partitions and partitioned table. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=6594481992dba7943a49524e0d3f99c026a88d34 Modified Files --

pgAdmin 4 commit: Allow screen-reader to read label & description of no

2020-01-27 Thread Akshay Joshi
Allow screen-reader to read label & description of non-textable elements. Fixes #4762. Allow screen-reader to identify the alert errors. Fixes #4763 Added role alertdialog for confirm and alert dialog. Added role status for all status bars/banners. Added role alert for error bars. Added a

Re: [pgAdmin][RM4763][RM4762] Allow screen readers to identify errors and read description of non-textable elements.

2020-01-27 Thread Akshay Joshi
role *alert* for error bars. > > RM4762 > >- Added *aria-labelledby* for charts on each dashboard, note that I >have also added tabindex for each chart so that it is navigable using tab >key. > > > -- > Thanks, > Nagesh > -- *Thanks & Regards* *A

pgAdmin 4 commit: Fixed following schema diff issues:

2020-01-28 Thread Akshay Joshi
Fixed following schema diff issues: 1) Version mismatch should be displayed if you select EPAS 11 as the source and EPAS 12 as the target. 2) We should handle schema diff if the user stops the server after compare. 3) The data type is not visible for column headers in the query tool/view da

Re: [pgAdmin4][Patch]: Schema Diff Fixes

2020-01-28 Thread Akshay Joshi
m vacuum is disabled > Thanks, > Khushboo > > On Tue, Jan 28, 2020 at 11:33 AM Khushboo Vashi < > khushboo.va...@enterprisedb.com> wrote: > >> Hi, >> >> Please find the attached patch to fix the Schema Diff issues. >> >> Thanks, >> Khushboo >> > -- *Thanks & Regards* *Akshay Joshi* *Sr. Software Architect* *EnterpriseDB Software India Private Limited* *Mobile: +91 976-788-8246*

pgAdmin 4 commit: Improve wordings.

2020-01-28 Thread Akshay Joshi
Improve wordings. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=02f9de5bdba716d5768d2a0e62149818af6ebee4 Modified Files -- .../server_groups/servers/databases/schemas/tables/static/js/table.js | 2 +- web/pgadmin/tools/debugger/

pgAdmin 4 commit: Set proper focus on tab navigation for file manager d

2020-01-30 Thread Akshay Joshi
Set proper focus on tab navigation for file manager dialog. Fixes #5107. Initial patch sent by Ganesh Jaybhay Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=989aa462f77d90d0da07862fc38f220d36135b12 Author: Murtuza Zabuawala Modified Files -

pgAdmin 4 commit: Fixed an issue where logout inactive session did not

2020-01-30 Thread Akshay Joshi
Fixed an issue where logout inactive session did not work when a new tab is opened from the already opened tab. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=75a3e920984eb37616c4bd32356a74ff9e0db247 Author: Aditya Toshniwal Modified Files

Re: [pgAdmin][RM5000] Logout the inactive session

2020-01-30 Thread Akshay Joshi
m the opened > tab. > Attached is the patch to fix the issue. > > On Wed, Jan 15, 2020 at 6:12 PM Akshay Joshi < > akshay.jo...@enterprisedb.com> wrote: > >> Thanks, patch applied. >> >> On Wed, Jan 15, 2020 at 3:18 PM Aditya Toshniwal < >> aditya.toshni..

Re: [pgAdmin4][RM#5107] Add tab navigation for tabs under explain panel in query tool

2020-01-30 Thread Akshay Joshi
stgreSQL Company > > > > On Thu, Jan 23, 2020 at 12:39 PM Akshay Joshi < > akshay.jo...@enterprisedb.com> wrote: > >> Hi Ganesh >> >> Following are the review comments: >> >>- Focus is going on Table headers but it is not visible. >>

Re: [pgAdmin][Accessibility][RM4601] Tab navigation for panel buttons.

2020-01-30 Thread Akshay Joshi
nels, > create/properties dialogs close buttons. Patch also fixes tab navigation > for scroll left and scroll right buttons on main window. > > Note - Currently there is no shortcut added to trigger close/scroll > left/scroll right current panel. > > -- > Thanks, > Nagesh >

pgAdmin 4 commit: Set input controls as read-only instead of disabled w

2020-01-30 Thread Akshay Joshi
Set input controls as read-only instead of disabled will allow tab navigation in the properties tab and also allow screen readers to read it. Fixes #4993 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=0da23b837dc1249aca1218d7417cc2f2b9549a7e

<    6   7   8   9   10   11   12   13   14   15   >