1) Edit cellEditing function, in some cases grid object is undefined.
2) Modify SubNodeCollectionControl, so that user can pass custom backgrid row.
3) Handling of visible parameter in SubNodeCollectionControl.
4) Customise title and delete message for Delete Cell.
5) Added Backgrid.Extension.Selec
Added support of Declarative Partitioning (Range, List) for PostgreSQL 10.
This allows the user to create partitioned table and it's partitions.
- Edit partitions, Create/Listing of constraints, rules, triggers under
partitions. (Implemented by Harshal)
- Updating browser tree node when crea
Fixed issue by adding extra check for 'relkind' column
Branch
--
master
Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=e793413d76a245dfcdb73e37abbf1df6f9676242
Modified Files
--
.../browser/server_groups/servers/databases/schemas/tables/utils.py
Partitioned table does not present in grant wizard. Fixes #2543
Branch
--
master
Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=fae185ff661e4c29de377446736fb798dc5b352e
Modified Files
--
.../templates/grant_wizard/pg/10_plus/sql/table.sql | 20 ++
Hi All
Attached is the patch file to fix the RM #2545, where user will be able to
create partitioned table using 'OF TYPE' feature of table dialog.
--
*Akshay Joshi*
*Principal Software Engineer *
*Phone: +91 20-3058-9517Mobile: +91 976-788-8246*
RM_2545.patch
Description: Binary data
ncate table' and 'reset statistics'.
--
*Akshay Joshi*
*Principal Software Engineer *
*Phone: +91 20-3058-9517Mobile: +91 976-788-8246*
RM_2550.patch
Description: Binary data
Hi
Attached is the patch file to fix RM #2566 Pause/Resume Replay of WAL files
are not working with PostgreSQL 10.
Please review it and let me the comments (if any)
--
*Akshay Joshi*
*Principal Software Engineer *
*Phone: +91 20-3058-9517Mobile: +91 976-788-8246*
RM_2566.patch
Description
call with AlertifyWrapper.
Attached is the POC patch, if it looks good then I'll start working on
replacing AlertifyWrapper with the above mentioned approach.
--
*Akshay Joshi*
*Principal Software Engineer *
*Phone: +91 20-3058-9517Mobile: +91 976-788-8246*
improved_alertify_wrapper.patch
Description: Binary data
it isn't only
> the alertify library, but it's been extended.
>
Thanks, but If I understand to you correctly calling it pgAdminAlertify
will required code changes wherever alertify. is called.
>
> Rob & Sarah
>
> On Thu, Jul 27, 2017 at 9:41 PM, Akshay Joshi &
Hi All
On Fri, Jul 28, 2017 at 1:51 PM, Dave Page wrote:
>
>
> On Thu, Jul 27, 2017 at 2:41 PM, Akshay Joshi <
> akshay.jo...@enterprisedb.com> wrote:
>
>> Hi All
>>
>> As in commit "Update alertify alerts to use the styling defined in
>>
1) Added partition module in webpack config.
2) Fixed missing logic of partition from primary_key.js and
unique_constraint.js as this two files are newly created for webpack.
3) Changed the node name from 'check_constraint' to 'check_constraints'. Also
changed the same in test case url.
Branch
-
Improved alertify notification logic. Remove AlertifyWrapper class and extend
notification methods in alertify itself.
Branch
--
master
Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=e506fa1dbea02f4801c1b916ff23e28f2a302911
Modified Files
--
.../
Domain create dialog do not open and Font size issue in Security label control.
Fixes #2616
Branch
--
master
Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=6717aff8f5f7c782b9d53facb14678b21af9b13e
Author: Murtuza Zabuawala
Modified Files
--
.../
uza Zabuawala
> EnterpriseDB: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
--
*Akshay Joshi*
*Principal Software Engineer *
*Phone: +91 20-3058-9517Mobile: +91 976-788-8246*
Fixed collation tests on Windows, replace use of default 'POSIX' collation with
'C' collation for testing. Fixes #2501
Branch
--
master
Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=bebfc627218eccce596caf8fea69eae14682ca7c
Author: Murtuza Zabuawala
Modifie
for testing, I
> have tested it macOS, Linux & Windows platform the tests are working fine.
> RM#2501
>
> I have also reported bug in Postgres community regarding "POSIX" collation
> issue on Windows.
>
> --
> Regards,
> Murtuza Zabuawala
> EnterpriseDB
Fixed issue in query tool where messages were not displaying from
functions/procedures properly. Fixes #2555
Branch
--
master
Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=ef48c2ed91b023e4075259c3279484b48f437e49
Author: Murtuza Zabuawala
Modified Files
--
reviewed with (Success/Fail/Error scenarios):
> 1) Table output
> 2) Function output
> 3) Procedure output (EPAS)
> 4) Adhoc query output (like vacuum)
>
> --
> Regards,
> Murtuza Zabuawala
> EnterpriseDB: http://www.enterprisedb.com
> The Enterprise PostgreSQL Com
Added missing pgagent file in webpack.config.js Fixes #2617
Branch
--
master
Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=06a65ecf71ccbbfb20cce86ebc1ad0b4b4289cdd
Author: Surinder Kumar
Modified Files
--
web/webpack.config.js | 3 ++-
1 file cha
gt;
> Thanks,
> Surinder
>
--
*Akshay Joshi*
*Principal Software Engineer *
*Phone: +91 20-3058-9517Mobile: +91 976-788-8246*
Set the database name to blank('') when job type is set to batch, while
creating pgAgent job. Fixes #2620
Branch
--
master
Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=801a05891e94304d267e91adb98a92b5d8ea48cd
Modified Files
--
.../server_groups
x27;::bpchar
> OR jstdbname = ''::name AND (jstkind = 'b'::bpchar OR jstconnstr <> ''
> ::text))
>
> Please find attached patch and review.
>
> Thanks,
> Surinder
>
>
--
*Akshay Joshi*
*Principal Software Engineer *
*Phone: +91 20-3058-9517Mobile: +91 976-788-8246*
Changed the mapping of cell from 'numeric' to 'integer' for integer control as
numeric cell has been removed from the code. Fixes #2631
Branch
--
master
Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=e418cb838730ce186c620cdf39c064eca02a7d61
Modified Files
--
Use dict based data instead of 2d-array in Type module as we are adding keys on
the fly.
Reviewed By: Harshal Dhumal
Branch
--
master
Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=2c6c4a16cecd8586c9ee5c9fa8456b6074813f46
Author: Murtuza Zabuawala
Modified
lt;http://www.enterprisedb.com/>
>>
>>
>> *http://www.linkedin.com/in/asheshvashi*
>> <http://www.linkedin.com/in/asheshvashi>
>>
>>>
>>> --
>>> Regards,
>>> Murtuza Zabuawala
>>> EnterpriseDB: http://www.enterprisedb.com
>>> The Enterprise PostgreSQL Company
>>>
>>
>>
>
--
*Akshay Joshi*
*Principal Software Engineer *
*Phone: +91 20-3058-9517Mobile: +91 976-788-8246*
1) Connection Type cell was not honouring to 'Kind' option in Subnode control.
2) Kind option was not saved properly
3) User was not be able to update Kind option in edit mode.
Fixes #2633
Branch
--
master
Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=2df462
terprisedb.com
> The Enterprise PostgreSQL Company
>
> [image: https://community.postgresrocks.net/]
> <https://community.postgresrocks.net/>
>
--
*Akshay Joshi*
*Principal Software Engineer *
*Phone: +91 20-3058-9517Mobile: +91 976-788-8246*
Fixed the path reference of load-node.gif which was referencing to vendor
directory. Fixes #2646
Branch
--
master
Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=bff48e0b2de6ba7e63f1f3ee8ae6cadfabf75938
Author: Surinder Kumar
Modified Files
--
we
ead of referencing to static/js/generated/load-node.gif.
>
> Fixed the reference path, now it points to static/js/generated/laod-node.
> gif.
>
> Please find attached patch and review.
>
> Thanks,
> Surinder
>
>
--
*Akshay Joshi*
*Principal Software Engineer *
*Phone: +91 20-3058-9517Mobile: +91 976-788-8246*
an empty value is set into the model, So, added a
> check to remove the model attribute if the field is an empty string before
> data is sent to the server.
>
> Please find attached patch.
>
> Thanks,
> Surinder
>
--
*Akshay Joshi*
*Principal Software Engineer *
*Phone: +91 20-3058-9517Mobile: +91 976-788-8246*
Unset compression ratio if it is an empty string in Backup module. Fixes #2582
Branch
--
master
Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=c7686dee054ef8a77ace02c1c4e4eed65a475602
Author: Surinder Kumar
Modified Files
--
web/pgadmin/tools/bac
Fixed alertify notification messages where checkmark box disconnected from
frame. Fixes #2644
Branch
--
master
Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=dee5186f655b46ac239a504d676c571e1e071d20
Author: Sarah McAlear
Modified Files
--
web/pg
>>>>>>>>>> set
>>>>>>>>>>>> refresh rate to 1 for all dashboard graphs and repeat the steps.
>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>>>>>>> Thanks,
>>>>>>>>>>>>>
>>>>>>>>>>>>> Wenlin &Violet
>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>>>>>>> On Mon, Aug 7, 2017 at 2:30 PM, Surinder Kumar <
>>>>>>>>>>>>> surinder.ku...@enterprisedb.com> wrote:
>>>>>>>>>>>>>
>>>>>>>>>>>>>> Hi
>>>>>>>>>>>>>> Review comments:
>>>>>>>>>>>>>>
>>>>>>>>>>>>>>1.
>>>>>>>>>>>>>>
>>>>>>>>>>>>>>For consistency, we use two spaces for indentation in CSS
>>>>>>>>>>>>>>files. Four spaces are used in _dashboard.scss file. The
>>>>>>>>>>>>>>configurations are defined in web/.editorconfig file.
>>>>>>>>>>>>>>2.
>>>>>>>>>>>>>>
>>>>>>>>>>>>>>In,dashboard.css Can we return function object in return
>>>>>>>>>>>>>>instead of function class itself, this will eliminate the
>>>>>>>>>>>>>> need of creating
>>>>>>>>>>>>>>function object every time we use info and error?
>>>>>>>>>>>>>>3.
>>>>>>>>>>>>>>
>>>>>>>>>>>>>>On Dashboard, I can see Postgres icon is misaligned
>>>>>>>>>>>>>>compared to other icons in Getting Started section. It is
>>>>>>>>>>>>>>not related to this patch. adjusting margin top will fix it.
>>>>>>>>>>>>>>4.
>>>>>>>>>>>>>>
>>>>>>>>>>>>>>I tried to test out Error message displayed, but I
>>>>>>>>>>>>>>encounter an error(screenshot attached).
>>>>>>>>>>>>>>Steps to reproduce:
>>>>>>>>>>>>>> - Open pgAdmin4 in browser
>>>>>>>>>>>>>> - Connect to PostgreSQL Server, Keep dashboard tab
>>>>>>>>>>>>>> open.
>>>>>>>>>>>>>> - Navigate to the database which is connected.
>>>>>>>>>>>>>> - Now disconnect pgAdmin4 python server.
>>>>>>>>>>>>>>
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> Here I mean Stop Python server. I
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>>>>>>>>1.
>>>>>>>>>>>>>> -
>>>>>>>>>>>>>> - No error message is displayed on Dashboard because
>>>>>>>>>>>>>> it breaks in JS as xhr.responseText is empty.
>>>>>>>>>>>>>> However, it might be an existing issue.
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> Thanks,
>>>>>>>>>>>>>> Surinder
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> On Mon, Aug 7, 2017 at 10:40 AM, Wenlin Zhang <
>>>>>>>>>>>>>> wzh...@pivotal.io> wrote:
>>>>>>>>>>>>>>
>>>>>>>>>>>>>> Hi Ashesh,
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>> That's correct. This patch just changed alert style in
>>>>>>>>>>>>>>> the 'tabs', such as Dependency and Dependents.
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>> Thanks
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>> Wenlin
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>> On Mon, Aug 7, 2017 at 12:51 PM, Ashesh Vashi <
>>>>>>>>>>>>>>> ashesh.va...@enterprisedb.com> wrote:
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>> Surinder,
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>> Please take a look at this patch.
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>> If I recalls correctly, this patch is related to styling of
>>>>>>>>>>>>>>>> the 'tabs' shown on the main window.
>>>>>>>>>>>>>>>> Wenlin - please correct me if my understanding is wrong.
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>> --
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>> Thanks & Regards,
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>> Ashesh Vashi
>>>>>>>>>>>>>>>> EnterpriseDB INDIA: Enterprise PostgreSQL Company
>>>>>>>>>>>>>>>> <http://www.enterprisedb.com>
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>> *http://www.linkedin.com/in/asheshvashi*
>>>>>>>>>>>>>>>> <http://www.linkedin.com/in/asheshvashi>
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>> On Mon, Aug 7, 2017 at 8:11 AM, Sarah McAlear <
>>>>>>>>>>>>>>>> smcal...@pivotal.io> wrote:
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>> Hi hackers,
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>> Could you please review this patch?
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>> Thanks
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>> Wenlin and Sarah
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>> On Wed, Aug 2, 2017 at 2:15 PM, Wenlin Zhang <
>>>>>>>>>>>>>>>>> wzh...@pivotal.io> wrote:
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>> Hi Hackers,
>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>> This patch changes the alert style in the sub-navigation
>>>>>>>>>>>>>>>>>> to match style guide.
>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>> Thanks,
>>>>>>>>>>>>>>>>>> Wenlin, Shirley & Sarah
>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>>
>>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>
>>>>>>>>
>>>>>>>
>>>>>>
>>>>>
>>>>
>>>
>>
>
--
*Akshay Joshi*
*Principal Software Engineer *
*Phone: +91 20-3058-9517Mobile: +91 976-788-8246*
User can not add New Server through Quick links. Fixes #2634
Branch
--
master
Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=e9b80dae9c0dc3e054512c16b4c38a98c8980c93
Author: Murtuza Zabuawala
Modified Files
--
.../browser/server_groups/servers/ro
erprisedb.com%5D(mailto:murtuza.zabuaw...@enterprisedb.com)>
>> wrote:
>>
>> Hi,
>>>
>>> PFA minor patch to fix the issue where add new server functionality
>>> through Quick link on Dashboard is broken.
>>> RM#2634
>>>
>>>
Datetimepicker will expand from bottom instead of Top, because of that user
won't be able to select start and end time properly. Fixes #2656
Branch
--
master
Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=cb9a05a7e7fb09b39afffb016b8824074eb325aa
Author: Surin
gt;>
>> Set `Backform.DatetimepickerControl` option `widget positioning >
>> vertical` to `bottom` which ensures Datepicker widget expands to bottom
>> whenever it is opened.
>>
>> Please find attached patch and review.
>>
>> Thanks,
>> Surinder
>>
>>
>
--
*Akshay Joshi*
*Principal Software Engineer *
*Phone: +91 20-3058-9517Mobile: +91 976-788-8246*
Syntax error while saving changes for start/end time, weekdays, monthdays,
month, hours, minutes while updating the pgAgent Job. Fixes #2657.
Branch
--
master
Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=ee20a10e9410f2ce5024a7b8e4fa758706dc52d0
Author: Suri
rote:
> Hi
>
> *Issues fixed:*
>
> - Syntax error while saving changes when start/end time is updating in
> Edit mode.
> - The data type of `jscstart` should be `timestamptz` not `text`.
>
> Please find attached patch and review.
>
> Thanks,
> Surinder
>
Unable to add/update variables for columns of a table. Fixes #2659
Branch
--
master
Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=fe6e4686a2bf5d9d7db438d209d4d4d6783543ce
Modified Files
--
.../schemas/tables/column/static/js/column.js |
Greenplum specific DDL and Dashboard display changes.
Initial patch by Sarah McAlear.
Branch
--
master
Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=46c5df4e7bb7abba6896cfb86eed43914a74850a
Author: Teng Zhang
Modified Files
--
web/config.py
gt;>>>>>>>>> a gpdb server.
>>>>>>>>>> For this patch specifically, the goal is to improve the
>>>>>>>>>> experience for greenplum users so they can get the same information
>>>>>>>>>> as
>>>>>>>>>> someone connected to a postgres server.
>>>>>>>>>>
>>>>>>>>>> I do agree that this is a bigger discussion about how we handle
>>>>>>>>>> behavior change overall if it's regular postgres or something else.
>>>>>>>>>> Let's
>>>>>>>>>> talk about how we can restructure this behavior in a wider context.
>>>>>>>>>> Are you
>>>>>>>>>> open to meeting about it?
>>>>>>>>>>
>>>>>>>>>> Thanks,
>>>>>>>>>> ~Jing
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>> On Fri, Aug 18, 2017 5:37 AM, Dave Cramer davecra...@gmail.com
>>>>>>>>>> wrote:
>>>>>>>>>>
>>>>>>>>>>> Hi Violet.
>>>>>>>>>>>
>>>>>>>>>>> I don't really like the way this has been implemented. It adds a
>>>>>>>>>>> variable which is only used for gpdb.
>>>>>>>>>>>
>>>>>>>>>>> There are other places in the code where the behaviour is
>>>>>>>>>>> changed if the server is ppas or regular postgres.
>>>>>>>>>>>
>>>>>>>>>>> Candidly I think all of this needs restructuring.
>>>>>>>>>>>
>>>>>>>>>>> Dave Cramer
>>>>>>>>>>>
>>>>>>>>>>> On 15 August 2017 at 23:29, Violet Cheng
>>>>>>>>>>> wrote:
>>>>>>>>>>>
>>>>>>>>>>> Hi,
>>>>>>>>>>>
>>>>>>>>>>> Any comment on this patch? If no, will it be committed soon?
>>>>>>>>>>>
>>>>>>>>>>> Thanks,
>>>>>>>>>>> Violet
>>>>>>>>>>>
>>>>>>>>>>> On Wed, Aug 9, 2017 at 12:05 PM, Sarah McAlear <
>>>>>>>>>>> smcal...@pivotal.io> wrote:
>>>>>>>>>>>
>>>>>>>>>>> Hi Hackers!
>>>>>>>>>>>
>>>>>>>>>>> This patch enables Greenplum users to see the same charts on the
>>>>>>>>>>> dashboard as postgres users. It also adds some additional
>>>>>>>>>>> information to
>>>>>>>>>>> the DDL that is Greenplum specific and necessary to create a new
>>>>>>>>>>> table.
>>>>>>>>>>>
>>>>>>>>>>> Thanks!
>>>>>>>>>>> Sarah
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> --
>>>>>>>>> Dave Page
>>>>>>>>> Blog: http://pgsnake.blogspot.com
>>>>>>>>> Twitter: @pgsnake
>>>>>>>>>
>>>>>>>>> EnterpriseDB UK: http://www.enterprisedb.com
>>>>>>>>> The Enterprise PostgreSQL Company
>>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>
>>>>>>
>>>>>
>>>>
>>>
>>>
>>
>
--
*Akshay Joshi*
*Principal Software Engineer *
*Phone: +91 20-3058-9517Mobile: +91 976-788-8246*
nsertions(+), 39 deletions(-)
>>
>>
>
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
--
*Akshay Joshi*
*Principal Software Engineer *
*Phone: +91 20-3058-9517Mobile: +91 976-788-8246*
Fixed issue where 'backend_type' column is exist for database server version
greater than 10.
Issue is regression of RM #2597.
Branch
--
master
Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=401e13ca650e06f2ee9c2220d0c7b7dcbbcf6dd6
Author: Murtuza Zabuawala
>>>>>>>>>>> On Mon, Jul 24, 2017 at 8:11 PM, Dave Page
>>>>>>>>>>> wrote:
>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>
1) Fixed error in alertify.pgNotifier when server connection is lost.
2) Change styling of alertify.pgNotifier as we did for success, error and info.
Branch
--
master
Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=47cf874460dd0fcd0f39af1772e4ba3913020ee1
Modi
ot;x-pgsql"
>>
>> Regards,
>> Hao Wang & Teng Zhang
>>
>>
>>
>
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
--
*Akshay Joshi*
*Principal Software Engineer *
*Phone: +91 20-3058-9517Mobile: +91 976-788-8246*
Highlighting greenplum keywords in sql editor
Branch
--
master
Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=512afd66182f463e6ce9515910205dcf0221e58c
Author: Teng Zhang
Modified Files
--
web/package.json |
Code looks good to me. Thanks patch applied.
On Mon, Sep 11, 2017 at 5:40 PM, Akshay Joshi wrote:
>
>
> On Mon, Sep 11, 2017 at 5:34 PM, Dave Page wrote:
>
>> Akshay, can you review/commit this please?
>>
>
> Sure Dave.
>
>>
>> Thanks.
>&
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>
>
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
--
*Akshay Joshi*
*Principal Software Engineer *
*Phone: +91 20-3058-9517Mobile: +91 976-788-8246*
Harshal,
Can you please rebase the patch, it's not applied with the latest code.
On Tue, Sep 12, 2017 at 2:37 PM, Akshay Joshi wrote:
>
>
> On Tue, Sep 12, 2017 at 2:34 PM, Dave Page wrote:
>
>> Adding Akshay...
>>
>
> Sure.
>
>>
>>
It works, sorry for the noise.
On Thu, Sep 14, 2017 at 3:48 PM, Akshay Joshi wrote:
> Harshal,
>
> Can you please rebase the patch, it's not applied with the latest code.
>
> On Tue, Sep 12, 2017 at 2:37 PM, Akshay Joshi <
> akshay.jo...@enterprisedb.com> wrote:
&g
Changed array representation and formatting for the data types in Query Tool
and View Data. Fixes #2671
Branch
--
master
Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=30e701607713edc1ba43173556c911c98fc09eb5
Author: Harshal Dhumal
Modified Files
--
[] (alias to
> character and character[] respectively)
> were not taken into consideration in sqleditor.js. I have attached updated
> patch which fixes this issue.
>
>
>
>
>
> --
> *Harshal Dhumal*
> *Sr. Software Engineer*
>
> EnterpriseDB India: http://www.e
"visible: false" from js
file.
--
*Akshay Joshi*
*Principal Software Engineer *
*Phone: +91 20-3058-9517Mobile: +91 976-788-8246*
RM_2691.patch
Description: Binary data
Filtered Rows dialog not opened from the context menu. Fixes #2699
Branch
--
master
Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=fe757c384bac26ca97e7a6c5d735d0b787ad0796
Modified Files
--
web/pgadmin/tools/datagrid/static/js/datagrid.js | 7
Hi
Attached is the patch file to fix RM 2673 "Error not displaying in proper
format in User management and Grant Wizard". Patch contains fix for Grant
Wizard, as fix for user management is already committed.
--
*Akshay Joshi*
*Principal Software Engineer *
*Phone: +91 20-3058-9517M
Hi
Attached is the patch to fix RM 2742 "Unable to connect to database server
with different user and role".
--
*Akshay Joshi*
*Sr. Software Architect *
*Phone: +91 20-3058-9517Mobile: +91 976-788-8246*
RM_2742.patch
Description: Binary data
Hi All
Attached is the patch file to fix RM #2830 "Corrupts type CHAR(4) data".
During that I found one more issue where message "Data saved successfully."
popped up even if there is an error while saving the data. I have fixed
that too.
--
*Akshay Joshi*
*Sr. Software A
Updated colours of tree view icons, which is to be more comfortable in
identifying.
Branch
--
master
Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=2be418706dd2ba86d79d2431b67d47cfd133c6fb
Author: Chethana Kumar
Modified Files
--
.../browser/ser
t;>
>> The Postgres Database Company
>>
>> P: +91 86981 57146 <+91%2086981%2057146>
>> www.enterprisedb.com
>>
>
>
>
> --
> Dave Page
> VP, Chief Architect, Tools & Installers
> EnterpriseDB: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
--
*Akshay Joshi*
*Sr. Software Architect *
*Phone: +91 20-3058-9517Mobile: +91 976-788-8246*
Sporadically crashes on Windows when exit. Fixes #3177
1) Shutdown the python server properly.
2) Disabled "Shutdown server" menu till server is not successfully started.
Initial patch sent by Maxim, modified by Akshay Joshi.
Branch
--
master
Details
---
https://git.post
Fixed PEP8 issue
Branch
--
master
Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=faf243db713970ef6267c972d504e8a64b1df340
Author: Murtuza Zabuawala
Modified Files
--
web/pgadmin/misc/__init__.py | 1 +
1 file changed, 1 insertion(+)
p://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
>
> On Thu, Mar 15, 2018 at 1:27 PM, Akshay Joshi <
> akshay.jo...@enterprisedb.com> wrote:
>
>> Sporadically crashes on Windows when exit. Fixes #3177
>> 1) Shutdown the python server properly.
>&
he front-end and now pass the Explain
>>>>> plan parameters as a JSON object in the start query call.
>>>>> Extract the compile_template_name into a function that can be used
>>>>> by the different places that try to select the version of the template and
>>>>> the server type
>>>>>
>>>>>
>>>>> Thanks
>>>>> Joao
>>>>>
>>>>
>>>>
>>>>
>>>> --
>>>> Dave Page
>>>> Blog: http://pgsnake.blogspot.com
>>>> Twitter: @pgsnake
>>>>
>>>> EnterpriseDB UK: http://www.enterprisedb.com
>>>> The Enterprise PostgreSQL Company
>>>>
>>>
>>>
>>>
>>> --
>>> Dave Page
>>> Blog: http://pgsnake.blogspot.com
>>> Twitter: @pgsnake
>>>
>>> EnterpriseDB UK: http://www.enterprisedb.com
>>> The Enterprise PostgreSQL Company
>>>
>>
>
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
--
*Akshay Joshi*
*Sr. Software Architect *
*Phone: +91 20-3058-9517Mobile: +91 976-788-8246*
the
> patch? What steps are being taken to ensure it's correct and doesn't cause
> regressions?
>
Harshal has already mentioned in the RM. Currently I am changing the
logic, but it may take time to complete, fully test and verify. I'll try my
best to do it asap.
&
Hi Hackers
Attached is the patch file to fix the RM #2815.
On Tue, Mar 20, 2018 at 3:24 PM, Dave Page
wrote:
>
>
> On Tue, Mar 20, 2018 at 9:48 AM, Akshay Joshi <
> akshay.jo...@enterprisedb.com> wrote:
>
>>
>>
>> On Tue, Mar 20, 2018 at 3:06 PM, D
ression/javascript/sqleditor/execute_query_spec.js:12874:56
>> HeadlessChrome 0.0.0 (Mac OS X 10.12.6): Executed 403 of 486 (19 FAILED)
>> (0 secs / 0 secs)
>> HeadlessChrome 0.0.0 (Mac OS X 10.12.6) ExecuteQuery #execute when the
>> SQL statement is not empty wh
On 21 Mar 2018 21:05, "Dave Page" wrote:
We've run into a number of unexpected issues with the v3.0 release that I
think we need to resolve before moving forwards. For the time being, only
patches critical to fix these issues should be committed.
I'll try to look at 1, though I do have another d
; File "C:\Program Files (x86)\pgAdmin
> 4\v3\web\pgadmin\misc\bgprocess\processes.py",
> line 584, in list
> details = desc.details(p.command, args)
> File "C:\Program Files (x86)\pgAdmin
> 4\v3\web\pgadmin\tools\backup\__init__.py",
> line 190, in details
> res += html.safe_str(cmd + self.cmd)
> AttributeError: 'BackupMessage' object has no attribute 'cmd'
>
>
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
--
*Akshay Joshi*
*Sr. Software Architect *
*Phone: +91 20-3058-9517Mobile: +91 976-788-8246*
e long
> term.
>
Option 2 seems good to me.
>
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
--
*Akshay Joshi*
*Sr. Software Architect *
*Phone: +91 20-3058-9517Mobile: +91 976-788-8246*
On Thu, Mar 22, 2018 at 3:22 PM, Dave Page wrote:
> Hi
>
> On Thu, Mar 22, 2018 at 9:21 AM, Akshay Joshi <
> akshay.jo...@enterprisedb.com> wrote:
>
>> Hi Dave
>>
>> On Wed, Mar 21, 2018 at 9:05 PM, Dave Page wrote:
>>
>>> We've run in
is what we want of course, macOS is causing the new
> instance to exit before it has a change to open a new pgAdmin window. Using
> "open -n ..." or calling the embedded executable directly resolves that
> issue.
>
> So, there's another challenge to figure out... :-(
>
OK. Will try to figure that out.
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
--
*Akshay Joshi*
*Sr. Software Architect *
*Phone: +91 20-3058-9517Mobile: +91 976-788-8246*
Hi Dave
On Fri, Mar 23, 2018 at 11:06 AM, Akshay Joshi <
akshay.jo...@enterprisedb.com> wrote:
>
>
> On Thu, Mar 22, 2018 at 10:24 PM, Dave Page wrote:
>
>> Hi
>>
>> On Thu, Mar 22, 2018 at 1:13 PM, Dave Page wrote:
>>
>>>
>>>>>
Hi Hackers,
Please find the attached patch to fix RM #3090 pgadmin shows misleading
"Query returned successfully" with incorrect SQL.
--
*Akshay Joshi*
*Sr. Software Architect *
*Phone: +91 20-3058-9517Mobile: +91 976-788-8246*
RM_3090.patch
Description: Binary data
;Not connected to the server .", but the stack
trace is same that was mentioned in the RM.
>
> Thanks
> Victoria & Joao
>
> On Mon, Mar 26, 2018 at 9:00 AM Dave Page wrote:
>
>> Thanks, applied.
>>
>> On Mon, Mar 26, 2018 at 11:43 AM, Akshay Joshi &
gt;
>
> As an aside sniping bugs is fine in some situations but as a general rule
> of thumb is a bad approach and creates a blob of code that no one can
> manage. A situation like this look like a very promising candidate for
> extraction/refactoring in our point of view. In wh
nds the
>> textarea inside it.
>>
>> I'm attaching my patch as bug3083.diff below as per the contribution
>> guidelines.
>>
>> Hope this helps. Thank you for your consideration!
>>
>> Sincerely,
>> Neethu Mariya Joy
>> GitHub <https:
h the pipelines and all of the tests passed.
>
> Sincerely,
>
> Joao and Victoria
>
> On Wed, Mar 28, 2018 at 8:03 AM Akshay Joshi <
> akshay.jo...@enterprisedb.com> wrote:
>
>> Hi
>>
>> On Fri, Mar 2, 2018 at 3:40 AM, Joao De Almeida Pereira &l
Hi Hackers,
Please find the attached patch to fix RM #3180 Index node is missing from
the tree view of the table node. This is a regression of one of the older
commit.
--
*Akshay Joshi*
*Sr. Software Architect *
*Phone: +91 20-3058-9517Mobile: +91 976-788-8246*
RM_3180.patch
Description
released by psycopg2, we will
work on this feature again and modified the code. I'll update the RM
accordingly.
Suggestion/ Comments?
--
*Akshay Joshi*
*Sr. Software Architect *
*Phone: +91 20-3058-9517Mobile: +91 976-788-8246*
atel
>
>
>
> On Wed, Mar 21, 2018 at 2:08 PM, Dave Page wrote:
>
>> Fix a number of broken connection detection scenarios.
>>
>> Branch
>> --
>> master
>>
>> Details
>> ---
>> https://git.postgresql.org/gitweb?p=pgadm
Hi Hackers,
Please find the attached patch to fix RM #3227 pgadmin4 crashed on Windows
If admin user name contains spaces.
--
*Akshay Joshi*
*Sr. Software Architect *
*Phone: +91 20-3058-9517Mobile: +91 976-788-8246*
RM_3227.patch
Description: Binary data
parameter
in config.py which checks the python version and set the flag accordingly.
In case of Python 2.6, 3.0, 3.1, 3.2 and 3.3 control on the "SSH Tunnel"
tab of server dialog will be disabled.
Please review it, and if looks good please commit the code.
--
*Akshay Joshi*
*Sr
gt;
>>
>> Anthony and Victoria
>>
>> On Thu, Apr 19, 2018 at 1:48 AM, Akshay Joshi <
>> akshay.jo...@enterprisedb.com> wrote:
>>
>>> Hi Hackers
>>>
>>> I have implemented the SSH Tunnel support using https://pypi.org/project
>>
geckodriver to /usr/local/bin or the path of the
geckodriver must be specified in PATH.
- Apply the attached patch.
- Change the parameter "DEFAULT_TEST_BROWSER = 'Firefox' "
- Start the feature test.
Please review it.
--
*Akshay Joshi*
*Sr. Software Architect *
t; tried to get the address and the server was not running. We saw this
> behavior in Ubuntu.
>
Yes I have faced the same problem in Ubuntu. As per suggestion by Dave I
have added parameter in test_config.json.in and also include the above code
given by Anthony.
Attached is the mod
>>> I'm facing an issue while handling the Browser tree section, It
>>>>>>>>>>>>>> is a wcDocer
>>>>>>>>>>>>>> frame <http://docker.api.webcabin.org/module-wcFrame.html>
>>>>>>>>&g
x27;
>>> buttons in different modules.
>>>
>>> Please review.
>>>
>>> --
>>>
>>> Thanks & Regards,
>>>
>>> Ashesh Vashi
>>> EnterpriseDB INDIA: Enterprise PostgreSQL Company
>>> <http://www.enterprisedb.co
gsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
--
*Akshay Joshi*
*Sr. Software Architect *
*Phone: +91 20-3058-9517Mobile: +91 976-788-8246*
Close button added to the alertify message box, which pops up in case of
backend error. Fixes #3290
Branch
--
master
Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=b653b742ede0e6d30ebb4ec03b8cbb2e0f993478
Author: Ashesh Vashi
Modified Files
--
w
Thanks patch applied
On Tue, Apr 24, 2018 at 2:29 PM, Akshay Joshi wrote:
>
>
> On Tue, Apr 24, 2018 at 1:47 PM, Dave Page wrote:
>
>> Akshay, can you review/commit this please?
>>
>
>Sure.
>
>>
>> Thanks.
>>
>> On Mon, Apr 2
through the code.
>
> I'd like to see end-to-end testing for regression sake, but it's hard to
> so at this moment.
>
> - Anthony and Joao.
>
> On Mon, Apr 23, 2018 at 5:09 AM, Akshay Joshi <
> akshay.jo...@enterprisedb.com> wrote:
>
>>
>>
>>
rn.
>
Please elaborate more with respect to my patch, which part of code
should required modification?
>
> Thanks
> Victoria & Joao
>
>
> On Tue, Apr 24, 2018 at 10:13 AM Akshay Joshi <
> akshay.jo...@enterprisedb.com> wrote:
>
>> Hi Hackers
>>
>&g
Fixed display SQL of table with index for GreenPlum database. Fixes #3306
Branch
--
master
Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=2ace6a60f3d16a0202b8ef8fdeb5218846e2bc0e
Author: Joao De Almeida Pereira
Modified Files
--
docs/en_US/releas
Thanks patch applied.
On Tue, Apr 24, 2018 at 2:29 PM, Akshay Joshi wrote:
>
>
> On Tue, Apr 24, 2018 at 1:19 PM, Dave Page wrote:
>
>> Akshay, can you review/commit this please? (and update the release notes)
>>
>
>Sure.
>
>>
>> On Mon, Apr
Fixed issue where icon for Partitioned tables was the same as Non Partitioned
tables for GreenPlum database. Fixes #3308
Branch
--
master
Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=966279c1b3cc9137ed6bb7ba21e76d0981178b3c
Author: Joao De Almeida Pereira
;? If yes then according to me it's
valid because for partitions we only override the icon with the partition
one. Please correct me if I am wrong.
>
>
> Thanks
> Victoria & Joao
>
--
*Akshay Joshi*
*Sr. Software Architect *
*Phone: +91 20-3058-9517Mobile: +91 976-788-8246*
efactoring of the keyboard.js file(some one letter variables
>>> and other code)
>>>
>>>
>>>
>>> Thanks
>>> Joao
>>>
>>> On Thu, Apr 26, 2018 at 5:34 AM Khushboo Vashi <
>>> khushboo.va...@enterprisedb.com> wrote:
&g
F5 key should work to refresh Browser tree. Fixes #3284
Refactoring by: Joao Pedro De Almeida Pereira
Branch
--
master
Details
---
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=732d8d903dc76eef22b83a8eb01ed754ba877f31
Author: Khushboo Vashi
Modified Files
1 - 100 of 5195 matches
Mail list logo
