[pgAdmin][RM6586] Wrong SQL / Drop down getting generated for tablespace

2021-07-27 Thread Aditya Toshniwal
Hi Hackers, Attached patch fixes the tablespace related issue. -- Thanks, Aditya Toshniwal pgAdmin hacker | Sr. Software Engineer | *edbpostgres.com* <http://edbpostgres.com> "Don't Complain about Heat, Plant a TREE" RM6586.patch Description: Binary data

[pgAdmin][patch] Incorrect indentation in table python code

2021-07-29 Thread Aditya Toshniwal
Hi Hackers, Attached patch fixes the indentation of a python code which can be a potential bug. Please review. -- Thanks, Aditya Toshniwal pgAdmin hacker | Sr. Software Engineer | *edbpostgres.com* <http://edbpostgres.com> "Don't Complain about Heat, Plant a TREE&qu

Re: [pgAdmin][patch] Incorrect indentation in table python code

2021-07-29 Thread Aditya Toshniwal
Hi Hackers, Please ignore the previous patch. Attached is the updated one. The patch aims - Fix potential buggy code in table python code. On Thu, Jul 29, 2021 at 12:32 PM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > Attached patch fixes the i

Re: [pgAdmin4] Questions about trigger properties's Fires in edit mode

2021-07-29 Thread Aditya Toshniwal
return true; > } else { > return false; > } > } else { > // Check if it is row trigger then enabled it. > var fires_ = m.get('fires'); > if (!_.isUndefined

Re: Translation to pt-BR

2021-08-22 Thread Aditya Toshniwal
; If not, can you send me the links to start to translate? > -- Thanks, Aditya Toshniwal pgAdmin hacker | Sr. Software Engineer | *edbpostgres.com* <http://edbpostgres.com> "Don't Complain about Heat, Plant a TREE"

[pgAdmin][RM6691] Set PSQLRC and PSQL_HISTORY env vars to apt. user storage path in sever mode

2021-08-23 Thread Aditya Toshniwal
Hi Hackers, Please review the attached patch. -- Thanks, Aditya Toshniwal pgAdmin hacker | Sr. Software Engineer | *edbpostgres.com* <http://edbpostgres.com> "Don't Complain about Heat, Plant a TREE" RM6691.patch Description: Binary data

[pgAdmin][RM4264] Make code folding case insensitive

2021-08-23 Thread Aditya Toshniwal
Hi Hackers, The RM 4264 was already fixed with some other patch. However, I noticed that the code folding is case sensitive. If the keywords are in capital letters, only then code folding works. Please review the attached patch which makes the code folding case insensitive. -- Thanks, Aditya

[pgAdmin][RM6531] ERD export as image issue

2021-08-24 Thread Aditya Toshniwal
Hi Hackers, Please review the attached patch which fixes the export image issue where relation lines are over the nodes. -- Thanks, Aditya Toshniwal pgAdmin hacker | Sr. Software Engineer | *edbpostgres.com* <http://edbpostgres.com> "Don't Complain about Heat, Plant a TREE

[pgAdmin][RM4629] Show DB and server information on maintenance process watcher

2021-08-24 Thread Aditya Toshniwal
Hi hackers, Please review the attached patch. -- Thanks, Aditya Toshniwal pgAdmin hacker | Sr. Software Engineer | *edbpostgres.com* <http://edbpostgres.com> "Don't Complain about Heat, Plant a TREE" RM4629.patch Description: Binary data

[pgAdmin][RM6495] ERD 1:M relationship - allow the referenced table to be the same as the local table.

2021-08-24 Thread Aditya Toshniwal
Hi Hackers, Please review the attached patch. -- Thanks, Aditya Toshniwal pgAdmin hacker | Sr. Software Engineer | *edbpostgres.com* <http://edbpostgres.com> "Don't Complain about Heat, Plant a TREE"

Re: [pgAdmin][RM6495] ERD 1:M relationship - allow the referenced table to be the same as the local table.

2021-08-24 Thread Aditya Toshniwal
PFA. :) On Tue, Aug 24, 2021 at 5:11 PM Akshay Joshi wrote: > Hi Aditya > > I think you forgot the attachment. > > On Tue, Aug 24, 2021 at 4:57 PM Aditya Toshniwal < > aditya.toshni...@enterprisedb.com> wrote: > >> Hi Hackers, >> >> Please

[pgAdmin][RM5849] "create or replace" for trigger functions

2021-08-24 Thread Aditya Toshniwal
Hi Hackers, Attached patch will change reverse engineered SQL from "create" to "create or replace" for trigger functions. Please review. -- Thanks, Aditya Toshniwal pgAdmin hacker | Sr. Software Engineer | *edbpostgres.com* <http://edbpostgres.com> "Don'

Re: [pgAdmin][RM4629] Show DB and server information on maintenance process watcher

2021-08-24 Thread Aditya Toshniwal
Hi Hackers, Attached patch fixes the test cases failing because of the previous patch. On Tue, Aug 24, 2021 at 5:12 PM Akshay Joshi wrote: > Thanks, the patch applied. > > On Tue, Aug 24, 2021 at 3:39 PM Aditya Toshniwal < > aditya.toshni...@enterprisedb.com> wrot

Re: [pgAdmin][RM4629] Show DB and server information on maintenance process watcher

2021-08-24 Thread Aditya Toshniwal
Hi Hackers, Please ignore the previous patch. Attached is the updated patch. On Tue, Aug 24, 2021 at 6:28 PM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > Attached patch fixes the test cases failing because of the previous patch. > > On Tue,

Re: [pgAdmin][RM4629] Show DB and server information on maintenance process watcher

2021-08-25 Thread Aditya Toshniwal
Hi Hackers, Attached patch fixes failing RE-SQL test cases. On Wed, Aug 25, 2021 at 11:15 AM Akshay Joshi wrote: > Thanks, the patch applied. > > On Wed, Aug 25, 2021 at 10:44 AM Aditya Toshniwal < > aditya.toshni...@enterprisedb.com> wrote: > >> Hi Hackers, >&

[pgAdmin][RM6419] pgAdmin blank screen issue on windows

2021-08-25 Thread Aditya Toshniwal
Hi Hackers, Attached patch fixes the blank screen issue on windows. I was able to reproduce this on my Windows 10 VM. I've also made changes to use NWjs manifest instead of our pgadmin config json for remembering window sizes. Please review. -- Thanks, Aditya Toshniwal pgAdmin hacker

[pgAdmin][patch] Test case failure fix

2021-08-26 Thread Aditya Toshniwal
Hi Hackers, The behaviour of MagicMock has somehow changed when a new venv is created. The attached patch fixes the test cases for the new behaviour. -- Thanks, Aditya Toshniwal pgAdmin hacker | Sr. Software Engineer | *edbpostgres.com* <http://edbpostgres.com> "Don't Complain a

[pgAdmin][RM2538] Truncate table with restart identity menu

2021-08-26 Thread Aditya Toshniwal
Hi Hackers, Please review the attached patch which adds the truncate table with restart identity menu. -- Thanks, Aditya Toshniwal pgAdmin hacker | Sr. Software Engineer | *edbpostgres.com* <http://edbpostgres.com> "Don't Complain about Heat, Plant a TREE" RM2538.patc

[pgAdmin][patch] Using addEventListener to avoid conflict with jquery.drag

2021-09-01 Thread Aditya Toshniwal
Hi Hackers, Attached is a small patch to avoid a potential conflict with jquery.drag and use addEventListener to bind events. Please review. -- Thanks, Aditya Toshniwal pgAdmin hacker | Sr. Software Engineer | *edbpostgres.com* <http://edbpostgres.com> "Don't Complain about He

[pgAdmin][patch] Min window size for desktop app be 1024x768

2021-09-06 Thread Aditya Toshniwal
Hi Hackers, Attached patch sets the min window size of the NWjs desktop app to be 1024x768. Please review. -- Thanks, Aditya Toshniwal pgAdmin hacker | Sr. Software Engineer | *edbpostgres.com* <http://edbpostgres.com> "Don't Complain about Heat, Plant a TREE"

Re: [pgAdmin][patch] Min window size for desktop app be 1024x768

2021-09-06 Thread Aditya Toshniwal
Attached is the patch :P On Mon, Sep 6, 2021 at 6:14 PM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > Attached patch sets the min window size of the NWjs desktop app to be > 1024x768. > Please review. > > -- > Thanks, > Adity

Re: [pgAdmin][RM2546]: Partitioned table should be created using COLLATE and opclass.

2021-09-07 Thread Aditya Toshniwal
le > Software Engineer | EnterpriseDB Corporation > -- Thanks, Aditya Toshniwal pgAdmin hacker | Sr. Software Engineer | *edbpostgres.com* <http://edbpostgres.com> "Don't Complain about Heat, Plant a TREE"

[pgAdmin][patch] Fix pgAdmin error after react branch merge

2021-09-09 Thread Aditya Toshniwal
Hi Hackers, Please review the attached patch. -- Thanks, Aditya Toshniwal pgAdmin hacker | Sr. Software Engineer | *edbpostgres.com* <http://edbpostgres.com> "Don't Complain about Heat, Plant a TREE" react.theme.servermode.patch Description: Binary data

[pgAdmin][patch] Few missing propTypes

2021-09-09 Thread Aditya Toshniwal
Hi Hackers, Please review the attached patch to add some missing propTypes. -- Thanks, Aditya Toshniwal pgAdmin hacker | Sr. Software Engineer | *edbpostgres.com* <http://edbpostgres.com> "Don't Complain about Heat, Plant a TREE" proptypes.react.patch Description: Binary data

[pgAdmin][patch] ERD table dialog failing to open

2021-09-20 Thread Aditya Toshniwal
Hi Hackers, As the primary key backbone model is removed after porting, ERD table dialog is failing to open. Attached patch will restore the removed model until ERD dialogs are ported to React based view. Please review. -- Thanks, Aditya Toshniwal pgAdmin Hacker | Software Architect

Re: [pgAdmin][patch] ERD table dialog failing to open

2021-09-21 Thread Aditya Toshniwal
Hi, Attached is the patch. :D On Tue, Sep 21, 2021 at 1:21 PM Akshay Joshi wrote: > Hi Aditya > > You forgot to attach the patch. > > On Tue, Sep 21, 2021 at 12:21 PM Aditya Toshniwal < > aditya.toshni...@enterprisedb.com> wrote: > >> Hi Hackers, >>

[pgAdmin][RM6762] Unable to create primary key from Table>Column tab

2021-09-21 Thread Aditya Toshniwal
Hi Hackers, Attached path synchronises the columns primary key flag and primary key constraint. Please review. -- Thanks, Aditya Toshniwal pgAdmin Hacker | Software Architect | *edbpostgres.com* <http://edbpostgres.com> "Don't Complain about Heat, Plant a TREE" RM6

Re: [pgAdmin][patch] ERD table dialog failing to open

2021-09-21 Thread Aditya Toshniwal
Hi, Please find the updated patch. On Tue, Sep 21, 2021 at 2:33 PM Akshay Joshi wrote: > Hi Aditya > > Patch throwing linter error, "Backgrid and Backform are not defined". > > On Tue, Sep 21, 2021 at 1:25 PM Aditya Toshniwal < > aditya.toshni...@e

[pgAdmin][RM6763] Default values are not populated in case of inherited table.

2021-09-21 Thread Aditya Toshniwal
age is changed from Label cannot be empty to Label in Collection cannot be empty for collections. -- Thanks, Aditya Toshniwal pgAdmin Hacker | Software Architect | *edbpostgres.com* <http://edbpostgres.com> "Don't Complain about Heat, Plant a TREE" RM6763.patch Description: Binary data

Re: [pgAdmin][RM6763] Default values are not populated in case of inherited table.

2021-09-21 Thread Aditya Toshniwal
Hi Hackers, Please ignore the previous patch. Attached is the updated patch. On Tue, Sep 21, 2021 at 4:24 PM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > Attached patch fixes: > 1) Make default values column readonly for inherited columns whe

Re: Autovacuum on Toast table

2021-09-21 Thread Aditya Toshniwal
db size > is growing rapidly. I am using the Azure PostgreSQL service. > In the base/parent table dead tuples are zero. Is it possible to run the > vacuum on toast tables?. > > Thanks in advance > > [image: image.png] > -- Thanks, Aditya Toshniwal pgAdmin Hacker | Soft

[pgAdmin][RM6770] Foreign Key multiple fixes

2021-09-21 Thread Aditya Toshniwal
, Aditya Toshniwal pgAdmin Hacker | Software Architect | *edbpostgres.com* <http://edbpostgres.com> "Don't Complain about Heat, Plant a TREE" RM6770.patch Description: Binary data

[pgAdmin][RM6766] Unable to change column properties from edit properties dialogue

2021-09-22 Thread Aditya Toshniwal
Hi Hackers, Attached patch fixes all the column edit related bugs. Please review. -- Thanks, Aditya Toshniwal pgAdmin Hacker | Software Architect | *edbpostgres.com* <http://edbpostgres.com> "Don't Complain about Heat, Plant a TREE" RM6766.patch Description: Binary data

[pgAdmin][RM6778] Properties panel not loaded for catalog tables

2021-09-22 Thread Aditya Toshniwal
Hi Hackers, Attached patch fixes issue where properties panel is not loaded for catalog tables. Please review. -- Thanks, Aditya Toshniwal pgAdmin Hacker | Software Architect | *edbpostgres.com* <http://edbpostgres.com> "Don't Complain about Heat, Plant a TREE"

Re: [pgAdmin][RM6778] Properties panel not loaded for catalog tables

2021-09-22 Thread Aditya Toshniwal
Not again. Attached is the patch. :D On Wed, Sep 22, 2021 at 6:47 PM Akshay Joshi wrote: > Can you please attached the patch :) > > On Wed, Sep 22, 2021 at 6:40 PM Aditya Toshniwal < > aditya.toshni...@enterprisedb.com> wrote: > >> Hi Hackers, >> >> Atta

Re: [pgAdmin][RM6778] Properties panel not loaded for catalog tables

2021-09-22 Thread Aditya Toshniwal
Hi, Attached is the updated patch. On Wed, Sep 22, 2021 at 7:15 PM Akshay Joshi wrote: > Patch not applied, please rebase and send again. > > On Wed, Sep 22, 2021 at 7:00 PM Aditya Toshniwal < > aditya.toshni...@enterprisedb.com> wrote: > >> Not again. Attached is

[pgAdmin][patch] Pin material-ui to v4.11

2021-09-22 Thread Aditya Toshniwal
Hi Hackers, Attached patch will pin material-ui to 4.11 as later versions have some breaking changes. Test cases are also failing because of the latest version. Please review. -- Thanks, Aditya Toshniwal pgAdmin Hacker | Software Architect | *edbpostgres.com* <http://edbpostgres.com>

Re: [pgAdmin][patch] Pin material-ui to v4.11

2021-09-22 Thread Aditya Toshniwal
😓 Attached is the patch. On Thu, Sep 23, 2021 at 11:58 AM Akshay Joshi wrote: > Hi Aditya > > You need a coffee, forgot to attach the patch again :) > > On Thu, Sep 23, 2021 at 11:38 AM Aditya Toshniwal < > aditya.toshni...@enterprisedb.com> wrote: > >> Hi H

Re: [pgAdmin][patch] Pin material-ui to v4.11

2021-09-23 Thread Aditya Toshniwal
Hi Hackers, Please pin @material-ui/lab to 4.0.0-alpha.58 also. Attached is the patch. On Thu, Sep 23, 2021 at 12:15 PM Akshay Joshi wrote: > Thanks, the patch applied. > > On Thu, Sep 23, 2021 at 12:08 PM Aditya Toshniwal < > aditya.toshni...@enterprisedb.com> wrote: >

[pgAdmin][RM6777] Deferrable, deferred, included columns fields are editable in Edit Table > Constraint tab

2021-09-23 Thread Aditya Toshniwal
name is empty. 4. Exclude - Column/Expression has incorrect values. 5. Save should not be enabled when Custom auto-vacuum is enabled but none of the parameters are edited. Please review. -- Thanks, Aditya Toshniwal pgAdmin Hacker | Software Architect | *edbpostgres.com* <http://edbpostgres.

[pgAdmin][RM6772] Modified SQL not loading Unique Constraint dialog

2021-09-23 Thread Aditya Toshniwal
Hi Hackers, Attached patch fixes issue where modified SQL not loading Unique Constraint dialog. Please review. -- Thanks, Aditya Toshniwal pgAdmin Hacker | Software Architect | *edbpostgres.com* <http://edbpostgres.com> "Don't Complain about Heat, Plant a TREE" RM6

[pgAdmin][RM6771] Exclusion Constraint Node fixes

2021-09-23 Thread Aditya Toshniwal
Hi Hackers, Attached patch fixes: 1. Incorrect error message. 2. Properties panel Column Section data missing 3. Operator class value is missing Please review. -- Thanks, Aditya Toshniwal pgAdmin Hacker | Software Architect | *edbpostgres.com* <http://edbpostgres.com> "Don'

[pgAdmin][RM6783] Partition Node related fixes

2021-09-24 Thread Aditya Toshniwal
Hi Hackers, Attached patch fixes: 1. When attaching a partition, tables were not loading in the dropdown. 2. When adding a sub partition in a partition, collations were not loading in dropdown. 3. Fix some grid column widths in table node. Please review. -- Thanks, Aditya Toshniwal pgAdmin

[pgAdmin][patch] UI Improvements

2021-09-27 Thread Aditya Toshniwal
Hi Hackers, Attached patch incorporates: 1. Switch control and CodeMirror control UI improvements for readonly and disabled state. 2. If a form input value changes to null, pass it as an empty string in URL params. Please review. -- Thanks, Aditya Toshniwal pgAdmin Hacker | Software Architect

Re: [pgAdmin][patch] UI Improvements

2021-09-27 Thread Aditya Toshniwal
Hi Hackers, Please find the updated patch with one more improvement - Use server_type instead of type from the server info. On Mon, Sep 27, 2021 at 4:57 PM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > Attached patch incorporates: > 1.

[pgAdmin][RM6814] Server and DB node related fixes

2021-09-28 Thread Aditya Toshniwal
come. 5. Values for parameters should be reset on changing parameter. 6. Added a new key - helpMessageMode which can have a value similar to mode. It will show the help message if mode is supported. -- Thanks, Aditya Toshniwal pgAdmin Hacker | Software Architect | *edbpostgres.com* <h

Re: [pgAdmin][RM6778] Properties panel not loaded for catalog tables

2021-09-28 Thread Aditya Toshniwal
Hi, Attached patch fixes: 1. Make Unlogged switch in table as read only. 2. Fix a console warning when saving node data. On Thu, Sep 23, 2021 at 12:16 PM Akshay Joshi wrote: > Thanks, the patch applied. > > On Thu, Sep 23, 2021 at 10:01 AM Aditya Toshniwal < > aditya.toshni...@e

[pgAdmin][RM6816] Date time control related fixes

2021-09-29 Thread Aditya Toshniwal
Hi Hackers, Attached patch fixes: 1. Date time control not working on firefox. 2. Replace moment with date-fns in date time control as date-fns is more maintained. Please review. -- Thanks, Aditya Toshniwal pgAdmin Hacker | Software Architect | *edbpostgres.com* <http://edbpostgres.com>

[pgAdmin][RM6825] Empty options table node

2021-09-29 Thread Aditya Toshniwal
Hi Hackers, Attached patch removes redundant empty option for Exclusion constraint access method name, Of type and Like relations. Please review. -- Thanks, Aditya Toshniwal pgAdmin Hacker | Software Architect | *edbpostgres.com* <http://edbpostgres.com> "Don't Complain abo

Re: [pgAdmin][RM6825] Empty options table node

2021-09-29 Thread Aditya Toshniwal
Hi, Attached patch fixes jasmine test cases failing because of previous patch. On Wed, Sep 29, 2021 at 3:24 PM Akshay Joshi wrote: > Thanks, the patch applied. > > On Wed, Sep 29, 2021 at 3:09 PM Aditya Toshniwal < > aditya.toshni...@enterprisedb.com> wrote: > >>

Re: [pgAdmin][RM6816] Date time control related fixes

2021-09-30 Thread Aditya Toshniwal
Hi Hackers, Attached is the patch for a few more stability improvements to date time picker. Please review. On Wed, Sep 29, 2021 at 1:44 PM Akshay Joshi wrote: > Thanks, the patch applied. > > On Wed, Sep 29, 2021 at 1:35 PM Aditya Toshniwal < > aditya.toshni...@enterpri

[pgAdmin][patch] Multiple table related fixes

2021-09-30 Thread Aditya Toshniwal
Hi Hackers, Attached patch fixes: 1. File select control sets value for all other to last selected file. Fixes #6814 2. Vacuum parameters related issues. Fixes #6777 3. Exclusion removes all columns if one row is removed. Fixes #6771 Please review. -- Thanks, Aditya Toshniwal pgAdmin Hacker

[pgAdmin][RM6846] Dark theme UI related fixes

2021-10-03 Thread Aditya Toshniwal
Hi Hackers, Attached patch fixes some visibility issues in the dark UI theme. Please review. -- Thanks, Aditya Toshniwal pgAdmin Hacker | Software Architect | *edbpostgres.com* <http://edbpostgres.com> "Don't Complain about Heat, Plant a TREE" RM6846.patch Description: Binary data

[pgAdmin][RM6837] Foreign key issues in edit mode

2021-10-04 Thread Aditya Toshniwal
Hi Hackers, Attached patch fixes: 1. Couple of foreign key issues in edit mode. Fixes #6837 2. Table "Of type" related issues. Fixes #6825 Please review. -- Thanks, Aditya Toshniwal pgAdmin Hacker | Software Architect | *edbpostgres.com* <http://edbpostgres.com> "Don&

[pgAdmin][RM6857] Unique Constraint dialogue > Index dropdown does not have options loaded

2021-10-04 Thread Aditya Toshniwal
Hi Hackers, Please review the attached patch for the fix. -- Thanks, Aditya Toshniwal pgAdmin Hacker | Software Architect | *edbpostgres.com* <http://edbpostgres.com> "Don't Complain about Heat, Plant a TREE" RM6857.patch Description: Binary data

[pgAdmin][patch] Exclusion constraint and vacuum related fixes

2021-10-05 Thread Aditya Toshniwal
Hi Hackers, Please review the attached patch which fixes: 1. Operators dropdown disabled. Fixes #6771. 2. Vacuum options value is not considered for M-SQL when creating. Fixes #6781. -- Thanks, Aditya Toshniwal pgAdmin Hacker | Software Architect | *edbpostgres.com* <http://edbpostgres.

[pgAdmin][patch] Partition node related fixes

2021-10-05 Thread Aditya Toshniwal
Hi Hackers, Please review the attached patch which fixes: 1. Unable to create trigger for partition table. Fixes #6867. 2. Unable to create index, RLS policy, rules, triggers for partition. Fixes #6868. -- Thanks, Aditya Toshniwal pgAdmin Hacker | Software Architect | *edbpostgres.com* <h

Re: [pgAdmin][patch] Partition node related fixes

2021-10-06 Thread Aditya Toshniwal
Hi Hackers, The nodes index, RLS policy, rules, triggers are failing to save for partitions. Please review the attached patch to fix the issue. On Wed, Oct 6, 2021 at 2:54 PM Akshay Joshi wrote: > Thanks, the patch applied. > > On Wed, Oct 6, 2021 at 12:25 PM Aditya Toshniwal < >

Re: [pgAdmin][patch] Partition node related fixes

2021-10-06 Thread Aditya Toshniwal
Hi Hackers, Following the chain, attached patch fixes indexes not loading in Primary constraint and Unique const dialog for partition. On Wed, Oct 6, 2021 at 5:00 PM Akshay Joshi wrote: > Thanks, the patch applied. > > On Wed, Oct 6, 2021 at 4:37 PM Aditya Toshniwal < >

Re: [pgAdmin][RM6081] Advanced table fields in ERD

2021-10-11 Thread Aditya Toshniwal
Hi, Please review the attached patch to fix failing API test case. On Mon, Oct 11, 2021 at 5:44 PM Akshay Joshi wrote: > Thanks, the patch applied. > > On Mon, Oct 11, 2021 at 5:14 PM Aditya Toshniwal < > aditya.toshni...@enterprisedb.com> wrote: > >> Hi Hackers, >

[pgAdmin][RM6900] Unable to create exclusion constraint from table properties

2021-10-12 Thread Aditya Toshniwal
. Please review. -- Thanks, Aditya Toshniwal pgAdmin Hacker | Software Architect | *edbpostgres.com* <http://edbpostgres.com> "Don't Complain about Heat, Plant a TREE" RM6900.patch Description: Binary data

[pgAdmin][RM6891] Composite foreign keys in ERD

2021-10-13 Thread Aditya Toshniwal
Hi Hackers, Please review the attached patch which adds support for composite foreign keys in ERD. -- Thanks, Aditya Toshniwal pgAdmin Hacker | Software Architect | *edbpostgres.com* <http://edbpostgres.com> "Don't Complain about Heat, Plant a TREE" RM6891.patch Description: Binary data

Re: [pgAdmin][RM6891] Composite foreign keys in ERD

2021-10-13 Thread Aditya Toshniwal
Hi, Attached is the updated patch. On Wed, Oct 13, 2021 at 12:53 PM Akshay Joshi wrote: > Hi Aditya > > Jasmine test cases are failing after applying the patch. Can you please > fix and resend it. > > On Wed, Oct 13, 2021 at 12:35 PM Aditya Toshniwal < > aditya.to

Re: [pgAdmin][RM6891] Composite foreign keys in ERD

2021-10-15 Thread Aditya Toshniwal
Hi, The patch fixes the issue where all FKs are removed if one of the multiple FKs on the same column is removed. Please review. On Wed, Oct 13, 2021 at 2:30 PM Akshay Joshi wrote: > Thanks, the patch applied. > > On Wed, Oct 13, 2021 at 1:53 PM Aditya Toshniwal < >

[pgAdmin][RM6929] Error Message displayed if user drag sequence in ERD

2021-10-18 Thread Aditya Toshniwal
Hi Hackers, Please review the attached patch which will not allow one to drop any node except table on ERD. -- Thanks, Aditya Toshniwal pgAdmin Hacker | Software Architect | *edbpostgres.com* <http://edbpostgres.com> "Don't Complain about Heat, Plant a TREE" RM6929.patc

[pgAdmin][RM6935] Wrong SQL generated when modifying existing table in table dialog

2021-10-19 Thread Aditya Toshniwal
Hi Hackers, Attached patch fixes the issue where wrong SQL is generated when deleting and renaming table columns together. Please review. -- Thanks, Aditya Toshniwal pgAdmin Hacker | Software Architect | *edbpostgres.com* <http://edbpostgres.com> "Don't Complain about He

[pgAdmin[patch] Ignore flask-security-too irrelevant vulnerability

2021-10-20 Thread Aditya Toshniwal
- thus making this attack vector mute.* Attached patch will ignore this ID for the audit. -- Thanks, Aditya Toshniwal pgAdmin Hacker | Software Architect | *edbpostgres.com* <http://edbpostgres.com> "Don't Complain about Heat, Plant a TREE" safety-40493.patch Description: Binary data

[pgAdmin][patch] Fix JS audit and ignore devDependencies

2021-10-21 Thread Aditya Toshniwal
Hi Hackers, Attached patch fixs JS audit issues wherever possible and ignores devDependencies from packages.json. Please review. -- Thanks, Aditya Toshniwal pgAdmin Hacker | Software Architect | *edbpostgres.com* <http://edbpostgres.com> "Don't Complain about Heat, Plant a TREE&

Re: [pgAdmin][patch] Fix JS audit and ignore devDependencies

2021-10-21 Thread Aditya Toshniwal
Hi, Attached patch will pin mozjpeg to 7.1.0 as the latest version will require zlib to be re-compiled. On Thu, Oct 21, 2021 at 3:23 PM Akshay Joshi wrote: > Already applied the latest patch that you have sent to me personally. > > On Thu, Oct 21, 2021 at 3:21 PM Aditya

Re: Conditional Tables Feature on PostGresSQL

2021-10-24 Thread Aditya Toshniwal
re that enables the use of conditional tables > on PostGreSQL, specifically the usage of variables, and implementing those > variables in our (complex) queries? > > Thanks, > Sanchari. > > -- Thanks, Aditya Toshniwal pgAdmin Hacker | Software Architect | *edbpostgres.com* <

[pgAdmin][RM6976] Allow large comments and resize textarea

2021-11-04 Thread Aditya Toshniwal
Hi Hackers, Attached patch will allow textrea's to be resized and have more than 255 chars. Please review. -- Thanks, Aditya Toshniwal pgAdmin Hacker | Software Architect | *edbpostgres.com* <http://edbpostgres.com> "Don't Complain about Heat, Plant a TREE" RM6976

[pgAdmin][RM6954] Changing themes does nothing on Windows when system high contrast mode is enabled

2021-11-05 Thread Aditya Toshniwal
Hi Hackers, Attached patch will disable the force-adjust-color of the system theme on pgAdmin. Please review. -- Thanks, Aditya Toshniwal pgAdmin Hacker | Software Architect | *edbpostgres.com* <http://edbpostgres.com> "Don't Complain about Heat, Plant a TREE" RM6954.patc

Re: [pgAdmin4][Patch] - RM 6905 - Impossible to load databases

2021-11-10 Thread Aditya Toshniwal
yarn bundle will be required. >>> Have you done that? >>> >>> Thanks, >>> Khushboo >>> >>> On Wed, Nov 10, 2021 at 5:00 PM Ayad Mohamed >>> wrote: >>> >>>> >>>> Hi Khushboo >>>> >>>> >>>> I patched our pgadmin4 6.1 with your patch but we still have the >>>> problem. >>>> >>>> >>>> regards >>>> >>>> Ayad Mohamed >>>> >>>> >>>> >>>> >>>> >>>> >>>> >>>> >>>> >>>> >>>> >>>> -- >>>> >>>> >>>> Videresendt brev >>>> *Fra*: Khushboo Vashi >>> > >>>> *Til*: pgadmin-hackers >>> > >>>> *Emne*: [pgAdmin4][Patch] - RM 6905 - Impossible to load databases >>>> *Dato*: Wed, 10 Nov 2021 11:06:00 +0530 >>>> >>>> Hi, >>>> >>>> Please find the attached patch to fix the RM #6905 - Impossible to load >>>> databases. >>>> >>>> The database nodes are not getting loaded *behind* *reverse proxy with >>>> SSL*. This issue has been fixed in this patch. >>>> >>>> Note: Yogesh helped me to setup the apache server with reverse proxy >>>> with SSL and to reproduce the issue. >>>> >>>> Thanks, >>>> Khushboo >>>> >>>> -- Thanks, Aditya Toshniwal pgAdmin Hacker | Software Architect | *edbpostgres.com* <http://edbpostgres.com> "Don't Complain about Heat, Plant a TREE"

[pgAdmin][patch] Fix JS audit issues

2021-11-12 Thread Aditya Toshniwal
Hi Hackers, Please review the attached patch. -- Thanks, Aditya Toshniwal pgAdmin Hacker | Software Architect | *edbpostgres.com* <http://edbpostgres.com> "Don't Complain about Heat, Plant a TREE" auditjs.12-nov.patch Description: Binary data

[pgAdmin][RM7044] Upload timeout caused by dropzone lib

2021-11-30 Thread Aditya Toshniwal
Hi Hackers, Attached patch will update the dropzone version to 5.9.3 -- Thanks, Aditya Toshniwal pgAdmin Hacker | Software Architect | *edbpostgres.com* <http://edbpostgres.com> "Don't Complain about Heat, Plant a TREE" RM7044.patch Description: Binary data

Re: [pgAdmin][RM7031]: Database definition wrong

2021-12-01 Thread Aditya Toshniwal
;> Thanks & Regards, >> Pradip Parkale >> Software Engineer | EnterpriseDB Corporation >> > > > -- > *Thanks & Regards* > *Akshay Joshi* > *pgAdmin Hacker | Principal Software Architect* > *EDB Postgres <http://edbpostgres.com>* > > *Mo

[pgAdmin][patch] React based Modal provider to replace Altertify alert

2021-12-02 Thread Aditya Toshniwal
Hi Hackers, Attached patch adds a React based modal provider to pgAdmin. It can be used to create modals on the fly. Based on this, I've created two functions - alert and confirm in the Notifier. This will help to replace Alertify alert and confirm. Please review. -- Thanks, Aditya Tosh

Re: Can't launch setup.py in Docker image - module named 'flask'

2021-12-12 Thread Aditya Toshniwal
On Mon, Dec 13, 2021 at 11:46 AM Alexey Murz Korepov wrote: > ow, sorry, in /venv/bin it works, thanks! > Great !! > > On Mon, Dec 13, 2021 at 9:14 AM Aditya Toshniwal < > aditya.toshni...@enterprisedb.com> wrote: > >> Hey, >> >> >> On Mon, Dec 13

[pgAdmin][RM7020] Status message hides last line of messages when running a query

2021-12-12 Thread Aditya Toshniwal
Hi Hackers, Attached is a tiny patch to change some styles to allow the last line of viewing messages when running a query. -- Thanks, Aditya Toshniwal pgAdmin Hacker | Software Architect | *edbpostgres.com* <http://edbpostgres.com> "Don't Complain about Heat, Plant a TREE

[pgAdmin][RM7071] Confirmation pop up is hidden behind Reassign/Drop Owned Dialogue

2021-12-14 Thread Aditya Toshniwal
Hi Hackers, Attached patch changes the z-index of modal dialogs so that they appear on top. Please review. -- Thanks, Aditya Toshniwal pgAdmin Hacker | Software Architect | *edbpostgres.com* <http://edbpostgres.com> "Don't Complain about Heat, Plant a TREE" RM7071.patc

Re: [patch][pgAdmin] RM7018 [React] Port Restore dialog to React.

2021-12-22 Thread Aditya Toshniwal
>> -- >> *Rahul Shirsat* >> Senior Software Engineer | EnterpriseDB Corporation. >> > > > -- > *Thanks & Regards* > *Akshay Joshi* > *pgAdmin Hacker | Principal Software Architect* > *EDB Postgres <http://edbpostgres.com>* > > *Mobile: +91 976-788-8246* > -- Thanks, Aditya Toshniwal pgAdmin Hacker | Software Architect | *edbpostgres.com* <http://edbpostgres.com> "Don't Complain about Heat, Plant a TREE"

[pgAdmin][patch] Common table styles and other styling improvements

2021-12-24 Thread Aditya Toshniwal
Hi Hackers, Attached patch adds a common table MUI style object which can be used on any table. Added a few more styling improvements. Please review. -- Thanks, Aditya Toshniwal pgAdmin Hacker | Software Architect | *edbpostgres.com* <http://edbpostgres.com> "Don't Complain abo

Re: [pgAdmin][patch] Common table styles and other styling improvements

2021-12-24 Thread Aditya Toshniwal
Sample usage: import { commonTableStyles } from '../Theme'; const tableClasses = commonTableStyles(); On Fri, Dec 24, 2021 at 3:44 PM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > Attached patch adds a common table MUI style object w

Re: [pgAdmin][patch] Common table styles and other styling improvements

2021-12-24 Thread Aditya Toshniwal
Hi, Attached patch fixes the linter issues. On Fri, Dec 24, 2021 at 4:16 PM Akshay Joshi wrote: > Thanks, the patch applied. > > On Fri, Dec 24, 2021 at 3:45 PM Aditya Toshniwal < > aditya.toshni...@enterprisedb.com> wrote: > >> Hi Hackers, >> >> Attac

[pgAdmin][patch] Form Input Select enhancements

2022-01-18 Thread Aditya Toshniwal
Hi Hackers, Attached will add support for grouping in input select boxes and allow setting default selected options. Please review. -- Thanks, Aditya Toshniwal pgAdmin Hacker | Software Architect | *edbpostgres.com* <http://edbpostgres.com> "Don't Complain about He

Re: [pgAdmin][RM-6916]: Allow disabling GPU hardware acceleration

2022-01-18 Thread Aditya Toshniwal
s,* >>>>> *Nikhil Mohite* >>>>> *Senior Software Engineer.* >>>>> *EDB Postgres* <https://www.enterprisedb.com/> >>>>> *Mob.No: +91-7798364578.* >>>>> >>>> >>>> >>>> -- >&g

Re: [pgAdmin][patch] Form Input Select enhancements

2022-01-18 Thread Aditya Toshniwal
Hi Hackers, Please ignore the previous patch. Attached is the updated version. On Tue, Jan 18, 2022 at 4:21 PM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > Attached will add support for grouping in input select boxes and allow > setting defaul

[pgAdmin][RM7142] Warning msg shown after database creation/modification

2022-01-30 Thread Aditya Toshniwal
Hi Hackers, The patch fixes: 1. Warning msg shown after database creation/modification. Fixes #7142. 2. Failing jasmine test cases. 3. Added error boundary to schema view which will improve the exception stack trace details. Please review. -- Thanks, Aditya Toshniwal pgAdmin Hacker | Software

[pgAdmin][RM7154] Layout change is reset on refresh

2022-02-04 Thread Aditya Toshniwal
Hi Hackers, Attached patch fixes a bug where layout is reset if a query tool is opened and pgAdmin is restarted. Please review. -- Thanks, Aditya Toshniwal pgAdmin Hacker | Software Architect | *edbpostgres.com* <http://edbpostgres.com> "Don't Complain about Heat, Plant a TREE

Re: Translations

2022-02-07 Thread Aditya Toshniwal
gt; > Best > > Jan > > > -- > Jan Birk > Høedvej 52 > 4450 Jyderup > Denmark > +45 31 54 64 10 > > -- Thanks, Aditya Toshniwal pgAdmin Hacker | Software Architect | *edbpostgres.com* <http://edbpostgres.com> "Don't Complain about Heat, Plant a TREE"

Re: Translations

2022-02-07 Thread Aditya Toshniwal
n... > > Best > > Jan > > > > On 07.02.2022 11.49, Aditya Toshniwal wrote: > > Hi Jan, > > Please visit - https://www.pgadmin.org/development/translations/ for more > information. > > On Sat, Feb 5, 2022 at 1:30 PM Jan Birk wrote: > >> Hi pgadmin-

Re: Bug #6991 - Suggestion to Contribute Fix

2022-02-08 Thread Aditya Toshniwal
wise be protected by work product immunity or other legal rules. > For more information about how and why we use personal information and who > to contact with any queries about this, please consult our Data Privacy > Policy on https://www.d-fine.com/en_DE/privacy-policy/. > Thank you. > -- Thanks, Aditya Toshniwal pgAdmin Hacker | Software Architect | *edbpostgres.com* <http://edbpostgres.com> "Don't Complain about Heat, Plant a TREE"

Re: show or hide geometry type fields

2022-02-17 Thread Aditya Toshniwal
gt; If it does not exist, where could I change to remove the geometry field > from the lists? > > -- > José Mercedes Venegas Acevedo > cel 955725384 > > > -- Thanks, Aditya Toshniwal pgAdmin Hacker | Software Architect | *edbpostgres.com* <http://edbpostgres.com> "Don't Complain about Heat, Plant a TREE"

Re: [PATCH] Change slash to backslash in make.bat

2022-02-18 Thread Aditya Toshniwal
------ > Although the slash does not affect the compilation, I think it is better > to modify it. > > Here is a patch for make.bat. > Please review. > > Best Regards! > Zhang Jie > -- Thanks, Aditya Toshniwal pgAdmin Hacker | Software Architect | *edbpostgres.com* <http://edbpostgres.com> "Don't Complain about Heat, Plant a TREE"

[pgAdmin][patch] Modal provider improvements

2022-02-23 Thread Aditya Toshniwal
Hi Hackers, Attached patch adds some improvements in the modal provider to make it more re-usable. Please review. -- Thanks, Aditya Toshniwal pgAdmin Hacker | Software Architect | *edbpostgres.com* <http://edbpostgres.com> "Don't Complain about Heat, Plant a TREE" mod

Re: [Patch] Bug #4256 - ALTER DEFAULT PRIVILEGES FOR ROLE some_role REVOKE EXECUTE ON FUNCTIONS FROM PUBLIC:

2022-02-28 Thread Aditya Toshniwal
cipal Software Architect* > *EDB Postgres <http://edbpostgres.com>* > > *Mobile: +91 976-788-8246* > -- Thanks, Aditya Toshniwal pgAdmin Hacker | Software Architect | *edbpostgres.com* <http://edbpostgres.com> "Don't Complain about Heat, Plant a TREE"

[pgAdmin][RM7202] Update requirements for Flask-Security-Too

2022-03-01 Thread Aditya Toshniwal
Hi Hackers, Attached patch will enforce Flask-Security-Too to use the latest version. The current requirement does not completely work. Please review. -- Thanks, Aditya Toshniwal pgAdmin Hacker | Software Architect | *edbpostgres.com* <http://edbpostgres.com> "Don't Complain abo

[pgAdmin][RM7172] Validation error block user from entering input

2022-03-04 Thread Aditya Toshniwal
Hi Hackers, Attached patch will add margin to form when a validation error occurs, so that the user can scroll and enter input. Please review. -- Thanks, Aditya Toshniwal pgAdmin Hacker | Software Architect | *edbpostgres.com* <http://edbpostgres.com> "Don't Complain about He

[pgAdmin][RM7238] ERD: Remove foreign references when table node is removed

2022-03-17 Thread Aditya Toshniwal
Hi Hackers, Attached patch fixes issue where foreign key is not removed even if the referred table is removed in ERD. I have also added a check to not allow duplicate table names. Please review. -- Thanks, Aditya Toshniwal pgAdmin Hacker | Software Architect | *edbpostgres.com* <h

Re: pgAdmin 4 commit: Port preferences dialog to React. Fixes #7149

2022-03-21 Thread Aditya Toshniwal
preferences.py | 20 +- > web/pgadmin/utils/preferences.py | 30 +- > .../components/KeyboardShortcuts.spec.js | 100 +++ > .../javascript/components/QueryThreshold.spec.js | 86 +++ > .../javascript/components/Themes.spec.js | 96 +++ > .

<    5   6   7   8   9   10   11   12   >