the label of the
form control. Below are screenshots.
Attached is the patch for the above changes.
Kindly review.
--
Thanks and Regards,
Aditya Toshniwal
Software Engineer | EnterpriseDB Software Solutions
Pune | Mob - 8055837949
diff --git a/web/pgadmin/static/css/bootstrap.overrides.css b/web
that
> we can keep track of changes, It will be difficult for us to keep track
> of email for the details.
>
> --
> Regards,
> Murtuza Zabuawala
> EnterpriseDB: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
>
> On Wed, Mar 21, 2018 at 2:28 PM, Ad
Hi Team,
PFA patch for RM#3179 where error message was displayed when user selects
the SQL tab for a trigger function.
Fixed the SQL query used to fetch the definition.
--
Thanks and Regards,
Aditya Toshniwal
Software Engineer | EnterpriseDB Software Solutions
Pune | Mob - 8055837949
diff --git
Hi Team,
Please hold on with the patch. Checking if changes are required for PPAS.
Will update soon.
On Thu, Apr 12, 2018 at 12:18 PM, Aditya Toshniwal <
aditya.toshni...@enterprisedb.com> wrote:
> Hi Team,
>
> PFA patch for RM#3179 where error message was displayed when user se
Hi Hackers,
PPAS SQL also needs to changed. PFA updated patch.
On Thu, Apr 12, 2018 at 2:14 PM, Aditya Toshniwal <
aditya.toshni...@enterprisedb.com> wrote:
> Hi Team,
>
> Please hold on with the patch. Checking if changes are required for PPAS.
> Will update soon.
>
>
Hi Khushboo,
Looks like that need to be fixed too. It is not because of the new patch.
Will send you the updated patch.
On Thu, Apr 12, 2018 at 2:47 PM, Khushboo Vashi <
khushboo.va...@enterprisedb.com> wrote:
> Hi Aditya,
>
> On Thu, Apr 12, 2018 at 2:30 PM, Aditya Toshniwal e
Hi Hackers,
PFA updated patch which includes procedure and functions of ppas. Other
nodes works fine.
On Thu, Apr 12, 2018 at 2:59 PM, Aditya Toshniwal <
aditya.toshni...@enterprisedb.com> wrote:
> Hi Khushboo,
>
> Looks like that need to be fixed too. It is not because of the ne
Hi Hackers,
PFA patch for replacing pycrytpo with pycryptodome.
Tested on Postgres 9.6,10 - Windows, Linux.
--
Thanks and Regards,
Aditya Toshniwal
Software Engineer | EnterpriseDB Software Solutions
Pune | Mob - 8055837949
RM_3272.patch
Description: Binary data
Hi,
I am aware of runtime issue, and will be testing in runtime.
Will update on this.
Thanks and Regards,
Aditya Toshniwal
Software Engineer | EnterpriseDB Software Solutions
Pune
On Mon, Apr 23, 2018 at 12:05 PM, Murtuza Zabuawala <
murtuza.zabuaw...@enterprisedb.com> wrote:
>
of
$.ajax call. The XHR is passed and handled in the function itself. Please
note that I have used JSON.parse and not $.parseJSON as it will be
deprecated in jQuery 3.x and thus removing many $.parseJSON calls.
Request you to kindly review.
Thanks and Regards,
Aditya Toshniwal
Software Engineer
Hi Hackers,
PFA patch for query tool keyboard issue where arrow keys were not behaving
as expected for execute options dropdown. Also, corrected couple of
dropdown HTML codes.
Request you to kindly review.
Thanks and Regards,
Aditya Toshniwal
Software Engineer | EnterpriseDB Software Solutions
and Regards,
Aditya Toshniwal
Software Engineer | EnterpriseDB Software Solutions | Pune
"Don't Complain about Heat, Plant a tree"
On Fri, Apr 27, 2018 at 5:34 PM, Dave Page wrote:
>
>
> On Fri, Apr 27, 2018 at 10:49 AM, Murtuza Zabuawala enterprisedb.com> wrote:
>
h. So, gave try by replacing "\/" with "\\" and it worked.
But then this will not work on Unix, and so changed it to [\\\/]+ taking
both styles.
Thanks and Regards,
Aditya Toshniwal
Software Engineer | EnterpriseDB Software Solutions | Pune
"Don't Complain about H
Hi Hackers,
PFA patch for upgrading jQuery version to 3.3.1 from current version
1.12.4. Patch includes replacing deprecated functions of jquery to latest
one.
Kindly review.
Thanks and Regards,
Aditya Toshniwal
Software Engineer | EnterpriseDB Software Solutions | Pune
"Don't Comp
Hi Hackers,
Please hold on with the patch. Will send the updated patch soon.
Apologies.
Thanks and Regards,
Aditya Toshniwal
Software Engineer | EnterpriseDB Software Solutions | Pune
"Don't Complain about Heat, Plant a tree"
On Mon, May 14, 2018 at 12:52 PM, Aditya Toshniwal
Hi Dave,
I suggest check which keyboard you are using, US or UK. If UK, try with US
keyboard.(might work)
Thanks and Regards,
Aditya Toshniwal
Software Engineer | EnterpriseDB Software Solutions | Pune
"Don't Complain about Heat, Plant a tree"
On Tue, May 15, 2018 at 11:35 A
On Tue, May 15, 2018 at 6:05 PM, Dave Page wrote:
> Hi
>
> On Tue, May 15, 2018 at 1:24 PM, Aditya Toshniwal enterprisedb.com> wrote:
>
>> Hi Dave,
>>
>> I suggest check which keyboard you are using, US or UK. If UK, try with
>> US keyboard.(might work)
&g
Hi Hackers,
PFA patch to allow server port number below 1024 till 1 in Create Server
dialog.
Thanks and Regards,
Aditya Toshniwal
Software Engineer | EnterpriseDB Software Solutions | Pune
"Don't Complain about Heat, Plant a tree"
diff --git a/web/pgadmin/browser/server_groups/se
Hi Hackers,
PFA updated patch for RM#3295. The patch is to fix the issue in firefox
also.
Kindly review. Please try in firefox also.
Thanks and Regards,
Aditya Toshniwal
Software Engineer | EnterpriseDB Software Solutions | Pune
"Don't Complain about Heat, Plant a tree"
On Wed, M
changed the code to focus its parent div(#container)
which have the tabindex="0" attribute.
I have added the comments in code also.
Thanks and Regards,
Aditya Toshniwal
Software Engineer | EnterpriseDB Software Solutions | Pune
"Don't Complain about Heat, Plant a tree"
On F
be working. Please note, the same is added to psycopg3
milestones
https://github.com/psycopg/psycopg2/milestone/4
Also fixed a small glitch for sql editor connection status check.
Kindly review.
Thanks and Regards,
Aditya Toshniwal
Software Engineer | EnterpriseDB Software Solutions | Pune
&qu
ains(@class, 'open')]")
File
"/root/.pyenv/versions/pgadmin36/lib/python3.6/site-packages/selenium/webdriver/support/wait.py",
line 80, in until
raise TimeoutException(message, screen, stacktrace)
selenium.common.exceptions.TimeoutException: Message:
Thanks and Reg
Thank you Victoria, Anthony.
Thanks and Regards,
Aditya Toshniwal
Software Engineer | EnterpriseDB Software Solutions | Pune
"Don't Complain about Heat, Plant a tree"
On Tue, May 22, 2018 at 7:15 PM, Victoria Henry wrote:
> Hi Aditya,
>
> We made a minor change to make
Regards,
Aditya Toshniwal
Software Engineer | EnterpriseDB Software Solutions | Pune
"Don't Complain about Heat, Plant a tree"
On Mon, May 14, 2018 at 1:23 PM, Aditya Toshniwal <
aditya.toshni...@enterprisedb.com> wrote:
> Hi Hackers,
>
> Please hold on with the patc
id, tried extracting id
directly, class, but none of them were present in the object.
I can try adding data-test-selector to the HTML5 tag, if it works then will
send the updated patch.
Thanks and Regards,
Aditya Toshniwal
Software Engineer | EnterpriseDB Software Solutions | Pune
"Don't
Hi,
No luck with data-test-selector. :(
I added data-test-selector to html tags. I get undefined for
.data('test-selector') as well as for .attr('data-test-selector').
Thanks and Regards,
Aditya Toshniwal
Software Engineer | EnterpriseDB Software Solutions | Pune
"
Hi Anthony/Joao,
That worked well !! Nice !! ( I am very new to Jasmine tests :P. Need to
dig in. )
Hackers,
Kindly review the patch attached in the trailing mail for RM#3271
Thanks and Regards,
Aditya Toshniwal
Software Engineer | EnterpriseDB Software Solutions | Pune
"Don't Comp
min4 error.
You need to change client_encoding to the appropriate. After changing
client_encoding using command - set client_encoding='XYZ', it will give not
give error.
Thanks and Regards,
Aditya Toshniwal
Software Engineer | EnterpriseDB Software Solutions | Pune
"Don'
Thanks
> Victoria && Joao
>
> On Wed, May 30, 2018 at 3:06 AM Aditya Toshniwal enterprisedb.com> wrote:
>
>> Hi Hackers,
>>
>> PFA updated patch after all the permutations, combinations for encoding
>> for SQL_ASCII database. Also fixed a small glitc
Hi Hackers,
PFA the updated patch on this. I have tried to add test cases to check for
different encoding database. In the test run, it will create a database,
fire a query for a string, check if we get the output and drops the
database.
Kindly review.
Thanks and Regards,
Aditya Toshniwal
Hi Hackers,
I missed one part here. There is a constraint on port in in sqlite config
database also, and is not allowing ports below 1024.
PFA patch - part2 which includes constraint change and migration script for
the db file.
Kindly review.
Thanks and Regards,
Aditya Toshniwal
Software
Missed the attachment. Apologies :(
PFA.
Thanks and Regards,
Aditya Toshniwal
Software Engineer | EnterpriseDB Software Solutions | Pune
"Don't Complain about Heat, Plant a tree"
On Mon, Jun 4, 2018 at 3:12 PM, Aditya Toshniwal <
aditya.toshni...@enterprisedb.com> wrote:
Hi Hackers,
Please ignore previous patch. Fixed some linter issues. PFA updated patch.
Thanks and Regards,
Aditya Toshniwal
Software Engineer | EnterpriseDB Software Solutions | Pune
"Don't Complain about Heat, Plant a tree"
On Mon, Jun 4, 2018 at 10:53 AM, Aditya Toshniwal
simulate the failure on some other machines.
Thanks and Regards,
Aditya Toshniwal
Software Engineer | EnterpriseDB Software Solutions | Pune
"Don't Complain about Heat, Plant a tree"
On Mon, Jun 4, 2018 at 8:54 PM, Joao De Almeida Pereira <
jdealmeidapere...@pivotal.io> wrote:
Hi
On Tue, Jun 5, 2018 at 1:08 AM, Joao De Almeida Pereira <
jdealmeidapere...@pivotal.io> wrote:
> Hello Aditya,
>
>>
>>
>> There is no change related to notifications in this patch.
>> The below code is minor fix related to connection status of sql editor.
>> Can you please share the code snipp
Regards,
Aditya Toshniwal
Software Engineer | EnterpriseDB Software Solutions | Pune
"Don't Complain about Heat, Plant a tree"
diff --git a/web/pgadmin/tools/sqleditor/__init__.py b/web/pgadmin/tools/sqleditor/__init__.py
index 013e4dc..a9460dd 100644
--- a/web/pgadmin/tools/sqleditor/__
Hi Hackers,
PFA updated patch. The sqleditor change is sent separately and removed from
current patch as suggested.
The test cases were running fine when the module was specified using --pkg
but were failing in complete run. Fixed that.
Kindly review.
Thanks and Regards,
Aditya Toshniwal
Hi Dave,
On Tue, Jun 5, 2018 at 4:56 PM, Dave Page wrote:
> Hi
>
> On Tue, Jun 5, 2018 at 9:50 AM, Aditya Toshniwal enterprisedb.com> wrote:
>
>> Hi Hackers,
>>
>> PFA updated patch. The sqleditor change is sent separately and removed
>> from current pat
ase
let me know why that was added.
Will remove the set call and will send you the updated patch if everything
works fine.
Thanks and Regards,
Aditya Toshniwal
Software Engineer | EnterpriseDB Software Solutions | Pune
"Don't Complain about Heat, Plant a tree"
On Tue, Jun 5, 2018 at
Also, there are limitations in psycopg2 as well related to encoding, which
makes it even more difficult to make behaviour similar to pgAdmin3 as there
are encodings and decodings done at pyscopg2 end also.
Thanks and Regards,
Aditya Toshniwal
Software Engineer | EnterpriseDB Software Solutions
Hi
On Tue, Jun 5, 2018 at 6:25 PM, Dave Page wrote:
>
>
> On Tue, Jun 5, 2018 at 1:49 PM, Aditya Toshniwal enterprisedb.com> wrote:
>
>> Hi Dave,
>>
>> The problem of SQL ASCII is solved with the patch, and not related to
>> setting the client encoding of
n python
__init__.py. Can't we move them too ? It would be nicer to not to leave
behind a single js.
Kindly let me know your views on this.
Thanks and Regards,
Aditya Toshniwal
Software Engineer | EnterpriseDB Software Solutions | Pune
"Don't Complain about Heat, Plant a tree"
x will be
considered as a plain string.
INSERT INTO sql_ascii (data) VALUES (E'[Invalid UTF-8] Blob:
\xf4\xa5\xa3\xa5');
Kindly review.
Thanks and Regards,
Aditya Toshniwal
Software Engineer | EnterpriseDB Software Solutions | Pune
"Don't Complain about Heat, Plant a tree&quo
n't we move them too ? It would be nicer to not to leave
>> behind a single js.
>
> I'm not sure what you mean. Could you point to an example of a single js
> file?
>
Sure. I did not find moving
web/pgadmin/tools/datagrid/static/js/datagrid.js. Please correct me if I am
Hi Dave,
On Thu, Jun 7, 2018 at 4:07 PM, Dave Page wrote:
> Hi
>
> On Wed, Jun 6, 2018 at 2:02 PM, Aditya Toshniwal <
> aditya.toshni...@enterprisedb.com> wrote:
>
>> Hi Hackers,
>>
>> PFA updated patch as the previous one was not working as expected. I h
moving
js files, why not this too.
> Sincerely,
>
> Victoria
>
>
>
>
> On Thu, Jun 7, 2018 at 12:35 AM Aditya Toshniwal enterprisedb.com> wrote:
>
>> Hi Victoria,
>>
>> On Wed, Jun 6, 2018 at 8:55 PM, Victoria Henry wrote:
>>
>>> Hi
properly on different browsers.
Request you to kindly suggest if you any better idea.
Thanks and Regards,
Aditya Toshniwal
Software Engineer | EnterpriseDB Software Solutions | Pune
"Don't Complain about Heat, Plant a tree"
Hi Harshal,
On Mon, Jun 11, 2018 at 6:37 PM, Harshal Dhumal <
harshal.dhu...@enterprisedb.com> wrote:
> On Mon, Jun 11, 2018 at 6:02 PM, Aditya Toshniwal enterprisedb.com> wrote:
>
>> Hi Hackers,
>>
>> This is regarding RM3294 which I am working on, where use
Hi Hackers,
PFA updated patch.
On Thu, Jun 7, 2018 at 4:41 PM, Dave Page wrote:
> Hi
>
> On Thu, Jun 7, 2018 at 12:05 PM, Aditya Toshniwal enterprisedb.com> wrote:
>
>> Hi Dave,
>>
>>
>> On Thu, Jun 7, 2018 at 4:07 PM, Dave Page wrote:
>>
>>
I am sorry I missed the attachment. :(
PFA.
On Thu, Jun 14, 2018 at 11:34 AM, Aditya Toshniwal <
aditya.toshni...@enterprisedb.com> wrote:
> Hi Hackers,
>
> PFA updated patch.
>
> On Thu, Jun 7, 2018 at 4:41 PM, Dave Page wrote:
>
>> Hi
>>
>> On Thu,
prefcache_version will increase to current
epoch time. New tab polling can check if the version has increased and can
update its preferences along with prefcache_version.
Please let me know if any suggestions.
> Thanks
> Victoria & Joao
>
--
Thanks and Regards,
Aditya Toshniwal
Software Engineer | EnterpriseDB Software Solutions | Pune
"Don't Complain about Heat, Plant a tree"
Hi Dave,
On Fri, Jun 15, 2018 at 2:08 PM, Dave Page wrote:
> Hi
>
> On Thu, Jun 14, 2018 at 7:05 AM, Aditya Toshniwal enterprisedb.com> wrote:
>
>> I am sorry I missed the attachment. :(
>> PFA.
>>
>
> It looks like the encoding names are getting munged
8 at 2:33 PM, Aditya Toshniwal <
aditya.toshni...@enterprisedb.com> wrote:
> Hi Dave,
>
> On Fri, Jun 15, 2018 at 2:08 PM, Dave Page wrote:
>
>> Hi
>>
>> On Thu, Jun 14, 2018 at 7:05 AM, Aditya Toshniwal <
>> aditya.toshni...@enterprisedb.com> wrote:
Hi Dave,
Attached is the updated patch. (Playing with encodings is not at all fun :(
)
On Tue, Jun 19, 2018 at 2:23 AM, Dave Page wrote:
> Hi
>
> On Mon, Jun 18, 2018 at 2:14 PM, Aditya Toshniwal enterprisedb.com> wrote:
>
>> Hi Hackers,
>>
>> Attached is the
Hi Hackers,
PFA patch to make SQL ASCII related changes compatible with Python 2.6.
Dictionary comprehension is not supported in Python 2.6.
On Thu, Jun 21, 2018 at 6:27 PM, Dave Page wrote:
> Thanks - patch applied!
>
> On Wed, Jun 20, 2018 at 3:17 PM, Aditya Toshniwal enterpr
gt; This error occurs even with the latest pull without changes.
>
>- Set the preferences setting "Open in new browser tab" to True and
>open the query tool. Refer "Open_In_New_Broswer.png".
>
> Will look into this.
> I haven't
Hi Dave,
On Fri, Jun 29, 2018 at 9:30 PM, Dave Page wrote:
> Hi
>
> On Fri, Jun 29, 2018 at 3:14 PM, Aditya Toshniwal enterprisedb.com> wrote:
>
>> Hi Hackers,
>>
>> Attached is the updated patch.
>>
>
> This seems to work for the most part, however
value will still be generated but nothing will be
stored at the backend.
Also, I have separated the garbage collection code in current ping service
to a new url /misc/cleanup. /misc/ping will be purely for is alive check.
Request you to kindly review.
--
Thanks and Regards,
Aditya Toshniwal
min/sessions$
On Mon, Jul 2, 2018 at 8:29 PM, Dave Page wrote:
> Hi
>
> I'm not in a position to test at the moment, but can you confirm this will
> work if the root of pgAdmin is at (for example) /pgadmin? So the actual
> root is /pgadmin/misc/ping ?
>
> On Mon, Ju
org/issues/3294>
patch 0001 which I had sent previously.
Also, fixed a small typo in
pgadmin/utils/preferences.py
Kindly review.
--
Thanks and Regards,
Aditya Toshniwal
Software Engineer | EnterpriseDB Software Solutions | Pune
"Don't Complain about Heat, Plant a tree"
RM3
Hi Hackers,
Attached is the patch to migrate few more occurrences of deprecated
functions of older jQuery versions in pgAdmin4 to jQuery 3 (which were
missed in previous patches of jQuery migration :( ).
Kindly review.
--
Thanks and Regards,
Aditya Toshniwal
Software Engineer | EnterpriseDB
Hi Hackers,
Attached is the fix. It is again related to changed made for RM3294, the
font size was set to 0em. Also included changes to make sure CodeMirror
font size is never set to 0em but to default 1em if font size is not
available from preferences.
--
Thanks and Regards,
Aditya Toshniwal
Hi Hackers,
On Tue, Jul 10, 2018 at 3:37 PM, Dave Page wrote:
> Hi
>
> On Tue, Jul 10, 2018 at 10:36 AM, Aditya Toshniwal enterprisedb.com> wrote:
>
>> Hi Hackers,
>>
>> Attached is the fix. It is again related to changed made for RM3294, the
>> font siz
Hi,
On Tue, Jul 10, 2018 at 4:24 PM, Dave Page wrote:
> I think you forgot the patch :-/
>
Apologies. I know this is annoying :(
PFA.
>
>
> On Tue, Jul 10, 2018 at 11:48 AM, Aditya Toshniwal enterprisedb.com> wrote:
>
>> Hi Hackers,
>>
>> On Tue, Ju
and
small fix in SQL Editor module where the test
case ExtractSQLFromNetworkParametersTest was failing for me due on Python
2.7.
Kindly review.
--
Thanks and Regards,
Aditya Toshniwal
Software Engineer | EnterpriseDB Software Solutions | Pune
"Don't Complain about Heat, Plant a tree
Hi Dave,
On Wed, Jul 18, 2018 at 6:07 PM, Dave Page wrote:
> Hi
>
> On Wed, Jul 18, 2018 at 12:12 PM, Aditya Toshniwal enterprisedb.com> wrote:
>
>> Hi Hackers,
>>
>> Attached is the patch to support INCLUDE clause for indexes which is
>> added fr
modules.
The changes are on the JS side and so patch does not have any test cases
included.
Kindly review.
On Thu, Jul 5, 2018 at 4:09 PM, Dave Page wrote:
> Thanks - patch applied!
>
> On Wed, Jul 4, 2018 at 10:19 AM, Aditya Toshniwal enterprisedb.com> wrote:
>
>> Hi Ha
Adding to previous mail,
I have removed shadow from graph lines and increased resolution for better
visibility and fixed few issues related to graphs.
On Tue, Jul 24, 2018 at 4:09 PM, Aditya Toshniwal <
aditya.toshni...@enterprisedb.com> wrote:
> Hi Hackers,
>
> Attached is the
Hi,
Attached is the updated patch.
On Tue, Jul 24, 2018 at 4:32 PM, Dave Page wrote:
> Hi
>
> On Tue, Jul 24, 2018 at 11:39 AM, Aditya Toshniwal enterprisedb.com> wrote:
>
>> Hi Hackers,
>>
>> Attached is the second part of the changes for making preference
Hi Hackers,
Attached is the updated patch with few more fixes of existing dashboard. Fixed
dashboard reloading even if subnodes under a dashboard or server selected.
On Tue, Jul 24, 2018 at 9:01 PM, Dave Page wrote:
> Thanks, applied.
>
> On Tue, Jul 24, 2018 at 2:11 PM, Aditya
dly review.
--
Thanks and Regards,
Aditya Toshniwal
Software Engineer | EnterpriseDB Software Solutions | Pune
"Don't Complain about Heat, Plant a tree"
RM2136.patch
Description: Binary data
>
This is done.
- The value of the INTERNAL_VERSION_PARAM can be 'ver' or 'v' instead of
> 'intver'.
>
Value set 'ver' for now. We can always change it later and thats why made
it configurable.
>
> Except above the patch looks good
>
>
> On Wed, Aug 15, 2018 at 1:17 PM, Dave Page wrote:
>
>> Hi
>>
>> On Tue, Aug 14, 2018 at 6:41 PM, Aditya Toshniwal <
>> aditya.toshni...@enterprisedb.com> wrote:
>>
>>> Hi Hackers,
>>>
>>> Attached is the updated pat
Hi Hackers,
Attached is minor patch to correctly handle "values" in web/pgadmin/__init__.py
-> strip_version_number which can be None in some cases and will cause
exception when None .
--
Thanks and Regards,
Aditya Toshniwal
Software Engineer | EnterpriseDB Software Solutions
fine product - we are very happy to use it and have a
> big benefit out of it.
>
> /Jan
>
>
>
> Den 16-08-2018 kl. 13:36 skrev redm...@postgresql.org:
>
> Issue #3556 <https://redmine.postgresql.org/issues/3556#change-12959> has
> been updated by Aditya Toshniwal.
&g
u, Aug 16, 2018 at 10:42 AM, Aditya Toshniwal enterprisedb.com> wrote:
>
>> Hi Dave/Hackers,
>>
>> Please find attached the updated patch.
>>
>> On Thu, Aug 16, 2018 at 1:45 PM, Dave Page wrote:
>>
>>> Hi
>>>
>>> On Thu
Hi Hackers,
Attached is the patch to fix the cursor size issue where the cursor size is
very small even if text is larger.
Kindly review.
--
Thanks and Regards,
Aditya Toshniwal
Software Engineer | EnterpriseDB Software Solutions | Pune
"Don't Complain about Heat, Plant a tree"
Hi Hackers,
Attached is the patch to fix filter dialog issue where it was not opening
at all when server is disconnected. The patch will make filter button
behaviour similar to Execute query button and will ask to connect.
--
Thanks and Regards,
Aditya Toshniwal
Software Engineer | EnterpriseDB
--inserts*" and "
>*--column-inserts*",added validation.
>
> Please review it.
>
> --
> *Akshay Joshi*
>
> *Sr. Software Architect *
>
>
>
> *Phone: +91 20-3058-9517Mobile: +91 976-788-8246*
>
--
Thanks and Regards,
Aditya Toshniwal
Software Engineer | EnterpriseDB Software Solutions | Pune
"Don't Complain about Heat, Plant a tree"
oad the current tree state will be saved.
> - On Reload, while opening the server, the stored path will be populated.
> - On closing the node the saved will be updated accordingly.
> - Jasmine test cases are included.
>
>
> Thanks,
> Khushboo
>
--
Thanks and Regards,
Adi
DROP
>
> I have also added some feature test for auto complete. Attached is the
> patch please review it.
> --
> *Akshay Joshi*
>
> *Sr. Software Architect *
>
>
>
> *Phone: +91 20-3058-9517Mobile: +91 976-788-8246*
>
--
Thanks and Regards,
Aditya Toshniwal
Software Engineer | EnterpriseDB Software Solutions | Pune
"Don't Complain about Heat, Plant a tree"
Hi Akshay,
Attached is the patch to make autocomplete changes python 2.6 compatible.
Please note, this patch should be applied over your patch.
On Mon, Aug 27, 2018 at 2:28 PM Aditya Toshniwal <
aditya.toshni...@enterprisedb.com> wrote:
> Hi,
>
> Did a basic testing. Looks g
Hi Hackers,
Attached is the patch to make debugger scroll automatically to current
active line and scroll along with StepIn/StepOut. Previously, we had to
manually scroll.
Kindly review.
--
Thanks and Regards,
Aditya Toshniwal
Software Engineer | EnterpriseDB Software Solutions | Pune
"
required changes. Thank you
Ashesh.
On Mon, Aug 27, 2018 at 6:16 PM Aditya Toshniwal <
aditya.toshni...@enterprisedb.com> wrote:
> Hi Hackers,
>
> Attached is the patch to make debugger scroll automatically to current
> active line and scroll along with StepIn/StepOut. Pre
Hi Hackers,
Attached is the updated patch which also includes code changes to avoid
reloading same proc/function again in case of a recursive call.
On Mon, Aug 27, 2018 at 6:44 PM Aditya Toshniwal <
aditya.toshni...@enterprisedb.com> wrote:
> Hi Hackers,
>
> Please hold on wit
) Found one bug where changing the preferences of Debugger to open in new
tab was not working. Debugger opened in same tab. This is fixed.
Kindly review.
On Mon, Aug 27, 2018 at 7:32 PM Aditya Toshniwal <
aditya.toshni...@enterprisedb.com> wrote:
> Hi Hackers,
>
> Attached is the upda
> /home/khushboo/Projects/pgadmin4/web/pgadmin/static/bundle/codemirror.js
> 20:28 error Strings must use singlequote quotes
> 22:53 error Strings must use singlequote quotes
>
> Thanks,
> Khushboo
>
> On Wed, Aug 29, 2018 at 11:10 AM, Aditya Toshniwal &l
hboard. Possible test cases
added.
Kindly review.
--
Thanks and Regards,
Aditya Toshniwal
Software Engineer | EnterpriseDB Software Solutions | Pune
"Don't Complain about Heat, Plant a tree"
RM3514.patch
Description: Binary data
that of
>>>>> the
>>>>> tabset control buttons which I'd argue are semantically different in
>>>>> purpose).
>>>>>
>>>>
>>>>Fixed. Please find attached patch file.
>>>>
>>>
>>> Al
and try to create a
column with that type. It failed to create.
4) DEFAULT keyword was added to generated SQL on focus on Default value
textbox focus and staying there forever even if textbox is blank.
Kindly review.
--
Thanks and Regards,
Aditya Toshniwal
Software Engineer | EnterpriseDB Software
gt; > > > git.postgresql.org.
> > > > > > > > >
> > > > > > > > >
> > > > > > > > >>
> > > > > > > > >> Then some tech-related questions:
> > > > > > > > >>
> > > > > > > > >> 1. It seems like window.top.pgAdmin.Browser.
> > > > > > > get_preferences_for_module
> > > > > > > > >> is used for getting preferences from js, and that the
> > > > > > > PreferencesModule
> > > > > > > > >> python class is responsible for managing preferences. But
> where
> > > > are
> > > > > > > the
> > > > > > > > >> default preferences listed?
> > > > > > > > >>
> > > > > > > > >
> > > > > > > > > You'll find register_preferences functions in some of the
> Python
> > > > > > > modules
> > > > > > > > > (e.g. web/pgadmin/dashboard/__init__.py). They tend to
> have a
> > > > bunch of
> > > > > > > > > calls in them that look like this:
> > > > > > > > >
> > > > > > > > > self.session_stats_refresh =
> self.dashboard_preference.register(
> > > > > > > > > 'dashboards', 'session_stats_refresh',
> > > > > > > > > gettext("Session statistics refresh rate"), 'integer',
> > > > > > > > > 1, min_val=1, max_val=99,
> > > > > > > > > category_label=gettext('Graphs'),
> > > > > > > > > help_str=gettext('The number of seconds between graph
> > > > samples.')
> > > > > > > > > )
> > > > > > > > >
> > > > > > > > > In this case, the 1 on the beginning of the fourth line is
> the
> > > > default
> > > > > > > > > value.
> > > > > > > > >
> > > > > > > > >
> > > > > > > > >> 2. Does the preferences code currently handle editing a
> list of
> > > > > > > elements?
> > > > > > > > >> I'm thinking that the preferences pane for map layers
> should be
> > > > > > > something
> > > > > > > > >> like this.
> > > > > > > > >>
> > > > > > > > >>
> > > > > > > > >> name| url
> > > > > > > > >> |
> > > > > > > > >>
> --|-
> > > > > > > |
> > > > > > > > >> --
> > > > > > > > >> streets | https://{s}.
> tile.openstreetmap.org/{z}/{x}/{y}.png
> <http://tile.openstreetmap.org/%7Bz%7D/%7Bx%7D/%7By%7D.png>
> > > > > > > > >> <
> http://tile.openstreetmap.org/%7Bz%7D/%7Bx%7D/%7By%7D.png> |
> > > > > > > [remove]
> > > > > > > > >> []| []
> > > > > > > > >> | [add]
> > > > > > > > >>
> > > > > > > > >> 2.1 If it does, where in the code can I find it?
> > > > > > > > >> 2.2 It it doesn't, where in the code can I add it and
> > > > > > > > >> 3. In either case of 2: how do I specify how a preference
> > > > object for a
> > > > > > > > >> module look like?
> > > > > > > > >>
> > > > > > > > >
> > > > > > > > > I don't believe it does at the moment. Khushboo, am I
> missing
> > > > > > > something?
> > > > > > > > >
> > > > > > > > > Yes, right, currently we don't have it.
> > > > > > > >
> > > > > > > > You can register the module wise preferences with the
> > > > > > > register_preferences
> > > > > > > > function mentioned by Dave above.
> > > > > > > > At the client side, we create the preferences cache and use
> the
> > > > cache in
> > > > > > > > the other JS modules as and when required. Please refer
> > > > > > > > pgadmin/browser/static/js/preferences.js file which is being
> used
> > > > to get
> > > > > > > > the cached preferences. You will find the different
> functions to
> > > > get the
> > > > > > > > specific preference here.
> > > > > > > >
> > > > > > > > The Preferences class is in web/pgadmin/utils/preferences.py.
> > > > > > > > >
> > > > > > > > > --
> > > > > > > > > Dave Page
> > > > > > > > > Blog: http://pgsnake.blogspot.com
> > > > > > > > > Twitter: @pgsnake
> > > > > > > > >
> > > > > > > > > EnterpriseDB UK: http://www.enterprisedb.com
> > > > > > > > > The Enterprise PostgreSQL Company
> > > > > > > > >
> > > > > > >
> > > > > >
> > > > > >
> > > > > >
> > > > > > --
> > > > > > Dave Page
> > > > > > Blog: http://pgsnake.blogspot.com
> > > > > > Twitter: @pgsnake
> > > > > >
> > > > > > EnterpriseDB UK: http://www.enterprisedb.com
> > > > > > The Enterprise PostgreSQL Company
> > > > >
> > > >
> > >
> > >
> > >
> > > --
> > > Dave Page
> > > Blog: http://pgsnake.blogspot.com
> > > Twitter: @pgsnake
> > >
> > > EnterpriseDB UK: http://www.enterprisedb.com
> > > The Enterprise PostgreSQL Company
> >
>
--
Thanks and Regards,
Aditya Toshniwal
Software Engineer | EnterpriseDB Software Solutions | Pune
"Don't Complain about Heat, Plant a tree"
Hi,
On Tue, Sep 18, 2018 at 1:32 PM Aditya Toshniwal <
aditya.toshni...@enterprisedb.com> wrote:
> Hi,
>
>
> On Tue, Sep 18, 2018 at 12:43 AM Atle Frenvik Sveen
> wrote:
>
>> Hi again!
>>
>> I started digging around in the code used to display the Gr
will do.
>
> -a
>
> --
> Atle Frenvik Sveen
> a...@frenviksveen.net
> 45278689
> atlefren.net
>
> On Tue, Sep 18, 2018, at 10:31, Dave Page wrote:
> > On Tue, Sep 18, 2018 at 9:06 AM, Aditya Toshniwal <
> > aditya.toshni...@enterprisedb.com> wr
Hi Hackers,
Attached is patch to fix auto commit issue where changing auto commit
option from preferences was not having any effect in query tools.
Kindly review.
--
Thanks and Regards,
Aditya Toshniwal
Software Engineer | EnterpriseDB Software Solutions | Pune
"Don't Complain
Hi,
Please hold on. Need to fix some PEP8 issues. :|
On Wed, Sep 19, 2018 at 6:07 PM Aditya Toshniwal <
aditya.toshni...@enterprisedb.com> wrote:
> Hi Hackers,
>
> Attached is patch to fix auto commit issue where changing auto commit
> option from preferences was not having a
Hi Hackers,
Attached is the updated patch. Kindly review.
On Wed, Sep 19, 2018 at 6:20 PM Aditya Toshniwal <
aditya.toshni...@enterprisedb.com> wrote:
> Hi,
>
> Please hold on. Need to fix some PEP8 issues. :|
>
> On Wed, Sep 19, 2018 at 6:07 PM Aditya Toshni
Hi Hackers,
Attached is the tiny patch for renaming 'SQL Editor' into 'Query Tool' in
Preferences.
--
Thanks and Regards,
Aditya Toshniwal
Software Engineer | EnterpriseDB Software Solutions | Pune
"Don't Complain about Heat, Plant a tree"
RM3660.patch
Description: Binary data
Hi,
On Mon, Oct 8, 2018 at 4:06 PM Dave Page wrote:
> Hi
>
> On Fri, Oct 5, 2018 at 1:51 PM Aditya Toshniwal <
> aditya.toshni...@enterprisedb.com> wrote:
>
>> Hi Hackers,
>>
>> Attached is the patch to migrate pgAdmin4 currently based on Bootstrap 3,
&g
able bring back the calendar control. (Create Role -> Account expiry)
Also fixed sort filter dropdown in query tool.
Kindly review.
On Wed, Oct 10, 2018 at 5:16 PM Dave Page wrote:
> Thanks, patch applied.
>
> On Wed, Oct 10, 2018 at 11:41 AM Aditya Toshniwal <
> aditya.toshni..
ced with d-none in
Bootstrap 4.
One more big miss - debugger button toolbar was not visible/or in position.
Fixed that as well.
Let me know if you find more. :/
On Thu, Oct 11, 2018 at 3:38 PM Aditya Toshniwal <
aditya.toshni...@enterprisedb.com> wrote:
> Hi Hackers,
>
> Team found
1 - 100 of 1171 matches
Mail list logo
