RE: Bug #6991 - Suggestion to Contribute Fix

That’s great. I am suggesting the attached change. In terms of test coverage, the change is already covered by existing LDAP connection tests. As far as I can see it’s not immediately possible to “sharpen” the existing tests to detect the bug I am trying to fix, as this would require a change

[pgAdmin][RM-7124] - Schema Diff with no results

Hi, Please find the patch which fixes the schema diff issue for comparison of 2 tables having different column positions(different attnum) and a column has default value. Thanks, Yogesh Mahajan EnterpriseDB RM_7124_v1.patch Description: Binary data

Re: Bug #6991 - Suggestion to Contribute Fix

Hi Khushboo Can you please review the patch? On Thu, Feb 10, 2022 at 1:49 PM Charlet, Christoph < christoph.char...@d-fine.de> wrote: > That’s great. > > > > I am suggesting the attached change. > > > > In terms of test coverage, the change is already covered by existing LDAP > connection tests.

pgAdmin 4 commit: Fixed the schema diff issue where tables have differe

Fixed the schema diff issue where tables have different column positions and a column has a default value. Fixes #7124 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=76a4dee4514c167871ac063891c0260176d44376 Author: Yogesh Mahajan Modified F

pgAdmin 4 commit: Implemented utilities in React to make porting easier

Implemented utilities in React to make porting easier for pgAdmin tools. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=bc4e8a3c8265dc0bea46146f0118d5a3a7217937 Author: Aditya Toshniwal Modified Files -- web/package.json

Re: [pgAdmin][RM-7124] - Schema Diff with no results

Thanks, the patch applied. On Thu, Feb 10, 2022 at 7:48 PM Yogesh Mahajan < yogesh.maha...@enterprisedb.com> wrote: > Hi, > > Please find the patch which fixes the schema diff issue for comparison of > 2 tables having different column positions(different attnum) and a column > has default value.

Re: [pgAdmin][patch] Utilities for porting pgAdmin tools to React

Thanks, the patch applied. On Thu, Feb 10, 2022 at 12:06 PM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi, > > Please ignore the previous patch. Attached is the correct path. > > On Wed, Feb 9, 2022 at 5:19 PM Aditya Toshniwal < > aditya.toshni...@enterprisedb.com> wrote: > >>

pgAdmin 4 commit: Uncomment the incorrectly commented code in the previ

Uncomment the incorrectly commented code in the previous commit. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=f002b11106400e744345a9c30e8540100c5a68ef Modified Files -- web/regression/javascript/jasmine_capture_warnings_beforeal

Re: Bug #6991 - Suggestion to Contribute Fix

Will review and test the patch. On Fri, Feb 11, 2022 at 10:16 AM Akshay Joshi wrote: > Hi Khushboo > > Can you please review the patch? > > On Thu, Feb 10, 2022 at 1:49 PM Charlet, Christoph < > christoph.char...@d-fine.de> wrote: > >> That’s great. >> >> >> >> I am suggesting the attached chang