pgAdmin 4 commit: Added support for OAuth 2 authentication. Fixes #5940

2021-07-06 Thread Akshay Joshi
Added support for OAuth 2 authentication. Fixes #5940 Initial patch sent by: Florian Sabonchi Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=48ca83f31dee76c05edb6b64a595964968ec7eb2 Author: Khushboo Vashi Modified Files -- DEPEN

Re: [pgAdmin][Patch] - RM #5940 - Add support for Oauth 2 authentication

2021-07-06 Thread Akshay Joshi
Thanks, the patch applied. On Tue, Jul 6, 2021 at 12:01 PM Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi Akshay, > > Please find the attached updated patch. > > Thanks, > Khushboo > On Mon, Jul 5, 2021 at 5:39 PM Akshay Joshi > wrote: > >> Hi Khushboo >> >> Following are the revi

Re: [pgAdmin][RM-6569]: [Housekeeping][React] Port catalog objects to react

2021-07-06 Thread Akshay Joshi
Hi Nikhil Jasmine test cases are failing, can you please fix and resend the patch. On Mon, Jul 5, 2021 at 11:48 AM Akshay Joshi wrote: > Hi Aditya > > Can you please review it? > > On Fri, Jul 2, 2021 at 1:42 PM Nikhil Mohite < > nikhil.moh...@enterprisedb.com> wrote: > >> Hi Hackers, >> >> Ple

Re: [pgAdmin][Patch] - Housekeeping #6582 - [React] Port Extension object to react

2021-07-06 Thread Akshay Joshi
Thanks, the patch applied. On Tue, Jul 6, 2021 at 11:58 AM Yogesh Mahajan < yogesh.maha...@enterprisedb.com> wrote: > Hi, > > Please find the updated patch.(..v2.patch) > > Thanks, > Yogesh Mahajan > EnterpriseDB > > > On Tue, Jul 6, 2021 at 11:05 AM Akshay Joshi < > akshay.jo...@enterprisedb.com

Re: [pgAdmin][RM6398]: Detaching query editor panel gives a blank white panel.

2021-07-06 Thread Pradip Parkale
Hi Akshay, Please find the updated patch. On Fri, Jun 25, 2021 at 11:40 AM Akshay Joshi wrote: > Thanks, the patch applied. > > On Thu, Jun 24, 2021 at 9:16 PM Pradip Parkale < > pradip.park...@enterprisedb.com> wrote: > >> Hi Akshay, >> Please find the updated patch. I have moved the function i

[pgAdmin4][patch] Remove extra brackets in CREATE Script and DDL Comparison

2021-07-06 Thread zhangj...@fujitsu.com
Hi, all Extra brackets appear in CREATE Script and DDL Comparison, please refer to the attachment error1.png and error2.png for details. ■ scenario The step is as follow: 1) Connect to pg9.6 or pg9.5 2) The SQL to create the trigger is as follows. - CRE

Re: [pgAdmin4][patch] Remove extra brackets in CREATE Script and DDL Comparison

2021-07-06 Thread Khushboo Vashi
Patch looks good to me. On Tue, Jul 6, 2021 at 3:15 PM zhangj...@fujitsu.com wrote: > Hi, all > > Extra brackets appear in CREATE Script and DDL Comparison, > please refer to the attachment error1.png and error2.png for details. > > ■ scenario > The step is as follow: > 1) Connect to pg9.6 or pg

Re: [pgAdmin][RM-6536]: Browse button: Directory issues

2021-07-06 Thread Nikhil Mohite
Hi Akshay, Please find the updated patch for RM-6536, Resolved the issue if user select folder "Select" button is not getting enabled in "Select folder" dialog. Regards, Nikhil Mohite On Mon, Jun 28, 2021 at 6:55 PM Akshay Joshi wrote: > Thanks, the patch applied. > > On Mon, Jun 28, 2021 at 6

pgAdmin 4 commit: 1) Set the default value of the long-running threshol

2021-07-06 Thread Akshay Joshi
1) Set the default value of the long-running threshold to 2 minutes for warning and 5 minutes for the alert. 2) Use $color-danger for the alert threshold. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=a0b2a28ee216935aa23ae73d99f801075d516c0

pgAdmin 4 commit: Remove extra brackets in CREATE script and DDL compar

2021-07-06 Thread Akshay Joshi
Remove extra brackets in CREATE script and DDL comparison for trigger node. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=39a845ad314a09fe8624e1596074d60f9116020d Author: Identifier Anonymous Modified Files -- .../schemas/tables

pgAdmin 4 commit: Fixed an issue where Schema Diff and Debugger give a

2021-07-06 Thread Akshay Joshi
Fixed an issue where Schema Diff and Debugger give a blank white panel. refs #6398 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=5d4c073730c679c6d2c41233aae94ace4548deee Author: Pradip Parkale Modified Files -- web/pgadmin/tool

pgAdmin 4 commit: Resolved the issue when the user selects the folder '

2021-07-06 Thread Akshay Joshi
Resolved the issue when the user selects the folder 'Select' button is not getting enabled for 'Select folder' dialog. refs #6536 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=669bdc7e3803778287e1716cb315edff9ba0f2c2 Author: Nikhil Mohite

Re: [patch][pgAdmin] RM3893 pgadmin4 Reassign/Drop Owned

2021-07-06 Thread Akshay Joshi
Hi Rahul On Tue, Jul 6, 2021 at 7:13 PM Rahul Shirsat wrote: > Hi Akshay, > > As discussed in the review meeting, following are the review comments > fixation: > > >- Label change - "Role operation" to "Reassign/Drop Own" > >IIRC, we have finalized "Operation" then from where

Re: [pgAdmin][RM-6536]: Browse button: Directory issues

2021-07-06 Thread Akshay Joshi
Thanks, the patch applied. On Tue, Jul 6, 2021 at 5:49 PM Nikhil Mohite wrote: > Hi Akshay, > > Please find the updated patch for RM-6536, Resolved the issue if user > select folder "Select" button is not getting enabled in "Select folder" > dialog. > > Regards, > Nikhil Mohite > > On Mon, Jun 2

Re: [pgAdmin4][patch] Remove extra brackets in CREATE Script and DDL Comparison

2021-07-06 Thread Akshay Joshi
Thanks, the patch applied. On Tue, Jul 6, 2021 at 3:15 PM zhangj...@fujitsu.com wrote: > Hi, all > > Extra brackets appear in CREATE Script and DDL Comparison, > please refer to the attachment error1.png and error2.png for details. > > ■ scenario > The step is as follow: > 1) Connect to pg9.6 or

Re: [pgAdmin][RM6398]: Detaching query editor panel gives a blank white panel.

2021-07-06 Thread Akshay Joshi
Thanks, the patch applied. On Tue, Jul 6, 2021 at 3:00 PM Pradip Parkale < pradip.park...@enterprisedb.com> wrote: > Hi Akshay, > Please find the updated patch. > > On Fri, Jun 25, 2021 at 11:40 AM Akshay Joshi < > akshay.jo...@enterprisedb.com> wrote: > >> Thanks, the patch applied. >> >> On Thu

Re: [pgAdmin][RM-6569]: [Housekeeping][React] Port catalog objects to react

2021-07-06 Thread Nikhil Mohite
Hi Akshay, Please find the updated patch for RM-6569, Resolved issue of falling Jasmine test cases. On Tue, Jul 6, 2021 at 2:25 PM Akshay Joshi wrote: > Hi Nikhil > > Jasmine test cases are failing, can you please fix and resend the patch. > > On Mon, Jul 5, 2021 at 11:48 AM Akshay Joshi < > ak

pgAdmin 4 commit: 1) Modified some labels and controls.

2021-07-06 Thread Akshay Joshi
1) Modified some labels and controls. 2) Fixed issue where the same user is showing in SQL query. 3) Added SQL tab in the dialog. refs #3893 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=8edd5946e55016b90be119f746ea79fd92201b26 Author: Rah

Re: [patch][pgAdmin] RM3893 pgadmin4 Reassign/Drop Owned

2021-07-06 Thread Akshay Joshi
Thanks, the patch applied. On Tue, Jul 6, 2021 at 9:47 PM Rahul Shirsat wrote: > Hi Akshay, > > Please find the updated patch. > > On Tue, Jul 6, 2021 at 8:07 PM Akshay Joshi > wrote: > >> Hi Rahul >> >> On Tue, Jul 6, 2021 at 7:13 PM Rahul Shirsat < >> rahul.shir...@enterprisedb.com> wrote: >>

Re: [pgAdmin][RM-6569]: [Housekeeping][React] Port catalog objects to react

2021-07-06 Thread Akshay Joshi
Thanks, the patch applied. On Wed, Jul 7, 2021 at 10:25 AM Nikhil Mohite < nikhil.moh...@enterprisedb.com> wrote: > Hi Akshay, > > Please find the updated patch for RM-6569, Resolved issue of falling > Jasmine test cases. > > On Tue, Jul 6, 2021 at 2:25 PM Akshay Joshi > wrote: > >> Hi Nikhil >>