Re: [patch][pgAdmin] Fix for pgadmin4-linux-qa #1651 failure

Hi All, Please find the attached patch for resolving this issue wrt above suggestion. Let me know if anyone has any queries. On Tue, Jun 29, 2021 at 9:20 PM Rahul Shirsat < rahul.shir...@enterprisedb.com> wrote: > Hi Dave / Aditya, > > For a time being, Let's make a call to gettext conditional

Re: [patch][pgAdmin] Fix for pgadmin4-linux-qa #1651 failure

Hi On Wed, Jun 30, 2021 at 8:28 AM Rahul Shirsat < rahul.shir...@enterprisedb.com> wrote: > Hi All, > > Please find the attached patch for resolving this issue wrt above > suggestion. > Well that may fix the problem (and is a reasonable change), however, I think it's important that we understand

pgAdmin 4 commit: Disable email deliverability check that was introduce

Disable email deliverability check that was introduced in flask-security-too by default to maintain backwards compatibility. Fixes #6550 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=b98e881d8440737b387debb7a8dbaf910f4d2349 Modified Files

pgAdmin 4 commit: PEP-8 fix.

PEP-8 fix. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=a2b67b933e4b00ac266d55649dc7424366511a78 Modified Files -- web/config.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

RM 6427 - Newlines in text columns of resultset show an allegedly "empty" field

Here's a simple patch for $SUBJECT. It will remove any leading spaces from the grid cell display and replace them with '[...] '. In edit mode, the data is unchanged. The only downside I can see to this is that the tooltip will show the modified data when it probably should actually show the un-mod

Re: RM 6427 - Newlines in text columns of resultset show an allegedly "empty" field

Hi Dave, On Wed, Jun 30, 2021 at 3:35 PM Dave Page wrote: > Here's a simple patch for $SUBJECT. It will remove any leading spaces from > the grid cell display and replace them with '[...] '. In edit mode, the > data is unchanged. > > The patch looks good to me. Do we need to specify somewhere wh

Re: RM 6427 - Newlines in text columns of resultset show an allegedly "empty" field

Hi On Wed, Jun 30, 2021 at 12:36 PM Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi Dave, > > On Wed, Jun 30, 2021 at 3:35 PM Dave Page wrote: > >> Here's a simple patch for $SUBJECT. It will remove any leading spaces >> from the grid cell display and replace them with '[...] '. In

Re: [patch][pgAdmin] Fix for pgadmin4-linux-qa #1651 failure

Hi On Wed, Jun 30, 2021 at 9:22 AM Dave Page wrote: > Hi > > On Wed, Jun 30, 2021 at 8:28 AM Rahul Shirsat < > rahul.shir...@enterprisedb.com> wrote: > >> Hi All, >> >> Please find the attached patch for resolving this issue wrt above >> suggestion. >> > > Well that may fix the problem (and is a

Re: [patch][pgAdmin] Fix for pgadmin4-linux-qa #1651 failure

Hi, On Wed, Jun 30, 2021 at 6:55 PM Dave Page wrote: > Hi > > On Wed, Jun 30, 2021 at 9:22 AM Dave Page wrote: > >> Hi >> >> On Wed, Jun 30, 2021 at 8:28 AM Rahul Shirsat < >> rahul.shir...@enterprisedb.com> wrote: >> >>> Hi All, >>> >>> Please find the attached patch for resolving this issue w

Re: [patch][pgAdmin] Fix for pgadmin4-linux-qa #1651 failure

On Wed, Jun 30, 2021 at 2:42 PM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi, > > On Wed, Jun 30, 2021 at 6:55 PM Dave Page wrote: > >> Hi >> >> On Wed, Jun 30, 2021 at 9:22 AM Dave Page wrote: >> >>> Hi >>> >>> On Wed, Jun 30, 2021 at 8:28 AM Rahul Shirsat < >>> rahul.shir.

Re: [patch][pgAdmin] Fix for pgadmin4-linux-qa #1651 failure

On Wed, Jun 30, 2021 at 6:55 PM Dave Page wrote: > Hi > > On Wed, Jun 30, 2021 at 9:22 AM Dave Page wrote: > >> Hi >> >> On Wed, Jun 30, 2021 at 8:28 AM Rahul Shirsat < >> rahul.shir...@enterprisedb.com> wrote: >> >>> Hi All, >>> >>> Please find the attached patch for resolving this issue wrt ab