pgAdmin 4 commit: Fixed binary path issue on Windows platform. refs #53

2021-06-14 Thread Akshay Joshi
Fixed binary path issue on Windows platform. refs #5370 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=2fdde6218a47291d4019a2aa360ee121561e4d55 Modified Files -- web/pgadmin/misc/__init__.py | 6 ++ web/pgadmin/utils/__init__.

[pgAdmin][RM-6469]: Role node: Calender control is not disabled in properties panel

2021-06-14 Thread Nikhil Mohite
Hi Hackers, Please find the attached patch for RM-6469 : Role node: Calender control is not disabled in properties panel. -- *Thanks & Regards,* *Nikhil Mohite* *Software Engineer.* *EDB Postgres* *Mob.No: +91-77983645

Re: [pgAdmin][RM6520]: pgAdmin4 v 5.3 text export error

2021-06-14 Thread Pradip Parkale
Hi Aditya and Akshay, Please find the updated patch. I have changed the variable name "data" to 'numeric_cols'. On Fri, Jun 11, 2021 at 7:38 PM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Pradip, > > Just did a go through to your patch. > The variable "data" which you've fo

Re: [pgAdmin][RM-2341]: Add menu option for starting PSQL

2021-06-14 Thread Nikhil Mohite
Hi Akshay, Please find the updated patch for psql, Updated invalid command logic added 3 more commands in it. 1. \copy or \COPY 2. \e or \E 3. \ef or \EF Now user can't execute these commands if allow shell commands is set to False. If required any changes please let me know. Regards, Nikhil Mo

Re: [pgAdmin][RM-2341]: Add menu option for starting PSQL

2021-06-14 Thread Dave Page
Hi On Mon, Jun 14, 2021 at 2:13 PM Nikhil Mohite < nikhil.moh...@enterprisedb.com> wrote: > Hi Akshay, > > Please find the updated patch for psql, Updated invalid command logic > added 3 more commands in it. > 1. \copy or \COPY > 2. \e or \E > 3. \ef or \EF > Should they just be case insensitive

Re: [pgAdmin][RM-2341]: Add menu option for starting PSQL

2021-06-14 Thread Nikhil Mohite
Hi Akshay, I have added the following commands for invalid command check: 1. \lo_import 2. \lo_export 3. \w or write 4. \o or \output 5. \g I am referring to the https://www.postgresql.org/docs/12/app-psql.html link for finding the commands. PFA patch V10. On Mon, Jun 14, 2021 a

Re: [pgAdmin][RM-2341]: Add menu option for starting PSQL

2021-06-14 Thread Dave Page
Hi On Mon, Jun 14, 2021 at 3:18 PM Nikhil Mohite < nikhil.moh...@enterprisedb.com> wrote: > Hi Akshay, > > I have added the following commands for invalid command check: > >1. \lo_import >2. \lo_export >3. \w or write >4. \o or \output >5. \g > > \qecho? \ev? I'm very concern

Re: [pgAdmin][RM-2341]: Add menu option for starting PSQL

2021-06-14 Thread Akshay Joshi
Hi Dave On Mon, Jun 14, 2021 at 7:57 PM Dave Page wrote: > Hi > > On Mon, Jun 14, 2021 at 3:18 PM Nikhil Mohite < > nikhil.moh...@enterprisedb.com> wrote: > >> Hi Akshay, >> >> I have added the following commands for invalid command check: >> >>1. \lo_import >>2. \lo_export >>3. \w o

Re: [pgAdmin][RM-2341]: Add menu option for starting PSQL

2021-06-14 Thread Nikhil Mohite
Hi Dave, On Mon, Jun 14, 2021 at 8:05 PM Akshay Joshi wrote: > Hi Dave > > On Mon, Jun 14, 2021 at 7:57 PM Dave Page wrote: > >> Hi >> >> On Mon, Jun 14, 2021 at 3:18 PM Nikhil Mohite < >> nikhil.moh...@enterprisedb.com> wrote: >> >>> Hi Akshay, >>> >>> I have added the following commands for i

Re: [pgAdmin][RM-2341]: Add menu option for starting PSQL

2021-06-14 Thread Dave Page
On Mon, Jun 14, 2021 at 3:35 PM Akshay Joshi wrote: > Hi Dave > > On Mon, Jun 14, 2021 at 7:57 PM Dave Page wrote: > >> Hi >> >> On Mon, Jun 14, 2021 at 3:18 PM Nikhil Mohite < >> nikhil.moh...@enterprisedb.com> wrote: >> >>> Hi Akshay, >>> >>> I have added the following commands for invalid com

Re: [pgAdmin][RM-2341]: Add menu option for starting PSQL

2021-06-14 Thread Dave Page
Hi On Mon, Jun 14, 2021 at 3:43 PM Nikhil Mohite < nikhil.moh...@enterprisedb.com> wrote: > Hi Dave, > > On Mon, Jun 14, 2021 at 8:05 PM Akshay Joshi < > akshay.jo...@enterprisedb.com> wrote: > >> Hi Dave >> >> On Mon, Jun 14, 2021 at 7:57 PM Dave Page wrote: >> >>> Hi >>> >>> On Mon, Jun 14, 20

pgAdmin 4 commit: If the binary path contains '' then show as it is on

2021-06-14 Thread Akshay Joshi
If the binary path contains '' then show as it is on GUI if the path contains valid utilities. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=c2ed799113d001c76c047126eeffd33782995c59 Modified Files -- web/pgadmin/utils/__init__.p

pgAdmin 4 commit: Update version for release.

2021-06-14 Thread Akshay Joshi
Update version for release. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=ae2d588f462e19f41d604d405b78361bc28d1f83 Modified Files -- web/config.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)

pgAdmin 4 commit: 1) Disable the PSQL feature entirely in server mode b

2021-06-14 Thread Akshay Joshi
1) Disable the PSQL feature entirely in server mode by default. 2) Remove the code that attempts to filter out commands. refs #2341 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=2549688bdf2de9093c1140e2b92a0aca119c45c7 Author: Nikhil Mohite

pgAdmin 4 commit: Ensure that the calendar control should be disabled i

2021-06-14 Thread Akshay Joshi
Ensure that the calendar control should be disabled in the properties panel for Role. Fixes #6469. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=71526ac79f6c5a9e6c0b87d17b67158db16a7172 Author: Nikhil Mohite Modified Files -- d

pgAdmin 4 commit: Update DEPENDENCIES.

2021-06-14 Thread Akshay Joshi
Update DEPENDENCIES. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=12d93d0805ca8c9d70c1d30e4f22bc7045ff53c8 Modified Files -- DEPENDENCIES | 155 +-- 1 file changed, 86 inser

pgAdmin 4 commit: Updated variable name as per review comments.

2021-06-14 Thread Akshay Joshi
Updated variable name as per review comments. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=3d685ef96c6a4dfe6d7e77b71ea075d50fae9f13 Author: Pradip Parkale Modified Files -- web/pgadmin/utils/driver/psycopg2/typecast.py | 8

Re: [pgAdmin][RM-6469]: Role node: Calender control is not disabled in properties panel

2021-06-14 Thread Akshay Joshi
Thanks, the patch applied. On Mon, Jun 14, 2021 at 3:15 PM Nikhil Mohite < nikhil.moh...@enterprisedb.com> wrote: > Hi Hackers, > > Please find the attached patch for RM-6469 > : Role node: Calender > control is not disabled in properties panel. > > >

pgAdmin4 v5.4 candidate builds

2021-06-14 Thread Akshay Joshi
Hi All, pgAdmin4 v5.4 candidate builds and source can be found at https://developer.pgadmin.org/builds/2021-06-14-1/ Fahar, can you please verify it for release on Thursday. -- *Thanks & Regards* *Akshay Joshi* *pgAdmin Hacker | Principal Software Architect* *EDB Postgres