pgAdmin 4 commit: Rename the video and log file created by Selenium tes

2021-04-01 Thread Akshay Joshi
Rename the video and log file created by Selenium tests. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=fe236316dea45235e4d13e45ca2b64911052f858 Author: Yogesh Mahajan Modified Files -- web/regression/python_test_utils/test_utils

Re: Feature Test Fix

2021-04-01 Thread Akshay Joshi
Thanks, patch applied. On Thu, Apr 1, 2021 at 12:28 PM Yogesh Mahajan < yogesh.maha...@enterprisedb.com> wrote: > Hello, > > Please find one more patch which rename nomenclature for video & log file > names created by solenoid. > > Thanks, > Yogesh Mahajan > EnterpriseDB > > > On Thu, Apr 1, 2021

pgAdmin 4 commit: Fixed PEP8 issue.

2021-04-01 Thread Akshay Joshi
Fixed PEP8 issue. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=e5d97e72e4556ed9eae113ae796f210a3197783d Modified Files -- web/regression/python_test_utils/test_utils.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

Re: CLI for Schema Diff

2021-04-01 Thread Dave Page
Hi On Thu, Apr 1, 2021 at 12:38 AM Steve Chavez wrote: > > but is this something you'd be interested in working on to become a more > fully featured and production quality CLI? > > Yes, absolutely! > Cool! > What would be the next step? I'm all for doing a CLI that covers pgAdmin > quality st

Re: CLI for Schema Diff

2021-04-01 Thread Steve Chavez
> but is this something you'd be interested in working on to become a more fully featured and production quality CLI? Yes, absolutely! What would be the next step? I'm all for doing a CLI that covers pgAdmin quality standards. On Wed, 31 Mar 2021 at 03:08, Dave Page wrote: > Hi > > On Tue, Mar

pgAdmin 4 commit: Ensure that while comparing domains check function de

2021-04-01 Thread Akshay Joshi
Ensure that while comparing domains check function dependencies should be considered in schema diff. Fixes #6327 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=c84df9cc0f7d5816bf74195105ee3f3536d58620 Modified Files -- docs/en_US

[pgAdmin][Patch] RM6076 - No error thrown while importing server if servers.json has incorrect keys/insufficient keys

2021-04-01 Thread Yogesh Mahajan
Hello Team, Please find an attached patch which shows the exact error if the json file used to load the server has missing keys/incorrect key value. Thanks, Yogesh Mahajan EnterpriseDB RM6076_v1.patch Description: Binary data

pgAdmin 4 commit: Fixed an issue where correct error not thrown while i

2021-04-01 Thread Akshay Joshi
Fixed an issue where correct error not thrown while importing servers and JSON file has incorrect/insufficient keys. Fixes #6076 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=53f5562468fde4bf06d3206eda0e6287e76d3015 Author: Yogesh Mahajan

Re: [pgAdmin][Patch] RM6076 - No error thrown while importing server if servers.json has incorrect keys/insufficient keys

2021-04-01 Thread Akshay Joshi
Thanks, patch applied. On Thu, Apr 1, 2021 at 5:43 PM Yogesh Mahajan < yogesh.maha...@enterprisedb.com> wrote: > Hello Team, > > Please find an attached patch which shows the exact error if the json file > used to load the server has missing keys/incorrect key value. > > Thanks, > Yogesh Mahajan