pgAdmin 4 commit: 1) Fixed an issue where the Save button is enabled by

2021-01-20 Thread Akshay Joshi
1) Fixed an issue where the Save button is enabled by default in Macro. Fixes #5905 2) Remove extra line after Manage Macros menu while clearing all macros. Fixes #5906 3) Ensure that 'Clear All Rows' should not work if there is no existing macro available and the user does not specify any value

Re: [pgAdmin4][Patch] - Fixed various issues of the Macros

2021-01-20 Thread Akshay Joshi
Thanks, patch applied. On Wed, Jan 20, 2021 at 12:55 PM Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi, > > Please find the attached patch to fix below the issues of the macro module: > > #5905 - Save button is enabled by-default > #5906 - Consistent behaviour should be displayed i

Re: [pgAdmin][RM5488] Tooltip information does not display properly if user check all options under explain analyze

2021-01-20 Thread Aditya Toshniwal
Hi Hackers, Attached patch: 1) Fixes the broken explain GUI test case. 2) Displays a tooltip "Click for details..." on hover over explain plan nodes. Please review. On Tue, Jan 12, 2021 at 4:45 PM Akshay Joshi wrote: > Thanks, patch applied. > > On Tue, Jan 12, 2021 at 4:08 PM Aditya Toshniwal

[pgAdmin4][Patch] - RPM/DEB dependency for Kerberos

2021-01-20 Thread Khushboo Vashi
Hi, Please find the attached patch to add the RPM/DEB dependency for Kerberos to the -server package rather than -web packages and to handle the OSError while importing the gssapi. Thanks, Khushboo kerberos_dep.patch Description: Binary data

pgAdmin 4 commit: Update instructions to include KfW build.

2021-01-20 Thread Dave Page
Update instructions to include KfW build. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=ddf7f04c943e98163531bda9f28f5deb52e1995e Modified Files -- pkg/win32/README.txt | 33 ++--- 1 file changed, 30 ins

pgAdmin 4 commit: Add a container option (PGADMIN_DISABLE_POSTFIX) to d

2021-01-20 Thread Dave Page
Add a container option (PGADMIN_DISABLE_POSTFIX) to disable the Postfix server. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=850afd74025e5ee1c1296843765d557ccdfdf1ea Modified Files -- docs/en_US/container_deployment.rst | 14 +++

pgAdmin 4 commit: 1) Added RPM/DEB dependency for Kerberos to the serve

2021-01-20 Thread Akshay Joshi
1) Added RPM/DEB dependency for Kerberos to the server package. 2) Handle the OSError while importing the gssapi, it fixes the Windows error. refs #5457 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=c71315f8cdd9830e2baa7b7b10e63d5727b4d7da A

pgAdmin 4 commit: 1) Fixes the broken explain GUI test case.

2021-01-20 Thread Akshay Joshi
1) Fixes the broken explain GUI test case. 2) Displays a tooltip "Click for details..." on hover over explain plan nodes. refs #5488 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=57a2559f112970ec31a4d9ff67264e13dc6881ab Author: Aditya Toshni

Re: [pgAdmin4][Patch] - RPM/DEB dependency for Kerberos

2021-01-20 Thread Akshay Joshi
Thanks, patch applied. On Wed, Jan 20, 2021 at 4:38 PM Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi, > > Please find the attached patch to add the RPM/DEB dependency for Kerberos > to the -server package rather than -web packages and to handle the OSError > while importing the gs

Re: [pgAdmin][RM5488] Tooltip information does not display properly if user check all options under explain analyze

2021-01-20 Thread Akshay Joshi
Thanks, patch applied. On Wed, Jan 20, 2021 at 4:37 PM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > Attached patch: > 1) Fixes the broken explain GUI test case. > 2) Displays a tooltip "Click for details..." on hover over explain plan > nodes. > > Please review.

pgAdmin 4 commit: Include PostgreSQL 13 utilities in the container. Fix

2021-01-20 Thread Dave Page
Include PostgreSQL 13 utilities in the container. Fixes #6162 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=32cdfa2969ac844e238e17ee6a3f73f7edb9993e Modified Files -- Dockerfile | 20 +---

pgAdmin 4 commit: Fix labels.

2021-01-20 Thread Dave Page
Fix labels. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=a2f626046aa37c76662d69c520938c074c4e1c19 Modified Files -- .../browser/server_groups/servers/databases/static/js/database.js | 2 +- web/pgadmin/tools/erd/static/js/e

Re: [pgAdmin][RM1802] ERD Tool (Beta)

2021-01-20 Thread Dave Page
Hi Where's the Save Image button gone? I know Aditya was removing it whilst working on other things, but it's still required for phase 1 release. On Mon, Jan 18, 2021 at 11:45 AM Akshay Joshi wrote: > Thanks, patch applied. > > On Mon, Jan 18, 2021 at 5:08 PM Aditya Toshniwal < > aditya.toshni.

pgAdmin 4 commit: Fix menu text (the Query tool option doesn't open a d

2021-01-20 Thread Dave Page
Fix menu text (the Query tool option doesn't open a dialogue, so should not have ...). Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=91ca746c2701b181aaa685a13c914b74bff05a3f Modified Files -- web/pgadmin/browser/static/js/collec

Re: [pgAdmin][RM1802] ERD Tool (Beta)

2021-01-20 Thread Aditya Toshniwal
Hi Dave, On Wed, Jan 20, 2021 at 9:20 PM Dave Page wrote: > Hi > > Where's the Save Image button gone? I know Aditya was removing it whilst > working on other things, but it's still required for phase 1 release. > It was not working 100% right. :( So I've removed it for the time being. I'm still

[pgAdmin][RM-6143]: Shared server entries not getting deleted.

2021-01-20 Thread Nikhil Mohite
Hi Team, Please find the attached patch for RM-6143 : Shared server entries not getting deleted. Added code to delete shared server entries if the admin deletes the user from user management. -- *Thanks & Regards,* *Nikhil Mohite* *Software Engineer.*

[pgAmin4][Patch] - Kerberos support for Windows Installer

2021-01-20 Thread Khushboo Vashi
Hi, Please find the attached patch to add the Kerberos support in the Windows installer script. Thanks, Khushboo Kerberos_win_dep.patch Description: Binary data