Re: Somewhat excessive version checks

On Mon, Jan 11, 2021 at 10:06 PM Magnus Hagander wrote: > Hi! > > If I read the code correctly, pgadmin will (unless turned off) hit the > website to check the version.json file for updates *every time it > starts*. > Every time the server starts, which is a little different, but still... > >

Re: [pgAdmin4][Patch] - RM 5457 - Kerberos Authentication - Phase 1

Hi On Mon, Jan 11, 2021 at 5:42 PM Stephen Frost wrote: > > Accessing systems outside of the Kerberized environment is obviously a > different situation as you *can't* use the Kerberos credentials- and, > hopefully, everyone is using password managers and has a distinct and > different password

Re: [pgAdmin][RM5488] Tooltip information does not display properly if user check all options under explain analyze

Hi Aditya Code looks good to me. Below are the review comments: - Copy and Paste not working in the popup. - Documentation needs to be updated. On Mon, Jan 11, 2021 at 4:38 PM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > Attached patch improves the way e

pgAdmin 4 commit: Fixed an issue where target connection is wrong while

Fixed an issue where target connection is wrong while checking version compatibility in schema diff. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=3f089f31a3bb1e787d926c78e8f291e59454fb13 Author: Huang, Jun Modified Files -- we

Re: The target connection was wrong in function check_version_compatibility()

Thanks, patch applied. On Tue, Jan 12, 2021 at 11:03 AM Huang, Jun wrote: > Hi, > The target connection was made by source connection manager(it should be > made by target connection manager) > in function > check_version_compatibility(web\pgadmin\tools\schema_diff\__init__.py). > Attached patch

Re: [pgAdmin4][Patch] - RM 5457 - Kerberos Authentication - Phase 1

On Tue, Jan 12, 2021 at 10:08 AM Dave Page wrote: > > Hi > > On Mon, Jan 11, 2021 at 5:42 PM Stephen Frost wrote: >> >> >> Accessing systems outside of the Kerberized environment is obviously a >> different situation as you *can't* use the Kerberos credentials- and, >> hopefully, everyone is usin

pgAdmin 4 commit: Improve the explain plan details by showing popup ins

Improve the explain plan details by showing popup instead of tooltip on clicking of the specified node. Fixes #5488 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=6589f82e777e2adef1433c9859121c98a029f1eb Author: Aditya Toshniwal Modified Fi

Re: [pgAdmin][RM5488] Tooltip information does not display properly if user check all options under explain analyze

Thanks, patch applied. On Tue, Jan 12, 2021 at 4:08 PM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Akshay, > > Attached is the updated patch. Please review. > > On Tue, Jan 12, 2021 at 2:51 PM Akshay Joshi < > akshay.jo...@enterprisedb.com> wrote: > >> Hi Aditya >> >> Code l

[pgAdmin][RM-6075]: Non-admin user is unable to view shared server created using 'Service'.

Hi Team, Please find the attached patch for RM-6075: Non-admin user is unable to view shared server created using 'Service'. 1. Added migration to remove "Not null" constraints from a port column of sharedserver table. 2. Updated model class of shareds

Re: [pgAdmin] RM4892 pgAdmin "Inception"

Hi Hackers, Please find the patch which reverts the previous changes. Code changes do not solve the issue, so a workaround is mentioned in the RM to cater the issue. On Thu, Dec 24, 2020 at 1:15 PM Akshay Joshi wrote: > Thanks, patch applied. > > On Wed, Dec 23, 2020 at 8:23 PM Rahul Shirsat <

Re: Somewhat excessive version checks

On Tue, Jan 12, 2021 at 9:57 AM Dave Page wrote: > > On Mon, Jan 11, 2021 at 10:06 PM Magnus Hagander wrote: >> >> Hi! >> >> If I read the code correctly, pgadmin will (unless turned off) hit the >> website to check the version.json file for updates *every time it >> starts*. > > > Every time the

Re: Somewhat excessive version checks

On Tue, Jan 12, 2021 at 5:59 AM Khushboo Vashi wrote: > > > > On Tue, Jan 12, 2021 at 3:36 AM Magnus Hagander wrote: >> >> Hi! >> >> If I read the code correctly, pgadmin will (unless turned off) hit the >> website to check the version.json file for updates *every time it >> starts*. >> >> Wouldn

pgAdmin 4 commit: Reverting fix for #4892, updated the RM with the work

Reverting fix for #4892, updated the RM with the workaround. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=18e4b30634ad681765d5bc39c5866d342084c074 Author: Rahul Shirsat Modified Files -- docs/en_US/release_notes_4_30.rst

pgAdmin 4 commit: Fixed an issue where Non-admin user is unable to view

Fixed an issue where Non-admin user is unable to view shared server created using service. Fixes #6075 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=1a756efe82340218045ff0e481676b349e0a1bf0 Author: Nikhil Mohite Modified Files

Re: [pgAdmin] RM4892 pgAdmin "Inception"

Thanks, patch applied. On Tue, Jan 12, 2021 at 7:01 PM Rahul Shirsat < rahul.shir...@enterprisedb.com> wrote: > Hi Hackers, > > Please find the patch which reverts the previous changes. Code changes do > not solve the issue, so a workaround is mentioned in the RM to cater the > issue. > > On Thu,

Re: [pgAdmin][RM-6075]: Non-admin user is unable to view shared server created using 'Service'.

Thanks, patch applied. On Tue, Jan 12, 2021 at 5:26 PM Nikhil Mohite < nikhil.moh...@enterprisedb.com> wrote: > Hi Team, > > Please find the attached patch for RM-6075: > Non-admin user is unable to > view shared server created using 'Service'. > > 1.