[pgAdmin] RM6128 RM6084 datistemplate issue

2021-01-11 Thread Rahul Shirsat
Hi Hackers, Please find the attached patch below which resolves the issue of datistemplate. -- *Rahul Shirsat* Senior Software Engineer | EnterpriseDB Corporation. RM6128_RM6084.patch Description: Binary data

[pgAdmin][PM-6069]: Getting error while refreshing files in query tool

2021-01-11 Thread Nikhil Mohite
Hi Tema, Please find the attached patch for RM-6069 : Getting error while refreshing files in query tool. -- *Thanks & Regards,* *Nikhil Mohite* *Software Engineer.* *EDB Postgres* *Mob.No: +91-7798364578.* RM_6069.p

[pgAdmin][RM5488] Tooltip information does not display properly if user check all options under explain analyze

2021-01-11 Thread Aditya Toshniwal
Hi Hackers, Attached patch improves the way explain plan details tooltip for a node is shown. With the change, popup with details will be shown upon clicking a node, and it will remain open until explicitly closed. Please review. -- Thanks, Aditya Toshniwal pgAdmin hacker | Sr. Software Enginee

pgAdmin 4 commit: Fixed an issue where sequences are not created. Fixes

2021-01-11 Thread Akshay Joshi
Fixed an issue where sequences are not created. Fixes #6128 refs #6084 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=d5c544216223bd9f995593b42ba74ef6ecd2 Author: Rahul Shirsat Modified Files -- docs/en_US/release_notes_4_30

pgAdmin 4 commit: Ensure that verbose logs should be visible for Utilit

2021-01-11 Thread Akshay Joshi
Ensure that verbose logs should be visible for Utility(Backup, Maintenance) jobs. Fixes #6140 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=90004119afd235b7c7c6d784b217f9a7684e420d Modified Files -- docs/en_US/release_notes_4_30

pgAdmin 4 commit: Fixed an issue on refreshing files in Query Tool. Fix

2021-01-11 Thread Akshay Joshi
Fixed an issue on refreshing files in Query Tool. Fixes #6069 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=0fcfe630921f49b89db89b47a51031f17474808c Author: Nikhil Mohite Modified Files -- docs/en_US/release_notes_4_30.rst

pgAdmin 4 commit: Fixed an issue where the database list in the new con

2021-01-11 Thread Akshay Joshi
Fixed an issue where the database list in the new connection window is not visible. Fixes #6121 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=f8497d4e7aa3af4ee4a24584ad67816be6405883 Author: Nikhil Mohite Modified Files -- docs

Re: [pgAdmin][RM-6121]: Unable to see database list in connection window launched from change connection option in query tool

2021-01-11 Thread Akshay Joshi
Thanks, patch applied. On Thu, Jan 7, 2021 at 5:05 PM Nikhil Mohite wrote: > Hi Team, > > Please find the attached patch for RM-6121 > : Unable to see database list > in connection window launched from change connection option in query tool. > > -- > *

Re: [pgAdmin] RM6128 RM6084 datistemplate issue

2021-01-11 Thread Akshay Joshi
Thanks, patch applied. On Mon, Jan 11, 2021 at 2:43 PM Rahul Shirsat < rahul.shir...@enterprisedb.com> wrote: > Hi Hackers, > > Please find the attached patch below which resolves the issue of > datistemplate. > > -- > *Rahul Shirsat* > Senior Software Engineer | EnterpriseDB Corporation. > --

Re: [pgAdmin][PM-6069]: Getting error while refreshing files in query tool

2021-01-11 Thread Akshay Joshi
Thanks, patch applied. On Mon, Jan 11, 2021 at 4:16 PM Nikhil Mohite < nikhil.moh...@enterprisedb.com> wrote: > Hi Tema, > > Please find the attached patch for RM-6069 > : Getting error while > refreshing files in query tool. > > > > -- > *Thanks & Rega

Re: [pgAdmin4][Patch] - RM 5457 - Kerberos Authentication - Phase 1

2021-01-11 Thread Magnus Hagander
On Sun, Jan 3, 2021 at 6:31 PM Stephen Frost wrote: > > Greetings, > > * Dave Page (dp...@pgadmin.org) wrote: > > On Sat, 2 Jan 2021 at 15:59, Stephen Frost wrote: > > > * Dave Page (dp...@pgadmin.org) wrote: > > > > On Sat, 2 Jan 2021 at 15:41, Stephen Frost wrote: > > > > > * Khushboo Vashi (k

Re: [pgAdmin4][Patch] - RM 5457 - Kerberos Authentication - Phase 1

2021-01-11 Thread Dave Page
On Mon, Jan 11, 2021 at 1:15 PM Magnus Hagander wrote: > On Sun, Jan 3, 2021 at 6:31 PM Stephen Frost wrote: > > > > Greetings, > > > > * Dave Page (dp...@pgadmin.org) wrote: > > > On Sat, 2 Jan 2021 at 15:59, Stephen Frost wrote: > > > > * Dave Page (dp...@pgadmin.org) wrote: > > > > > On Sat,

Re: [pgAdmin4][Patch] - RM 5457 - Kerberos Authentication - Phase 1

2021-01-11 Thread Stephen Frost
Greetings, * Dave Page (dp...@pgadmin.org) wrote: > On Mon, Jan 11, 2021 at 1:15 PM Magnus Hagander wrote: > > One question around that though -- when I click "save password" on a > > database connection in pgadmin, it gets stored on the pgadmin server. > > Isn't the key used to encrypt that deri

Re: [pgAdmin4][Patch] - RM 5457 - Kerberos Authentication - Phase 1

2021-01-11 Thread Dave Page
On Mon, Jan 11, 2021 at 4:50 PM Stephen Frost wrote: > Greetings, > > * Dave Page (dp...@pgadmin.org) wrote: > > On Mon, Jan 11, 2021 at 1:15 PM Magnus Hagander > wrote: > > > One question around that though -- when I click "save password" on a > > > database connection in pgadmin, it gets store

Re: [pgAdmin4][Patch] - RM 5457 - Kerberos Authentication - Phase 1

2021-01-11 Thread Stephen Frost
Greetings, * Dave Page (dp...@pgadmin.org) wrote: > On Mon, Jan 11, 2021 at 4:50 PM Stephen Frost wrote: > > If you're saying that, when Kerberos is enabled, users will never be > > prompted to provide a password because password-based auth has been > > disabled, then perhaps that's reasonable.

Somewhat excessive version checks

2021-01-11 Thread Magnus Hagander
Hi! If I read the code correctly, pgadmin will (unless turned off) hit the website to check the version.json file for updates *every time it starts*. Wouldn't it make sense to rate limit that to checking say once per 24 hours maximum? Or even 48? It seems nobody needs the update *that* quickly,

Re: Somewhat excessive version checks

2021-01-11 Thread Khushboo Vashi
On Tue, Jan 12, 2021 at 3:36 AM Magnus Hagander wrote: > Hi! > > If I read the code correctly, pgadmin will (unless turned off) hit the > website to check the version.json file for updates *every time it > starts*. > > Wouldn't it make sense to rate limit that to checking say once per 24 > hours

The target connection was wrong in function check_version_compatibility()

2021-01-11 Thread Huang, Jun
Hi, The target connection was made by source connection manager(it should be made by target connection manager) in function check_version_compatibility(web\pgadmin\tools\schema_diff\__init__.py). Attached patch adds the changes. Regrads, Huang 0001-Target-connection-was-wrong-in-function.pat