[pgAdmin][RM4806] Add info to empty explain tab

2020-09-28 Thread Aditya Toshniwal
Hi Hackers, Attached is the patch to add a useful message when the explain plan is not used and is empty. I've also added a message for the data output tab. Please review. -- Thanks, Aditya Toshniwal pgAdmin hacker | Sr. Software Engineer | *edbpostgres.com* "Don't Comp

[pgAdmin][RM5131] ctrl + a shortcut does not move cursor in sql editor with macOS

2020-09-28 Thread Aditya Toshniwal
Hi Hackers, Attached patch removes the incorrect overriding of default CodeMirror shortcuts. Please review. -- Thanks, Aditya Toshniwal pgAdmin hacker | Sr. Software Engineer | *edbpostgres.com* "Don't Complain about Heat, Plant a TREE" RM5131.patch Description: Binary

Re: [pgAdmin] Fix incorrect import in setup.py

2020-09-28 Thread Aditya Toshniwal
Hi Azad, The patch looks good to me. On Thu, Sep 24, 2020 at 6:33 PM Azad Salahlı wrote: > Hi, > > First time posting here. I've attached a fix for an incorrect import > in `setup.py`. Trying to import from `pgadmin` before adding the root > directory to the system path results in import error,

pgAdmin 4 commit: Fixed incorrect import in setup.py

2020-09-28 Thread Akshay Joshi
Fixed incorrect import in setup.py Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=43f1953aa770d59dca06b056f43e4794d9ee8ca2 Author: Azad Salahli Modified Files -- web/setup.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(

pgAdmin 4 commit: Added useful message when the explain plan is not use

2020-09-28 Thread Akshay Joshi
Added useful message when the explain plan is not used and empty. Fixes #4806 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=1fc06b8d577d2c225e7928cac199ec8fea5f1020 Author: Aditya Toshniwal Modified Files -- docs/en_US/release_n

pgAdmin 4 commit: Added support to ignore the owner while comparing obj

2020-09-28 Thread Akshay Joshi
Added support to ignore the owner while comparing objects in the Schema Diff tool. Fixes #5200. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=952197f1305c318dd4cbc56994501ed925b939a6 Modified Files -- docs/en_US/images/preferenc

pgAdmin 4 commit: Added Macro support. Fixes #1402

2020-09-28 Thread Akshay Joshi
Added Macro support. Fixes #1402 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=4616a740290b69010d1fddf59e3d8fc8e91b23f9 Author: Khushboo Vashi Modified Files -- docs/en_US/release_notes_4_27.rst | 1 + web/migr

Re: [pgAdmin4][Patch] - RM 1402 - Macro support like pgAdmin3

2020-09-28 Thread Akshay Joshi
Thanks, patch applied. On Mon, Sep 28, 2020 at 2:18 PM Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi, > > Please find the attached updated patch. > > Thanks, > Khushboo > > On Wed, Sep 23, 2020 at 5:42 PM Akshay Joshi < > akshay.jo...@enterprisedb.com> wrote: > >> Hi Khushboo >> >

Re: [pgAdmin][RM4806] Add info to empty explain tab

2020-09-28 Thread Akshay Joshi
Thanks, patch applied. On Mon, Sep 28, 2020 at 3:02 PM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > Attached is the patch to add a useful message when the explain plan is not > used and is empty. I've also added a message for the data output tab. > > Please revie

Re: [pgAdmin] Fix incorrect import in setup.py

2020-09-28 Thread Akshay Joshi
Thanks, patch applied. On Mon, Sep 28, 2020 at 4:48 PM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Azad, > > The patch looks good to me. > > On Thu, Sep 24, 2020 at 6:33 PM Azad Salahlı > wrote: > >> Hi, >> >> First time posting here. I've attached a fix for an incorrect im

Re: [pgAdmin][RM3794]:Allow User to Change Database Connection from an Open Query Tool Tab

2020-09-28 Thread Akshay Joshi
Hi Nikhil The patch is not applying, rebase, and send it again. Please check your code should not create any new SonarQube issues. On Mon, Sep 28, 2020 at 11:20 AM Nikhil Mohite < nikhil.moh...@enterprisedb.com> wrote: > Hi Akshay, > > I have resolved all the review comments and also updated the

Re: [pgAdmin][RM5131] ctrl + a shortcut does not move cursor in sql editor with macOS

2020-09-28 Thread Akshay Joshi
Hi Aditya The patch is not applying, rebase, and send it again. On Mon, Sep 28, 2020 at 3:23 PM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > Attached patch removes the incorrect overriding of default CodeMirror > shortcuts. > Please review. > > -- > Thanks, > Ad

[pgAdmin][RM4855] Renaming a file removes the file extension

2020-09-28 Thread Aditya Toshniwal
Hi Hackers, Attached is the patch to fix a bug where extension file extension is stripped on renaming a file. Pleasure review. -- Thanks, Aditya Toshniwal pgAdmin hacker | Sr. Software Engineer | *edbpostgres.com* "Don't Complain about Heat, Plant a TREE" RM4855.patch

Re: [pgAdmin][RM5131] ctrl + a shortcut does not move cursor in sql editor with macOS

2020-09-28 Thread Aditya Toshniwal
Hi, Please find the updated patch. On Mon, Sep 28, 2020 at 5:59 PM Akshay Joshi wrote: > Hi Aditya > > The patch is not applying, rebase, and send it again. > > On Mon, Sep 28, 2020 at 3:23 PM Aditya Toshniwal < > aditya.toshni...@enterprisedb.com> wrote: > >> Hi Hackers, >> >> Attached patch r

Error in pgadmin 4

2020-09-28 Thread Leandro Bugalho
Hi, I need help, I have a problem using pgadmin 4 and greenplum. I had a popup error Internal Server Error - "depends/gpdb/#80323#/dependencies.sql" , how can i resolve these errors? thanks for help Leandro

Re: Error in pgadmin 4

2020-09-28 Thread Akshay Joshi
Hi Leandro pgAdmin4 doesn't support the Greenplum database. On Tue, Sep 29, 2020 at 12:08 AM Leandro Bugalho wrote: > Hi, I need help, I have a problem using pgadmin 4 and greenplum. I had > a popup error Internal Server Error - > "depends/gpdb/#80323#/dependencies.sql" , how can i resolve the

pgAdmin 4 commit: Ensure that 'ctrl + a' shortcut does not move the cur

2020-09-28 Thread Akshay Joshi
Ensure that 'ctrl + a' shortcut does not move the cursor in SQL editor. Fixes #5131 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=3e7cdcdf90827ee3b07f981758aecbc0bfed10a8 Author: Aditya Toshniwal Modified Files -- docs/en_US/re

pgAdmin 4 commit: Fixed an issue where file extension is stripped on re

2020-09-28 Thread Akshay Joshi
Fixed an issue where file extension is stripped on renaming a file. Fixes #4855 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=c7c199210dbd7971c96fce4c67d7b4ec14585cda Author: Aditya Toshniwal Modified Files -- docs/en_US/release

Re: [pgAdmin][RM3794]:Allow User to Change Database Connection from an Open Query Tool Tab

2020-09-28 Thread Akshay Joshi
Hi Nikhil Your patch introduces 1 new Bug and 13 new code smells, please fix those and resend the patch. On Mon, Sep 28, 2020 at 7:31 PM Nikhil Mohite < nikhil.moh...@enterprisedb.com> wrote: > Hi Akshay, > > I have resolved code conflict issues and sonarqube issues. > PFA updated patch. > > Reg