Re: RM5841: server.username can be empty when using .pg_service.conf

2020-09-20 Thread Akshay Joshi
Hi Pradip Can you please review the patch as that condition we have added for Shared Server implementation? On Sat, Sep 19, 2020 at 6:22 PM Cyril Jouve wrote: > fix for https://redmine.postgresql.org/issues/5841 > -- *Thanks & Regards* *Akshay Joshi* *pgAdmin Hacker | Sr. Software Architect*

pgAdmin 4 commit: Fixed an issue where a column is renamed and then rem

2020-09-20 Thread Akshay Joshi
Fixed an issue where a column is renamed and then removed, then the drop SQL query takes the wrong column name. Fixes #5807. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=553be14000b698774136dda362a8c3b8e1bd5a0d Author: Aditya Toshniwal Mo

Re: [pgAdmin][RM5830] View: parenthesis re-arrangement with AND/OR

2020-09-20 Thread Akshay Joshi
Thanks, patch applied. On Mon, Sep 14, 2020 at 5:13 PM Ganesh Jaybhay < ganesh.jayb...@enterprisedb.com> wrote: > Hi Hackers, > > Please find the attached patch to add the parenthesis similar to dba_views > for the created views. > Please review. > > Regards, > Ganesh Jaybhay > -- *Thanks & Re

pgAdmin 4 commit: Ensure that multiple extensions can be dropped from t

2020-09-20 Thread Akshay Joshi
Ensure that multiple extensions can be dropped from the properties tab. Fixes #5839. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=3489f94ca728d3c55f813f0f6819e96c8d6a2554 Modified Files -- docs/en_US/release_notes_4_27.rst

pgAdmin 4 commit: Fixed reverse engineering SQL where parenthesis is no

2020-09-20 Thread Akshay Joshi
Fixed reverse engineering SQL where parenthesis is not properly arranged for View/MView definition. Fixes #5830 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=b0475566ca61cdcfff07f8a24ef0ddcf9f46f1a7 Author: Ganesh Jaybhay Modified Files --

Re: [pgAdmin][RM5807] Removed columns use modified name in generated script

2020-09-20 Thread Akshay Joshi
Thanks, patch applied. On Thu, Sep 17, 2020 at 3:29 PM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > If a column is renamed and then removed, then drop SQL query takes the > renamed column and not the original one. > Attached is the patch to fix this issue. > > --