pgAdmin 4 commit: Added shared server support for admin users. Fixes #4

Added shared server support for admin users. Fixes #4979 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=b562ab768150b99947346975b63f89637ad4cea0 Author: Pradip Parkale Modified Files -- docs/en_US/release_notes_4_26.rst

pgAdmin 4 commit: Improve code coverage and API test cases for Tables.

Improve code coverage and API test cases for Tables. Fixes #5774. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=3e35dc95e5c633572a24371b49011e306f18f0a0 Author: Yogesh Mahajan Modified Files -- docs/en_US/release_notes_4_26.rst

Re: Housekeeping #5774 - [Code Coverage] Improve API test cases for Table node

Thanks, patch applied. On Thu, Sep 3, 2020 at 12:12 PM Yogesh Mahajan < yogesh.maha...@enterprisedb.com> wrote: > Hi, > > Please find a patch which adds tests for table nodes. Test coverage for > table nodes has increased from 16% to 56%. > > > Thanks, > Yogesh Mahajan > QA - Team > EnterpriseDB

pgAdmin 4 commit: Fixed linter error by removing 'debugger;' keyword.

Fixed linter error by removing 'debugger;' keyword. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=ed0c4037ad8e1a2cd987d2f9e86d8e18e6003db0 Modified Files -- web/pgadmin/preferences/static/js/preferences.js | 1 - 1 file changed, 1

pgAdmin 4 commit: Fixed API test cases failed due to commit for #4979.

Fixed API test cases failed due to commit for #4979. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=a67f6e4f9c1ffc24d7d5ddece97689d3533912dc Modified Files -- .../browser/server_groups/servers/tests/test_shared_server.py|

[pgAdmin][SonarQube] : Remove duplicates string literals.

Hi Hackers, Attached is a patch for removing duplicates string literals. /server_groups/servers/roles/__init__.py - 8 places -- Thanks & Regards, Pradip Parkale Software Engineer | EnterpriseDB Corporation sonar_Qube_v1.patch Description: Binary data

Re: [pgAdmin4][Patch] - SonarQube Fixes

Hi, Please find more fixes for the sonarqube code smells having the rule "String literals should not be duplicated". Thanks, Khushboo On Wed, Aug 19, 2020 at 2:27 PM Akshay Joshi wrote: > Thanks, patch applied. > > On Wed, Aug 19, 2020 at 2:01 PM Khushboo Vashi < > khushboo.va...@enterprisedb.

Re: [pgAdmin][SonarQube] : Remove duplicates string literals.

Hi Pradip Following are the review comments: - ROLE_NOT_FOUND already in wrapped in gettext() then no need to use like gone(_(ROLE_NOT_FOUND)). In fact, can we use self.not_found_error_msg()instead of new constant. - Same with ERROR_FETCHING_ROLE_INFORMATION it's already in gettext,

pgAdmin 4 commit: Fixed cognitive complexity issues reported by SonarQu

Fixed cognitive complexity issues reported by SonarQube. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=974d395a488f8e9a64586bbc6a15201e3f1b0321 Author: Aditya Toshniwal Modified Files -- web/pgadmin/misc/file_manager/__init__.py

pgAdmin 4 commit: Fixed primary key/unique constraint icon issue.

Fixed primary key/unique constraint icon issue. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=eaa90ee8eb6a4a39f379e050eb20927f4bbba7ce Modified Files -- .../schemas/tables/constraints/index_constraint/__init__.py | 6

pgAdmin 4 commit: Fixed code smell 'String literals should not be dupli

Fixed code smell 'String literals should not be duplicated'. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=31bbdd6a126c93815a960453d0644747e2f33099 Author: Khushboo Vashi Modified Files -- .../servers/databases/schemas/utils.py

Re: [pgAdmin4][Patch] - SonarQube Fixes

Thanks, patch applied. On Thu, Sep 3, 2020 at 4:39 PM Khushboo Vashi < khushboo.va...@enterprisedb.com> wrote: > Hi, > > Please find more fixes for the sonarqube code smells having the rule "String > literals should not be duplicated". > > Thanks, > Khushboo > > On Wed, Aug 19, 2020 at 2:27 PM Ak

Re: [pgAdmin][SonarQube] Reduce cognitive complexity

Thanks, patch applied. On Thu, Sep 3, 2020 at 3:38 PM Aditya Toshniwal < aditya.toshni...@enterprisedb.com> wrote: > Hi Hackers, > > Attached is the patch to reduce cognitive complexity as below: > web/pgadmin/misc/file_manager/__init__.py 20 to 15 > web/pgadmin/tools/grant_wizard/__init__.py 55

Re: [pgAdmin][SonarQube] : Remove duplicates string literals.

Hi Akshay, Please find the updated patch. On Thu, Sep 3, 2020 at 6:24 PM Akshay Joshi wrote: > Hi Pradip > > Following are the review comments: > >- ROLE_NOT_FOUND already in wrapped in gettext() then no need to use >like gone(_(ROLE_NOT_FOUND)). In fact, can we use > >self.not_fou

pgAdmin 4 commit: Modified the logic to check Port is in use for runtim

Modified the logic to check Port is in use for runtime. Fixes #5751. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=9ae9ccff1618e37a93e56072a3422e83fa82deb4 Modified Files -- runtime/Runtime.cpp | 12 1 file changed, 8