pgAdmin 4 commit: Improve code coverage and API test cases for Columns

2020-08-26 Thread Akshay Joshi
Improve code coverage and API test cases for Columns and Constraints (Index, Foreign Key, Check, Exclusion). Fixes #5332 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=8fcf5276327b101be869785159c6f9f557b4a211 Author: Yogesh Mahajan Modified

Re: [pgAdmin][Patch] - Housekeeping #5332 - [Code Coverage] Improve API test cases for Tables, Columns and Constraints (Index, Foreign Key, Check, Exclusion)

2020-08-26 Thread Akshay Joshi
Thanks, patch applied. On Wed, Aug 26, 2020 at 9:57 AM Yogesh Mahajan < yogesh.maha...@enterprisedb.com> wrote: > Hello, > > Please find a patch which adds api test cases for Column, Constraint, > Check constraint, Exclusion constraint, Foreign key, Index constraint. > > Code coverage for above m

Re: [pgAdmin][RM5990]: Update the style guide on pgAdmin4 website

2020-08-26 Thread Nikhil Mohite
Hi Dave/Team, Updated the implementation for the set title of the page, for this, I have done a few changes in the flow. 1. Earlier we are using {% include %} for showing pages in the base page (styleguide/index.html) for a style guide but in the Django template we can't use {% block %} statement

Re: [pgAdmin][RM5990]: Update the style guide on pgAdmin4 website

2020-08-26 Thread Dave Page
Thanks, applied with a few changes for consistency in the titles and 404 handling. On Wed, Aug 26, 2020 at 8:23 AM Nikhil Mohite < nikhil.moh...@enterprisedb.com> wrote: > Hi Dave/Team, > > Updated the implementation for the set title of the page, for this, I have > done a few changes in the flow

[pgAdmin][Patch] RM4216 - Schema list does not support standard_conforming_strings set to off

2020-08-26 Thread Yogesh Mahajan
Hello, Please find a patch which enables pgAdmin4 to show schema names starting with 'pg' under schema node when 'standard_conforming_strings = off'. (Default is on) for database. Thanks, Yogesh Mahajan QA - Team EnterpriseDB Corporation Phone: +91-9741705709 RM4216_v1.patch Description: Bina

Re: [pgAdmin][RM5990]: Update the style guide on pgAdmin4 website

2020-08-26 Thread Aradhana Birewar
Hi Nikhil, I was going through the style guide, I have a few observations that I would like to share with you. 1. In the Typography section, for font size text, the Roboto font is not getting applied. [image: image.png] 2. In the Dropdown section, the expanded dropdown image appe

[PATCH] Fix pgAdmin4 v4.25 ignoring user configuration. Fixes #5773

2020-08-26 Thread Chris Mayo
--- runtime/Runtime.cpp | 22 ++ runtime/Runtime.h | 1 - 2 files changed, 14 insertions(+), 9 deletions(-) diff --git a/runtime/Runtime.cpp b/runtime/Runtime.cpp index ff124fbc9..b7ff12406 100644 --- a/runtime/Runtime.cpp +++ b/runtime/Runtime.cpp @@ -59,6 +59,8 @@ bool Ru

[PATCH] Fix pgAdmin4 v4.25 ignoring user configuration. Fixes #5773

2020-08-26 Thread Chris Mayo
--- runtime/Runtime.cpp | 22 ++ runtime/Runtime.h | 1 - 2 files changed, 14 insertions(+), 9 deletions(-) diff --git a/runtime/Runtime.cpp b/runtime/Runtime.cpp index ff124fbc9..b7ff12406 100644 --- a/runtime/Runtime.cpp +++ b/runtime/Runtime.cpp @@ -59,6 +59,8 @@ bool Ru

SCSS Minor SonarQube fixes

2020-08-26 Thread Pramod Ahire
Hi, Please find attached minor fixes for sonarqube, which includes changes as below: Removed duplicate CSS declaration Added proper font with font-family Please do let me know if any changes or missed. Pramod Ahire Software Engineer C: +91-020-66449600/601 D: +91-9028697679