pgAdmin 4 commit: Fixed cognitive complexity issues reported by SonarQu

2020-08-21 Thread Akshay Joshi
Fixed cognitive complexity issues reported by SonarQube. Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=19491d79a51fcc8579ad4ee01b78300657abdeea Author: Nikhil Mohite Modified Files -- .../foreign_servers/__init__.py

pgAdmin 4 commit: Replace 'fa-clock-o' with 'fa-clock' which is appropr

2020-08-21 Thread Akshay Joshi
Replace 'fa-clock-o' with 'fa-clock' which is appropriate for font awesome v5 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=dd6ae193ff56e61d5ef11f1996fd7703a57c514d Modified Files -- web/pgadmin/static/js/backform.pgadmin.js | 6

Re: Patch for SonarQube code scan fixes.

2020-08-21 Thread Akshay Joshi
Thanks, patch applied. On Fri, Aug 21, 2020 at 12:23 PM Nikhil Mohite < nikhil.moh...@enterprisedb.com> wrote: > Hi Team, > > I have fixed some code smell issues in the SonarQube scan, PFA patch. > Details as follows: > 1. Foreign servers: > >- Refactor this function to reduce its Cognitive C

Re: [pgAdmin][RM4979]: Configuration files for data sources or similar.

2020-08-21 Thread Akshay Joshi
Hi Pradip The patch is not applied, can you please rebase and send it again. On Thu, Aug 20, 2020 at 3:58 PM Pradip Parkale < pradip.park...@enterprisedb.com> wrote: > Hi Hackers, > > Please find the attached patch for the shared server implementation. > > Few key points: > >1. The admin who

pgAdmin 4 commit: Updated some more font awesome icons for v5

2020-08-21 Thread Akshay Joshi
Updated some more font awesome icons for v5 Branch -- master Details --- https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=b53de0c31d7626938c674afc9c664222380dd329 Author: Neel Patel Modified Files -- .../databases/schemas/tables/partitions/static/js/partition.

pgadmin open file feature

2020-08-21 Thread Peter Antolík
Hello, Would it be possible to add the possibility to have path bookmarks for local storage in the opening file wizard? Query tool/Open file --> Select file (and use the bookmarks from ubuntu/windows, or custom bookmarks defined only for pgadmin)? Best, //Peter

Re: pgadmin open file feature

2020-08-21 Thread Khushboo Vashi
Hi, On Fri, Aug 21, 2020 at 6:43 PM Peter Antolík wrote: > Hello, > > Would it be possible to add the possibility to have path bookmarks for > local storage in the opening file wizard? > > Query tool/Open file à Select file (and use the bookmarks from > ubuntu/windows, or custom bookmarks define